@stonyx/orm 0.3.2-beta.160 → 0.3.2-beta.162

package/dist/utils.js

@@ -15,50 +15,3 @@ export function pluralize(word) {
     }
     return basePluralize(word);
 }
-/**
- * The highest NUMERIC id held by a set of records, or `0` when there is none.
- *
- * ONE COPY, and the duplication it replaces is the reason it lives here. Three
- * near-identical reduces existed at once: `assignRecordId` (server-assigned id
- * selection), `StandaloneDB.create` (src/standalone-db.ts) and the #203 test
- * helper. `docs/improvements.md`'s standing WET Code category prescribes
- * exactly this remedy -- extract into the module that already acts as the
- * shared utility -- and `assignRecordId` already imported `isOrmRecord` from
- * here.
- *
- * NON-NUMBERS ARE SKIPPED RATHER THAN COERCED TO `0`, AND THAT IS STYLISTIC.
- * `StandaloneDB`'s shape mapped them to `0`, which can never beat a seed of
- * `0`. Measured over eleven input classes (`[]`, `1`, `NaN`, `'5'`, `'abc'`,
- * `-3`, `0`, `null`, `undefined`, `Infinity`, and mixed arrays) the two shapes
- * produce IDENTICAL output on every one. In particular `typeof NaN` is
- * `'number'`, so NEITHER shape coerces `NaN` -- both reject it on `NaN > max`,
- * which is `false`. An earlier revision of this code asserted that the skip was
- * what made the `NaN` case work; it is not, the comparison is, and that claim
- * has been removed rather than left standing.
- *
- * WHAT IS LOAD-BEARING is that this is not `Math.max(...ids)`. `Math.max`
- * returns `NaN` if any operand is `NaN`, and a record CAN be held under the key
- * `NaN` -- so the obvious fix assigns `NaN`, lands on that slot and overwrites
- * it, which is abofs/stonyx-orm#203 in a new disguise. Pinned by
- * test/unit/assign-record-id-test.ts AC2; before that file existed the whole
- * suite scored 951/0 under exactly that fix.
- */
-export function maxNumericId(records) {
-    return records.reduce((max, record) => {
-        const { id } = record;
-        return typeof id === 'number' && id > max ? id : max;
-    }, 0);
-}
-/**
- * The message prefix `assignRecordId` throws with when no free id can be
- * derived for a model, and the ONE string `createHandler` matches on to answer
- * `409` instead of letting the rejection reach express's default handler.
- *
- * It lives here rather than in either file because both need it and neither
- * should own a copy: a literal in two places is how the two id coercions in
- * orm-request.ts drifted apart (see `coerceId`). The repo has no error codes
- * and no custom error classes -- 24 bare `throw new Error` sites across `src/`
- * -- so a shared prefix is the narrowest way to make ONE failure distinguishable
- * without inventing an error taxonomy this codebase does not use.
- */
-export const NO_FREE_ID_ERROR = 'Cannot assign record ID: no free id available';

package/package.json

@@ -4,7 +4,7 @@
     "stonyx-async",
     "stonyx-module"
   ],
-  "version": "0.3.2-beta.160",
+  "version": "0.3.2-beta.162",
   "description": "",
   "main": "dist/index.js",
   "type": "module",
@@ -61,10 +61,10 @@
   },
   "homepage": "https://github.com/abofs/stonyx-orm#readme",
   "dependencies": {
-    "@stonyx/cron": "0.2.1-beta.85",
+    "@stonyx/cron": "0.2.1-beta.91",
     "@stonyx/events": "0.1.1-beta.52",
     "@stonyx/utils": "0.2.3-beta.26",
-    "stonyx": "0.2.3-beta.77"
+    "stonyx": "0.2.3-beta.79"
   },
   "peerDependencies": {
     "@aws-sdk/client-dynamodb": "^3.0.0",
@@ -91,7 +91,7 @@
     }
   },
   "devDependencies": {
-    "@stonyx/rest-server": "0.2.1-beta.84",
+    "@stonyx/rest-server": "0.2.1-beta.95",
     "@types/node": "^25.6.0",
     "mysql2": "^3.20.0",
     "pg": "^8.20.0",

package/src/hooks.ts

@@ -37,21 +37,7 @@ export interface HookContext {
   state?: Record<string, unknown>;
   /** Previous record state (available in update hooks). */
   oldState?: unknown;
-  /**
-   * Target record ID for single-record operations.
-   *
-   * SET ONLY UNDER `delete`. `_withHooks` assigns this key in the two
-   * `operation === 'delete'` branches and nowhere else, so on `get`, `list`,
-   * `create` and `update` the key is ABSENT -- not `undefined`-valued, absent.
-   * A hook rule written as `ctx.recordId === '<id>'` never fires on an update;
-   * the addressed id is in `ctx.params`. Tracked as abofs/stonyx-orm#242.
-   *
-   * @see AccessContext.recordId in ./types/orm-types.ts -- an identically-named
-   * key on an identically-shaped context object, and NOT interchangeable with
-   * this one: it is present on every route `auth()` classifies, and spells
-   * absence as `null` rather than `undefined`. They differ in coverage on four
-   * of five operations, not only in the absence spelling.
-   */
+  /** Target record ID for single-record operations. */
   recordId?: string | number;
   /** Response data (available in after hooks). */
   response?: unknown;

package/src/index.ts

@@ -27,16 +27,6 @@ import { count, avg, sum, min, max } from './aggregates.js';
 export { default } from './main.js';
 export { store, relationships } from './main.js';
 export type { PersistErrorDetail } from './main.js';
-export type { AccessContext, AccessFunction, AccessMethod, AccessOperation } from './types/orm-types.js'; // access() contract (#202)
-export type { LinkageFilter } from './types/orm-types.js'; // linkage verdict contract (#234)
-// The request-scoped linkage-verdict factory (#234). PUBLIC on purpose: the
-// README tells a consumer serializing a `Record` outside the REST layer to pass
-// their own resolved `linkage` option, and without an exported factory the only
-// way to follow that advice is to write a SECOND reading of `access()` in
-// consumer code -- the exact "unreviewed second authorization vocabulary" that
-// src/access-verdict.ts exists to prevent, reproduced where no reviewer sees it
-// drift. Give them the one interpreter instead of an invitation to fork it.
-export { createLinkageFilter } from './access-verdict.js';
 export { Model, View, Serializer }; // base classes
 export { attr, belongsTo, hasMany, createRecord, updateRecord }; // helpers
 export { count, avg, sum, min, max }; // aggregate helpers

package/src/main.ts

@@ -25,7 +25,6 @@ import baseTransforms from './transforms.js';
 import Store from './store.js';
 import Serializer from './serializer.js';
 import { setup } from '@stonyx/events';
-import type { AccessFunction } from './types/orm-types.js';
 
 interface OrmOptions {
   dbType?: string;
@@ -69,53 +68,6 @@ export default class Orm {
   views: Record<string, unknown> = {};
   transforms: Record<string, (value: unknown) => unknown> = { ...baseTransforms };
   warnings: Set<string> = new Set();
-
-  /**
-   * Model name -> the `access` predicate of the access class that CLAIMS that
-   * model (abofs/stonyx-orm#202).
-   *
-   * Not "that model's own predicate". One access class may claim many models
-   * -- `GlobalAccess` in this repo's fixtures declares five, and `models = '*'`
-   * claims every model in the store -- and it declares ONE `access` method, so
-   * the same function object is registered under every one of those keys.
-   * `getAccess('owner') === getAccess('animal')` is `true` there. The
-   * one-to-one guarantee below is key -> function, never function -> model,
-   * and a caller must not read a resolved predicate as being animal-specific.
-   * What makes the ANSWER model-specific is the context the caller passes and
-   * the predicate actually reading it -- see {@link Orm#getAccess}.
-   *
-   * NAMED FOR WHAT IT HOLDS. It was `accessFiles` through review, inherited
-   * from the function-local in `setup-rest-server.ts` where the values came
-   * straight out of `forEachFileImport` and "files" was defensible. The values
-   * are `AccessFunction`s, and the sibling public registries on this class
-   * (`models`, `serializers`, `views`, `transforms`) are all plural nouns of
-   * the thing held. Renamed here because #202 is the last moment it is free.
-   *
-   * Populated by `setup-rest-server.ts` at boot, from the access classes under
-   * `config.orm.paths.access`, BEFORE any route is mounted -- so it is complete
-   * and reachable before the first request can be served. The mapping is
-   * one-to-one by construction: setup-rest-server throws if two access classes
-   * claim the same model.
-   *
-   * Keys are model names as declared and stored (kebab-case, e.g.
-   * `'phone-number'`), NOT pluralised or mount-prefixed route names.
-   *
-   * WHY THIS EXISTS AS A FIELD. It used to be a function-local in
-   * setup-rest-server that was discarded when that function returned, so at
-   * request time there was no way to get from a model name to that model's
-   * predicate at all. Each `OrmRequest` held only its OWN model's predicate.
-   * That made cross-model authorization -- asking model X's predicate about a
-   * request routed to model Y -- inexpressible, which is the capability
-   * abofs/stonyx-orm#196 and abofs/stonyx-orm#207 are built on.
-   *
-   * Empty when the REST server is disabled, and PARTIAL when one access file
-   * failed to load (`setup-rest-server.ts` catches, warns and assigns whatever
-   * it had). So a missing key does NOT mean the model has no access class.
-   * Prefer {@link Orm#getAccess} over indexing this directly -- it is guarded
-   * against the prototype chain and this is not.
-   */
-  accessFunctions: Record<string, AccessFunction> = {};
-
   options!: OrmOptions;
   sqlDb?: SqlDb;
   db?: OrmDB | SqlDb;
@@ -243,81 +195,6 @@ export default class Orm {
     Orm.initialized = true;
   }
 
-  /**
-   * Resolve the `access` predicate registered for a model name
-   * (abofs/stonyx-orm#202).
-   *
-   * This is the supported way to reach another model's predicate while
-   * servicing a request routed to a different model. Call it with the model
-   * name and invoke the result with the live request and an explicit context
-   * naming THAT model:
-   *
-   * ```js
-   * const predicate = Orm.instance.getAccess('animal');
-   * if (!predicate) return deny;
-   * const verdict = predicate(request, { model: 'animal', operation: 'read' });
-   * ```
-   *
-   * WHAT IT RESOLVES. The predicate of the access CLASS that claims the model,
-   * which is not necessarily specific to it: one class may claim many models
-   * and declares one `access` method, so
-   * `getAccess('owner') === getAccess('animal')` is `true` against this repo's
-   * fixture. See {@link Orm#accessFunctions}.
-   *
-   * `undefined` means NO PREDICATE COULD BE RESOLVED for that name. That
-   * includes a model whose access class failed to LOAD -- `setup-rest-server`
-   * catches, warns and publishes the partial map -- so it is not the same claim
-   * as "this model is unrestricted". Treat it as DENY, the same way
-   * `AccessContext.operation === undefined` is treated.
-   *
-   * PASSING THE CONTEXT MAKES A MODEL-CORRECT ANSWER POSSIBLE. It does not, on
-   * its own, make the answer model-correct: the resolved predicate has to READ
-   * the context. Measured against this repo's shipped access class on a request
-   * express dispatched to `GET /owners/angela`, asked about ANIMALS:
-   *
-   * ```
-   * getAccess('animal')(ownersRequest, { model: 'animal', operation: 'read' })
-   *   ->  record => record.id !== 'angela' && record.id !== 'restricted'
-   * ```
-   *
-   * The OWNERS filter, which returns `true` for animal 21 -- the record hidden
-   * on every animal surface. Under a mount that predicate recognises neither
-   * way it falls through to `['read', 'create', 'update', 'delete']`, a full
-   * CRUD grant. Either way: context supplied, answer not the animal answer,
-   * wrong in the GRANTING direction, because that predicate is arity-1 and
-   * identifies its collection from the request. AC9 asserts the first case on a
-   * live dispatch.
-   *
-   * Every predicate in this repo and in every consumer tree is arity-1 today,
-   * and there is no supported way for the caller to tell which kind it got; the
-   * boot-time arity warning that would surface it is abofs/stonyx-orm#213. Pass
-   * the context, and do not treat a resolved predicate's answer as
-   * model-specific until that predicate reads it.
-   *
-   * OWN PROPERTIES ONLY. A bare `this.accessFunctions[modelName]` walks the
-   * prototype chain, so `getAccess('constructor')` resolved `Object` and
-   * `getAccess('toString')` resolved `Object.prototype.toString` -- both
-   * callable, and the documented `predicate?.(request, ctx)` pattern then
-   * returned a TRUTHY value (`Object(request)` is the request), bypassing the
-   * `undefined`-means-deny contract entirely. Nothing in the ORM calls
-   * `getAccess` yet, so it was not exploitable as shipped -- but #207 takes the
-   * model name from the REQUEST BODY (`data.relationships.<key>.data.type`),
-   * which would have made a one-field body an authorization bypass. Guarded
-   * here at the read point rather than by constructing the map with a null
-   * prototype, because the field is public and reassignable and the guard has
-   * to hold whatever object it is holding.
-   *
-   * @param modelName - Model name as declared and stored (kebab-case).
-   * @returns The predicate, or `undefined` when no predicate could be resolved
-   *   for that name. `undefined` is NOT "this model is unrestricted" -- see the
-   *   note above. Treat it as deny.
-   */
-  getAccess(modelName: string): AccessFunction | undefined {
-    if (!Object.hasOwn(this.accessFunctions, modelName)) return undefined;
-
-    return this.accessFunctions[modelName];
-  }
-
   async startup(): Promise<void> {
     if (this.sqlDb) await this.sqlDb.startup();
   }

package/src/manage-record.ts

@@ -2,7 +2,7 @@ import Orm, { store } from '@stonyx/orm';
 import OrmRecord from './record.js';
 import { getGlobalRegistry, getPendingRegistry, getPendingBelongsToRegistry, getBelongsToRegistry, getHasManyRegistry } from './relationships.js';
 import type Serializer from './serializer.js';
-import { isOrmRecord, maxNumericId, NO_FREE_ID_ERROR } from './utils.js';
+import { isOrmRecord } from './utils.js';
 
 interface CreateRecordOptions {
   isDbRecord?: boolean;
@@ -195,58 +195,17 @@ export function updateRecord(record: OrmRecord, rawData: unknown, userOptions: C
 }
 
 /**
- * gets the next available id, based on the HIGHEST id present.
+ * gets the next available id based on last record entry.
  *
  * In MySQL mode with numeric IDs, assigns a temporary pending ID.
  * MySQL's AUTO_INCREMENT provides the real ID after INSERT.
- *
- * ---------------------------------------------------------------------------
- * WAS: `Array.from(storeMap.values()).at(-1).id + 1` — the LAST INSERTED id,
- * not the maximum (abofs/stonyx-orm#203). The store is a Map, so insertion
- * order stops being ascending the moment a record is deleted and recreated, a
- * db.json is written out of order, a directory-mode store is read back in file
- * order, or a caller POSTs a high id and then a low one. After that, every
- * server-assigned id is one that is ALREADY TAKEN — and `createRecord`'s
- * last-entry-wins branch then overwrites that record IN PLACE and answers 200.
- * No error, no 409, and the store's size does not change. That is the whole
- * defect, and it is reachable from a create with NO id at all, which is the
- * most ordinary write a consumer performs.
- *
- * Covered by test/unit/assign-record-id-test.ts. Note for anyone changing this
- * function: before that file existed, the whole suite scored 951/0 both on the
- * defect and on a naive `Math.max` fix that introduced a second one. A green
- * suite is not evidence here; those assertions are.
- * ---------------------------------------------------------------------------
  */
 function assignRecordId(modelName: string, rawData: { [key: string]: unknown }): void {
-  // PRESENCE, not truthiness. `0` is a legal value for an `attr('number')` id,
-  // and `if (rawData.id) return` silently reassigned it, handing the caller back
-  // a different record than the one it named (#203).
-  //
-  // `''` is deliberately NOT honoured here and this is not an oversight: it is
-  // the one string that means "no id". `parseInt('')` is `NaN`, a record CAN be
-  // held under the key `NaN`, and orm-request.ts's body-id normalisation relies
-  // on `''` staying absent — otherwise `POST {"id":""}` answers 409 against a
-  // record it never named.
-  //
-  // WHAT WIDENING THIS TO `!== undefined` ACTUALLY DOES, measured rather than
-  // asserted: `{id: ''}` early-returns, `parseInt('')` NaNs it, and the record
-  // lands on the store's `NaN` slot and OVERWRITES whatever is there — #203's
-  // own defect class. It does NOT turn access-filter-enforcement-test.ts
-  // assertion 44 red; an earlier revision of this comment claimed it did, which
-  // converted an unknown into a false assurance. AC6's BOUNDARY assertions are
-  // what catch it, and they only do so because they seed the `NaN` slot first.
-  if (rawData.id || rawData.id === 0) return;
+  if (rawData.id) return;
 
   // In SQL mode with numeric IDs, defer to database auto-increment.
   // Use unique negative integers — they survive the number transform (parseInt preserves negatives)
   // and avoid NaN store-key collisions that string pending IDs caused.
-  //
-  // This early return is ABOVE the max computation on purpose: a pending
-  // negative must never be a candidate for, or be perturbed by, the max path.
-  // Pinned directly (AC5.3) rather than by asserting the max is unaffected —
-  // that assertion could not have failed, because nothing negative ever reaches
-  // the code below.
   if (Orm.instance?.sqlDb && !isStringIdModel(modelName)) {
     rawData.id = -(++pendingIdCounter);
     rawData.__pendingSqlId = true;
@@ -256,218 +215,15 @@ function assignRecordId(modelName: string, rawData: { [key: string]: unknown }):
   const storeMap = store.get(modelName);
   if (!storeMap) throw new Error(`Cannot assign record ID: model "${modelName}" not found in store`);
   const modelStore = Array.from(storeMap.values()).filter(isOrmRecord);
-
-  // ONE COPY of the max-numeric-id reduce, in src/utils.ts. There were three
-  // (here, StandaloneDB.create, and the #203 test helper) and `docs/
-  // improvements.md`'s WET Code category prescribes the extraction. What that
-  // helper must NOT be is `Math.max(...ids)`; the reason is measured and it is
-  // documented at the helper rather than duplicated here. Pinned by AC2.
-  const maxId = maxNumericId(modelStore);
-
-  // THE OCCUPANCY CHECK RUNS ON THE LANDING KEY, NOT ON THE RAW CANDIDATE, and
-  // the difference is a silent data loss rather than a nicety.
-  //
-  // `createRecord` looks the record up under `rawData.id` (:50) but WRITES it
-  // under `record.id` (:69) — the value after the model's declared id transform
-  // has run inside `serialize`. When the transform is not the identity those two
-  // differ, so a guard written as `storeMap.has(rawData.id)` checks a key the
-  // record will never occupy, misses an occupied slot and overwrites it —
-  // measured on an `uppercase`-id model: the guard checks `owner-1`, the record
-  // lands under `OWNER-1`, store size unchanged, no error. That is
-  // abofs/stonyx-orm#205's lookup-key/landing-key divergence reappearing inside
-  // #203's own fix, which is why AC4 exists and why `rawData.id` is set to the
-  // LANDING key below.
-  //
-  // THE SCOPE OF THAT CLAIM, stated rather than implied. Setting `rawData.id` to
-  // the landing key makes :50 and :69 agree for every IDEMPOTENT id transform —
-  // `number`, `float`, `string`, `passthrough`, `uppercase`, `trim`. It does NOT
-  // make them agree for `date` or `timestamp`: `transforms.date` returns a NEW
-  // object every call and a `Map` keys by identity, so `storeMap.has(landingKey)`
-  // is always `false` there and the occupancy check is vacuous. `dev` is broken
-  // for those types too — this is not a regression — but no comment here may
-  // claim a property it was not measured to have (#212 § AC5).
-  //
-  // Resolved ONCE, outside the walk: `getIdType` instantiates the model class,
-  // so resolving it per candidate would put a model construction on every
-  // iteration of a loop that exists to walk past occupied slots.
-  const toStoreKey = storeKeyDeriver(modelName);
-
-  // DOES THIS MODEL FILE ITS RECORDS UNDER STRING KEYS? Decided by RUNNING the
-  // model's own id transform once, not by matching a type NAME against a list:
-  // `Orm.instance.transforms` (main.ts:70) is a public, MUTABLE instance
-  // property, so any enumeration of "the string-ish types" written here would be
-  // wrong the moment a consumer registers one.
-  const stringKeyed = typeof toStoreKey(maxId + 1) === 'string';
-
-  // THE CANDIDATE FOR A STRING-KEYED MODEL IS NOT A BARE NUMBER, and this is
-  // abofs/stonyx-orm#209 — which is REOPENED — not aesthetics.
-  //
-  // `orm-request.ts`'s `coerceId` (:322) resolves a NUMERIC-LOOKING string to a
-  // NUMBER on every id-bearing surface, while a model declaring
-  // `id = attr('string')` files under the STRING key. So a server-assigned `'1'`
-  // produces a record that is created and then NOT ADDRESSABLE. Measured over
-  // the route, owner store `{'1': ...}`:
-  //
-  //   GET    /owners/1       -> 404      (the record exists)
-  //   DELETE /owners/1       -> 404
-  //   GET    /owners/owner-1 -> 200
-  //
-  // and `_withHooks` (:1185) hands an after-`create` hook
-  // `context.record === undefined` for the same reason. `dev` assigned `'bob1'`,
-  // which is not numeric-looking, so `dev` has neither problem: a bare-number
-  // candidate would move #209 from "a caller supplied a numeric-looking id" onto
-  // the DEFAULT path for every server-assigned create on every string-id model.
-  // Prefixing with the model name keeps #209's population exactly as narrow as
-  // it already was, without touching the one shared coercion or the assertion
-  // that pins #209 open. Pinned by AC3.
-  const toCandidate = stringKeyed
-    ? (value: number) => `${modelName}-${value}`
-    : (value: number) => value;
-
-  // `maxId + 1` is the id AC1 pins: strictly greater than every numeric key
-  // present. IT IS NOT ALWAYS AVAILABLE, and that gap was a live denial of
-  // service. Float64 has no integer successor at or above 2^53, so
-  // `maxId + 1 === maxId` for every `maxId >= 9007199254740992` and `+ 1` inside
-  // the walk is a NO-OP there. One record filed under that key — which an
-  // unauthenticated `POST {"id":9007199254740992}` puts there, and which reaches
-  // even a filter-protected collection through has-many.ts:65 (#207), a channel
-  // GATE 0 does not cover — made the walk unable to advance, so it exhausted its
-  // budget and threw on EVERY subsequent server-assigned create, permanently,
-  // until that record was deleted. Measured over the route: 200, then 500 for
-  // every no-id create. `dev` answers 200.
-  //
-  // So a store holding one adversarial record must not disable its collection.
-  // When "above the max" is not a usable strategy the walk RESTARTS FROM 1: the
-  // store holds at most `size` keys, so one of `1 .. size + 1` is always free
-  // under an injective id transform. Pinned by AC7.
-  const start = maxId + 1;
-  let landingKey = firstFreeKey(storeMap, toStoreKey, toCandidate, start);
-
-  // THE RESTART, and it is the whole of the ceiling fix. Killing mutation:
-  // delete this block -> AC7 goes red (the route answers 409 instead of the
-  // created resource).
-  if (landingKey === NO_FREE_KEY && start !== 1) {
-    landingKey = firstFreeKey(storeMap, toStoreKey, toCandidate, 1);
-  }
-
-  if (landingKey === NO_FREE_KEY) {
-    // Reachable only with a NON-INJECTIVE id transform — see `firstFreeKey`.
-    // `createHandler` matches this message and answers 409 rather than letting it
-    // reach express's default handler, which serialises a stack trace with
-    // absolute install paths outside NODE_ENV=production (the hazard
-    // orm-request.ts:553-558 exists to name). Pinned by AC8.
-    throw new Error(`${NO_FREE_ID_ERROR} for model "${modelName}"`);
-  }
-
-  rawData.id = landingKey;
+  const lastRecord = modelStore.at(-1);
+  rawData.id = lastRecord ? (lastRecord.id as number) + 1 : 1;
 }
 
-// Returned instead of a key so that "no key" cannot be confused with a transform
-// that legitimately produced `undefined` or `null`.
-const NO_FREE_KEY = Symbol('no free store key');
-
-/**
- * The first store key at or above `start` that no record occupies, walking
- * candidate ids upward, or `NO_FREE_KEY` if the walk cannot reach one.
- */
-function firstFreeKey(
-  storeMap: Map<number | string, unknown>,
-  toStoreKey: (value: number | string) => number | string,
-  toCandidate: (value: number) => number | string,
-  start: number
-): number | string | typeof NO_FREE_KEY {
-  let candidate = start;
-  let landingKey = toStoreKey(toCandidate(candidate));
-  let attempts = 0;
-
-  while (storeMap.has(landingKey)) {
-    // THE BOUND IS EXACTLY TIGHT, not conservative: this walk tries
-    // `storeMap.size + 1` DISTINCT candidates against at most `storeMap.size`
-    // occupied keys, so under an injective `toStoreKey` it provably cannot fire.
-    // Under a non-injective one it provably terminates — and that is a reachable
-    // consumer state rather than a hypothesis: `transforms.boolean`
-    // (transforms.ts:4) collapses every candidate onto `true`/`false`, and
-    // `Orm.instance.transforms` (main.ts:70) is public and MUTABLE, so a consumer
-    // can register an arbitrary non-injective transform and name it as an id
-    // type. Without this, a no-id create spins forever inside a synchronous store
-    // walk and pins a worker, which is worse than either collision policy. Its
-    // EXISTENCE and its THRESHOLD are both pinned by AC8: deleting it makes AC8
-    // HANG rather than fail, and weakening it to fire on the first collision
-    // makes AC8.1 red.
-    if (++attempts > storeMap.size) return NO_FREE_KEY;
-
-    // NOTE FOR ANYONE ADDING A SECOND EXIT HERE. A `candidate + 1 === candidate`
-    // float-saturation check was written, measured, and REMOVED: with the
-    // restart-from-1 above in place, deleting the saturation check leaves the
-    // whole suite green, because the budget reaches the same `NO_FREE_KEY` one
-    // pass later and the restart still answers. An unkillable guard in a change
-    // whose deliverable is falsifiable coverage is exactly what this story exists
-    // to stop shipping. `+ 1` being a no-op at 2^53 costs `size` extra `Map.has`
-    // calls on that one path and changes no outcome.
-    candidate += 1;
-    landingKey = toStoreKey(toCandidate(candidate));
-  }
-
-  return landingKey;
-}
-
-/**
- * Returns the derivation that maps an id VALUE to the store KEY a record
- * carrying it will actually be filed under — the model's declared id transform,
- * the same one `serialize` runs at createRecord:68 before the `.set` at :69.
- */
-function storeKeyDeriver(modelName: string): (value: number | string) => number | string {
-  const idType = getIdType(modelName);
-  const transform = idType ? Orm.instance?.transforms?.[idType] : undefined;
-
-  // SURVIVOR, RETAINED, with its reachability condition stated rather than left
-  // silent — `docs/project-structure.md` § "unkillable code reads as coverage and
-  // is not" is the standing rule and it applies outside orm-request.ts too.
-  //
-  // No mutation in this repo can kill this branch, and that is STRUCTURAL rather
-  // than an untested gap: `Model` declares `id = attr('number')` (model.ts:15) so
-  // every registered model has an id type; `ModelProperty` refuses a type with no
-  // registered transform (model-property.ts:4) so a declared type always
-  // resolves; and `getIdType` can therefore only return `undefined` when
-  // `getRecordClasses` yields no `modelClass` — in which case `createRecord`
-  // throws at :62 a few lines later regardless, so no record is ever filed
-  // through this branch.
-  //
-  // BECOMES REACHABLE if a model can be declared without an `id` property, if a
-  // store map can exist for a model with no registered class, or if
-  // `createRecord` stops constructing the model class. Kept rather than deleted
-  // because the alternative on that path is a `transform is not a function`
-  // TypeError, and because identity is exactly what `createRecord` would file
-  // under when no transform exists — the two agree, which is the property AC4 is
-  // about.
-  if (typeof transform !== 'function') return value => value;
-
-  return value => {
-    try {
-      return transform(value) as number | string;
-    } catch {
-      // `uppercase` and `trim` (transforms.ts:11-12) call a string method on the
-      // value directly, so a NUMERIC candidate throws `value?.toUpperCase is not
-      // a function`. On `dev` they never saw one — `lastRecord.id + 1` on a
-      // string id is a string — so feeding them a number here would regress a
-      // legal, registered id type into an uncaught 500. The retry feeds the
-      // string form, which is the shape an id actually arrives in off a JSON body
-      // or a URL param. A transform that throws on BOTH shapes still propagates.
-      // Pinned by AC9.
-      return transform(String(value)) as number | string;
-    }
-  };
-}
-
-function getIdType(modelName: string): string | undefined {
-  const modelClass = Orm.instance?.getRecordClasses(modelName).modelClass as (new (name: string) => { [key: string]: unknown }) | undefined;
-  if (!modelClass) return undefined;
+function isStringIdModel(modelName: string): boolean {
+  const modelClass = Orm.instance.getRecordClasses(modelName).modelClass as (new (name: string) => { [key: string]: unknown }) | undefined;
+  if (!modelClass) return false;
 
   const model = new modelClass(modelName);
 
-  return (model.id as { type?: string } | undefined)?.type;
-}
-
-function isStringIdModel(modelName: string): boolean {
-  return getIdType(modelName) === 'string';
+  return (model.id as { type?: string } | undefined)?.type === 'string';
 }