@stonyx/orm 0.3.2-alpha.113 → 0.3.2-alpha.114

package/dist/column-conversion.js

@@ -23,7 +23,12 @@
 export function convertRow(row, columns, rule) {
     const converted = {};
     for (const [col, value] of Object.entries(row)) {
-        converted[col] = rule(value, columns[col]);
+        // `Object.hasOwn`, not `columns[col]`: a column named `toString` or
+        // `constructor` would otherwise reach the rule with a function as its
+        // "declared type". Inert for the shipped Postgres rule (strict equality
+        // against 'JSONB'), but `ColumnRule` is the extension point other drivers
+        // write against, and the obvious `if (columnType)` rule would invert.
+        converted[col] = rule(value, Object.hasOwn(columns, col) ? columns[col] : undefined);
     }
     return converted;
 }

package/dist/postgres/column-rules.d.ts

@@ -18,7 +18,16 @@ import type { ColumnRule } from '../column-conversion.js';
  *    `schema.columns`.
  *
  * The `'JSONB'` sentinel is the exact literal emitted by
- * `src/postgres/type-map.ts` (`getPgType`/`mysqlTypeToPg`), which is the only
- * producer of the values in `schema.columns`.
+ * `src/postgres/type-map.ts`, the only module that produces the values in
+ * `schema.columns`. The two producing functions are `getPgType` and
+ * `getVectorType` (`src/postgres/schema-introspector.ts` writes `columns[key]`
+ * at exactly three sites, all routed through those two); `mysqlTypeToPg` is not
+ * exported and is reachable only from inside `getPgType`.
+ *
+ * One documented gap: `getPgType` returns a consumer transform's declared
+ * `pgType` verbatim, so a consumer writing `pgType: 'jsonb'` puts a value in
+ * `schema.columns` that type-map never authored and this exact-match sentinel
+ * misses. It misses identically on the create path, pre-fix and post-fix --
+ * pre-existing and symmetric, not introduced here.
  */
 export declare const postgresJsonRule: ColumnRule;

package/dist/postgres/column-rules.js

@@ -17,8 +17,17 @@
  *    `schema.columns`.
  *
  * The `'JSONB'` sentinel is the exact literal emitted by
- * `src/postgres/type-map.ts` (`getPgType`/`mysqlTypeToPg`), which is the only
- * producer of the values in `schema.columns`.
+ * `src/postgres/type-map.ts`, the only module that produces the values in
+ * `schema.columns`. The two producing functions are `getPgType` and
+ * `getVectorType` (`src/postgres/schema-introspector.ts` writes `columns[key]`
+ * at exactly three sites, all routed through those two); `mysqlTypeToPg` is not
+ * exported and is reachable only from inside `getPgType`.
+ *
+ * One documented gap: `getPgType` returns a consumer transform's declared
+ * `pgType` verbatim, so a consumer writing `pgType: 'jsonb'` puts a value in
+ * `schema.columns` that type-map never authored and this exact-match sentinel
+ * misses. It misses identically on the create path, pre-fix and post-fix --
+ * pre-existing and symmetric, not introduced here.
  */
 export const postgresJsonRule = (value, columnType) => columnType === 'JSONB' && typeof value !== 'string'
     ? JSON.stringify(value)

package/package.json

@@ -4,7 +4,7 @@
     "stonyx-async",
     "stonyx-module"
   ],
-  "version": "0.3.2-alpha.113",
+  "version": "0.3.2-alpha.114",
   "description": "",
   "main": "dist/index.js",
   "type": "module",

package/src/column-conversion.ts

@@ -41,7 +41,12 @@ export function convertRow(
   const converted: Record<string, unknown> = {};
 
   for (const [col, value] of Object.entries(row)) {
-    converted[col] = rule(value, columns[col]);
+    // `Object.hasOwn`, not `columns[col]`: a column named `toString` or
+    // `constructor` would otherwise reach the rule with a function as its
+    // "declared type". Inert for the shipped Postgres rule (strict equality
+    // against 'JSONB'), but `ColumnRule` is the extension point other drivers
+    // write against, and the obvious `if (columnType)` rule would invert.
+    converted[col] = rule(value, Object.hasOwn(columns, col) ? columns[col] : undefined);
   }
 
   return converted;

package/src/postgres/column-rules.ts

@@ -19,8 +19,17 @@ import type { ColumnRule } from '../column-conversion.js';
  *    `schema.columns`.
  *
  * The `'JSONB'` sentinel is the exact literal emitted by
- * `src/postgres/type-map.ts` (`getPgType`/`mysqlTypeToPg`), which is the only
- * producer of the values in `schema.columns`.
+ * `src/postgres/type-map.ts`, the only module that produces the values in
+ * `schema.columns`. The two producing functions are `getPgType` and
+ * `getVectorType` (`src/postgres/schema-introspector.ts` writes `columns[key]`
+ * at exactly three sites, all routed through those two); `mysqlTypeToPg` is not
+ * exported and is reachable only from inside `getPgType`.
+ *
+ * One documented gap: `getPgType` returns a consumer transform's declared
+ * `pgType` verbatim, so a consumer writing `pgType: 'jsonb'` puts a value in
+ * `schema.columns` that type-map never authored and this exact-match sentinel
+ * misses. It misses identically on the create path, pre-fix and post-fix --
+ * pre-existing and symmetric, not introduced here.
  */
 export const postgresJsonRule: ColumnRule = (value, columnType) =>
   columnType === 'JSONB' && typeof value !== 'string'