@stjoseph/prumo 0.4.1 → 0.4.2

package/.prumo-templates/core/testing.md

@@ -55,11 +55,13 @@ been published since January 2024. Every other rule here (placement, no database
 behaviour) holds unchanged. **What it costs:** two runners in one workspace with near-identical APIs, so `vi.fn`
 written in a mobile test is a mistake an assistant will make.
 
-**Three things a mobile test meets, verified with Expo SDK 57:** `render` from `@testing-library/react-native` 14
+**Four things a mobile test meets, verified with Expo SDK 57:** `render` from `@testing-library/react-native` 14
 is **asynchronous** and its matchers need no setup. `expo-secure-store` needs the native Keychain or Keystore,
 which Jest does not have, so a test builds the auth client with an in-memory token store, which is why a form
 asks only for the auth methods it calls. And `jest-expo` leaves the app manifest empty, so `expo-linking` cannot
-know the app's scheme: a test that reaches `Linking.createURL` mocks it with the scheme it expects.
+know the app's scheme: a test that reaches `Linking.createURL` mocks it with the scheme it expects. A test rendering a `useMutation` builds
+its `QueryClient` with `mutations: { gcTime: Infinity }`: once unmounted, the mutation otherwise starts TanStack
+Query's five-minute garbage-collection timer, and Jest force-exits the worker still waiting on it.
 
 A coverage threshold turns a proxy into a target. Whoever is below writes tests to raise the number rather
 than to check anything; whoever is above stops thinking. With no database mocks a test costs more to write,

package/.prumo-templates/database/migrations.md

@@ -11,6 +11,8 @@ boot, and never by hand.
 Make every migration compatible with the **previous** release. Removing a column is two deployments:
 one that stops using it, one that removes it.
 
+Keep the `package.json` in the migrations directory. It holds only `"type": "module"`.
+
 Delete the generated `down`. Undoing a schema change is a new migration going forward.
 
 Keep DDL and data apart. A migration performs DDL only. Filling existing rows is a separate task, run
@@ -31,6 +33,12 @@ migration fails. It would also mean **the process serving requests holds DDL per
 injection or compromise could drop a table. A separate step lets the deploy use a privileged user for
 thirty seconds while the application runs as one that only reads and writes rows.
 
+The migrations are TypeScript that Node loads directly, by type stripping; the build never compiles
+them. They use `import`, and without a declared module type Node guesses: it fails to parse them as
+CommonJS, reparses them as ES modules, and warns `MODULE_TYPELESS_PACKAGE_JSON` in every process that
+runs them. The nearest `package.json` decides a file's type, so the one in the migrations directory
+settles it for those files alone and leaves the CommonJS build untouched.
+
 During a rolling deploy the previous version is still running against the new schema, so a migration
 that removes something the old code reads breaks production before the new version finishes arriving.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stjoseph/prumo",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "Scaffolds a TypeScript project and ships it the conventions it follows, in a .prumo/ folder any AI assistant reads.",
   "keywords": [
     "scaffolding",

package/templates/api/migrations/package.json

@@ -0,0 +1,3 @@
+{
+  "type": "module"
+}

package/templates/api/test/support/global-setup.ts

@@ -1,7 +1,7 @@
 import { PostgreSqlContainer, type StartedPostgreSqlContainer } from '@testcontainers/postgresql'
 import type { TestProject } from 'vitest/node'
 
-let container: StartedPostgreSqlContainer
+let container: StartedPostgreSqlContainer | undefined
 
 export async function setup(project: TestProject): Promise<void> {
   container = await new PostgreSqlContainer('postgres:18-alpine').start()
@@ -9,8 +9,10 @@ export async function setup(project: TestProject): Promise<void> {
   project.provide('postgresUrl', container.getConnectionUri())
 }
 
+// Vitest still tears down when setup threw, as when the image could not be pulled; there is no container then, and
+// failing here would print a second error over the one that matters.
 export async function teardown(): Promise<void> {
-  await container.stop()
+  await container?.stop()
 }
 
 declare module 'vitest' {

package/templates/mobile/test/features/profile/profile-form.spec.tsx

@@ -36,8 +36,12 @@ describe('ProfileForm', () => {
       }),
     })
 
+    // A mutation left without an observer starts a five-minute garbage-collection timer, and Jest's worker would wait
+    // it out. Infinity schedules none, as TanStack Query's testing guide advises.
+    const queryClient = new QueryClient({ defaultOptions: { mutations: { gcTime: Infinity } } })
+
     await render(
-      <QueryClientProvider client={new QueryClient()}>
+      <QueryClientProvider client={queryClient}>
         <ProfileForm api={api} profile={profile} />
       </QueryClientProvider>,
     )