@stilero/bankan 1.0.7 → 1.0.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stilero/bankan",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "type": "module",
   "description": "Run AI coding agents like a Kanban board. Plan, implement, review and ship code using parallel AI agents across your local repositories.",
   "license": "MIT",

package/server/src/orchestrator.js

@@ -7,7 +7,7 @@ import config, { loadSettings, getWorkspacesDir } from './config.js';
 import store from './store.js';
 import agentManager from './agents.js';
 import bus from './events.js';
-import { parseReviewResult, reviewShouldPass } from './workflow.js';
+import { isReviewResultPlaceholder, parseReviewResult, reviewShouldPass } from './workflow.js';
 
 const POLL_INTERVAL = 4000;
 const SIGNAL_CHECK_INTERVAL = 2500;
@@ -354,15 +354,17 @@ ${task.plan}
 Instructions:
 ${promptBody}
 
-Output ONLY in this exact format:
+Output ONLY a completed review block in this format.
+Do not copy placeholder text. Replace every field with concrete findings from the actual diff.
+Do not emit the review block until after you have run the required git diff commands and finished the review.
 
 === REVIEW START ===
-VERDICT: PASS
+VERDICT: PASS or FAIL
 CRITICAL_ISSUES:
-- none
+- concrete issue, or none
 MINOR_ISSUES:
-- (issue description, or 'none')
-SUMMARY: (2-3 sentences summarising the review)
+- concrete issue, or none
+SUMMARY: 2-3 concrete sentences summarising the review, including changed files and strengths
 === REVIEW END ===`;
 }
 
@@ -721,6 +723,7 @@ async function onReviewComplete(agentId, taskId) {
   const reviewText = getLastStructuredBlock(sourceText, '=== REVIEW START ===', '=== REVIEW END ===');
   if (!reviewText) return;
   const reviewResult = parseReviewResult(reviewText);
+  if (isReviewResultPlaceholder(reviewText, reviewResult)) return;
   const shouldPass = reviewShouldPass(reviewResult);
 
   store.updateTask(taskId, { review: reviewText });
@@ -1081,7 +1084,21 @@ function pollLoop() {
             ? hasCodexStructuredOutput(buf, '=== REVIEW END ===')
             : buf.includes('=== REVIEW END ===');
           if (reviewReady) {
-            onReviewComplete(agent.id, taskId);
+            const reviewer = agentManager.get(agent.id);
+            const bufStr = reviewer?.getBufferString(100) || '';
+            const captured = reviewer?.cli === 'codex' ? readCapturedCodexMessage(bufStr, { remove: false }) : null;
+            const sourceText = captured || bufStr;
+            const reviewText = getLastStructuredBlock(sourceText, '=== REVIEW START ===', '=== REVIEW END ===');
+            const reviewResult = reviewText ? parseReviewResult(reviewText) : null;
+            if (reviewText && reviewResult && !isReviewResultPlaceholder(reviewText, reviewResult)) {
+              onReviewComplete(agent.id, taskId);
+            } else {
+              store.updateTask(taskId, {
+                status: 'blocked',
+                blockedReason: 'Reviewer exited after returning placeholder output',
+                assignedTo: null,
+              });
+            }
           } else {
             store.updateTask(taskId, {
               status: 'blocked',
@@ -1147,8 +1164,15 @@ bus.on('agent:unexpected-exit', ({ agentId, taskId }) => {
         ? hasCodexStructuredOutput(buf, '=== REVIEW END ===')
         : buf.includes('=== REVIEW END ===');
       if (reviewReady) {
-        onReviewComplete(agentId, taskId);
-        return;
+        const captured = agent.cli === 'codex' ? readCapturedCodexMessage(buf, { remove: false }) : null;
+        const sourceText = captured || buf;
+        const reviewText = getLastStructuredBlock(sourceText, '=== REVIEW START ===', '=== REVIEW END ===');
+        const reviewResult = reviewText ? parseReviewResult(reviewText) : null;
+        if (reviewText && reviewResult && !isReviewResultPlaceholder(reviewText, reviewResult)) {
+          onReviewComplete(agentId, taskId);
+          return;
+        }
+        authBlockedReason = 'Reviewer exited after returning placeholder output';
       }
     }
     console.error(`[unexpected-exit] agent=${agentId} task=${taskId} last output:\n${buf.slice(-500)}`);

package/server/src/workflow.js

@@ -27,11 +27,13 @@ export function parseReviewResult(reviewText) {
   const minorIssues = parseBulletList(
     extractSection(reviewText, 'MINOR_ISSUES:', ['SUMMARY:', '=== REVIEW END ==='])
   ).filter(item => item.toLowerCase() !== 'none');
+  const summary = extractSection(reviewText, 'SUMMARY:', ['=== REVIEW END ===']);
 
   return {
     verdict,
     criticalIssues,
     minorIssues,
+    summary,
     hasCriticalIssues: criticalIssues.length > 0,
   };
 }
@@ -40,6 +42,20 @@ export function reviewShouldPass(reviewResult) {
   return reviewResult.verdict === 'PASS' || !reviewResult.hasCriticalIssues;
 }
 
+export function isReviewResultPlaceholder(reviewText, reviewResult = parseReviewResult(reviewText)) {
+  if (typeof reviewText !== 'string' || !reviewText.trim()) return true;
+
+  const normalized = reviewText.replace(/\s+/g, ' ').trim().toLowerCase();
+  if (normalized.includes("(issue description, or 'none')")) return true;
+  if (normalized.includes('(2-3 sentences summarising the review)')) return true;
+
+  const summary = (reviewResult.summary || '').replace(/\s+/g, ' ').trim().toLowerCase();
+  if (!summary) return true;
+  if (summary.includes('2-3 sentences summarising the review')) return true;
+
+  return false;
+}
+
 export function getLiveTaskAgent(task, agentManager) {
   if (!task?.assignedTo) return null;
   const agent = agentManager.get(task.assignedTo);

package/server/src/workflow.test.js

@@ -3,6 +3,7 @@ import assert from 'node:assert/strict';
 
 import {
   getLiveTaskAgent,
+  isReviewResultPlaceholder,
   parseReviewResult,
   reviewShouldPass,
   stageToRetryStatus,
@@ -42,6 +43,36 @@ SUMMARY: A must-fix issue remains.
   assert.equal(reviewShouldPass(result), false);
 });
 
+test('placeholder review template is rejected', () => {
+  const reviewText = `=== REVIEW START ===
+VERDICT: PASS
+CRITICAL_ISSUES:
+- none
+MINOR_ISSUES:
+- (issue description, or 'none')
+SUMMARY: (2-3 sentences summarising the review)
+=== REVIEW END ===`;
+
+  const result = parseReviewResult(reviewText);
+
+  assert.equal(isReviewResultPlaceholder(reviewText, result), true);
+});
+
+test('concrete review output is not treated as placeholder', () => {
+  const reviewText = `=== REVIEW START ===
+VERDICT: PASS
+CRITICAL_ISSUES:
+- none
+MINOR_ISSUES:
+- none
+SUMMARY: Changed files: server/src/orchestrator.js, server/src/workflow.js. The review completion gate now rejects placeholder output and the branch otherwise looks consistent with existing task flow. Strengths: the change is narrowly scoped and adds regression coverage.
+=== REVIEW END ===`;
+
+  const result = parseReviewResult(reviewText);
+
+  assert.equal(isReviewResultPlaceholder(reviewText, result), false);
+});
+
 test('retry ignores stale assigned agent process from another task', () => {
   const task = {
     id: 'T-123',