@stilero/bankan 1.0.18 → 1.0.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stilero/bankan",
-  "version": "1.0.18",
+  "version": "1.0.19",
   "type": "module",
   "description": "Run AI coding agents like a Kanban board. Plan, implement, review and ship code using parallel AI agents across your local repositories.",
   "license": "MIT",

package/server/src/orchestrator.js

@@ -545,7 +545,7 @@ RISKS:
   return prompt;
 }
 
-function buildImplementorPrompt(task, workspacePath) {
+export function buildImplementorPrompt(task, workspacePath) {
   const repoDir = workspacePath || task.repoPath;
   const promptBody = getPromptBody('implementation');
   let prompt = `You are an expert software engineer implementing a feature on a real codebase.
@@ -568,9 +568,9 @@ Instructions:
 - You are already on branch ${task.branch} in ${repoDir}
 ${promptBody}
 - Before signaling completion, ensure ALL changes are committed to git on branch ${task.branch}
-- When fully complete and all changes are committed, output the completion block below with the placeholder replaced:
+- When fully complete and all changes are committed, output the completion block below — replace {TASK_ID} with the actual TASK ID shown above:
   === IMPLEMENTATION RESULT START ===
-  === IMPLEMENTATION COMPLETE ${task.id} ===
+  === IMPLEMENTATION COMPLETE {TASK_ID} ===
   === IMPLEMENTATION RESULT END ===
 - If you encounter a blocker you cannot resolve, output:
   === IMPLEMENTATION RESULT START ===

package/server/src/orchestrator.test.js

@@ -2,12 +2,14 @@ import { describe, expect, test, vi } from 'vitest';
 
 import {
   buildAgentCommand,
+  buildImplementorPrompt,
   cleanTerminalArtifacts,
   extractImplementationResult,
   extractPlannerPlanText,
   extractReviewerReviewText,
   sanitizeBranchName,
 } from './orchestrator.js';
+import { isImplementationPlaceholder } from './workflow.js';
 
 describe('structured output extraction', () => {
   test('planner extraction falls back to agent structured capture when the PTY tail lost the full block', () => {
@@ -265,6 +267,49 @@ SUMMARY: Stable review capture prevents timeout.
     expect(result).not.toContain('{task.id}');
   });
 
+  test('implementation extraction rejects echoed prompt with {TASK_ID} placeholder and finds real block', () => {
+    // After the fix, the prompt template uses {TASK_ID} instead of the
+    // interpolated task ID, so the streaming parser captures a block with
+    // {TASK_ID} which isImplementationPlaceholder correctly rejects.
+    const readCaptured = vi.fn(() => null);
+    const echoedBlock = `=== IMPLEMENTATION RESULT START ===
+  === IMPLEMENTATION COMPLETE {TASK_ID} ===
+  === IMPLEMENTATION RESULT END ===`;
+    const realBlock = `=== IMPLEMENTATION RESULT START ===
+  === IMPLEMENTATION COMPLETE T-ABC123 ===
+  === IMPLEMENTATION RESULT END ===`;
+    const agent = {
+      cli: 'claude',
+      getBufferString: vi.fn(() => 'noise'),
+      getStructuredBlock: vi.fn(() => echoedBlock),
+      getAllCapturedBlocks: vi.fn(() => [echoedBlock, realBlock]),
+    };
+
+    const result = extractImplementationResult(agent, { readCapturedCodexMessage: readCaptured });
+    expect(result).toContain('IMPLEMENTATION COMPLETE T-ABC123');
+    expect(result).not.toContain('{TASK_ID}');
+  });
+
+  test('implementation extraction returns null when only echoed {TASK_ID} block exists', () => {
+    // When the agent has only echoed the prompt and hasn't produced real
+    // output yet, extraction should return the placeholder (which the
+    // signal checker will then reject via isImplementationPlaceholder).
+    const readCaptured = vi.fn(() => null);
+    const echoedBlock = `=== IMPLEMENTATION RESULT START ===
+  === IMPLEMENTATION COMPLETE {TASK_ID} ===
+  === IMPLEMENTATION RESULT END ===`;
+    const agent = {
+      cli: 'claude',
+      getBufferString: vi.fn(() => echoedBlock),
+      getStructuredBlock: vi.fn(() => echoedBlock),
+      getAllCapturedBlocks: vi.fn(() => [echoedBlock]),
+    };
+
+    const result = extractImplementationResult(agent, { readCapturedCodexMessage: readCaptured });
+    // Should return the placeholder block (caller checks isImplementationPlaceholder)
+    expect(result).toContain('{TASK_ID}');
+  });
+
   test('implementation extraction falls back to buffer scan when structured capture is placeholder', () => {
     const readCaptured = vi.fn(() => null);
     const templateBlock = `=== IMPLEMENTATION RESULT START ===
@@ -285,6 +330,34 @@ SUMMARY: Stable review capture prevents timeout.
   });
 });
 
+describe('implementation prompt echo safety', () => {
+  test('completion block in implementor prompt is detected as placeholder by isImplementationPlaceholder', () => {
+    // This is the core bug: the prompt template interpolates ${task.id} into
+    // the example completion block. When the CLI echoes the prompt, the
+    // streaming parser captures a block with the real task ID, and
+    // isImplementationPlaceholder fails to detect it as a template echo.
+    const task = {
+      id: 'T-4F66CF',
+      title: 'Reporting',
+      branch: 'feature/t-4f66cf-reporting',
+      plan: 'Add reporting feature',
+    };
+    const prompt = buildImplementorPrompt(task, '/tmp/workspace');
+
+    // Extract the completion block from the prompt the same way the
+    // streaming parser would when the CLI echoes the prompt.
+    const startMarker = '=== IMPLEMENTATION RESULT START ===';
+    const endMarker = '=== IMPLEMENTATION RESULT END ===';
+    const startIdx = prompt.indexOf(startMarker);
+    const endIdx = prompt.indexOf(endMarker, startIdx);
+    const echoedBlock = prompt.slice(startIdx, endIdx + endMarker.length);
+
+    // The echoed completion block from the prompt MUST be detected as a
+    // placeholder — otherwise the signal checker treats it as real completion.
+    expect(isImplementationPlaceholder(echoedBlock)).toBe(true);
+  });
+});
+
 describe('sanitizeBranchName', () => {
   test('strips garbage text appended by ANSI cursor collapse', () => {
     expect(sanitizeBranchName('feature/t-a811ca-reporting FILES_TO_MODIFY:'))

package/server/src/workflow.js

@@ -61,6 +61,7 @@ export function isImplementationPlaceholder(resultText) {
   if (typeof resultText !== 'string' || !resultText.trim()) return true;
   const normalized = resultText.replace(/\s+/g, ' ').trim().toLowerCase();
   if (normalized.includes('{describe the blocker here}')) return true;
+  if (normalized.includes('{task_id}')) return true;
   // The prompt template contains placeholder instruction text — if the
   // captured block matches the template exactly it's an echo, not real output.
   if (normalized.includes('output the completion block below with the placeholder replaced')) return true;

package/server/src/workflow.test.js

@@ -195,6 +195,13 @@ some random text without markers
 === IMPLEMENTATION RESULT END ===`;
     expect(isImplementationPlaceholder(noise)).toBe(true);
   });
+
+  test('echoed prompt with {TASK_ID} placeholder is detected as placeholder', () => {
+    const echoedWithPlaceholder = `=== IMPLEMENTATION RESULT START ===
+  === IMPLEMENTATION COMPLETE {TASK_ID} ===
+  === IMPLEMENTATION RESULT END ===`;
+    expect(isImplementationPlaceholder(echoedWithPlaceholder)).toBe(true);
+  });
 });
 
 describe('retry status resolution', () => {