@stigmer/server 3.23.0 → 3.24.0

package/src/authorization/derived-tuples.ts

@@ -12,7 +12,6 @@
  *   - owner SELF:     <row>#owner@identity_account:<row id>
  *   - creator:        <row>#creator@identity_account:<creator stamp>   (kinds flagged requires_creator_tuple)
  *   - org-viewer:     <row>#viewer@organization:<org>#viewer          (visibility_org; cloud#257's shape)
- *   - public-viewer:  <row>#viewer@identity_account:* with allow_public
  *   - platform-viewer: none — it fans out over identity providers, a kind this edition does not serve
  *
  * Two facts are this edition's own and are stated here, nowhere else:
@@ -91,11 +90,7 @@ import type {
   Tuple,
   TupleSource,
 } from "./tuples.js";
-import {
-  ACCOUNT_TYPE,
-  ALLOW_PUBLIC_CONDITION,
-  formatObjectRef,
-} from "./tuples.js";
+import { ACCOUNT_TYPE, formatObjectRef } from "./tuples.js";
 
 /**
  * Kinds whose `[identity_account]` owner is recorded as an IamPolicy row
@@ -184,12 +179,6 @@ function visibilitySubject(
             object: { type: "organization", id: org },
             relation: "viewer",
           };
-    case "public-viewer":
-      return {
-        form: "wildcard",
-        type: ACCOUNT_TYPE,
-        condition: ALLOW_PUBLIC_CONDITION,
-      };
     case "platform-viewer":
       return undefined;
     default: {
@@ -361,24 +350,18 @@ function tupleOfRow(row: IamPolicy): Tuple {
     type: principal?.kind ?? "",
     id: principal?.id ?? "",
   };
-  let subject: Subject;
-  if (principal !== undefined && principal.relation !== "") {
-    subject = {
-      form: "userset",
-      object: principalObject,
-      relation: principal.relation,
-    };
-  } else if (principalObject.id === "*") {
-    // A wildcard row carries no condition of its own; the evaluator
-    // honours it only where a line admits an unconditioned wildcard,
-    // which no line in the model does.
-    subject = {
-      form: "wildcard",
-      type: principalObject.type,
-      condition: undefined,
-    };
-  } else {
-    subject = { form: "object", object: principalObject };
-  }
+  // A principal id of `*` (a wildcard row a cloud database may still hold
+  // from the retired public level) is read as an ordinary object id here:
+  // no person carries `*` among their aliases, so the row matches nobody
+  // and reads as the inert grant it is, never as a fault that would turn
+  // the resource unreadable.
+  const subject: Subject =
+    principal !== undefined && principal.relation !== ""
+      ? {
+          form: "userset",
+          object: principalObject,
+          relation: principal.relation,
+        }
+      : { form: "object", object: principalObject };
   return { object, relation: spec?.relation ?? "", subject };
 }

package/src/authorization/evaluator.ts

@@ -1,10 +1,11 @@
 /**
  * The evaluator — OpenFGA's check, over the built-in model and a tuple
  * source, small because the model uses four rewrite forms and nothing
- * else (model/rewrite.ts). `checkRelation(object, relation, person, context)`
+ * else (model/rewrite.ts). `checkRelation(object, relation, person)`
  * answers "does this person hold this relation on this object" the way
  * the cloud's engine answers it over stored tuples, so the two editions
- * share one meaning of authorization.
+ * share one meaning of authorization. There is no context parameter: the
+ * model declares no condition, so a check has no posture to state.
  *
  * The walk, in the order a `.fga` line reads:
  *   - `this`: the tuples on (object, relation). A tuple counts only if
@@ -12,9 +13,7 @@
  *     OpenFGA makes at write time, made here at read time, so a derived
  *     tuple the model no longer admits denies instead of allowing. An
  *     object subject matches when it names one of the person's aliases;
- *     a userset subject is resolved on its own object; the wildcard is
- *     honoured only under its condition (`allow_public` reads the
- *     context's `allow`; an unknown condition is a fault).
+ *     a userset subject is resolved on its own object.
  *   - `computed`: the same object, another relation.
  *   - `from`: every object the tupleset relation links to (again within
  *     the tupleset line's type restriction), resolved for the relation.
@@ -44,19 +43,8 @@
  */
 import type { Model } from "./model/index.js";
 import type { Rewrite, SubjectType } from "./model/rewrite.js";
-import type {
-  CheckContext,
-  ObjectRef,
-  Person,
-  Subject,
-  TupleSource,
-} from "./tuples.js";
-import {
-  ACCOUNT_TYPE,
-  ALLOW_PUBLIC_CONDITION,
-  formatObjectRef,
-  pairKey,
-} from "./tuples.js";
+import type { ObjectRef, Person, Subject, TupleSource } from "./tuples.js";
+import { ACCOUNT_TYPE, formatObjectRef, pairKey } from "./tuples.js";
 
 /**
  * OpenFGA's default resolution-depth limit (its `resolveNodeLimit`), so
@@ -77,8 +65,7 @@ export type EvaluationFault =
   | "undeclared-target-kind"
   | "internal-caller-offered"
   | "resolution-depth-exceeded"
-  | "resolution-cycle"
-  | "unknown-condition";
+  | "resolution-cycle";
 
 /** A fault in the model or its evaluation — never a denial; the driver maps it to `unavailable`. */
 export class AuthorizationEvaluationError extends Error {
@@ -101,7 +88,6 @@ export async function checkRelation(
   object: ObjectRef,
   relation: string,
   person: Person,
-  context: CheckContext,
 ): Promise<boolean> {
   if (deps.model.byType(object.type) === undefined) {
     throw new AuthorizationEvaluationError(
@@ -109,7 +95,7 @@ export async function checkRelation(
       `no declaration for kind '${object.type}' (target ${formatObjectRef(object)})`,
     );
   }
-  return new Walk(deps, person, context).resolve(object, relation, 0);
+  return new Walk(deps, person).resolve(object, relation, 0);
 }
 
 /** One check's state: the memo and the in-progress set, over one source. */
@@ -120,7 +106,6 @@ class Walk {
   constructor(
     private readonly deps: EvaluationDeps,
     private readonly person: Person,
-    private readonly context: CheckContext,
   ) {}
 
   resolve(
@@ -234,15 +219,6 @@ class Walk {
               allowed.relation === subject.relation,
           ) && (await this.resolve(subject.object, subject.relation, depth + 1))
         );
-      case "wildcard": {
-        const allowed = restriction.some(
-          (entry) =>
-            entry.form === "wildcard" &&
-            entry.type === subject.type &&
-            entry.condition === subject.condition,
-        );
-        return allowed && this.conditionHolds(subject.condition);
-      }
       default: {
         const exhaustive: never = subject;
         throw new Error(`unknown subject form: ${JSON.stringify(exhaustive)}`);
@@ -250,18 +226,6 @@ class Walk {
     }
   }
 
-  private conditionHolds(condition: string | undefined): boolean {
-    switch (condition) {
-      case ALLOW_PUBLIC_CONDITION:
-        return this.context.allow;
-      default:
-        throw new AuthorizationEvaluationError(
-          "unknown-condition",
-          `the model declares no condition '${String(condition)}'`,
-        );
-    }
-  }
-
   /** The object types the tupleset line admits — `[organization]`, `[session]` — from its `this` nodes. */
   private objectTypesOf(
     object: ObjectRef,

package/src/authorization/list-read-scope.ts

@@ -11,12 +11,10 @@
  * row a second time. A self-host's lists show a person exactly what a
  * `get` would let them read.
  *
- * Both verbs ask under the LISTING context, `allow: false` — the public
- * wildcard suppressed, the cloud's own posture (its Java
- * listAuthorizedResourceIds set it): a legacy PUBLIC row reads for any
- * signed-in person on a point check and never expands into an outsider's
- * listing; the organization's own people still reach it through the
- * org-viewer shape public also emits.
+ * Both verbs ask the same question a point check asks, `can_view` on the
+ * candidate: the model has no subject whose answer differs between a
+ * listing and a get, so a list is exactly the set of rows a get would
+ * read.
  *
  *   - `restrictListEntries`: one derived source for the caller, seeded
  *     with every candidate's facts; one `checkRelation` per unique id —
@@ -84,14 +82,11 @@ import { builtInModel } from "./model/index.js";
 import type { KindDeclaration } from "./model/rewrite.js";
 import type { AccountsByCaller } from "./person.js";
 import { resolvePerson } from "./person.js";
-import type { CheckContext, ObjectRef, Person } from "./tuples.js";
+import type { ObjectRef, Person } from "./tuples.js";
 
 /** The relation every list lane reads through (the cloud's LIST_RELATION). */
 const LIST_RELATION = "can_view";
 
-/** The listing context: the public wildcard suppressed (the module header). */
-const LISTING: CheckContext = { allow: false };
-
 export interface BuiltInListReadScopeDeps {
   readonly store: Store;
   /** The port the grant path writes through — the person's rows are read from the same instance. */
@@ -138,7 +133,6 @@ export function newBuiltInListReadScope(
           object,
           LIST_RELATION,
           person,
-          LISTING,
         );
         return allowed ? facts.id : undefined;
       }),

package/src/authorization/model/agent.ts

@@ -4,9 +4,8 @@
  * read by whoever the visibility axis lets in. The `organization#member`
  * and `organization#viewer` usersets on `viewer` are the org-visibility
  * tuple's two shapes (the cloud writes `#viewer` since cloud#257; `#member`
- * is the legacy shape it still honours), the conditional wildcard is the
- * public level, and `platform_viewer` is an identity-provider userset no
- * open-source tuple ever names.
+ * is the legacy shape it still honours), and `platform_viewer` is an
+ * identity-provider userset no open-source tuple ever names.
  */
 import { AgentSchema } from "@stigmer/protos/ai/stigmer/agentic/agent/v1/api_pb";
 import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/apiresourcekind/api_resource_kind_pb";
@@ -17,7 +16,6 @@ import {
   direct,
   from,
   objectOf,
-  publicWith,
   union,
   usersetOf,
 } from "./rewrite.js";
@@ -44,7 +42,6 @@ export const agentDeclaration = declareKind({
       union(
         direct(
           objectOf("identity_account"),
-          publicWith("identity_account", "allow_public"),
           usersetOf("organization", "member"),
           usersetOf("organization", "viewer"),
         ),

package/src/authorization/model/agent_instance.ts

@@ -19,7 +19,6 @@ import {
   direct,
   from,
   objectOf,
-  publicWith,
   union,
   usersetOf,
 } from "./rewrite.js";
@@ -38,7 +37,6 @@ export const agentInstanceDeclaration = declareKind({
       union(
         direct(
           objectOf("identity_account"),
-          publicWith("identity_account", "allow_public"),
           usersetOf("organization", "member"),
           usersetOf("organization", "viewer"),
         ),

package/src/authorization/model/mcp_server.ts

@@ -12,7 +12,6 @@ import {
   direct,
   from,
   objectOf,
-  publicWith,
   union,
   usersetOf,
 } from "./rewrite.js";
@@ -39,7 +38,6 @@ export const mcpServerDeclaration = declareKind({
       union(
         direct(
           objectOf("identity_account"),
-          publicWith("identity_account", "allow_public"),
           usersetOf("organization", "member"),
           usersetOf("organization", "viewer"),
         ),

package/src/authorization/model/plugin.ts

@@ -2,8 +2,7 @@
  * Transcript of fga/model/agentic/plugin.fga — the unit of install, shaped
  * exactly like a skill: an organization-owned blueprint whose owner is the
  * installer (and, through the organization, its admins), whose viewers are
- * the org's members and viewers, public readers when published, and the
- * platform viewer. Its verbs are the blueprint set: `can_view`, `can_edit`
+ * the org's members and viewers and the platform viewer. Its verbs are the blueprint set: `can_view`, `can_edit`
  * (visibility), `can_delete` (uninstall), `can_grant_access`,
  * `can_view_access`; `can_use` is carried as the model's word for
  * "install from" though no wire permission names it yet.
@@ -21,7 +20,6 @@ import {
   direct,
   from,
   objectOf,
-  publicWith,
   union,
   usersetOf,
 } from "./rewrite.js";
@@ -48,7 +46,6 @@ export const pluginDeclaration = declareKind({
       union(
         direct(
           objectOf("identity_account"),
-          publicWith("identity_account", "allow_public"),
           usersetOf("organization", "member"),
           usersetOf("organization", "viewer"),
         ),

package/src/authorization/model/rewrite.ts

@@ -6,12 +6,17 @@
  *   define organization: [organization]                      → direct(objectOf("organization"))
  *   define owner: [identity_account] or admin from organization
  *                → union(direct(objectOf("identity_account")), from("admin", "organization"))
- *   define viewer: [identity_account, identity_account:* with allow_public,
- *                   organization#member, organization#viewer] or owner or platform_viewer
- *                → union(direct(objectOf(...), publicWith(...), usersetOf(...), usersetOf(...)),
+ *   define viewer: [identity_account, organization#member, organization#viewer]
+ *                   or owner or platform_viewer
+ *                → union(direct(objectOf(...), usersetOf(...), usersetOf(...)),
  *                        computed("owner"), computed("platform_viewer"))
  *   define can_view: viewer                                   → computed("viewer")
  *
+ * A subject type is an object type or a userset; the model admits no
+ * wildcard (`type:*`) and declares no condition, so neither has a form
+ * here. The day a line needs one, the transcript cannot be written and
+ * the gap is a design act.
+ *
  * A declaration file (model/<kind>.ts) is a TRANSCRIPT of its `.fga`
  * file: the same relations, in the file's order, each line rewritten in
  * these builders so a reader with the model open sees the same text, and
@@ -53,12 +58,6 @@ export type SubjectType =
       readonly form: "userset";
       readonly type: string;
       readonly relation: string;
-    }
-  /** `[identity_account:* with allow_public]` — every object of the type, under the condition. */
-  | {
-      readonly form: "wildcard";
-      readonly type: string;
-      readonly condition: string;
     };
 
 export type Rewrite =
@@ -87,10 +86,6 @@ export function usersetOf(type: string, relation: string): SubjectType {
   return { form: "userset", type, relation };
 }
 
-export function publicWith(type: string, condition: string): SubjectType {
-  return { form: "wildcard", type, condition };
-}
-
 export function direct(...subjects: ReadonlyArray<SubjectType>): Rewrite {
   return { node: "this", subjects };
 }

package/src/authorization/model/skill.ts

@@ -14,7 +14,6 @@ import {
   direct,
   from,
   objectOf,
-  publicWith,
   union,
   usersetOf,
 } from "./rewrite.js";
@@ -41,7 +40,6 @@ export const skillDeclaration = declareKind({
       union(
         direct(
           objectOf("identity_account"),
-          publicWith("identity_account", "allow_public"),
           usersetOf("organization", "member"),
           usersetOf("organization", "viewer"),
         ),

package/src/authorization/model/workflow.ts

@@ -14,7 +14,6 @@ import {
   direct,
   from,
   objectOf,
-  publicWith,
   union,
   usersetOf,
 } from "./rewrite.js";
@@ -41,7 +40,6 @@ export const workflowDeclaration = declareKind({
       union(
         direct(
           objectOf("identity_account"),
-          publicWith("identity_account", "allow_public"),
           usersetOf("organization", "member"),
           usersetOf("organization", "viewer"),
         ),

package/src/authorization/model/workflow_instance.ts

@@ -30,7 +30,6 @@ import {
   direct,
   from,
   objectOf,
-  publicWith,
   union,
   usersetOf,
 } from "./rewrite.js";
@@ -84,7 +83,6 @@ export const workflowInstanceDeclaration = declareKind({
       union(
         direct(
           objectOf("identity_account"),
-          publicWith("identity_account", "allow_public"),
           usersetOf("organization", "member"),
           usersetOf("organization", "viewer"),
         ),

package/src/authorization/organization-directory.ts

@@ -32,8 +32,7 @@
  * annotation, which is why this driver meets that caller at all: a
  * skip lane hands the directory the identity the interceptor stamped,
  * and no Authorize arm ran before it. Every other caller gets the
- * evaluated list. The listing context (`allow: false`) is the cloud's,
- * though no organization line admits a wildcard.
+ * evaluated list.
  * The controller loads each id it is handed and skips the ones whose row
  * is gone (grants can outlive rows); the source has already loaded the
  * row once for the evaluation — two primary-key reads per organization,
@@ -102,7 +101,6 @@ export function newBuiltInOrganizationDirectory(
             { type: ORGANIZATION, id },
             "can_view",
             person,
-            { allow: false },
           )
         ) {
           visible.push(id);

package/src/authorization/store-test-kit.ts

@@ -41,26 +41,18 @@
  * `skipped` is therefore complete once every case has run; a consumer
  * pins it after the cases, which is the order a test file declares them.
  *
- * Context. A check's `context.allow` is the `allow_public` parameter
- * (tuples.ts). A check without a context runs with `allow: false`, the
- * listing posture: OpenFGA itself would fault on a conditional tuple it
- * reached with the parameter missing, so the cloud's documents never do
- * that — their CI would already fail — and the choice cannot change an
- * answer the oracle gives. The parser is strict on purpose: an unknown
- * key anywhere is a thrown fault, so a change to the format upstream is
- * loud here rather than half-run.
+ * The parser is strict on purpose: an unknown key anywhere is a thrown
+ * fault, so a change to the format upstream is loud here rather than
+ * half-run. The model declares no condition, so the format's `condition`
+ * on a tuple and `context` on a check are among the keys refused: a
+ * document that still carries them is written against a model this
+ * evaluator does not answer, and saying so beats running it half-blind.
  */
 import assert from "node:assert/strict";
 
 import { checkRelation } from "./evaluator.js";
 import type { Model } from "./model/index.js";
-import type {
-  CheckContext,
-  Person,
-  Subject,
-  Tuple,
-  TupleSource,
-} from "./tuples.js";
+import type { Person, Subject, Tuple, TupleSource } from "./tuples.js";
 import {
   ACCOUNT_TYPE,
   newInMemoryTupleSource,
@@ -76,20 +68,17 @@ export interface StoreTestTuple {
   readonly user: string;
   readonly relation: string;
   readonly object: string;
-  readonly condition?: { readonly name: string };
 }
 
 export interface StoreTestCheck {
   readonly user: string;
   readonly object: string;
-  readonly context?: CheckContext;
   readonly assertions: Readonly<Record<string, boolean>>;
 }
 
 export interface StoreTestListObjects {
   readonly user: string;
   readonly type: string;
-  readonly context?: CheckContext;
   readonly assertions: Readonly<Record<string, ReadonlyArray<string>>>;
 }
 
@@ -132,28 +121,12 @@ export function parseStoreTestDocument(
 }
 
 function parseTuple(value: unknown, where: string): StoreTestTuple {
-  const entry = record(value, where, [
-    "user",
-    "relation",
-    "object",
-    "condition",
-  ]);
-  const tuple: StoreTestTuple = {
+  const entry = record(value, where, ["user", "relation", "object"]);
+  return {
     user: text(entry["user"], `${where}.user`),
     relation: text(entry["relation"], `${where}.relation`),
     object: text(entry["object"], `${where}.object`),
   };
-  if (entry["condition"] === undefined) {
-    return tuple;
-  }
-  const condition = record(entry["condition"], `${where}.condition`, [
-    "name",
-    "context",
-  ]);
-  return {
-    ...tuple,
-    condition: { name: text(condition["name"], `${where}.condition.name`) },
-  };
 }
 
 function parseTest(value: unknown, where: string): StoreTest {
@@ -173,12 +146,7 @@ function parseTest(value: unknown, where: string): StoreTest {
 }
 
 function parseCheck(value: unknown, where: string): StoreTestCheck {
-  const entry = record(value, where, [
-    "user",
-    "object",
-    "context",
-    "assertions",
-  ]);
+  const entry = record(value, where, ["user", "object", "assertions"]);
   const assertions = record(entry["assertions"], `${where}.assertions`);
   const parsed: Record<string, boolean> = {};
   for (const [relation, expected] of Object.entries(assertions)) {
@@ -187,17 +155,15 @@ function parseCheck(value: unknown, where: string): StoreTestCheck {
     }
     parsed[relation] = expected;
   }
-  const context = parseContext(entry["context"], `${where}.context`);
   return {
     user: text(entry["user"], `${where}.user`),
     object: text(entry["object"], `${where}.object`),
-    ...(context === undefined ? {} : { context }),
     assertions: parsed,
   };
 }
 
 function parseListObjects(value: unknown, where: string): StoreTestListObjects {
-  const entry = record(value, where, ["user", "type", "context", "assertions"]);
+  const entry = record(value, where, ["user", "type", "assertions"]);
   const assertions = record(entry["assertions"], `${where}.assertions`);
   const parsed: Record<string, ReadonlyArray<string>> = {};
   for (const [relation, expected] of Object.entries(assertions)) {
@@ -205,26 +171,13 @@ function parseListObjects(value: unknown, where: string): StoreTestListObjects {
       (item, index) => text(item, `${where}.assertions.${relation}[${index}]`),
     );
   }
-  const context = parseContext(entry["context"], `${where}.context`);
   return {
     user: text(entry["user"], `${where}.user`),
     type: text(entry["type"], `${where}.type`),
-    ...(context === undefined ? {} : { context }),
     assertions: parsed,
   };
 }
 
-function parseContext(value: unknown, where: string): CheckContext | undefined {
-  if (value === undefined) {
-    return undefined;
-  }
-  const entry = record(value, where, ["allow"]);
-  if (typeof entry["allow"] !== "boolean") {
-    throw new Error(`${where}.allow: expected a boolean`);
-  }
-  return { allow: entry["allow"] };
-}
-
 function record(
   value: unknown,
   where: string,
@@ -297,9 +250,6 @@ export interface StoreTestKit {
   readonly skipped: ReadonlyArray<StoreTestSkip>;
 }
 
-/** The listing posture, for a check the document leaves without a context (the module header). */
-const CONTEXT_WHEN_ABSENT: CheckContext = { allow: false };
-
 /**
  * The document's tests as runnable cases over `model`, plus every
  * assertion group the kit does not run.
@@ -346,7 +296,6 @@ export function storeTestCases(
         for (const item of runnable) {
           const object = parseObjectRef(item.object);
           const person = personOf(item.user);
-          const context = item.context ?? CONTEXT_WHEN_ABSENT;
           for (const [relation, expected] of Object.entries(item.assertions)) {
             const recording = recordUndeclaredTypes(source, model);
             const actual = await checkRelation(
@@ -354,7 +303,6 @@ export function storeTestCases(
               object,
               relation,
               person,
-              context,
             );
             if (recording.reached.size > 0) {
               skipped.push({
@@ -371,7 +319,7 @@ export function storeTestCases(
             assert.equal(
               actual,
               expected,
-              `${document.name} :: ${test.name}: ${item.user} ${relation} ${item.object} (allow: ${String(context.allow)}) expected ${String(expected)}, got ${String(actual)}`,
+              `${document.name} :: ${test.name}: ${item.user} ${relation} ${item.object} expected ${String(expected)}, got ${String(actual)}`,
             );
           }
         }
@@ -389,10 +337,9 @@ interface RecordingTupleSource extends TupleSource {
 /**
  * A view of `inner` that records, for one walk, every subject type the
  * evaluator read that `model` does not declare. A person
- * (`identity_account:<id>`, the wildcard) is a subject the evaluator
- * compares, never a type it resolves, so it is not a "reach" whatever
- * the model declares; a userset or a parent object of an undeclared
- * type is.
+ * (`identity_account:<id>`) is a subject the evaluator compares, never a
+ * type it resolves, so it is not a "reach" whatever the model declares; a
+ * userset or a parent object of an undeclared type is.
  */
 function recordUndeclaredTypes(
   inner: TupleSource,
@@ -423,8 +370,6 @@ function resolvedTypeOf(subject: Subject): string | undefined {
         : subject.object.type;
     case "userset":
       return subject.object.type;
-    case "wildcard":
-      return undefined;
     default: {
       const exhaustive: never = subject;
       throw new Error(`unknown subject form: ${JSON.stringify(exhaustive)}`);
@@ -433,14 +378,10 @@ function resolvedTypeOf(subject: Subject): string | undefined {
 }
 
 function tupleOf(entry: StoreTestTuple): Tuple {
-  const subject = parseSubject(entry.user);
   return {
     object: parseObjectRef(entry.object),
     relation: entry.relation,
-    subject:
-      subject.form === "wildcard" && entry.condition !== undefined
-        ? { ...subject, condition: entry.condition.name }
-        : subject,
+    subject: parseSubject(entry.user),
   };
 }