@stigmer/server 3.22.1-dev.20260922095755 → 3.22.1

package/src/authorization/__tests__/derived-tuples.test.ts

@@ -3,7 +3,8 @@
  * built-in authorizer: which tuples a stored row stands for, in exactly
  * the shapes the cloud's tuple driver writes (stigmer-cloud
  * iam/tuple-lifecycle.ts: `organization:<org>#viewer` for the org level,
- * the owner by the kind's attribution, the parent links by `kind_meta`). Two facts are the
+ * the conditional `identity_account:*` for public, the owner by the
+ * kind's attribution, the parent links by `kind_meta`). Two facts are the
  * OSS edition's own and are pinned here by name: the organization's owner
  * is a ROW (2b's role lifecycle), never derived from its creator stamp,
  * or a revoked founder would stay owner; and a stamp that names no person
@@ -95,7 +96,7 @@ describe("deriveTuples — the cloud driver's shapes, from the row", () => {
     ]);
   });
 
-  it("a row that still carries the retired public level derives no viewer tuple at all — no shape reaches every account, and the level's own org floor left with it", () => {
+  it("a public blueprint adds the conditional wildcard AND keeps the org floor", () => {
     expect(
       derivedFor("skill", {
         visibility: ApiResourceVisibility.visibility_public,
@@ -103,6 +104,8 @@ describe("deriveTuples — the cloud driver's shapes, from the row", () => {
     ).toEqual([
       "skill:skill-1#organization@organization:acme",
       "skill:skill-1#owner@identity_account:ida_carol",
+      "skill:skill-1#viewer@identity_account:* with allow_public",
+      "skill:skill-1#viewer@organization:acme#viewer",
     ]);
   });
 
@@ -163,7 +166,7 @@ describe("deriveTuples — the cloud driver's shapes, from the row", () => {
     ).toEqual(["memory:memory-1#organization@organization:acme"]);
   });
 
-  it("an environment carries its creator tuple and an org-viewer at org level, and nothing beyond its org ceiling", () => {
+  it("an environment carries its creator tuple, an org-viewer at org level, and NO public wildcard (the kind's ceiling)", () => {
     expect(
       derivedFor("environment", {
         visibility: ApiResourceVisibility.visibility_org,
@@ -176,7 +179,7 @@ describe("deriveTuples — the cloud driver's shapes, from the row", () => {
     ]);
     expect(
       derivedFor("environment", {
-        visibility: ApiResourceVisibility.visibility_platform,
+        visibility: ApiResourceVisibility.visibility_public,
       }),
     ).toEqual([
       "environment:environment-1#organization@organization:acme",
@@ -506,6 +509,9 @@ describe.each(driverFixtures(SEEDED_KINDS))(
             object,
             "can_view",
             DAVE,
+            {
+              allow: false,
+            },
           ),
         ).toBe(true);
         expect(rowReads).toBe(1);
@@ -701,6 +707,7 @@ describe.each(driverFixtures(SEEDED_KINDS))(
           parseObjectRef(object),
           relation,
           person,
+          { allow: true },
         );
       }
 

package/src/authorization/__tests__/evaluator.test.ts

@@ -1,10 +1,11 @@
 /**
  * Pins the evaluator's semantics the store tests cannot express (the
  * cloud's `.fga.yaml` documents prove the model's answers; this file
- * proves the machinery under them): how a person matches a tuple, that a
- * direct tuple outside the line's type restriction is ignored (model drift
- * fails closed), how far a resolution may walk, and that a declaration
- * cycle or an undeclared target is a thrown fault and never a silent deny.
+ * proves the machinery under them): how a person matches a tuple, what
+ * the `allow_public` context does, that a direct tuple outside the line's
+ * type restriction is ignored (model drift fails closed), how far a
+ * resolution may walk, and that a declaration cycle or an undeclared
+ * target is a thrown fault and never a silent deny.
  *
  * The fixture source is the in-memory one the store-test kit uses, so the
  * two proofs share one tuple vocabulary. Where a case needs a shape the
@@ -29,6 +30,7 @@ import {
   direct,
   from,
   objectOf,
+  publicWith,
   union,
   usersetOf,
 } from "../model/rewrite.js";
@@ -54,17 +56,22 @@ function person(accountId: string, ...aliases: string[]): Person {
   return { accountId, aliases: new Set([accountId, ...aliases]) };
 }
 
+const RESOLVE = { allow: true };
+const LIST = { allow: false };
+
 async function allowed(
   source: TupleSource,
   object: string,
   relation: string,
   who: Person,
+  context = RESOLVE,
 ): Promise<boolean> {
   return checkRelation(
     { model: builtInModel, source },
     parseObjectRef(object),
     relation,
     who,
+    context,
   );
 }
 
@@ -93,17 +100,67 @@ describe("a person against a direct tuple", () => {
   });
 });
 
-describe("a stranger against a row with no grant that names them", () => {
-  it("reads nothing: no subject form reaches every account, so a stranger holds no relation on a row they were not granted", async () => {
-    const source = newInMemoryTupleSource([
-      tuple("agent:open#organization@organization:acme"),
-      tuple("agent:open#owner@identity_account:ida_carol"),
-      tuple("agent:open#viewer@organization:acme#viewer"),
-    ]);
-    const stranger = person("ida_mallory");
+describe("the public wildcard and its condition", () => {
+  const publicViewer = (object: string): Tuple => ({
+    object: parseObjectRef(object),
+    relation: "viewer",
+    subject: {
+      form: "wildcard",
+      type: "identity_account",
+      condition: "allow_public",
+    },
+  });
+  const source = newInMemoryTupleSource([
+    tuple("agent:open#organization@organization:acme"),
+    publicViewer("agent:open"),
+  ]);
+  const stranger = person("ida_mallory");
+
+  it("reads for anyone on a point check (the cloud's `allow: true`) and for nobody in a listing (`allow: false`)", async () => {
     expect(await allowed(source, "agent:open", "can_view", stranger)).toBe(
-      false,
+      true,
     );
+    expect(
+      await allowed(source, "agent:open", "can_view", stranger, LIST),
+    ).toBe(false);
+  });
+
+  it("ignores a wildcard tuple that carries no condition where the line demands one — a tuple the cloud could never have written", async () => {
+    const bare = newInMemoryTupleSource([
+      tuple("agent:open#viewer@identity_account:*"),
+    ]);
+    expect(await allowed(bare, "agent:open", "can_view", stranger)).toBe(false);
+  });
+
+  it("is a thrown fault under a condition the transcript names but the evaluator does not know — a model that grew a condition", async () => {
+    const grown = declareKind({
+      kind: ApiResourceKind.agent,
+      schema: AgentSchema,
+      source: "test/grown.fga",
+      relations: [
+        ["viewer", direct(publicWith("identity_account", "after_hours"))],
+      ],
+    });
+    const afterHours = newInMemoryTupleSource([
+      {
+        object: parseObjectRef("agent:open"),
+        relation: "viewer",
+        subject: {
+          form: "wildcard",
+          type: "identity_account",
+          condition: "after_hours",
+        },
+      },
+    ]);
+    await expect(
+      checkRelation(
+        { model: newModel([grown]), source: afterHours },
+        parseObjectRef("agent:open"),
+        "viewer",
+        stranger,
+        RESOLVE,
+      ),
+    ).rejects.toMatchObject({ reason: "unknown-condition" });
   });
 });
 
@@ -220,6 +277,7 @@ describe("the walk itself", () => {
         parseObjectRef("agent:n0"),
         "next",
         person("ida_nobody"),
+        RESOLVE,
       ),
     ).rejects.toMatchObject({ reason: "resolution-depth-exceeded" });
   });
@@ -240,6 +298,7 @@ describe("the walk itself", () => {
         parseObjectRef("agent:x"),
         "a",
         person("ida_nobody"),
+        RESOLVE,
       ),
     ).rejects.toBeInstanceOf(AuthorizationEvaluationError);
   });
@@ -273,7 +332,7 @@ describe("declareKind validates a transcript at load", () => {
         source: "test/bad.fga",
         relations: [
           ["viewer", direct(objectOf("identity_account"))],
-          ["viewer", direct(usersetOf("organization", "viewer"))],
+          ["viewer", direct(publicWith("identity_account", "allow_public"))],
         ],
       }),
     ).toThrow("declared twice");

package/src/authorization/__tests__/facts.test.ts

@@ -50,7 +50,7 @@ describe("rowFactsOf against the tuple lifecycle's own resolution", () => {
     for (const visibility of [
       ApiResourceVisibility.visibility_private,
       ApiResourceVisibility.visibility_org,
-      ApiResourceVisibility.visibility_platform,
+      ApiResourceVisibility.visibility_public,
     ]) {
       it(`${declaration.type} at ${ApiResourceVisibility[visibility]}: the same parent links and visibility shapes`, () => {
         const row = fixtureRow(declaration, {
@@ -133,7 +133,7 @@ describe("a list candidate against the loaded row — the facts' two producers",
     for (const visibility of [
       ApiResourceVisibility.visibility_private,
       ApiResourceVisibility.visibility_org,
-      ApiResourceVisibility.visibility_platform,
+      ApiResourceVisibility.visibility_public,
     ]) {
       it(`${declaration.type} at ${ApiResourceVisibility[visibility]}: the candidate the helper builds carries the facts the driver derives from`, async () => {
         const row = fixtureRow(declaration, {

package/src/authorization/__tests__/fixtures/fga/agent-instance-creation.fga.yaml

@@ -0,0 +1,185 @@
+# Pinned copy of stigmer-cloud backend/services/stigmer-server/fga/tests/agent-instance-creation.fga.yaml
+# at commit 4c03c38d2 (the OpenFGA store test the cloud runs against its live model).
+# The body below is byte-identical to the source; the cloud re-runs the LIVE
+# file against this evaluator at the re-pin, so a stale copy is caught there.
+# Store tests for agent-instance creation: two halves, asked together by
+# the create since stigmer#1209 (v3.22.0). The agent half is the agent's
+# can_create_instance (can_execute, so the viewer set: whoever may run the
+# agent may instantiate it). The organization half is
+# can_create_agent_instance: member on the organization the instance is
+# created IN, which is the caller's own, not the agent's: a personal
+# instance of another organization's public agent lives in the caller's
+# organization (the marketplace case), so the agent's permission alone
+# would let a row be planted in any organization named on the request.
+#
+# What these pin: owners, admins and members hold the organization half;
+# a viewer-role account may run an org-visible agent (the agent half) and
+# still lacks the organization half; a guest holds neither; an outsider
+# holds neither; and the marketplace case passes on the caller's own
+# organization while the agent half comes from the public wildcard.
+#
+# Run: fga model test --tests agent-instance-creation.fga.yaml
+
+name: agent-instance-creation
+model_file: ../model/fga.mod
+
+tuples:
+  # Org acme: olivia owns it, oscar administers, dave is a plain member,
+  # vera a read-only viewer, greta the share-link guest account.
+  - user: identity_account:olivia
+    relation: owner
+    object: organization:acme
+  - user: identity_account:oscar
+    relation: admin
+    object: organization:acme
+  - user: identity_account:dave
+    relation: member
+    object: organization:acme
+  - user: identity_account:vera
+    relation: viewer
+    object: organization:acme
+  - user: identity_account:greta
+    relation: guest
+    object: organization:acme
+
+  # Org consumer: mia is a plain member there and holds no role in acme.
+  - user: identity_account:mia
+    relation: member
+    object: organization:consumer
+
+  # An ORG-visible agent in acme, authored by oscar.
+  - user: organization:acme
+    relation: organization
+    object: agent:team-bot
+  - user: identity_account:oscar
+    relation: owner
+    object: agent:team-bot
+  - user: organization:acme#viewer
+    relation: viewer
+    object: agent:team-bot
+
+  # A PRIVATE agent in acme, authored by oscar (no visibility tuple).
+  - user: organization:acme
+    relation: organization
+    object: agent:secret-bot
+  - user: identity_account:oscar
+    relation: owner
+    object: agent:secret-bot
+
+  # A PUBLIC marketplace agent in acme (the conditional wildcard plus the
+  # org floor tuple the visibility writer emits).
+  - user: organization:acme
+    relation: organization
+    object: agent:open-bot
+  - user: identity_account:oscar
+    relation: owner
+    object: agent:open-bot
+  - user: identity_account:*
+    relation: viewer
+    object: agent:open-bot
+    condition:
+      name: allow_public
+      context: {}
+  - user: organization:acme#viewer
+    relation: viewer
+    object: agent:open-bot
+
+tests:
+  - name: owners, admins and members hold the organization half
+    check:
+      - user: identity_account:olivia
+        object: organization:acme
+        assertions:
+          can_create_agent_instance: true
+      - user: identity_account:oscar
+        object: organization:acme
+        assertions:
+          can_create_agent_instance: true
+      - user: identity_account:dave
+        object: organization:acme
+        assertions:
+          can_create_agent_instance: true
+
+  - name: a viewer, a guest and an outsider do not
+    check:
+      - user: identity_account:vera
+        object: organization:acme
+        assertions:
+          can_create_agent_instance: false
+          can_create_session: false
+      - user: identity_account:greta
+        object: organization:acme
+        assertions:
+          can_create_agent_instance: false
+          can_create_session: true
+      - user: identity_account:mia
+        object: organization:acme
+        assertions:
+          can_create_agent_instance: false
+
+  - name: a member instantiates an org-visible agent, both halves held
+    check:
+      - user: identity_account:dave
+        object: agent:team-bot
+        context:
+          allow: false
+        assertions:
+          can_create_instance: true
+          can_execute: true
+
+  - name: a viewer may run the org-visible agent and still cannot instantiate it here
+    check:
+      - user: identity_account:vera
+        object: agent:team-bot
+        context:
+          allow: false
+        assertions:
+          can_create_instance: true
+      - user: identity_account:vera
+        object: organization:acme
+        assertions:
+          can_create_agent_instance: false
+
+  - name: a private agent gives the agent half to its author and the admins only
+    check:
+      - user: identity_account:oscar
+        object: agent:secret-bot
+        context:
+          allow: false
+        assertions:
+          can_create_instance: true
+      - user: identity_account:olivia
+        object: agent:secret-bot
+        context:
+          allow: false
+        assertions:
+          can_create_instance: true
+      - user: identity_account:dave
+        object: agent:secret-bot
+        context:
+          allow: false
+        assertions:
+          can_create_instance: false
+      - user: identity_account:mia
+        object: agent:secret-bot
+        context:
+          allow: false
+        assertions:
+          can_create_instance: false
+
+  - name: the marketplace case, the agent half from the wildcard and the organization half at home
+    check:
+      - user: identity_account:mia
+        object: agent:open-bot
+        context:
+          allow: true
+        assertions:
+          can_create_instance: true
+      - user: identity_account:mia
+        object: organization:consumer
+        assertions:
+          can_create_agent_instance: true
+      - user: identity_account:mia
+        object: organization:acme
+        assertions:
+          can_create_agent_instance: false