@stigmer/server 3.21.0 → 3.22.1-dev.20260922095755

package/src/domain/skill/controller.ts

@@ -53,7 +53,6 @@ import type {
   UpdateVisibilityInput,
 } from "@stigmer/protos/ai/stigmer/commons/apiresource/io_pb";
 import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/apiresourcekind/api_resource_kind_pb";
-import { IamPermission } from "@stigmer/protos/ai/stigmer/iam/v1/enum_pb";
 
 import type { ArtifactStorage } from "../../artifactstorage/artifact-storage.js";
 import type { Logger } from "../../boot/logger.js";
@@ -70,11 +69,12 @@ import { newPipeline } from "../../pipeline/pipeline.js";
 import type { PipelineStep } from "../../pipeline/pipeline.js";
 import { callerIdentityOf } from "../../pipeline/interceptors/auth.js";
 import { RequestContext } from "../../pipeline/request-context.js";
+import { newAuthorizeStep } from "../../pipeline/steps/authorize.js";
 import {
-  authorizeResolvedResource,
-  newAuthorizeStep,
-} from "../../pipeline/steps/authorize.js";
-import { newAuthorizeVisibilityTransitionStep } from "../../pipeline/steps/visibility-gates.js";
+  loadedTargetAsMethod,
+  newAuthorizeResolvedTargetStep,
+} from "../../pipeline/steps/authorize-resolved-target.js";
+import { versionHistoryTarget } from "../../pipeline/steps/version-history.js";
 import {
   newCleanupIamPoliciesStep,
   newRecordVisibilityBeforeUpdateStep,
@@ -449,12 +449,6 @@ async function updateVisibility(
     )
     .addStep(newRecordVisibilityBeforeUpdateStep(UPDATE_VISIBILITY_SKILL_KEY))
     .addStep(newValidateVisibilityUpdateStep())
-    .addStep(
-      newAuthorizeVisibilityTransitionStep(
-        UPDATE_VISIBILITY_SKILL_KEY,
-        deps.authorizer,
-      ),
-    )
     .addStep(newSetVisibilityStep())
     .addStep(newPersistSkillForVisibilityUpdateStep(deps.store))
     .addStep(
@@ -677,6 +671,12 @@ async function getByReference(
     )
     .addStep(newValidateProtoStep())
     .addStep(newLoadSkillByReferenceStep(deps.store))
+    .addStep(
+      newAuthorizeResolvedTargetStep(
+        deps.authorizer,
+        loadedTargetAsMethod(SkillQueryController.method.get),
+      ),
+    )
     .build()
     .execute(reqCtx);
   return reqCtx.get(TARGET_RESOURCE_KEY) as Skill;
@@ -808,26 +808,20 @@ async function listVersions(
     )
     .addStep(newValidateProtoStep())
     .addStep(newResolveSkillBySlugStep(deps.store))
-    .addStep({
-      name: "AuthorizeResolvedSkill",
-      async execute(stepCtx): Promise<void> {
-        // The Java SkillListVersionsHandler's mid-chain can_view on the
-        // RESOLVED skill id (20260830.01 ruling Q8 — the second of the two
-        // traced ListVersions handlers, DD-007's named pattern). Deny copy
-        // is the Java handler's byte-pinned error_msg; unknown slugs were
-        // already answered NOT_FOUND by the resolve step above.
-        await authorizeResolvedResource(
-          deps.authorizer,
-          stepCtx.callerIdentity,
-          {
-            permission: IamPermission.can_view,
-            resourceKind: ApiResourceKind.skill,
-            resourceId: stepCtx.get(LIST_VERSIONS_SKILL_ID_KEY) as string,
-          },
+    // The Java SkillListVersionsHandler's mid-chain can_view on the RESOLVED
+    // skill id; the copy is the Java handler's byte-pinned error_msg, and an
+    // unknown slug was already answered NOT_FOUND by the resolve step above.
+    .addStep(
+      newAuthorizeResolvedTargetStep(
+        deps.authorizer,
+        versionHistoryTarget(
+          ApiResourceKind.skill,
           "unauthorized to view skill version history",
-        );
-      },
-    })
+          LIST_VERSIONS_SKILL_ID_KEY,
+        ),
+        "AuthorizeResolvedSkill",
+      ),
+    )
     .addStep(newLoadAndMapVersionsStep(deps.store))
     .build()
     .execute(reqCtx);

package/src/domain/workflow/__tests__/agent-call-references.test.ts

@@ -0,0 +1,222 @@
+/**
+ * Pins the workflow domain's collector for the reference rule
+ * (../agent-call-references.ts): the strict `slug` / `org/slug` parser and
+ * its refusal copy, the walk over top-level, nested and compensate tasks
+ * in declaration order with the bare form resolved to the workflow's
+ * organization, a config that does not decode skipped rather than
+ * double-reported, and the step over a real store answering the rule's
+ * verdicts — a missing agent with the rule's copy, another organization's
+ * org-visible agent with the one cross-organization sentence, a
+ * platform-visible one admitted.
+ */
+import { create } from "@bufbuild/protobuf";
+import { Code, ConnectError } from "@connectrpc/connect";
+import { afterEach, beforeEach, describe, expect, it } from "vitest";
+
+import { AgentSchema } from "@stigmer/protos/ai/stigmer/agentic/agent/v1/api_pb";
+import { WorkflowSchema } from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/api_pb";
+import { WorkflowTaskKind } from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/enum_pb";
+import type { WorkflowSpec } from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/spec_pb";
+import { WorkflowSpecSchema } from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/spec_pb";
+import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/apiresourcekind/api_resource_kind_pb";
+import { ApiResourceVisibility } from "@stigmer/protos/ai/stigmer/commons/apiresource/enum_pb";
+
+import { RequestContext } from "../../../pipeline/request-context.js";
+import { testCallerIdentity } from "../../../pipeline/__tests__/support.js";
+import {
+  missingReferencesMessage,
+  notAvailableReferenceMessage,
+  referenceTargetKind,
+} from "../../../pipeline/steps/references.js";
+import type { SqliteStore } from "../../../store/sqlite/store.js";
+import { tempStore } from "../../../store/sqlite/__tests__/support.js";
+import {
+  collectAgentCallReferences,
+  malformedAgentReferenceMessage,
+  newValidateAgentCallReferencesStep,
+  parseAgentReference,
+} from "../agent-call-references.js";
+
+const V = ApiResourceVisibility;
+const AGENT = referenceTargetKind(ApiResourceKind.agent)!;
+
+function agentCall(name: string, agent: string) {
+  return {
+    name,
+    kind: WorkflowTaskKind.agent_call,
+    taskConfig: { agent, message: "do the thing" },
+  };
+}
+
+function specOf(tasks: ReadonlyArray<Record<string, unknown>>): WorkflowSpec {
+  return create(WorkflowSpecSchema, { tasks } as never);
+}
+
+describe("parseAgentReference", () => {
+  it("accepts `slug` and `org/slug` and nothing else", () => {
+    expect(parseAgentReference("reviewer")).toEqual({
+      org: "",
+      slug: "reviewer",
+    });
+    expect(parseAgentReference("acme/reviewer")).toEqual({
+      org: "acme",
+      slug: "reviewer",
+    });
+    for (const malformed of ["", "/reviewer", "acme/", "a/b/c", "//"]) {
+      expect(parseAgentReference(malformed), malformed).toBeUndefined();
+    }
+  });
+});
+
+describe("collectAgentCallReferences", () => {
+  it("collects top-level, nested and compensate agent_call tasks in declaration order, the bare form resolved to the workflow's organization", () => {
+    const spec = specOf([
+      agentCall("first", "reviewer"),
+      {
+        name: "loop",
+        kind: WorkflowTaskKind.for_each,
+        taskConfig: {
+          each: "item",
+          in: "${ .items }",
+          // A nested task inside the Struct is JSON: proto field names.
+          do: [
+            {
+              name: "inner",
+              kind: "agent_call",
+              task_config: { agent: "globex/summarizer", message: "sum" },
+            },
+          ],
+        },
+        compensate: [agentCall("undo", "cleaner")],
+      },
+      {
+        name: "pause",
+        kind: WorkflowTaskKind.wait,
+        taskConfig: { duration: {} },
+      },
+    ]);
+    expect(collectAgentCallReferences(spec, "acme")).toEqual([
+      { kind: ApiResourceKind.agent, org: "acme", slug: "reviewer" },
+      { kind: ApiResourceKind.agent, org: "globex", slug: "summarizer" },
+      { kind: ApiResourceKind.agent, org: "acme", slug: "cleaner" },
+    ]);
+  });
+
+  it("refuses a malformed agent string naming the task", () => {
+    const spec = specOf([agentCall("broken", "a/b/c")]);
+    expect(() => collectAgentCallReferences(spec, "acme")).toThrow(
+      malformedAgentReferenceMessage("broken", "a/b/c"),
+    );
+    let error: unknown;
+    try {
+      collectAgentCallReferences(spec, "acme");
+    } catch (e) {
+      error = e;
+    }
+    expect((error as ConnectError).code).toBe(Code.InvalidArgument);
+  });
+
+  it("skips a config that does not decode — the spec validation step has already refused it", () => {
+    const spec = specOf([
+      {
+        name: "odd",
+        kind: WorkflowTaskKind.agent_call,
+        taskConfig: { agent: "reviewer", not_a_field: true },
+      },
+    ]);
+    expect(collectAgentCallReferences(spec, "acme")).toEqual([]);
+    expect(collectAgentCallReferences(undefined, "acme")).toEqual([]);
+  });
+});
+
+describe("ValidateAgentCallReferences over a store", () => {
+  let store: SqliteStore;
+  let cleanup: () => Promise<void>;
+
+  beforeEach(() => {
+    const temp = tempStore();
+    store = temp.store;
+    cleanup = temp.cleanup;
+  });
+
+  afterEach(async () => {
+    await cleanup();
+  });
+
+  async function seedAgent(
+    id: string,
+    org: string,
+    slug: string,
+    visibility: ApiResourceVisibility,
+  ): Promise<void> {
+    await store.saveResource(
+      ApiResourceKind.agent,
+      id,
+      AgentSchema,
+      create(AgentSchema, {
+        apiVersion: "agentic.stigmer.ai/v1",
+        kind: "Agent",
+        metadata: { id, name: slug, slug, org, visibility },
+        spec: { instructions: "a conformant instruction body" },
+      }),
+    );
+  }
+
+  function workflowCalling(...agents: string[]) {
+    return create(WorkflowSchema, {
+      apiVersion: "agentic.stigmer.ai/v1",
+      kind: "Workflow",
+      metadata: { name: "Pipeline", org: "acme", visibility: V.visibility_org },
+      spec: specOf(agents.map((agent, i) => agentCall(`call_${i}`, agent))),
+    });
+  }
+
+  async function run(workflow: ReturnType<typeof workflowCalling>) {
+    const ctx = new RequestContext(
+      WorkflowSchema,
+      workflow,
+      testCallerIdentity(),
+      ApiResourceKind.workflow,
+    );
+    try {
+      await newValidateAgentCallReferencesStep(store).execute(ctx);
+      return undefined;
+    } catch (error) {
+      return error;
+    }
+  }
+
+  it("a missing agent is refused with the rule's copy; an existing one passes", async () => {
+    const error = await run(workflowCalling("reviewer"));
+    expect(error).toBeInstanceOf(ConnectError);
+    expect((error as ConnectError).code).toBe(Code.FailedPrecondition);
+    expect((error as ConnectError).rawMessage).toBe(
+      missingReferencesMessage(AGENT, [{ slug: "reviewer", org: "acme" }]),
+    );
+    await seedAgent("agt_1", "acme", "reviewer", V.visibility_org);
+    expect(await run(workflowCalling("reviewer"))).toBeUndefined();
+  });
+
+  it("another organization's agent is admitted only at platform visibility, with the one sentence otherwise", async () => {
+    await seedAgent("agt_shared", "globex", "shared", V.visibility_platform);
+    await seedAgent("agt_internal", "globex", "internal", V.visibility_org);
+    expect(await run(workflowCalling("globex/shared"))).toBeUndefined();
+    const error = await run(workflowCalling("globex/internal"));
+    expect((error as ConnectError).rawMessage).toBe(
+      notAvailableReferenceMessage(AGENT, {
+        kind: ApiResourceKind.agent,
+        org: "globex",
+        slug: "internal",
+      }),
+    );
+  });
+
+  it("the floor holds for the agent a workflow calls: an org-visible workflow may not call a private agent", async () => {
+    await seedAgent("agt_mine", "acme", "mine", V.visibility_private);
+    const error = await run(workflowCalling("mine"));
+    expect((error as ConnectError).code).toBe(Code.FailedPrecondition);
+    expect((error as ConnectError).rawMessage).toContain(
+      "referenced agent 'acme/mine' is visibility_private while this resource is visibility_org",
+    );
+  });
+});

package/src/domain/workflow/agent-call-references.ts

@@ -0,0 +1,157 @@
+/**
+ * ValidateAgentCallReferences — the second collector for the reference rule
+ * (pipeline/steps/references.ts): a workflow's `agent_call` tasks name their
+ * agent as a STRING, `"slug"` or `"org/slug"`, inside a `google.protobuf.Struct`
+ * config the generic spec walker cannot see, so the rule would never meet
+ * them. This step parses each task's config through the converter's own
+ * strict decoder (`unmarshalTaskConfig`, the one reader of a task config),
+ * walks nested control-flow tasks exactly as the constraint validator does,
+ * turns every `agent` string into a reference with the workflow as parent,
+ * and asks the rule's one function — same clauses, same copy. It lives in
+ * the workflow domain and not inside `InProcessValidator` because the
+ * validator is pure over the spec by design and a rule that reads the
+ * target's row cannot be.
+ *
+ * The parser here is STRICT: exactly `slug` or `org/slug`, both segments
+ * non-empty, anything else refused at write naming the task. Two lenient
+ * readers of the same string exist downstream and disagree with each other
+ * (the runner's `parseAgentReference` in activities/call-agent.ts splits on
+ * the first `/` and drops a third segment; the CLI's `parseReference` in
+ * client-apps/cli/src/resources/reference.ts refuses a leading slash);
+ * refusing every malformed shape here means neither ever meets one. The
+ * three cannot share code — the packages share only the protos — so the
+ * execution conformance suite is where their agreement is proven.
+ *
+ * Runs after NormalizeReferences and ValidateReferences on the workflow
+ * create and update chains, so the org the walk sees is the workflow's own
+ * for a bare slug. Proven by __tests__/agent-call-references.test.ts and
+ * the workflow conformance suite's reference arm.
+ */
+import type { WorkflowSchema } from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/api_pb";
+import type { AgentCallTaskConfig } from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/tasks/agent_call_pb";
+import type {
+  WorkflowSpec,
+  WorkflowTask,
+} from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/spec_pb";
+import { WorkflowTaskKind } from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/enum_pb";
+import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/apiresourcekind/api_resource_kind_pb";
+
+import type { Store } from "../../store/interface.js";
+import { internalError, invalidArgumentError } from "../../pipeline/errors.js";
+import type { PipelineStep } from "../../pipeline/pipeline.js";
+import type { RequestContext } from "../../pipeline/request-context.js";
+import type {
+  ReferenceParent,
+  SpecReference,
+} from "../../pipeline/steps/references.js";
+import { checkReferences } from "../../pipeline/steps/references.js";
+import { metadataOf } from "../../pipeline/steps/shapes.js";
+import { unmarshalTaskConfig } from "./converter/unmarshal.js";
+import { nestedTasks } from "./validation/task-config-constraints.js";
+
+/** The one sentence for an `agent` string that is neither `slug` nor `org/slug`. */
+export function malformedAgentReferenceMessage(
+  taskName: string,
+  agent: string,
+): string {
+  return `task '${taskName}': agent '${agent}' is not a reference; write 'slug' for an agent of this organization or 'org/slug' for another organization's.`;
+}
+
+/**
+ * `slug` or `org/slug` → the reference, with `org` empty for the bare form
+ * (the caller fills the parent's). Returns undefined for any other shape.
+ */
+export function parseAgentReference(
+  agent: string,
+): { readonly org: string; readonly slug: string } | undefined {
+  const parts = agent.split("/");
+  if (parts.length === 1) {
+    return parts[0] === "" ? undefined : { org: "", slug: parts[0]! };
+  }
+  if (parts.length === 2 && parts[0] !== "" && parts[1] !== "") {
+    return { org: parts[0]!, slug: parts[1]! };
+  }
+  return undefined;
+}
+
+/**
+ * Every `agent_call` task's agent as a reference, nested tasks included in
+ * declaration order, the bare form resolved to `parentOrg`. Throws
+ * INVALID_ARGUMENT on the first malformed string. A config that does not
+ * decode is skipped: the spec validation step has already refused the
+ * workflow for it, and this collector never double-reports.
+ */
+export function collectAgentCallReferences(
+  spec: WorkflowSpec | undefined,
+  parentOrg: string,
+): SpecReference[] {
+  const refs: SpecReference[] = [];
+  if (spec === undefined) {
+    return refs;
+  }
+  const visit = (task: WorkflowTask): void => {
+    if (task.taskConfig !== undefined) {
+      let config;
+      try {
+        config = unmarshalTaskConfig(task.kind, task.taskConfig);
+      } catch {
+        config = undefined;
+      }
+      if (config !== undefined) {
+        if (task.kind === WorkflowTaskKind.agent_call) {
+          const agent = (config as AgentCallTaskConfig).agent;
+          const parsed = parseAgentReference(agent);
+          if (parsed === undefined) {
+            throw invalidArgumentError(
+              malformedAgentReferenceMessage(task.name, agent),
+            );
+          }
+          refs.push({
+            kind: ApiResourceKind.agent,
+            org: parsed.org === "" ? parentOrg : parsed.org,
+            slug: parsed.slug,
+          });
+        }
+        for (const nested of nestedTasks(config)) {
+          visit(nested);
+        }
+      }
+    }
+    for (const compensate of task.compensate) {
+      visit(compensate);
+    }
+  };
+  for (const task of spec.tasks) {
+    visit(task);
+  }
+  return refs;
+}
+
+export function newValidateAgentCallReferencesStep(
+  store: Store,
+): PipelineStep<typeof WorkflowSchema> {
+  return {
+    name: "ValidateAgentCallReferences",
+    async execute(ctx: RequestContext<typeof WorkflowSchema>): Promise<void> {
+      const metadata = metadataOf(ctx.newState);
+      if (metadata === undefined) {
+        throw internalError(
+          new Error("resource metadata is nil"),
+          "validate agent_call references",
+        );
+      }
+      const refs = collectAgentCallReferences(ctx.newState.spec, metadata.org);
+      if (refs.length === 0) {
+        return;
+      }
+      const parent: ReferenceParent = {
+        org: metadata.org,
+        visibility: metadata.visibility,
+      };
+      const refusal = await checkReferences(store, parent, refs);
+      if (refusal !== undefined) {
+        throw refusal;
+      }
+    },
+  };
+}