@stigmer/server 3.18.0-dev.20260918103812 → 3.18.0

package/src/sandbox/__tests__/steps.test.ts

@@ -11,10 +11,7 @@
  *   - the terminal observer deprovisions exactly on transitions INTO a
  *     terminal phase, fire-and-forget, and swallows (logs) teardown
  *     failures;
- *   - a disabled mint lane launches token-less rather than failing;
- *   - the caller splits two ways on both lanes: the identity id reaches
- *     the credential mint, the caller class reaches the driver's
- *     environment unchanged (a composed lane such as `guest` included).
+ *   - a disabled mint lane launches token-less rather than failing.
  */
 import { mkdtempSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
@@ -56,25 +53,14 @@ import {
   ensureWorkflowSandboxForExecution,
   newWorkflowSandboxTerminalObserver,
   SANDBOX_PROVISIONING_FAILED_PREFIX,
-  type SandboxCaller,
 } from "../steps.js";
 
 /**
- * The caller the ensure bodies split two ways: the identity id into the
- * credential mint (C4 — the OSS execution-scoped mint ignores it, so the
- * token assertions stay binding-shaped) and the class onto the driver's
- * environment. `user` is the plain lane; the class-propagation cases hand
- * in a composed lane's word to prove the body copies, never normalises.
+ * The caller identity the ensure bodies thread into the credential mint
+ * (C4): the OSS execution-scoped mint ignores it, so these tests pass a
+ * fixed value and the token assertions stay binding-shaped.
  */
 const TEST_CALLER_IDENTITY_ID = "ida_test_caller";
-const TEST_CALLER: SandboxCaller = {
-  identityId: TEST_CALLER_IDENTITY_ID,
-  callerClass: "user",
-};
-const GUEST_CALLER: SandboxCaller = {
-  identityId: "ida_guest_caller",
-  callerClass: "guest",
-};
 
 const silentLogger = createLogger({
   level: "error",
@@ -249,7 +235,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         temporalConfig: sessionRoutingCloudDefault,
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     expect(provisioner.ensured).toEqual([
       {
@@ -258,32 +244,11 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         env: {
           taskQueue: `session:${sessionId}`,
           stigmerToken: `tok-${execution.metadata?.id ?? ""}`,
-          callerClass: "user",
         },
       },
     ]);
   });
 
-  it("hands the caller's class to the driver unchanged and the caller's id to the mint", async () => {
-    const provisioner = fakeProvisioner();
-    const credentials = capabilityCredentials();
-    const { execution } = await seed(ExecutionTarget.CLOUD);
-    await ensureSessionSandboxForExecution(
-      {
-        store,
-        logger: silentLogger,
-        lane: lane(provisioner, credentials),
-        temporalConfig: sessionRoutingCloudDefault,
-      },
-      execution,
-      GUEST_CALLER,
-    );
-    expect(provisioner.ensured[0]?.env.callerClass).toBe("guest");
-    expect(credentials.minted[0]?.callerIdentityId).toBe(
-      GUEST_CALLER.identityId,
-    );
-  });
-
   it("delegates the mint to the capability provider with the full provisioning context (C4)", async () => {
     const provisioner = fakeProvisioner();
     const credentials = capabilityCredentials();
@@ -312,7 +277,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         temporalConfig: sessionRoutingCloudDefault,
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
 
     expect(credentials.minted).toEqual([
@@ -338,7 +303,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         temporalConfig: sessionRoutingCloudDefault,
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     expect(provisioner.ensured).toEqual([]);
   });
@@ -362,7 +327,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         temporalConfig: sessionRoutingCloudDefault,
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
   });
 
@@ -380,7 +345,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         temporalConfig: sessionRoutingCloudDefault,
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     expect(provisioner.ensured).toEqual([]);
   });
@@ -401,7 +366,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         ),
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     expect(provisioner.ensured).toEqual([]);
   });
@@ -417,7 +382,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         temporalConfig: sessionRoutingCloudDefault,
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     expect(provisioner.ensured[0]?.env.stigmerToken).toBe("");
   });
@@ -436,7 +401,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         temporalConfig: sessionRoutingCloudDefault,
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     const stamped = await store.getResource(
       ApiResourceKind.agent_execution,
@@ -474,7 +439,7 @@ describe("the session lane (ensureSessionSandboxForExecution)", () => {
         temporalConfig: sessionRoutingCloudDefault,
       },
       execution,
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     const after = await store.getResource(
       ApiResourceKind.agent_execution,
@@ -502,35 +467,17 @@ describe("the workflow lane (ensureWorkflowSandboxForExecution)", () => {
         temporalConfig: executionRoutingConfig,
       },
       workflowExecution(ExecutionTarget.CLOUD),
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     expect(provisioner.ensured).toEqual([
       {
         scope: "workflow",
         id: "wfx_sbx_1",
-        env: {
-          taskQueue: "wfexec:wfx_sbx_1",
-          stigmerToken: "tok-wfx_sbx_1",
-          callerClass: "user",
-        },
+        env: { taskQueue: "wfexec:wfx_sbx_1", stigmerToken: "tok-wfx_sbx_1" },
       },
     ]);
   });
 
-  it("hands the caller's class to the driver unchanged on the workflow lane", async () => {
-    const provisioner = fakeProvisioner();
-    await ensureWorkflowSandboxForExecution(
-      {
-        logger: silentLogger,
-        lane: lane(provisioner),
-        temporalConfig: executionRoutingConfig,
-      },
-      workflowExecution(ExecutionTarget.CLOUD),
-      GUEST_CALLER,
-    );
-    expect(provisioner.ensured[0]?.env.callerClass).toBe("guest");
-  });
-
   it("delegates the mint to the capability provider on the workflow scope (C4)", async () => {
     const provisioner = fakeProvisioner();
     const credentials = capabilityCredentials();
@@ -544,7 +491,7 @@ describe("the workflow lane (ensureWorkflowSandboxForExecution)", () => {
         metadata: { id: "wfx_sbx_cap", name: "wfx_sbx_cap", org: "org-test" },
         spec: { executionTarget: ExecutionTarget.CLOUD },
       }),
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     expect(credentials.minted).toEqual([
       {
@@ -567,7 +514,7 @@ describe("the workflow lane (ensureWorkflowSandboxForExecution)", () => {
         temporalConfig: executionRoutingConfig,
       },
       workflowExecution(ExecutionTarget.LOCAL),
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     await ensureWorkflowSandboxForExecution(
       {
@@ -581,7 +528,7 @@ describe("the workflow lane (ensureWorkflowSandboxForExecution)", () => {
         ),
       },
       workflowExecution(ExecutionTarget.CLOUD),
-      TEST_CALLER,
+      TEST_CALLER_IDENTITY_ID,
     );
     expect(provisioner.ensured).toEqual([]);
   });
@@ -598,7 +545,7 @@ describe("the workflow lane (ensureWorkflowSandboxForExecution)", () => {
           temporalConfig: executionRoutingConfig,
         },
         workflowExecution(ExecutionTarget.CLOUD),
-        TEST_CALLER,
+        TEST_CALLER_IDENTITY_ID,
       );
       expect.unreachable("the workflow lane must throw on failure");
     } catch (error) {

package/src/sandbox/kubernetes.ts

@@ -85,14 +85,7 @@ const RUNNER_RESOURCES = {
   limits: { cpu: "2", memory: "2Gi" },
 } as const;
 
-/**
- * The persistent-workspace scopes (SandboxScope.persistentWorkspace).
- * Durability here is decided by SCOPE alone: this driver reads neither the
- * environment's caller class nor any per-session policy, so every session
- * keeps its PVC whoever asked. A driver that gives some caller classes a
- * workspace that dies with the conversation is a composition's choice
- * built on SandboxEnvironment.callerClass, not a built-in behaviour.
- */
+/** The persistent-workspace scopes (SandboxScope.persistentWorkspace). */
 const PERSISTENT_SCOPES: ReadonlySet<SandboxScope> = new Set([
   "session",
   "workflow",

package/src/sandbox/provisioner.ts

@@ -39,16 +39,13 @@
  * runner process polls the queues.
  */
 import type { Logger } from "../boot/logger.js";
-import type { CallerClass } from "../extensions/identity.js";
 
 /**
- * What is TRUE about one provisioning request, handed to a driver: which
- * queue the sandboxed runner must poll, the credential it authenticates
- * with, and the class of the caller whose request is being served. Facts
- * only — what a driver DOES with them (the workspace's durability, the
- * pod's shape, whether a warm pool is consulted) is driver policy and
- * never travels here. Endpoints, images and resource shapes are driver
- * configuration, not per-sandbox state.
+ * The runtime handed to a provisioner for one sandbox: which queue the
+ * sandboxed runner must poll and the credential it authenticates with.
+ * Deliberately minimal (the Java SandboxEnvironment carries the same two
+ * load-bearing fields plus cloud-only accounting) — endpoints, images,
+ * and resource shapes are DRIVER configuration, not per-sandbox state.
  */
 export interface SandboxEnvironment {
   /** The Temporal task queue the sandboxed runner polls (session:{id} / wfexec:{id}). */
@@ -59,18 +56,6 @@ export interface SandboxEnvironment {
    * and EC decrypt falls back to redaction, the oss#535 posture.
    */
   readonly stigmerToken: string;
-  /**
-   * The class of the caller whose request provisioned this sandbox — the
-   * identity interceptor's word for it (`user`, `internal`, a composed
-   * verifier's own lane such as a guest or a scheduled fire). A driver
-   * that gives some session classes a workspace that does not outlive the
-   * conversation reads it here; the built-in drivers (`local-process`,
-   * `docker`, `kubernetes`) ignore it and keep every session persistent.
-   * Required rather than optional so a construction site that forgets it
-   * fails to compile instead of silently reading as a persistent user
-   * session to every driver.
-   */
-  readonly callerClass: CallerClass;
 }
 
 /** One sandbox's observed live state (the Q5 probe result). */

package/src/sandbox/steps.ts

@@ -50,7 +50,6 @@ import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/
 
 import type { Logger } from "../boot/logger.js";
 import type { AgentExecutionTemporalConfig } from "../domain/agentexecution/temporal/config.js";
-import type { CallerIdentity } from "../extensions/identity.js";
 import {
   WORKFLOW_ROUTING_EXECUTION,
   type WorkflowExecutionTemporalConfig,
@@ -73,17 +72,6 @@ import { mintSandboxToken, type SandboxLane } from "./lane.js";
 export const SANDBOX_PROVISIONING_FAILED_PREFIX =
   "Sandbox provisioning failed: ";
 
-/**
- * The two facts about the requesting caller a sandbox ensure carries, cut
- * from the chain's CallerIdentity (the domain/identityaccount/actor.ts
- * shape): the id rides into the credential mint, so the session token is
- * minted FOR the caller; the class rides onto the driver's environment,
- * so a driver can decide the workspace's durability by who asked. A step
- * hands `ctx.callerIdentity` in whole; the pick keeps a test's fixture to
- * the two fields the body reads.
- */
-export type SandboxCaller = Pick<CallerIdentity, "identityId" | "callerClass">;
-
 type AgentExecutionCreateDesc = typeof AgentExecutionSchema;
 
 export interface EnsureSessionSandboxDeps {
@@ -113,7 +101,7 @@ export function newEnsureSessionSandboxStep(
       await ensureSessionSandboxForExecution(
         deps,
         ctx.newState,
-        ctx.callerIdentity,
+        ctx.callerIdentity.identityId,
       );
     },
   };
@@ -126,18 +114,15 @@ export function newEnsureSessionSandboxStep(
  * chains' differing context shapes (newState vs loaded execution) meet
  * at this seam instead.
  *
- * The caller splits two ways (SandboxCaller): `identityId` rides into the
- * credential mint (lane.ts) — the Java ensure step mints session tokens
- * FOR the requesting caller, so the capability mint needs the identity
- * the OSS execution-scoped mint never did — and `callerClass` rides onto
- * the driver's environment as the one request fact a driver may decide
- * durability by. The chain always has a caller: the in-process transport
- * mints `internal` for the server's own calls.
+ * `callerIdentityId` rides into the credential mint (lane.ts): the Java
+ * ensure step mints session tokens FOR the requesting caller, so the
+ * capability mint needs the identity the OSS execution-scoped mint never
+ * did. Empty when the invoking site has no caller.
  */
 export async function ensureSessionSandboxForExecution(
   deps: EnsureSessionSandboxDeps,
   execution: AgentExecution,
-  caller: SandboxCaller,
+  callerIdentityId: string,
 ): Promise<void> {
   if (!deps.lane.enabled) {
     return;
@@ -182,11 +167,10 @@ export async function ensureSessionSandboxForExecution(
           sessionId,
           executionId,
           org: execution.metadata?.org ?? "",
-          callerIdentityId: caller.identityId,
+          callerIdentityId,
         },
         deps.logger,
       ),
-      callerClass: caller.callerClass,
     });
   } catch (error) {
     // Non-critical: never fail the launch — but never silent either
@@ -263,7 +247,7 @@ export function newEnsureWorkflowSandboxStep(
       await ensureWorkflowSandboxForExecution(
         deps,
         ctx.newState,
-        ctx.callerIdentity,
+        ctx.callerIdentity.identityId,
       );
     },
   };
@@ -274,13 +258,13 @@ export function newEnsureWorkflowSandboxStep(
  * re-provision (lifecycle.ts — the previous sandbox was deprovisioned at
  * the terminal FAILED, so a recovered execution needs a fresh one before
  * its fresh workflow starts). Throws Unavailable on provisioning failure
- * — the critical posture in both chains. The caller splits exactly as on
- * the session body: id to the mint, class to the environment.
+ * — the critical posture in both chains. `callerIdentityId` rides into
+ * the credential mint exactly as on the session body.
  */
 export async function ensureWorkflowSandboxForExecution(
   deps: EnsureWorkflowSandboxDeps,
   execution: WorkflowExecution,
-  caller: SandboxCaller,
+  callerIdentityId: string,
 ): Promise<void> {
   if (!deps.lane.enabled) {
     return;
@@ -312,11 +296,10 @@ export async function ensureWorkflowSandboxForExecution(
           sessionId: "",
           executionId,
           org: execution.metadata?.org ?? "",
-          callerIdentityId: caller.identityId,
+          callerIdentityId,
         },
         deps.logger,
       ),
-      callerClass: caller.callerClass,
     });
   } catch (error) {
     deps.logger.error(

package/src/store/interface.ts

@@ -217,8 +217,12 @@ export interface SearchIndexQueryResult {
 // =============================================================================
 
 /**
- * Key-value state for idempotent seedpack bootstrap. Common keys:
- * "seedpack_version", "bootstrap_status", "skill:<name>", "agent:<name>".
+ * Key-value state for one-shot boot work that must run once per database.
+ * The one writer today is the membership rules' reconciliation
+ * (`iampolicy/constants.ts` ROLES_RECONCILED_KEY). A database migrated
+ * from the Go server carries that server's bootstrap keys too; the
+ * migration preserves them (see sqlite/__tests__/migrations.test.ts) and
+ * nothing reads them.
  */
 export interface BootstrapStateStore {
   /** Returns "" (not an error) when the key does not exist — Go's contract. */