@stigmer/server 3.17.0 → 3.18.0

package/src/pipeline/apiresource-labels.ts

@@ -13,7 +13,11 @@
  * authorizer's permissive default ALLOWS reserved-label writes by design
  * (the self-hosted operator owns the store), which is why a restrict-shaped
  * predicate here still pairs the label with server-owned state: the
- * plugin-managed guard refuses only beside an existing plugin row.
+ * plugin-managed guard refuses only beside an existing plugin row, and a
+ * plugin adopts a system-content row only when its own claim to the same
+ * label was just charged to `can_write_reserved_labels` by the sanitiser
+ * (domain/plugin/members.ts) — the label narrows which rows are eligible,
+ * the live authorization is what grants.
  */
 import type { ApiResourceMetadata } from "@stigmer/protos/ai/stigmer/commons/apiresource/metadata_pb";
 
@@ -39,6 +43,20 @@ export const DEFAULT_INSTANCE_LABEL = `${RESERVED_LABEL_PREFIX}default-instance`
  */
 export const SYSTEM_MANAGED_LABEL = `${RESERVED_LABEL_PREFIX}system-managed`;
 
+/**
+ * Marks system content: a resource the platform itself seeded rather than a
+ * user authored — the system organization, the default agent, the
+ * platform's own MCP servers. The label predates this module (the retired
+ * seedpack wrote it on every row it applied; the official plugins' overlays
+ * carry it on the resources they replace) and has one server-side meaning:
+ * a plugin push may adopt a system-content row that holds a slug the plugin
+ * needs, keeping the row's id and everything bound to it, instead of
+ * refusing the slug as taken. It never marks a user's resource, so a user's
+ * row is never adopted (domain/plugin/members.ts, judgeSlug). The CLI names
+ * the same bytes as SYSTEM_ORG_LABEL for the organization it ensures.
+ */
+export const SYSTEM_LABEL = `${RESERVED_LABEL_PREFIX}system`;
+
 /**
  * The only value that activates a reserved marker label; any other value is
  * inert (matching cloud's "true".equals(...)). Stamped by the flows that
@@ -86,3 +104,10 @@ export function isDefaultInstance(
 ): boolean {
   return metadata?.labels[DEFAULT_INSTANCE_LABEL] === RESERVED_LABEL_TRUE;
 }
+
+/** Whether the metadata carries the SYSTEM_LABEL marker (undefined-safe). */
+export function isSystemContent(
+  metadata: ApiResourceMetadata | undefined,
+): boolean {
+  return metadata?.labels[SYSTEM_LABEL] === RESERVED_LABEL_TRUE;
+}

package/src/sandbox/__tests__/local-process.integration.test.ts

@@ -6,7 +6,11 @@
  * can read it, so no real runner install is needed.
  *
  * Unix-only like the runner itself; deterministic (poll with timeout,
- * never sleep).
+ * never sleep). Every poll gets an explicit budget: vitest's default
+ * second is enough on an idle laptop and not under the full suite's
+ * load, where a /bin/sh child can take longer than that to start and
+ * write its first line. Polling returns the moment the condition holds,
+ * so the larger budget costs nothing on a quiet host.
  */
 import {
   chmodSync,
@@ -25,6 +29,9 @@ import { createLogger } from "../../boot/logger.js";
 import { newLocalProcessSandboxProvisioner } from "../local-process.js";
 import type { SandboxDriverConfig } from "../provisioner.js";
 
+/** How long a spawned child is given to start, write, or die under load. */
+const CHILD_SETTLE_TIMEOUT_MS = 10_000;
+
 const silentLogger = createLogger({
   level: "error",
   pretty: false,
@@ -75,7 +82,9 @@ describe.skipIf(process.platform === "win32")(
         taskQueue: "session:ses_smoke",
         stigmerToken: "tok-smoke",
       });
-      await vi.waitFor(() => expect(spawnCount()).toBe(1));
+      await vi.waitFor(() => expect(spawnCount()).toBe(1), {
+        timeout: CHILD_SETTLE_TIMEOUT_MS,
+      });
       expect(await driver.probe("session", "ses_smoke")).toBe("running");
 
       // Fast path: a second ensure must not spawn a second process.
@@ -104,16 +113,21 @@ describe.skipIf(process.platform === "win32")(
 
     it("deprovision kills the child; probe reports absent; re-ensure respawns", async () => {
       await driver.deprovisionSessionSandbox("ses_smoke");
-      await vi.waitFor(async () => {
-        expect(await driver.probe("session", "ses_smoke")).toBe("absent");
-      });
+      await vi.waitFor(
+        async () => {
+          expect(await driver.probe("session", "ses_smoke")).toBe("absent");
+        },
+        { timeout: CHILD_SETTLE_TIMEOUT_MS },
+      );
 
       // The repair arm without stored state: a fresh ensure respawns.
       await driver.ensureSessionSandbox("ses_smoke", {
         taskQueue: "session:ses_smoke",
         stigmerToken: "",
       });
-      await vi.waitFor(() => expect(spawnCount()).toBe(2));
+      await vi.waitFor(() => expect(spawnCount()).toBe(2), {
+        timeout: CHILD_SETTLE_TIMEOUT_MS,
+      });
       expect(await driver.probe("session", "ses_smoke")).toBe("running");
     });
 

package/src/store/interface.ts

@@ -217,8 +217,12 @@ export interface SearchIndexQueryResult {
 // =============================================================================
 
 /**
- * Key-value state for idempotent seedpack bootstrap. Common keys:
- * "seedpack_version", "bootstrap_status", "skill:<name>", "agent:<name>".
+ * Key-value state for one-shot boot work that must run once per database.
+ * The one writer today is the membership rules' reconciliation
+ * (`iampolicy/constants.ts` ROLES_RECONCILED_KEY). A database migrated
+ * from the Go server carries that server's bootstrap keys too; the
+ * migration preserves them (see sqlite/__tests__/migrations.test.ts) and
+ * nothing reads them.
  */
 export interface BootstrapStateStore {
   /** Returns "" (not an error) when the key does not exist — Go's contract. */