@stigmer/sdk 3.35.0 → 3.37.0

package/src/__tests__/update-input.test.ts

@@ -1,250 +0,0 @@
-import { describe, it, expect } from "vitest";
-import { create, toJson } from "@bufbuild/protobuf";
-import { ApiResourceVisibility } from "@stigmer/protos/ai/stigmer/commons/apiresource/enum_pb";
-import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/apiresourcekind/api_resource_kind_pb";
-import {
-  OrganizationSchema,
-  type Organization,
-} from "@stigmer/protos/ai/stigmer/tenancy/organization/v1/api_pb";
-import { OrganizationSpecSchema } from "@stigmer/protos/ai/stigmer/tenancy/organization/v1/spec_pb";
-import { ManagementMode } from "@stigmer/protos/ai/stigmer/tenancy/organization/v1/enum_pb";
-import {
-  IdentityAccountSchema,
-  type IdentityAccount,
-} from "@stigmer/protos/ai/stigmer/iam/identityaccount/v1/api_pb";
-import { IdentityAccountSpecSchema } from "@stigmer/protos/ai/stigmer/iam/identityaccount/v1/spec_pb";
-import { IdentityAccountProvisioningMode } from "@stigmer/protos/ai/stigmer/iam/identityaccount/v1/enum_pb";
-import {
-  buildOrganizationProto,
-  toOrganizationUpdateInput,
-} from "../gen/organization";
-import {
-  buildIdentityAccountProto,
-  toIdentityAccountUpdateInput,
-} from "../gen/identityaccount";
-
-/**
- * Update RPCs are full-spec replacements, so a complete mapper must
- * round-trip EVERY mutable field of a loaded resource through the generated
- * builder without loss. These tests pin that contract: fully-populated
- * resource → mapper → builder → spec (as JSON, defaults omitted) deep-equals
- * the original. If a mapper drops a field, the wipe-bug class is back.
- */
-
-function fullOrganization(): Organization {
-  return create(OrganizationSchema, {
-    apiVersion: "tenancy.stigmer.ai/v1",
-    kind: "Organization",
-    metadata: {
-      id: "acme",
-      name: "Acme Corp",
-      slug: "acme",
-      org: "acme",
-      labels: { tier: "gold" },
-      visibility: ApiResourceVisibility.visibility_private,
-    },
-    spec: {
-      description: "We make everything.",
-      logoUrl: "https://acme.example/logo.png",
-      managementMode: ManagementMode.self_managed,
-      identityProviderRef: {
-        org: "acme",
-        slug: "acme-okta",
-        kind: ApiResourceKind.identity_provider,
-      },
-      externalOrgId: "ext-org-1",
-      isPersonal: true,
-      preferences: { standingContext: "We deploy to us-east-1." },
-    },
-  });
-}
-
-function fullIdentityAccount(): IdentityAccount {
-  return create(IdentityAccountSchema, {
-    apiVersion: "iam.stigmer.ai/v1",
-    kind: "IdentityAccount",
-    metadata: {
-      id: "ia-123",
-      name: "Ada Lovelace",
-      slug: "ada-lovelace",
-      org: "acme",
-      labels: { team: "platform" },
-      visibility: ApiResourceVisibility.visibility_private,
-    },
-    spec: {
-      idpId: "auth0|abc123",
-      email: "ada@acme.example",
-      firstName: "Ada",
-      lastName: "Lovelace",
-      pictureUrl: "https://acme.example/ada.png",
-      isMachineAccount: true,
-      provisioningMode: IdentityAccountProvisioningMode.federated,
-      identityProviderRef: { org: "acme", slug: "acme-okta" },
-      preferences: {
-        standingContext: "Keep answers terse.",
-        defaultHarness: "cursor",
-        defaultNativeModel: "claude-sonnet-4.6",
-        defaultCursorModel: "composer-2.5",
-      },
-    },
-  });
-}
-
-describe("toOrganizationUpdateInput", () => {
-  it("round-trips a fully-populated organization spec through the builder", () => {
-    const org = fullOrganization();
-
-    const built = buildOrganizationProto(toOrganizationUpdateInput(org));
-
-    expect(toJson(OrganizationSpecSchema, built.spec!)).toEqual(
-      toJson(OrganizationSpecSchema, org.spec!),
-    );
-    expect(built.metadata?.name).toBe("Acme Corp");
-    expect(built.metadata?.slug).toBe("acme");
-    expect(built.metadata?.org).toBe("acme");
-    expect(built.metadata?.labels).toEqual({ tier: "gold" });
-    expect(built.metadata?.visibility).toBe(
-      ApiResourceVisibility.visibility_private,
-    );
-  });
-
-  it("preserves preferences when a caller overrides only profile fields (the wipe-bug class)", () => {
-    const org = fullOrganization();
-
-    const built = buildOrganizationProto({
-      ...toOrganizationUpdateInput(org),
-      description: "New description",
-    });
-
-    expect(built.spec?.preferences?.standingContext).toBe(
-      "We deploy to us-east-1.",
-    );
-    expect(built.spec?.description).toBe("New description");
-    expect(built.spec?.logoUrl).toBe("https://acme.example/logo.png");
-  });
-
-  it("maps an empty spec without inventing values", () => {
-    const org = create(OrganizationSchema, {
-      metadata: { name: "Bare", slug: "bare", org: "bare" },
-      spec: {},
-    });
-
-    const built = buildOrganizationProto(toOrganizationUpdateInput(org));
-
-    expect(toJson(OrganizationSpecSchema, built.spec!)).toEqual({});
-  });
-
-  it("falls back to the slug when metadata.org is empty", () => {
-    const org = create(OrganizationSchema, {
-      metadata: { name: "Bare", slug: "bare" },
-    });
-
-    expect(toOrganizationUpdateInput(org).org).toBe("bare");
-  });
-
-  it("carries metadata.id for exact update addressing", () => {
-    const built = buildOrganizationProto(
-      toOrganizationUpdateInput(fullOrganization()),
-    );
-
-    expect(built.metadata?.id).toBe("acme");
-  });
-});
-
-describe("toIdentityAccountUpdateInput", () => {
-  it("round-trips a fully-populated identity account spec through the builder", () => {
-    const account = fullIdentityAccount();
-
-    const built = buildIdentityAccountProto(
-      toIdentityAccountUpdateInput(account),
-    );
-
-    expect(toJson(IdentityAccountSpecSchema, built.spec!)).toEqual(
-      toJson(IdentityAccountSpecSchema, account.spec!),
-    );
-    expect(built.metadata?.name).toBe("Ada Lovelace");
-    expect(built.metadata?.labels).toEqual({ team: "platform" });
-  });
-
-  it("carries org and slug — the update pipeline's fallback address", () => {
-    const input = toIdentityAccountUpdateInput(fullIdentityAccount());
-
-    expect(input.org).toBe("acme");
-    expect(input.slug).toBe("ada-lovelace");
-  });
-
-  it("carries metadata.id — the ONLY address that works for a real (org-less) account", () => {
-    // Identity accounts are platform-scoped: metadata.org is never set in
-    // production, so the pipeline's org+slug fallback structurally cannot
-    // match one. Without the id, this update is NOT_FOUND by construction.
-    const account = create(IdentityAccountSchema, {
-      metadata: {
-        id: "ida_01JEXAMPLE",
-        name: "ada@acme.example",
-        slug: "ada-acme-example",
-      },
-      spec: { idpId: "auth0|abc123" },
-    });
-
-    const built = buildIdentityAccountProto(
-      toIdentityAccountUpdateInput(account),
-    );
-
-    expect(built.metadata?.id).toBe("ida_01JEXAMPLE");
-    expect(built.metadata?.slug).toBe("ada-acme-example");
-  });
-
-  it("preserves the rest of the spec when a caller overrides only preferences", () => {
-    const account = fullIdentityAccount();
-    const mapped = toIdentityAccountUpdateInput(account);
-
-    const built = buildIdentityAccountProto({
-      ...mapped,
-      preferences: { ...mapped.preferences, standingContext: "Prefer bullet points." },
-    });
-
-    expect(built.spec?.preferences?.standingContext).toBe(
-      "Prefer bullet points.",
-    );
-    expect(built.spec?.email).toBe("ada@acme.example");
-    expect(built.spec?.idpId).toBe("auth0|abc123");
-    expect(built.spec?.provisioningMode).toBe(
-      IdentityAccountProvisioningMode.federated,
-    );
-  });
-
-  it("preserves structured defaults when only standing context is edited (nested wipe-bug class)", () => {
-    const account = fullIdentityAccount();
-    const mapped = toIdentityAccountUpdateInput(account);
-
-    // The correct editor pattern for a nested message: spread the mapper's
-    // COMPLETE preferences and override only the edited field. A bare
-    // `preferences: { standingContext }` literal would wipe the structured
-    // defaults — the session-4 wipe bug recurring one level down.
-    const built = buildIdentityAccountProto({
-      ...mapped,
-      preferences: { ...mapped.preferences, standingContext: "Terser still." },
-    });
-
-    expect(built.spec?.preferences?.standingContext).toBe("Terser still.");
-    expect(built.spec?.preferences?.defaultHarness).toBe("cursor");
-    expect(built.spec?.preferences?.defaultNativeModel).toBe("claude-sonnet-4.6");
-    expect(built.spec?.preferences?.defaultCursorModel).toBe("composer-2.5");
-  });
-
-  it("clears standing context to wire-absent when the text is emptied", () => {
-    const account = fullIdentityAccount();
-    const mapped = toIdentityAccountUpdateInput(account);
-
-    const built = buildIdentityAccountProto({
-      ...mapped,
-      preferences: { ...mapped.preferences, standingContext: "" },
-    });
-
-    // Proto3 empty string is the field default — wire-identical to absent,
-    // which the server compose steps treat as "no preference declared".
-    expect(built.spec?.preferences?.standingContext ?? "").toBe("");
-    // Clearing one field never disturbs its siblings.
-    expect(built.spec?.preferences?.defaultHarness).toBe("cursor");
-  });
-});

package/src/execution/__tests__/approval-provenance.test.ts

@@ -1,60 +0,0 @@
-import { describe, it, expect } from "vitest";
-import {
-  ApprovalPolicySource,
-  describeApprovalPolicySource,
-  isInformativePolicySource,
-} from "../approval-provenance";
-
-describe("describeApprovalPolicySource", () => {
-  it("maps each known source to a stable human phrase", () => {
-    expect(describeApprovalPolicySource(ApprovalPolicySource.CLASSIFIER_DEFAULT)).toBe(
-      "required by the tool's default policy",
-    );
-    expect(describeApprovalPolicySource(ApprovalPolicySource.BUILTIN_CATEGORY)).toBe(
-      "required by built-in tool policy",
-    );
-    expect(describeApprovalPolicySource(ApprovalPolicySource.AGENT_OVERRIDE)).toBe(
-      "required by agent override",
-    );
-    expect(
-      describeApprovalPolicySource(ApprovalPolicySource.ANNOTATION_DESTRUCTIVE_TIGHTEN),
-    ).toBe("required: marked destructive by the server");
-  });
-
-  it("returns null for UNSPECIFIED (legacy / ungated)", () => {
-    expect(describeApprovalPolicySource(ApprovalPolicySource.UNSPECIFIED)).toBeNull();
-  });
-});
-
-describe("isInformativePolicySource", () => {
-  it("suppresses the everyday default gating reasons", () => {
-    // These add nothing beyond "this tool needs approval" — noise at the gate.
-    expect(isInformativePolicySource(ApprovalPolicySource.CLASSIFIER_DEFAULT)).toBe(false);
-    expect(isInformativePolicySource(ApprovalPolicySource.BUILTIN_CATEGORY)).toBe(false);
-    expect(isInformativePolicySource(ApprovalPolicySource.UNSPECIFIED)).toBe(false);
-  });
-
-  it("surfaces reasons that change the user's understanding of the gate", () => {
-    expect(isInformativePolicySource(ApprovalPolicySource.PINNED_OVERRIDE)).toBe(true);
-    expect(isInformativePolicySource(ApprovalPolicySource.AGENT_OVERRIDE)).toBe(true);
-    expect(
-      isInformativePolicySource(ApprovalPolicySource.ANNOTATION_DESTRUCTIVE_TIGHTEN),
-    ).toBe(true);
-    expect(isInformativePolicySource(ApprovalPolicySource.AUTO_APPROVE_ALL)).toBe(true);
-    expect(isInformativePolicySource(ApprovalPolicySource.APPROVAL_LEASE)).toBe(true);
-  });
-
-  it("only surfaces a reason that also has a phrase to show", () => {
-    // The card renders `isInformative(source) && describe(source) != null`; the
-    // two must never disagree for a surfaced source.
-    for (const source of [
-      ApprovalPolicySource.PINNED_OVERRIDE,
-      ApprovalPolicySource.AGENT_OVERRIDE,
-      ApprovalPolicySource.ANNOTATION_DESTRUCTIVE_TIGHTEN,
-      ApprovalPolicySource.AUTO_APPROVE_ALL,
-      ApprovalPolicySource.APPROVAL_LEASE,
-    ]) {
-      expect(describeApprovalPolicySource(source)).not.toBeNull();
-    }
-  });
-});

package/src/execution/__tests__/file-review-fold.corpus.test.ts

@@ -1,127 +0,0 @@
-// Cross-edition parity lock for the file-review projection.
-//
-// The Go (`FileChangeSetProjector` / project.go) and Java (`FileChangeSetProjector`)
-// projectors replay the shared corpus at apis/testdata/hitl/file-review/*.json.
-// This test replays the SAME corpus against the TypeScript fold, so a drift
-// between the SDK and either backend fails here rather than shipping.
-//
-// The corpus `expected` is the server (actionable) projection, which is empty
-// for a terminal execution. The SDK's display fold intentionally has no terminal
-// gate, so to reproduce the server contract exactly this test applies the phase
-// gate the accessor's callers apply: isTerminalPhase(phase) ? [] : fold(stream).
-// That both proves parity for non-terminal vectors AND pins the terminal-empty
-// vector — the one place the SDK deliberately differs is covered by the accessor
-// test in file-review-fold.test.ts, not here.
-
-import { readFileSync, readdirSync } from "node:fs";
-import { fileURLToPath } from "node:url";
-import { dirname, resolve } from "node:path";
-import { describe, it, expect } from "vitest";
-import { create, fromJson, type JsonValue } from "@bufbuild/protobuf";
-import {
-  FileReviewEventSchema,
-  FileReviewEventStreamSchema,
-} from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/filereview_pb";
-import {
-  ExecutionPhase,
-  FileChangeSetStatus,
-} from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
-import { foldFileReviewEventStream } from "../file-review-fold";
-import { isTerminalPhase } from "../execution-phases";
-
-const here = dirname(fileURLToPath(import.meta.url));
-// sdk/typescript/src/execution/__tests__ -> repo root is five levels up.
-const corpusDir = resolve(here, "../../../../../apis/testdata/hitl/file-review");
-
-/** The `expected` summary shape each vector pins (see the corpus README). */
-interface ExpectedSet {
-  id: string;
-  status: string; // full proto enum name, e.g. FILE_CHANGE_SET_STATUS_DECIDED
-  change_ids?: string[];
-  decision_count?: number;
-  aggregate_digest?: string;
-  has_approved_snapshot?: boolean;
-}
-
-interface Vector {
-  name: string;
-  description?: string;
-  execution_id: string;
-  phase: string;
-  events: JsonValue[];
-  expected: ExpectedSet[];
-}
-
-function statusFromName(name: string): FileChangeSetStatus {
-  const key = name.replace(
-    /^FILE_CHANGE_SET_STATUS_/,
-    "",
-  ) as keyof typeof FileChangeSetStatus;
-  const value = FileChangeSetStatus[key];
-  if (typeof value !== "number") {
-    throw new Error(`unknown FileChangeSetStatus in corpus: ${name}`);
-  }
-  return value;
-}
-
-function phaseFromName(name: string): ExecutionPhase {
-  const value = ExecutionPhase[name as keyof typeof ExecutionPhase];
-  if (typeof value !== "number") {
-    throw new Error(`unknown ExecutionPhase in corpus: ${name}`);
-  }
-  return value;
-}
-
-const vectorFiles = readdirSync(corpusDir).filter(
-  (f) => f.endsWith(".json") && f !== "schema.json",
-);
-
-describe("file-review fold — cross-edition corpus parity", () => {
-  it("finds the corpus vectors", () => {
-    expect(vectorFiles.length).toBeGreaterThan(0);
-  });
-
-  for (const file of vectorFiles) {
-    const vector = JSON.parse(
-      readFileSync(resolve(corpusDir, file), "utf8"),
-    ) as Vector;
-
-    it(`${file}: ${vector.name}`, () => {
-      // Decode each event with the generated schema so a malformed fixture fails
-      // loudly (matching the backend corpus drivers), then build the stream.
-      const events = vector.events.map((ev) =>
-        fromJson(FileReviewEventSchema, ev),
-      );
-      const stream = create(FileReviewEventStreamSchema, {
-        executionId: vector.execution_id,
-        events,
-      });
-
-      const phase = phaseFromName(vector.phase);
-      // Reproduce the server's actionable projection: phase-gated fold.
-      const projected = isTerminalPhase(phase)
-        ? []
-        : foldFileReviewEventStream(stream);
-
-      const actual = projected.map((set) => ({
-        id: set.id,
-        status: set.status,
-        change_ids: set.changes.map((c) => c.id),
-        decision_count: set.decisions.length,
-        aggregate_digest: set.aggregateDigest,
-        has_approved_snapshot: set.approvedSnapshot !== undefined,
-      }));
-
-      const expected = vector.expected.map((e) => ({
-        id: e.id,
-        status: statusFromName(e.status),
-        change_ids: e.change_ids ?? [],
-        decision_count: e.decision_count ?? 0,
-        aggregate_digest: e.aggregate_digest ?? "",
-        has_approved_snapshot: e.has_approved_snapshot ?? false,
-      }));
-
-      expect(actual).toEqual(expected);
-    });
-  }
-});