@stigmer/runner 3.28.0 → 3.30.0

package/src/workflows/__tests__/barrel.test.ts

@@ -0,0 +1,41 @@
+/**
+ * The fence on what a runner registers. Every export of `workflows/index.ts`
+ * is a Temporal workflow type on every worker root, and anyone who can
+ * reach Temporal can start any of them on a runner's queue. So the set is
+ * pinned exactly: the three types the server starts, each by id, none of
+ * which takes a model to run. A new export fails here until this list, and
+ * the review that comes with changing it, admits it.
+ *
+ * It also pins the link to the `run.workflow` refusal
+ * (`workflow-engine/tasks/run.ts`): every registered type carries
+ * `PLATFORM_WORKFLOW_TYPE_PREFIX`, so a workflow can never name one as its
+ * child.
+ */
+
+import { describe, expect, it } from "vitest";
+
+import * as barrel from "../index.js";
+import { EXECUTE_FROM_EXECUTION_WORKFLOW_TYPE } from "../execute-from-execution.js";
+import { PLATFORM_WORKFLOW_TYPE_PREFIX } from "../../workflow-engine/tasks/run.js";
+
+describe("the registered workflow types", () => {
+  it("are exactly the types the server starts", () => {
+    expect(Object.keys(barrel).sort()).toEqual(
+      [
+        "stigmer/mcp-server/connect",
+        "stigmer/mcp-server/discover",
+        EXECUTE_FROM_EXECUTION_WORKFLOW_TYPE,
+      ].sort(),
+    );
+  });
+
+  it("include no type that runs a model handed to it", () => {
+    expect(Object.keys(barrel)).not.toContain("stigmer/workflow/execute");
+  });
+
+  it("all carry the platform prefix the run.workflow refusal checks", () => {
+    for (const type of Object.keys(barrel)) {
+      expect(type.startsWith(PLATFORM_WORKFLOW_TYPE_PREFIX), type).toBe(true);
+    }
+  });
+});

package/src/workflows/__tests__/{execute-serverless-workflow.test.ts → engine-inline-model.test.ts}

@@ -1,7 +1,19 @@
+/**
+ * The workflow engine (`engine-core.ts`) driven with a materialized model,
+ * through the test harness's inline entry
+ * (`src/__test-utils__/workflows/inline-model.ts`), with the Temporal
+ * workflow API mocked. It pins the engine's behaviour: task output,
+ * workflow-level `input.from` and `output.as`, expression evaluation
+ * through the local activity, error handling, event sequences and flow
+ * directives. Production reaches the same engine only through the
+ * hydration workflow; `barrel.test.ts` pins that no production type takes
+ * a model from its caller.
+ */
+
 import { describe, it, expect, vi, beforeEach } from "vitest";
 import { evaluateExpressionBatch } from "../../workflow-engine/expression.js";
 import type { WorkflowModel } from "../../workflow-engine/types.js";
-import type { ExecuteServerlessWorkflowInput } from "../execute-serverless-workflow.js";
+import type { ExecuteServerlessWorkflowInput } from "../engine-core.js";
 
 const mockEvaluateExpressions = vi.fn();
 const mockResetEventSequence = vi.fn();
@@ -51,7 +63,7 @@ vi.mock("@temporalio/workflow", () => ({
   isCancellation: vi.fn(() => false),
 }));
 
-describe("executeServerlessWorkflow", () => {
+describe("the engine, on a materialized model", () => {
   beforeEach(() => {
     vi.clearAllMocks();
     mockEvaluateExpressions.mockImplementation(
@@ -60,8 +72,8 @@ describe("executeServerlessWorkflow", () => {
   });
 
   async function runWorkflow(input: ExecuteServerlessWorkflowInput) {
-    const { executeServerlessWorkflow } = await import("../execute-serverless-workflow.js");
-    return executeServerlessWorkflow(input);
+    const { executeInlineModel } = await import("../../__test-utils__/workflows/inline-model.js");
+    return executeInlineModel(input);
   }
 
   describe("basic workflow execution", () => {

package/src/workflows/call-agent-orchestrator.ts

@@ -10,7 +10,7 @@
  *
  * The workflow engine's CallAgentTaskBuilder (workflow-engine/tasks/
  * call-agent.ts) calls `ctx.callAgent()`, which is wired to
- * `orchestrateAgentCall()` in execute-serverless-workflow.ts.
+ * `orchestrateAgentCall()` in engine-core.ts.
  *
  * SANDBOX RULES: Only @temporalio/workflow imports, type-only imports,
  * and pure logic. No Node.js built-ins.

package/src/workflows/engine-core.ts

@@ -2,10 +2,13 @@
  * Shared workflow engine core — runs CNCF Serverless Workflow DSL
  * tasks inside the Temporal deterministic sandbox.
  *
- * Extracted from execute-serverless-workflow.ts so that both the
- * direct workflow ("stigmer/workflow/execute") and the hydration
- * wrapper ("stigmer/workflow/execute-from-execution") can share the
- * engine without code duplication.
+ * The engine runs a fully materialized {@link ExecuteServerlessWorkflowInput}
+ * and owns that type. Production reaches it only through the hydration
+ * workflow ("stigmer/workflow/execute-from-execution"), which reads the
+ * model, env and input back from the server by id; no registered workflow
+ * accepts a materialized model from its caller (see `index.ts`). The test
+ * harness runs goldens through an inline entry of its own
+ * (`src/__test-utils__/workflows/`).
  *
  * SANDBOX RULES: This file runs inside the Temporal deterministic V8
  * isolate. No Node.js built-ins (crypto, fs, net), no non-deterministic
@@ -46,10 +49,9 @@ import type {
   HumanInputExecutionConfig,
   TaskExecutionContext,
   WorkflowEventDescriptor,
+  WorkflowModel,
 } from "../workflow-engine/types.js";
 
-import type { ExecuteServerlessWorkflowInput } from "./execute-serverless-workflow.js";
-
 // ─────────────────────────────────────────────────────────────────────────────
 // Activity Proxies (module-level singletons — shared across all workflow
 // invocations within the same worker)
@@ -132,6 +134,30 @@ const promoteProxy = proxyLocalActivities<PromoteActivities>({
   },
 });
 
+// ─────────────────────────────────────────────────────────────────────────────
+// Engine Input
+// ─────────────────────────────────────────────────────────────────────────────
+
+/**
+ * What the engine runs: a parsed model, the merged env and the workflow
+ * input. Built by the hydration activity from what the server holds
+ * (`activities/hydrate-workflow-execution.ts`), never taken from a caller.
+ */
+export interface ExecuteServerlessWorkflowInput {
+  model: WorkflowModel;
+  workflow_input: unknown;
+  env: Record<string, unknown>;
+  metadata?: ExecutionMetadata;
+}
+
+export interface ExecutionMetadata {
+  execution_id?: string;
+  workflow_id?: string;
+  workflow_instance_id?: string;
+  org_id?: string;
+  execution_target?: number;
+}
+
 // ─────────────────────────────────────────────────────────────────────────────
 // Engine Core
 // ─────────────────────────────────────────────────────────────────────────────
@@ -149,9 +175,8 @@ export interface RunWorkflowEngineOptions {
  * executes all tasks via {@link executeDoTasks}, and returns the final
  * output.
  *
- * Called by both:
- * - `executeServerlessWorkflow` (direct invocation with pre-materialized input)
- * - `executeFromExecution` (wrapper that hydrates from slim IDs first)
+ * Called by `executeFromExecution` once it has hydrated the input from
+ * slim ids, and by the test harness's inline entry.
  *
  * @param options.checkPause Optional pause yield point callback. When
  *   provided, the engine calls this between tasks and allows the

package/src/workflows/index.ts

@@ -1,13 +1,29 @@
 /**
- * Workflow barrel file — the entry point for Temporal's workflow bundler.
+ * Workflow barrel file — the entry point for Temporal's workflow bundler,
+ * and the complete list of workflow types a runner registers.
  *
  * Re-exports workflow functions with the exact Temporal workflow type
- * names that the Java/Go backend uses to start them. The Temporal TS
- * SDK derives the workflow type from the export name of the module
- * passed to `workflowsPath`.
+ * names that the server uses to start them. The Temporal TS SDK derives
+ * the workflow type from the export name of the module passed to
+ * `workflowsPath`, so every export here is a registered type on every
+ * worker root: the static worker, the manager and pool workers, and the
+ * pre-built bundle (`scripts/bundle-slim.mjs`).
  *
- * The Java backend starts workflows via:
- *   workflowClient.newUntypedWorkflowStub("stigmer/mcp-server/connect", ...)
+ * THE RULE: every export is a type the server starts, and each takes ids
+ * that the runner reads back from the server, never a model to run.
+ * Anyone who can reach Temporal can start any type registered here on a
+ * runner's queue, so a new export is a new door and is reviewed as a
+ * wire change. `__tests__/barrel.test.ts` pins the exact set. Tests that
+ * hand the engine a model directly use the test barrel
+ * (`src/__test-utils__/workflows/index.ts`).
+ *
+ * The types and their starters:
+ *   - "stigmer/mcp-server/connect" and "stigmer/mcp-server/discover": the
+ *     server's MCP connect lane (`temporal/mcpserver/names.ts` in the
+ *     server), by MCP server id.
+ *   - "stigmer/workflow/execute-from-execution": the server's workflow
+ *     execution orchestrator (`temporal/workflowexecution/names.ts`), by
+ *     execution id; it hydrates the model from the server.
  *
  * ES2022 arbitrary module export names (`export { fn as "..." }`) let
  * us map TypeScript function names to the slash-delimited Temporal
@@ -26,10 +42,6 @@ export {
   discoverMcpServerLegacy as "stigmer/mcp-server/discover",
 } from "./connect-mcp-server.js";
 
-export {
-  executeServerlessWorkflow as "stigmer/workflow/execute",
-} from "./execute-serverless-workflow.js";
-
 export {
   executeFromExecution as "stigmer/workflow/execute-from-execution",
 } from "./execute-from-execution.js";

package/src/workflows/workflow-signals.ts

@@ -1,8 +1,8 @@
 /**
  * Shared pause/resume signal definitions and handler setup for
- * workflow execution. Used by both the hydration wrapper
- * ("stigmer/workflow/execute-from-execution") and the direct
- * invocation path ("stigmer/workflow/execute").
+ * workflow execution. Used by the hydration wrapper
+ * ("stigmer/workflow/execute-from-execution") and by the test harness's
+ * inline entry (`src/__test-utils__/workflows/inline-model.ts`).
  *
  * The Java/Go orchestrators forward pause and resume signals to
  * the child workflow. The engine checks a `checkPause` callback

package/dist/workflows/execute-serverless-workflow.d.ts

@@ -1,32 +0,0 @@
-/**
- * Temporal workflow for executing CNCF Serverless Workflow definitions.
- *
- * Workflow type: "stigmer/workflow/execute"
- *
- * Accepts a fully materialized {@link ExecuteServerlessWorkflowInput}
- * (parsed WorkflowModel, merged env, workflow_input) and runs the
- * engine. Callers that already have the materialized input use this
- * workflow directly. The hydration wrapper workflow
- * ("stigmer/workflow/execute-from-execution") handles the case where
- * only slim IDs are available.
- *
- * SANDBOX RULES: This file runs inside the Temporal deterministic V8
- * isolate. No Node.js built-ins (crypto, fs, net), no non-deterministic
- * operations, no side-effecting imports. Only @temporalio/workflow APIs,
- * type-only imports, and pure JS/TS logic.
- */
-import type { WorkflowModel } from "../workflow-engine/types.js";
-export interface ExecuteServerlessWorkflowInput {
-    model: WorkflowModel;
-    workflow_input: unknown;
-    env: Record<string, unknown>;
-    metadata?: ExecutionMetadata;
-}
-export interface ExecutionMetadata {
-    execution_id?: string;
-    workflow_id?: string;
-    workflow_instance_id?: string;
-    org_id?: string;
-    execution_target?: number;
-}
-export declare function executeServerlessWorkflow(input: ExecuteServerlessWorkflowInput): Promise<unknown>;

package/dist/workflows/execute-serverless-workflow.js

@@ -1,36 +0,0 @@
-/**
- * Temporal workflow for executing CNCF Serverless Workflow definitions.
- *
- * Workflow type: "stigmer/workflow/execute"
- *
- * Accepts a fully materialized {@link ExecuteServerlessWorkflowInput}
- * (parsed WorkflowModel, merged env, workflow_input) and runs the
- * engine. Callers that already have the materialized input use this
- * workflow directly. The hydration wrapper workflow
- * ("stigmer/workflow/execute-from-execution") handles the case where
- * only slim IDs are available.
- *
- * SANDBOX RULES: This file runs inside the Temporal deterministic V8
- * isolate. No Node.js built-ins (crypto, fs, net), no non-deterministic
- * operations, no side-effecting imports. Only @temporalio/workflow APIs,
- * type-only imports, and pure JS/TS logic.
- */
-import { isCancellation } from "@temporalio/workflow";
-import { runWorkflowEngine } from "./engine-core.js";
-import { setupPauseResumeHandlers } from "./workflow-signals.js";
-// ─────────────────────────────────────────────────────────────────────────────
-// Workflow Function
-// ─────────────────────────────────────────────────────────────────────────────
-export async function executeServerlessWorkflow(input) {
-    const { checkPause } = setupPauseResumeHandlers();
-    try {
-        return await runWorkflowEngine(input, { checkPause });
-    }
-    catch (err) {
-        if (isCancellation(err)) {
-            // Let CancelledFailure propagate — parent handles cleanup
-        }
-        throw err;
-    }
-}
-//# sourceMappingURL=execute-serverless-workflow.js.map

package/dist/workflows/execute-serverless-workflow.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"execute-serverless-workflow.js","sourceRoot":"","sources":["../../src/workflows/execute-serverless-workflow.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,OAAO,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAC;AAEtD,OAAO,EAAE,iBAAiB,EAAE,MAAM,kBAAkB,CAAC;AACrD,OAAO,EAAE,wBAAwB,EAAE,MAAM,uBAAuB,CAAC;AAqBjE,gFAAgF;AAChF,oBAAoB;AACpB,gFAAgF;AAEhF,MAAM,CAAC,KAAK,UAAU,yBAAyB,CAC7C,KAAqC;IAErC,MAAM,EAAE,UAAU,EAAE,GAAG,wBAAwB,EAAE,CAAC;IAElD,IAAI,CAAC;QACH,OAAO,MAAM,iBAAiB,CAAC,KAAK,EAAE,EAAE,UAAU,EAAE,CAAC,CAAC;IACxD,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,IAAI,cAAc,CAAC,GAAG,CAAC,EAAE,CAAC;YACxB,0DAA0D;QAC5D,CAAC;QACD,MAAM,GAAG,CAAC;IACZ,CAAC;AACH,CAAC"}

package/src/workflows/execute-serverless-workflow.ts

@@ -1,60 +0,0 @@
-/**
- * Temporal workflow for executing CNCF Serverless Workflow definitions.
- *
- * Workflow type: "stigmer/workflow/execute"
- *
- * Accepts a fully materialized {@link ExecuteServerlessWorkflowInput}
- * (parsed WorkflowModel, merged env, workflow_input) and runs the
- * engine. Callers that already have the materialized input use this
- * workflow directly. The hydration wrapper workflow
- * ("stigmer/workflow/execute-from-execution") handles the case where
- * only slim IDs are available.
- *
- * SANDBOX RULES: This file runs inside the Temporal deterministic V8
- * isolate. No Node.js built-ins (crypto, fs, net), no non-deterministic
- * operations, no side-effecting imports. Only @temporalio/workflow APIs,
- * type-only imports, and pure JS/TS logic.
- */
-
-import { isCancellation } from "@temporalio/workflow";
-import type { WorkflowModel } from "../workflow-engine/types.js";
-import { runWorkflowEngine } from "./engine-core.js";
-import { setupPauseResumeHandlers } from "./workflow-signals.js";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Workflow Input/Output Types
-// ─────────────────────────────────────────────────────────────────────────────
-
-export interface ExecuteServerlessWorkflowInput {
-  model: WorkflowModel;
-  workflow_input: unknown;
-  env: Record<string, unknown>;
-  metadata?: ExecutionMetadata;
-}
-
-export interface ExecutionMetadata {
-  execution_id?: string;
-  workflow_id?: string;
-  workflow_instance_id?: string;
-  org_id?: string;
-  execution_target?: number;
-}
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Workflow Function
-// ─────────────────────────────────────────────────────────────────────────────
-
-export async function executeServerlessWorkflow(
-  input: ExecuteServerlessWorkflowInput,
-): Promise<unknown> {
-  const { checkPause } = setupPauseResumeHandlers();
-
-  try {
-    return await runWorkflowEngine(input, { checkPause });
-  } catch (err) {
-    if (isCancellation(err)) {
-      // Let CancelledFailure propagate — parent handles cleanup
-    }
-    throw err;
-  }
-}