@stigmer/runner 3.15.3-dev.20260914100347 → 3.15.3-dev.20260916211208

package/src/activities/execute-deep-agent/deep-agent-capabilities.ts

@@ -21,8 +21,8 @@
  *  - File review under the `deep-agent` harness id with nothing excluded:
  *    this harness writes no transient file into the repo (the `.stigmer`
  *    link is the runtime's, created before its baseline pin and git-excluded
- *    at provision). The capture is the runtime's (`harness/capture.ts`, S3
- *    M4); this harness binds its `CasCaptureObserver`'s snapshot as the
+ *    at provision). The capture is the runtime's (`harness/capture.ts`,
+ *    since #1096); this harness binds its `CasCaptureObserver`'s snapshot as the
  *    runtime's CAS observations (`turn.ts`).
  */
 

package/src/activities/execute-deep-agent/hitl.ts

@@ -13,9 +13,9 @@
  * one settlement that stays here because its evidence — the gate's registry
  * of auto-skipped call ids — exists only inside this harness.
  *
- * Until S3 M2a this module also read the decisions from the execution itself
+ * Until #1096 this module also read the decisions from the execution itself
  * and carried the SKIP/REJECT settlement; both are the runtime's now, one
- * copy for every harness (S3 M1, Q-S3-2).
+ * copy for every harness.
  */
 
 import { Command } from "@langchain/langgraph";

package/src/activities/execute-deep-agent/inline-publisher.ts

@@ -19,11 +19,22 @@ import {
   ExecutionArtifactKind,
 } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
 import type { ArtifactStorage } from "../../shared/artifact-storage.js";
+import type { ExecutionArtifact } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/artifact_pb";
 import type { WorkspaceBackend } from "../../shared/workspace/types.js";
-import type { ExecutionStatusWriter } from "../../shared/execution-status-writer.js";
 import { utcTimestamp } from "../../shared/status.js";
 import { isSecretLikePath } from "../../shared/filereview/secret-paths.js";
 
+/**
+ * Where a published artifact is registered: the one member of the transcript
+ * builder this publisher needs (`harness/transcript/builder.ts` `addArtifact`,
+ * which owns the upsert rule and marks the transcript dirty so the row
+ * reaches the next persist). Declared here as the narrow view this consumer
+ * needs, never the whole builder — the `SessionProvisionConfig` rule.
+ */
+export interface ArtifactSink {
+  addArtifact(artifact: ExecutionArtifact): void;
+}
+
 export class InlinePublisher {
   private readonly workspaceBackend: WorkspaceBackend;
   /**
@@ -33,7 +44,7 @@ export class InlinePublisher {
    * persists without the offloaded artifact.
    */
   private readonly artifactStorage: ArtifactStorage | undefined;
-  private readonly statusWriter: ExecutionStatusWriter;
+  private readonly artifacts: ArtifactSink;
   private readonly executionId: string;
 
   /** Tracks (sandboxPath -> contentHash) for deduplication. */
@@ -42,12 +53,12 @@ export class InlinePublisher {
   constructor(opts: {
     workspaceBackend: WorkspaceBackend;
     artifactStorage: ArtifactStorage | undefined;
-    statusWriter: ExecutionStatusWriter;
+    artifacts: ArtifactSink;
     executionId: string;
   }) {
     this.workspaceBackend = opts.workspaceBackend;
     this.artifactStorage = opts.artifactStorage;
-    this.statusWriter = opts.statusWriter;
+    this.artifacts = opts.artifacts;
     this.executionId = opts.executionId;
   }
 
@@ -105,7 +116,7 @@ export class InlinePublisher {
         contentHash,
       });
 
-      this.statusWriter.addArtifact(artifact);
+      this.artifacts.addArtifact(artifact);
       this.published.set(sandboxPath, contentHash);
 
       console.log(

package/src/activities/execute-deep-agent/prompt-builder.ts

@@ -7,7 +7,7 @@
  * Pure functions: no side effects, no I/O. `turn-setup.ts` gathers the
  * inputs from the runtime's resolved record and this module renders them.
  *
- * What is this harness's and what is shared (S3 M5, Q-S3-10 / Q-M5-2):
+ * What is this harness's and what is shared (since #1096):
  *  - Shared through `shared/prompt-sections.ts`: WHICH standing sections
  *    render and in WHAT order (`standingContextSections`), the input-files
  *    bullet and disclosure lines (`inputFileLines`), which skills a prompt
@@ -29,7 +29,6 @@
 import { relative } from "node:path";
 import { InteractionMode } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
 import type { ProvisionResult, GitMetadata } from "../../shared/workspace/types.js";
-import { SourceType } from "../../shared/workspace/types.js";
 import { formatConversationCatchupText } from "../../shared/conversation-catchup.js";
 import type { SenderIdentity } from "../../shared/sender-identity.js";
 import type { DeclaredPreferencesContent } from "../../shared/declared-preferences.js";
@@ -116,7 +115,7 @@ directly over delegating. Only delegate when context isolation \
 or parallelism genuinely helps the user.
 `;
 
-/** The agent's instructions when the blueprint carries none; the prompt is never empty (S3 M2a, F-M2a-16: was `setup.ts`'s alone). */
+/** The agent's instructions when the blueprint carries none; the prompt is never empty (since #1096: was `setup.ts`'s alone). */
 export const DEFAULT_INSTRUCTIONS = "You are a helpful AI assistant.";
 
 export interface PromptBuilderInput {
@@ -333,7 +332,7 @@ export function composeUserMessage(
  * disclosure model: only name, description and location are injected; the
  * agent reads SKILL.md on demand through its filesystem tools. Byte for byte
  * the text the orchestrator-era `generatePromptSection` rendered from the
- * `Skill` proto (deleted with `setup.ts` at S3 M2b); the one difference is
+ * `Skill` proto (deleted with `setup.ts` in #1096); the one difference is
  * the input — a mounted file's metadata, not a fetched resource — so this
  * renderer needs no client and serves the root and every sub-agent alike.
  * Empty for no skills.
@@ -446,7 +445,7 @@ function workspaceRelativePath(rootDir: string, containerRoot: string): string {
 function formatEntryDescription(result: ProvisionResult): string {
   const name = result.entryName || "this entry";
 
-  if (result.sourceType === SourceType.LOCAL_PATH) {
+  if (result.sourceType === "local_path") {
     return (
       `Workspace entry **${name}** is the user's project directory ` +
       `at \`${result.rootDir}\`.\n` +
@@ -455,7 +454,7 @@ function formatEntryDescription(result: ProvisionResult): string {
     );
   }
 
-  if (result.sourceType === SourceType.GIT_REPO && result.gitMetadata) {
+  if (result.sourceType === "git_repo" && result.gitMetadata) {
     const meta: GitMetadata = result.gitMetadata;
     const shortSha = meta.baseCommit.length >= 7
       ? meta.baseCommit.slice(0, 7)
@@ -467,7 +466,7 @@ function formatEntryDescription(result: ProvisionResult): string {
     );
   }
 
-  if (result.sourceType === SourceType.EMPTY) {
+  if (result.sourceType === "empty") {
     return (
       `Workspace entry **${name}** is an empty workspace.\n` +
       "Create files and directories as needed for your task."

package/src/activities/execute-deep-agent/streaming-side-effects.ts

@@ -1,18 +1,26 @@
 /**
- * The inline-publish trigger of the native stream: a v3 `tools` event carries
- * the tool INPUT on `tool-started` and the OUTPUT on `tool-finished`, so the
- * two are correlated by `tool_call_id` and a file-modifying tool's target
- * path is published (`InlinePublisher`) once the call has finished — the
- * artifact appears on the status mid-turn, not at the end.
+ * The inline-publish trigger of the native stream: a `tool_started` carries
+ * the tool's INPUT and a `tool_finished` its completion, so the two are
+ * correlated by `callId` and a file-modifying tool's target path is published
+ * (`InlinePublisher`) once the call has finished — the artifact appears on
+ * the status mid-turn, not at the end.
  *
- * Until S3 M2b (Q-M1-1) the same correlation also fed the write-back
+ * Reads the canonical `TranscriptEvent`s the translator emits, never the raw
+ * v3 wire (since #1097): until then this trigger re-implemented the
+ * translator's field parsers (`tool_call_id`/`toolCallId`, the input as a
+ * string or an object) to read the same two facts off the raw event, a
+ * second parser of the wire that could drift from the first. Since then the
+ * raw event has two readers in the loop — the recorder, which records it
+ * raw by design, and `usageOf` — and everything else reads the translation.
+ *
+ * Until #1096 the same correlation also fed the write-back
  * coordinator's per-file commit (`onFileModified`); write-back is
  * finalize-only now, the turn runtime's, so publishing is this trigger's one
  * effect. The loop (`turn-stream.ts`) drains {@link pendingPublishPromises}
  * in the settle.
  */
 
-import type { V3ProtocolEvent } from "./v3-event-recorder.js";
+import type { TranscriptEvent } from "../../harness/transcript/events.js";
 import type { InlinePublisher } from "./inline-publisher.js";
 import { extractFilePath, isFileModifyingTool } from "../../shared/file-tools.js";
 
@@ -24,45 +32,28 @@ interface CachedToolInput {
 export class StreamingSideEffects {
   private readonly inputCache = new Map<string, CachedToolInput>();
   private readonly inlinePublisher: InlinePublisher | undefined;
+
   readonly pendingPublishPromises: Promise<void>[] = [];
 
   constructor(opts: { inlinePublisher?: InlinePublisher }) {
     this.inlinePublisher = opts.inlinePublisher;
   }
 
-  onProtocolEvent(event: V3ProtocolEvent): void {
-    if (event.method !== "tools") return;
+  onEvent(event: TranscriptEvent): void {
     if (!this.inlinePublisher) return;
 
-    const data = event.params.data as Record<string, unknown> | undefined;
-    if (!data) return;
-
-    const eventType = (data.event ?? data.type) as string | undefined;
-    const callId = (data.tool_call_id ?? data.toolCallId) as string | undefined;
-    if (!callId) return;
-
-    if (eventType === "tool-started") {
-      const toolName = (data.tool_name ?? data.toolName ?? data.name ?? "") as string;
-      const rawInput = data.input;
-      let input: Record<string, unknown> = {};
-      if (typeof rawInput === "string") {
-        try { input = JSON.parse(rawInput); } catch { /* leave empty */ }
-      } else if (rawInput && typeof rawInput === "object" && !Array.isArray(rawInput)) {
-        input = rawInput as Record<string, unknown>;
-      }
-      this.inputCache.set(callId, { toolName, input });
+    if (event.kind === "tool_started") {
+      this.inputCache.set(event.callId, { toolName: event.name, input: event.input });
       return;
     }
 
-    if (eventType === "tool-finished") {
-      const cached = this.inputCache.get(callId);
-      this.inputCache.delete(callId);
+    if (event.kind === "tool_finished") {
+      const cached = this.inputCache.get(event.callId);
+      this.inputCache.delete(event.callId);
       if (!cached) return;
       if (!isFileModifyingTool(cached.toolName)) return;
-
       const filePath = extractFilePath(cached.input);
       if (!filePath) return;
-
       this.pendingPublishPromises.push(this.inlinePublisher.publish(filePath));
     }
   }

package/src/activities/execute-deep-agent/subagent-transformer.ts

@@ -140,8 +140,8 @@ export interface SubagentTransformOptions {
   /**
    * Each sub-agent's mounted skills, keyed by the sub-agent's name — the
    * runtime's `TurnSkills.bySubAgent` (resolved and mounted by its skills
-   * phase, S3 M1 Q-S3-5). A sub-agent with no entry renders no skills
-   * section. Until S3 M2a this module fetched and mounted them itself with
+   * phase, since #1096). A sub-agent with no entry renders no skills
+   * section. Until then this module fetched and mounted them itself with
    * a control-plane client; the compile step is client-free now.
    */
   readonly skills: ReadonlyMap<string, readonly SkillMetadata[]>;
@@ -432,7 +432,7 @@ export function resolveSubagentSkillPrompt(
  * Heuristic check for native extended thinking support. Models with thinking
  * support don't need the explicit think tool. Read for the parent (does its
  * graph carry `think`?) and inherited by every sub-agent that names no model
- * of its own. Moved from `setup.ts` at S3 M2a: the compile step is where it
+ * of its own. Moved from `setup.ts` in #1096: the compile step is where it
  * is consumed, and the adapter's setup reads it from here too.
  */
 export function modelHasNativeThinking(modelId: string): boolean {