@stigmer/runner 3.12.6 → 3.12.7

package/src/activities/execute-cursor/index.ts

@@ -57,6 +57,7 @@ import {
 } from "../../shared/caller-identity.js";
 import { readSessionContext } from "../../shared/session-context.js";
 import { readDeclaredPreferences } from "../../shared/declared-preferences.js";
+import { readRecalledMemories } from "../../shared/recalled-memories.js";
 import { withholdSecretContentFromMessages } from "../../shared/tool-row.js";
 import { StallTimeoutError, formatStallFailure } from "../../shared/stall-watchdog.js";
 import { resolveUsableArtifactStorage, loadArtifactStorageConfig, type ArtifactStorage } from "../../shared/artifact-storage.js";
@@ -1179,6 +1180,7 @@ async function executeCursorInner(
       senderIdentity: readSenderIdentity(blueprint.sessionSpec.metadata),
       sessionContext: readSessionContext(blueprint.sessionSpec.metadata),
       declaredPreferences: readDeclaredPreferences(spec.declaredPreferences),
+      recalledMemories: readRecalledMemories(spec.recalledMemories),
       conversationCatchup: readConversationCatchup(spec.conversationCatchup),
       // The turn's recorded transcript, seeded from the persisted execution
       // on a reinvocation (Phase 3). Consumed only by the HITL-recovery
@@ -1886,6 +1888,7 @@ async function executeCursorInner(
             senderIdentity: readSenderIdentity(blueprint.sessionSpec.metadata),
             sessionContext: readSessionContext(blueprint.sessionSpec.metadata),
             declaredPreferences: readDeclaredPreferences(spec.declaredPreferences),
+            recalledMemories: readRecalledMemories(spec.recalledMemories),
             conversationCatchup: readConversationCatchup(spec.conversationCatchup),
             // Composed fresh (not reused from Phase 10): the failed primary
             // stream may have appended partial work onto status.messages,
@@ -2486,6 +2489,16 @@ export interface BuildPromptInput {
    * store with identical content.
    */
   declaredPreferences?: import("../../shared/declared-preferences.js").DeclaredPreferencesContent;
+  /**
+   * The subject's confirmed memories from the execution spec's
+   * `recalled_memories` (stigmer/stigmer#293 Phase 2, DD-006). Like the
+   * preferences, only the enhanced-prompt path consumes it — deliberately
+   * frozen per Cursor session (DD-002 D3, inherited by DD-006 D4): the
+   * first turn delivers it into the agent's own conversation store, and
+   * repeating it on resumed turns would bloat the store with identical
+   * content.
+   */
+  recalledMemories?: import("../../shared/recalled-memories.js").RecalledMemoriesContent;
   /**
    * Conversation catchup from the execution spec's `conversation_catchup`
    * (cloud DD-006): what happened on the channel conversation that the
@@ -2625,6 +2638,7 @@ export function buildPrompt(input: BuildPromptInput): string {
           senderIdentity: input.senderIdentity,
           sessionContext: input.sessionContext,
           declaredPreferences: input.declaredPreferences,
+          recalledMemories: input.recalledMemories,
           conversationCatchup,
         },
         {
@@ -2692,6 +2706,7 @@ export function buildPrompt(input: BuildPromptInput): string {
     senderIdentity: input.senderIdentity,
     sessionContext: input.sessionContext,
     declaredPreferences: input.declaredPreferences,
+    recalledMemories: input.recalledMemories,
     conversationCatchup,
   });
 }

package/src/activities/execute-cursor/prompt-builder.ts

@@ -35,6 +35,10 @@ import {
   formatDeclaredPreferencesText,
   type DeclaredPreferencesContent,
 } from "../../shared/declared-preferences.js";
+import {
+  formatRecalledMemoriesText,
+  type RecalledMemoriesContent,
+} from "../../shared/recalled-memories.js";
 import {
   visionDisclosureLines,
   type NotViewableEntry,
@@ -160,6 +164,16 @@ export interface EnhancedPromptOptions {
    * it every resumed turn would bloat the store with identical content.
    */
   declaredPreferences?: DeclaredPreferencesContent;
+  /**
+   * The subject's confirmed memories (stigmer/stigmer#293 Phase 2, DD-006):
+   * consent-gated facts server-snapshotted onto the execution spec's
+   * `recalled_memories` at create. Like the preferences, it lands in the
+   * first message and persists in the cursor agent's own conversation
+   * store — deliberately frozen per Cursor session (DD-002 D3, inherited
+   * by DD-006 D4): repeating it every resumed turn would bloat the store
+   * with identical content.
+   */
+  recalledMemories?: RecalledMemoriesContent;
   /**
    * Conversation catchup (cloud DD-006): what happened on the channel
    * conversation that the agent has not seen, read from the execution
@@ -253,6 +267,14 @@ export function buildEnhancedPrompt(options: EnhancedPromptOptions): string {
     sections.push(formatDeclaredPreferencesSection(options.declaredPreferences));
   }
 
+  // Declared-by-humans precedes learned-and-confirmed (DD-006 D4): both
+  // are platform-authored standing background, but a preference is the
+  // user's exact words while a memory is an agent's confirmed inference —
+  // the exact statement reads first.
+  if (options.recalledMemories) {
+    sections.push(formatRecalledMemoriesSection(options.recalledMemories));
+  }
+
   // Standing facts about the user (session context) come before the
   // carried conversation (bridge): the bridge may refer back to them.
   if (options.sessionContext) {
@@ -472,6 +494,12 @@ export function formatDeclaredPreferencesSection(
   return `<declared_preferences>\n${formatDeclaredPreferencesText(preferences)}\n</declared_preferences>`;
 }
 
+export function formatRecalledMemoriesSection(
+  memories: RecalledMemoriesContent,
+): string {
+  return `<recalled_memories>\n${formatRecalledMemoriesText(memories)}\n</recalled_memories>`;
+}
+
 export function formatSessionContextSection(context: string): string {
   return `<session_context>\n${formatSessionContextText(context)}\n</session_context>`;
 }

package/src/activities/execute-deep-agent/__tests__/hitl-reject.test.ts

@@ -251,6 +251,7 @@ const httpConfig: Config = {
   cloudModeEnabled: true,
   checkpointerType: "http",
   checkpointerProxyEndpoint: "http://localhost:7234",
+  artifactProxyEndpoint: null,
   primaryModel: "claude-sonnet",
   cursorStreamStallTimeoutMs: 180000,
   agentResolveTimeoutMs: 120000,

package/src/activities/execute-deep-agent/__tests__/hitl-resume-approve-all.test.ts

@@ -296,6 +296,7 @@ const baseConfig: Config = {
   cloudModeEnabled: true,
   checkpointerType: "http",
   checkpointerProxyEndpoint: "http://localhost:7234",
+  artifactProxyEndpoint: null,
   primaryModel: "claude-sonnet",
   cursorStreamStallTimeoutMs: 180000,
   agentResolveTimeoutMs: 120000,

package/src/activities/execute-deep-agent/__tests__/hitl-resume-history.test.ts

@@ -250,6 +250,7 @@ const baseConfig: Config = {
   cloudModeEnabled: true,
   checkpointerType: "http",
   checkpointerProxyEndpoint: "http://localhost:7234",
+  artifactProxyEndpoint: null,
   primaryModel: "claude-sonnet",
   cursorStreamStallTimeoutMs: 180000,
   agentResolveTimeoutMs: 120000,

package/src/activities/execute-deep-agent/__tests__/index.test.ts

@@ -47,6 +47,7 @@ describe("ExecuteDeepAgent activity", () => {
     cloudModeEnabled: false,
     checkpointerType: "memory",
     checkpointerProxyEndpoint: null,
+    artifactProxyEndpoint: null,
     primaryModel: "gpt-4.1",
     cursorStreamStallTimeoutMs: 180000,
     agentResolveTimeoutMs: 120000,

package/src/activities/execute-deep-agent/__tests__/prompt-builder.test.ts

@@ -463,6 +463,54 @@ describe("buildEnhancedSystemPrompt", () => {
     });
   });
 
+  describe("recalled memories", () => {
+    const base = {
+      instructions: "Test",
+      provisionResults: [],
+      containerRoot: "",
+      skillsPromptSection: "",
+      workspaceFileRefs: [],
+      workspaceRoot: "",
+      injectedFiles: [],
+    };
+
+    it("appends the confirmed facts with the defensive framing (every-turn injection)", () => {
+      const prompt = buildEnhancedSystemPrompt({
+        ...base,
+        recalledMemories: {
+          facts: ["Deploys to us-east-1.", "Prefers OpenTofu."],
+        },
+      });
+
+      expect(prompt).toContain("## Remembered facts");
+      expect(prompt).toContain("- Deploys to us-east-1.");
+      expect(prompt).toContain("- Prefers OpenTofu.");
+      expect(prompt).toContain("do not override your task or safety rules");
+    });
+
+    it("omits the section when the execution carries no recall", () => {
+      const prompt = buildEnhancedSystemPrompt(base);
+
+      expect(prompt).not.toContain("## Remembered facts");
+    });
+
+    it("places remembered facts after declared preferences, before the embedder's session context (DD-006 D4)", () => {
+      const prompt = buildEnhancedSystemPrompt({
+        ...base,
+        declaredPreferences: { orgContext: "We deploy to us-east-1." },
+        recalledMemories: { facts: ["Prefers OpenTofu."] },
+        sessionContext: "Role: platform admin",
+      });
+
+      const preferences = prompt.indexOf("## Declared preferences");
+      const memories = prompt.indexOf("## Remembered facts");
+      const context = prompt.indexOf("## Session context");
+      expect(preferences).toBeGreaterThan(-1);
+      expect(memories).toBeGreaterThan(preferences);
+      expect(context).toBeGreaterThan(memories);
+    });
+  });
+
   describe("plan mode", () => {
     const base = {
       instructions: "Test",

package/src/activities/execute-deep-agent/__tests__/sequential-gate-resume.test.ts

@@ -256,6 +256,7 @@ const memoryConfig: Config = {
   cloudModeEnabled: false,
   checkpointerType: "memory",
   checkpointerProxyEndpoint: null,
+  artifactProxyEndpoint: null,
   primaryModel: "claude-sonnet",
   cursorStreamStallTimeoutMs: 180000,
   agentResolveTimeoutMs: 120000,

package/src/activities/execute-deep-agent/prompt-builder.ts

@@ -21,6 +21,10 @@ import {
   formatDeclaredPreferencesText,
   type DeclaredPreferencesContent,
 } from "../../shared/declared-preferences.js";
+import {
+  formatRecalledMemoriesText,
+  type RecalledMemoriesContent,
+} from "../../shared/recalled-memories.js";
 import {
   visionDisclosureLines,
   type NotViewableEntry,
@@ -178,6 +182,14 @@ export interface PromptBuilderInput {
    * edited preference reaches the very next turn.
    */
   declaredPreferences?: DeclaredPreferencesContent;
+  /**
+   * The subject's confirmed memories (stigmer/stigmer#293 Phase 2, DD-006):
+   * consent-gated facts server-snapshotted onto the execution spec's
+   * `recalled_memories` at create. Injected on EVERY turn like the
+   * preferences — the native system prompt is rebuilt per invocation, so a
+   * deleted memory is gone from the very next turn.
+   */
+  recalledMemories?: RecalledMemoriesContent;
 }
 
 // The prompt renders the injector's own result type — a local structural twin
@@ -251,6 +263,16 @@ export function buildEnhancedSystemPrompt(input: PromptBuilderInput): string {
       formatDeclaredPreferencesText(input.declaredPreferences);
   }
 
+  // Declared-by-humans precedes learned-and-confirmed (DD-006 D4): both
+  // are platform-authored standing background, but a preference is the
+  // user's exact words while a memory is an agent's confirmed inference —
+  // the exact statement reads first.
+  if (input.recalledMemories) {
+    prompt +=
+      "\n\n## Remembered facts\n\n" +
+      formatRecalledMemoriesText(input.recalledMemories);
+  }
+
   // Standing facts about the user (session context) come before the
   // carried conversation (bridge): the bridge may refer back to them.
   if (input.sessionContext) {

package/src/activities/execute-deep-agent/setup.ts

@@ -33,6 +33,7 @@ import {
 } from "../../shared/caller-identity.js";
 import { readSessionContext } from "../../shared/session-context.js";
 import { readDeclaredPreferences } from "../../shared/declared-preferences.js";
+import { readRecalledMemories } from "../../shared/recalled-memories.js";
 import { connectMcpServers, type McpConnectionResult } from "../../shared/mcp-manager.js";
 import { mergeMcpServerUsages, resolveMcpServers } from "../../shared/mcp-resolver.js";
 import { resolveMcpTransportPosture } from "../../shared/mcp-transport-guard.js";
@@ -577,6 +578,9 @@ export async function performSetup(deps: SetupDependencies): Promise<SetupResult
       declaredPreferences: readDeclaredPreferences(
         execution.spec!.declaredPreferences,
       ),
+      recalledMemories: readRecalledMemories(
+        execution.spec!.recalledMemories,
+      ),
     });
 
     // Step 9: Construct the LLM model. Resolution to the provider API id

package/src/config.ts

@@ -96,6 +96,16 @@ export interface Config {
   readonly cloudModeEnabled: boolean;
   readonly checkpointerType: "memory" | "http" | "sqlite";
   readonly checkpointerProxyEndpoint: string | null;
+  /**
+   * Endpoint the proxy artifact store presigns against
+   * (STIGMER_ARTIFACT_PROXY_ENDPOINT), defaulting to {@link proxyEndpoint} —
+   * the checkpointer-override pattern (stigmer#803). Splitting the two lets
+   * artifact traffic target the real control plane while LLM traffic goes
+   * elsewhere (the conformance harness points LLM calls at a mock proxy that
+   * serves no presign routes; embedders can route artifact storage
+   * independently the same way).
+   */
+  readonly artifactProxyEndpoint: string | null;
   readonly primaryModel: string;
   /**
    * No-progress bound for the Cursor harness stream (milliseconds). If no
@@ -197,6 +207,8 @@ export function loadConfig(): Config {
     ?? (mode === "cloud" ? "http" : "sqlite");
   const checkpointerProxyEndpoint = process.env.STIGMER_CHECKPOINTER_PROXY_ENDPOINT
     ?? proxyEndpoint;
+  const artifactProxyEndpoint = process.env.STIGMER_ARTIFACT_PROXY_ENDPOINT
+    ?? proxyEndpoint;
 
   const primaryModel = process.env.STIGMER_PRIMARY_MODEL ?? "gpt-4.1";
 
@@ -228,6 +240,7 @@ export function loadConfig(): Config {
     cloudModeEnabled: process.env.STIGMER_CURSOR_CLOUD_MODE_ENABLED === "true",
     checkpointerType,
     checkpointerProxyEndpoint,
+    artifactProxyEndpoint,
     primaryModel,
     cursorStreamStallTimeoutMs,
     agentResolveTimeoutMs,

package/src/main.ts

@@ -89,6 +89,7 @@ async function runManagerMode(config: import("./config.js").Config): Promise<voi
       primaryModel: config.primaryModel,
       checkpointerType: config.checkpointerType,
       checkpointerProxyEndpoint: config.checkpointerProxyEndpoint ?? undefined,
+      artifactProxyEndpoint: config.artifactProxyEndpoint ?? undefined,
       cloudModeEnabled: config.cloudModeEnabled,
       executionMode: config.mode,
     });
@@ -213,6 +214,7 @@ async function runPoolMode(
     primaryModel: config.primaryModel,
     checkpointerType: config.checkpointerType,
     checkpointerProxyEndpoint: config.checkpointerProxyEndpoint ?? undefined,
+    artifactProxyEndpoint: config.artifactProxyEndpoint ?? undefined,
     cloudModeEnabled: config.cloudModeEnabled,
     executionMode: config.mode,
   });
@@ -338,6 +340,7 @@ async function runStaticMode(config: import("./config.js").Config): Promise<void
     primaryModel: config.primaryModel,
     checkpointerType: config.checkpointerType,
     checkpointerProxyEndpoint: config.checkpointerProxyEndpoint ?? undefined,
+    artifactProxyEndpoint: config.artifactProxyEndpoint ?? undefined,
     cloudModeEnabled: config.cloudModeEnabled,
     // Honor the operator's MODE env (resolved into config.mode) instead of
     // re-deriving execution location from the proxy. This keeps static mode

package/src/runner-manager.ts

@@ -114,6 +114,9 @@ export interface RunnerManagerOptions {
   /** Checkpointer proxy endpoint. Falls back to proxyEndpoint. */
   readonly checkpointerProxyEndpoint?: string;
 
+  /** Artifact presign endpoint (stigmer#803). Falls back to proxyEndpoint. */
+  readonly artifactProxyEndpoint?: string;
+
   /** Enable Cursor cloud mode. @default false */
   readonly cloudModeEnabled?: boolean;
 
@@ -721,6 +724,8 @@ export function mapManagerOptionsToConfig(
       options.checkpointerType ?? (proxyActive ? "http" : "sqlite"),
     checkpointerProxyEndpoint:
       options.checkpointerProxyEndpoint ?? options.proxyEndpoint ?? null,
+    artifactProxyEndpoint:
+      options.artifactProxyEndpoint ?? options.proxyEndpoint ?? null,
     primaryModel: options.primaryModel ?? "gpt-4.1",
     cursorStreamStallTimeoutMs:
       options.cursorStreamStallTimeoutMs ?? DEFAULT_CURSOR_STREAM_STALL_TIMEOUT_MS,

package/src/runner.ts

@@ -18,7 +18,8 @@ import { homedir, tmpdir } from "node:os";
 import type { Config } from "./config.js";
 import { DEFAULT_CURSOR_AGENT_RESOLVE_TIMEOUT_MS, DEFAULT_CURSOR_STREAM_STALL_TIMEOUT_MS, DEFAULT_WORKSPACE_LOCK_TIMEOUT_MS } from "./config.js";
 import type { WorkerActivities } from "./worker.js";
-import { resolveRunnerBootstrap } from "./bootstrap.js";
+import { resolveRunnerBootstrap, refreshRunnerAccessToken } from "./bootstrap.js";
+import { createRunnerTokenCoordinator } from "./runner-token-coordinator.js";
 import { assertLlmBackendsPreflight } from "./preflight.js";
 import {
   captureRunnerSecrets,
@@ -86,6 +87,9 @@ export interface StigmerRunnerOptions {
   /** Checkpointer proxy endpoint. Falls back to proxyEndpoint. */
   readonly checkpointerProxyEndpoint?: string;
 
+  /** Artifact presign endpoint (stigmer#803). Falls back to proxyEndpoint. */
+  readonly artifactProxyEndpoint?: string;
+
   /** Enable Cursor cloud mode for workspace-less execution. @default false */
   readonly cloudModeEnabled?: boolean;
 
@@ -253,11 +257,6 @@ export async function createStigmerRunner(
   // Only the worker connection consumes these coordinates — no activity dials
   // Temporal directly (emit-event, the last one, now routes signals through
   // the server's SendSignal lane; see oss#517).
-  //
-  // The static runner brings its own already-proxy-valid token (harness/CLI),
-  // so it does not consume the minted runner token from the bootstrap response;
-  // that proxy-credential lifecycle lives in createStigmerRunnerManager (the
-  // long-lived desktop host that needs it). Only the coordinates are used here.
   const coordinates = await resolveRunnerBootstrap({
     explicitAddress: options.temporalAddress,
     explicitNamespace: options.temporalNamespace,
@@ -269,11 +268,44 @@ export async function createStigmerRunner(
   // activity clients read the ref per request instead of pinning the boot
   // token for the pod's whole life.
   const tokenRef = { current: baseConfig.stigmerToken };
+
+  // Adopt the bootstrap-minted embedded_runner credential for gRPC runner-class
+  // calls (stigmer-cloud#507). The static path historically discarded it ("the
+  // static token is already proxy-valid") — true for the PROXY lane, but the
+  // ExecutionContext decrypt lane is gated on runner-class token_type
+  // (stigmer-cloud#152/#155): a user-token static runner (conformance harness,
+  // CLI daemon with a cloud token) had its scoped-token exchange refused and
+  // silently read REDACTED secret values. The coordinator owns the mint's TTL
+  // (same module the desktop manager uses — one refresh implementation, not
+  // two); its only sink here is the gRPC runner-credential ref, because the
+  // static host's proxy token is provided by the host and stays untouched.
+  // Servers that mint nothing (explicit-address boots, tokenless OSS, cloud
+  // sandboxes with baked credentials) leave the ref null — byte-identical
+  // behavior to before.
+  const runnerTokenRef: { current: string | null } = { current: null };
+  const runnerTokenCoordinator = createRunnerTokenCoordinator({
+    applyProxyToken: (token) => {
+      runnerTokenRef.current = token;
+    },
+    reMint: () =>
+      refreshRunnerAccessToken({
+        token: tokenRef.current,
+        stigmerEndpoint: baseConfig.stigmerBackendEndpoint,
+      }),
+  });
+  if (coordinates.runnerAccessToken) {
+    runnerTokenCoordinator.adoptMintedToken(
+      coordinates.runnerAccessToken,
+      coordinates.runnerAccessTokenExpiresInSeconds,
+    );
+  }
+
   const config: Config = {
     ...baseConfig,
     temporalAddress: coordinates.temporalAddress,
     temporalNamespace: coordinates.temporalNamespace,
     stigmerTokenRef: tokenRef,
+    stigmerRunnerTokenRef: runnerTokenRef,
   };
   markBoot("bootstrap_resolved");
 
@@ -359,6 +391,7 @@ export async function createStigmerRunner(
     },
     shutdown() {
       tokenRenewal?.stop();
+      runnerTokenCoordinator.stop();
       // Classification first, drain second: an in-flight activity cancelled
       // by the drain must observe the signal already aborted (see
       // shared/worker-shutdown.ts for the ownership contract).
@@ -418,6 +451,9 @@ export function mapOptionsToConfig(options: StigmerRunnerOptions): Config {
     checkpointerProxyEndpoint: options.checkpointerProxyEndpoint
       ?? options.proxyEndpoint
       ?? null,
+    artifactProxyEndpoint: options.artifactProxyEndpoint
+      ?? options.proxyEndpoint
+      ?? null,
     primaryModel: options.primaryModel ?? "gpt-4.1",
     cursorStreamStallTimeoutMs:
       options.cursorStreamStallTimeoutMs ?? DEFAULT_CURSOR_STREAM_STALL_TIMEOUT_MS,

package/src/shared/__tests__/artifact-storage.test.ts

@@ -654,6 +654,7 @@ describe("loadArtifactStorageConfig", () => {
     runnerId: null,
     checkpointerType: "memory" as const,
     checkpointerProxyEndpoint: null,
+    artifactProxyEndpoint: null,
     primaryModel: "gpt-4.1",
     cursorStreamStallTimeoutMs: 180000,
     agentResolveTimeoutMs: 120000,
@@ -672,10 +673,14 @@ describe("loadArtifactStorageConfig", () => {
   });
 
   it("defaults to proxy in cloud mode", () => {
+    // loadConfig derives artifactProxyEndpoint from proxyEndpoint when the
+    // STIGMER_ARTIFACT_PROXY_ENDPOINT override is unset; Config literals here
+    // mirror that invariant.
     const cfg = loadArtifactStorageConfig({
       ...baseConfig,
       mode: "cloud",
       proxyEndpoint: "https://proxy.example.com",
+      artifactProxyEndpoint: "https://proxy.example.com",
       stigmerToken: "tok",
     });
     expect(cfg.type).toBe("proxy");
@@ -689,6 +694,7 @@ describe("loadArtifactStorageConfig", () => {
       ...baseConfig,
       mode: "local",
       proxyEndpoint: "https://localhost:9090",
+      artifactProxyEndpoint: "https://localhost:9090",
       stigmerToken: "tok",
     });
     expect(cfg.type).toBe("proxy");
@@ -696,6 +702,21 @@ describe("loadArtifactStorageConfig", () => {
     expect(cfg.proxyAuthToken).toBe("tok");
   });
 
+  it("presigns against the artifact override when split from the LLM proxy endpoint (stigmer#803)", () => {
+    // The conformance harness points LLM traffic at a mock proxy that serves
+    // no presign routes; the artifact override routes storage at the real
+    // control plane independently (the checkpointer-override pattern).
+    process.env.ARTIFACT_STORAGE_TYPE = "proxy";
+    const cfg = loadArtifactStorageConfig({
+      ...baseConfig,
+      proxyEndpoint: "https://mock-llm.example.com",
+      artifactProxyEndpoint: "https://service.example.com",
+      stigmerToken: "tok",
+    });
+    expect(cfg.type).toBe("proxy");
+    expect(cfg.proxyEndpoint).toBe("https://service.example.com");
+  });
+
   it("honors ARTIFACT_STORAGE_TYPE=none even when a proxy endpoint is configured", () => {
     // "none" is a deliberate operator/e2e posture — it must beat the
     // storage-follows-transport default exactly like the other overrides.

package/src/shared/__tests__/recalled-memories.test.ts

@@ -0,0 +1,88 @@
+/**
+ * Unit tests for the recalled-memories module (stigmer/stigmer#293 Phase 2,
+ * DD-006). Like declared-preferences there is no string key to mirror-guard —
+ * the value rides the typed `AgentExecutionSpec.recalled_memories` proto
+ * field, so codegen enforces the cross-repo contract. What IS pinned here:
+ * the render-only-when-something-to-say read semantics (disabled OR empty
+ * renders nothing — the enabled bit with zero facts is Stage 3's remember-
+ * tool signal, not this module's concern), the server-composed fact order,
+ * the content-only rendering (memory_id never reaches the prompt), and the
+ * framing's behavioral contract.
+ */
+
+import { describe, it, expect } from "vitest";
+import { create } from "@bufbuild/protobuf";
+import { RecalledMemoriesSchema } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/spec_pb";
+
+import {
+  formatRecalledMemoriesText,
+  readRecalledMemories,
+} from "../recalled-memories.js";
+
+const FACT_OLDER = "Deploys to us-east-1.";
+const FACT_NEWER = "Prefers OpenTofu over Terraform.";
+
+describe("readRecalledMemories", () => {
+  it("reads the facts in server-composed order (oldest-first in both editions)", () => {
+    const recalled = create(RecalledMemoriesSchema, {
+      enabled: true,
+      facts: [
+        { memoryId: "mem_older", content: FACT_OLDER },
+        { memoryId: "mem_newer", content: FACT_NEWER },
+      ],
+    });
+    expect(readRecalledMemories(recalled)).toEqual({
+      facts: [FACT_OLDER, FACT_NEWER],
+    });
+  });
+
+  it("answers undefined when the field is absent (pre-Phase-2 executions)", () => {
+    expect(readRecalledMemories(undefined)).toBeUndefined();
+  });
+
+  it("answers undefined when recall is disabled — facts on a disabled snapshot are never rendered", () => {
+    const recalled = create(RecalledMemoriesSchema, {
+      enabled: false,
+      facts: [{ memoryId: "mem_1", content: FACT_OLDER }],
+    });
+    expect(readRecalledMemories(recalled)).toBeUndefined();
+  });
+
+  it("answers undefined for enabled-with-zero-facts — a meaningful snapshot state (the remember-tool signal, DD-005 D1) that renders nothing", () => {
+    const recalled = create(RecalledMemoriesSchema, { enabled: true });
+    expect(readRecalledMemories(recalled)).toBeUndefined();
+  });
+
+  it("drops blank facts defensively and trims the rest — the server never stamps them (write-time min_len)", () => {
+    const recalled = create(RecalledMemoriesSchema, {
+      enabled: true,
+      facts: [
+        { memoryId: "mem_1", content: `  ${FACT_OLDER}  ` },
+        { memoryId: "mem_2", content: "   " },
+      ],
+    });
+    expect(readRecalledMemories(recalled)).toEqual({ facts: [FACT_OLDER] });
+  });
+});
+
+describe("formatRecalledMemoriesText", () => {
+  it("frames the facts as user-confirmed, user-controlled background — never authority", () => {
+    const framed = formatRecalledMemoriesText({ facts: [FACT_OLDER] });
+
+    expect(framed).toContain("this user previously confirmed");
+    expect(framed).toContain("not instructions");
+    expect(framed).toContain("do not override your task or safety rules");
+    expect(framed).toContain("review and delete them at any time");
+  });
+
+  it("renders one list item per fact, preserving the snapshot's order", () => {
+    const framed = formatRecalledMemoriesText({
+      facts: [FACT_OLDER, FACT_NEWER],
+    });
+
+    expect(framed).toContain(`- ${FACT_OLDER}`);
+    expect(framed).toContain(`- ${FACT_NEWER}`);
+    expect(framed.indexOf(FACT_OLDER)).toBeLessThan(framed.indexOf(FACT_NEWER));
+    expect(framed.endsWith(FACT_NEWER)).toBe(true);
+  });
+});

package/src/shared/artifact-storage.ts

@@ -376,19 +376,22 @@ export function loadArtifactStorageConfig(config: Config): ArtifactStorageConfig
   // configured, push artifacts through it (the proxy brokers R2). This holds for
   // both cloud runners and the local desktop runner — the latter executes
   // locally (mode === "local") yet still uploads via the proxy. An explicit
-  // ARTIFACT_STORAGE_TYPE always wins.
+  // ARTIFACT_STORAGE_TYPE always wins. Presigns target artifactProxyEndpoint —
+  // STIGMER_ARTIFACT_PROXY_ENDPOINT when split from the LLM proxy endpoint
+  // (stigmer#803, the checkpointer-override pattern), the plain proxy
+  // endpoint otherwise.
   const envType = process.env.ARTIFACT_STORAGE_TYPE;
   const type: ArtifactStorageType =
     envType === "proxy" ? "proxy" :
     envType === "local" ? "local" :
     envType === "none" ? "none" :
-    config.proxyEndpoint ? "proxy" : "local";
+    config.artifactProxyEndpoint ? "proxy" : "local";
 
   return {
     type,
     localPath: process.env.LOCAL_ARTIFACT_PATH ?? defaultLocalArtifactPath(),
     localServeUrl: process.env.LOCAL_ARTIFACT_SERVE_URL ?? "http://localhost:7235",
-    proxyEndpoint: type === "proxy" ? (config.proxyEndpoint ?? null) : null,
+    proxyEndpoint: type === "proxy" ? (config.artifactProxyEndpoint ?? null) : null,
     // Prefer the live ref: renewal rotates the token in place and uploads
     // must present the current credential, not the boot one.
     proxyAuthToken: type === "proxy"
@@ -408,7 +411,9 @@ export function createArtifactStorage(cfg: ArtifactStorageConfig): ArtifactStora
   }
   if (cfg.type === "proxy") {
     if (!cfg.proxyEndpoint) {
-      throw new Error("Proxy artifact storage requires STIGMER_PROXY_ENDPOINT");
+      throw new Error(
+        "Proxy artifact storage requires STIGMER_ARTIFACT_PROXY_ENDPOINT or STIGMER_PROXY_ENDPOINT",
+      );
     }
     const tokenAtBoot = typeof cfg.proxyAuthToken === "string"
       ? cfg.proxyAuthToken