@stigmer/react 3.40.1 → 3.41.1-dev.20261003094357.g39d6aa748646

package/src/workflow/instance/WorkflowInstanceDetailPanel.tsx

@@ -68,15 +68,16 @@ export function WorkflowInstanceDetailPanel({
   const visibility = meta?.visibility ?? ApiResourceVisibility.visibility_private;
   // Run observability is a separate axis from instance visibility, and only
   // meaningful while the instance is private (ORG/PUBLIC already expose runs
-  // by inheritance). It is offered only to those who can grant access, so it
-  // rides into the dialog as the resource-specific section — present only when
-  // both conditions hold.
-  const { allowed: canGrantAccess } = useCheckPermission(
+  // by inheritance). It is offered only to those who may change who reaches
+  // the instance (can_manage_audience, the server's bar on
+  // updateExecutionVisibility), so it rides into the dialog as the
+  // resource-specific section — present only when both conditions hold.
+  const { allowed: canManageAudience } = useCheckPermission(
     id ? { kind: "workflow_instance", id } : null,
-    "can_grant_access",
+    "can_manage_audience",
   );
   const runVisibilitySection =
-    visibility === ApiResourceVisibility.visibility_private && canGrantAccess
+    visibility === ApiResourceVisibility.visibility_private && canManageAudience
       ? {
           title: "Run visibility",
           description:

package/src/workflow/task-detail/task-approval.ts

@@ -50,15 +50,6 @@ export interface TaskApprovalRequestView {
   readonly payloadArtifactId: string | null;
 }
 
-/**
- * A resolved human_input decision, sourced from the canonical task-output
- * record (the runner stores the reviewer's full response as the task
- * output) and enriched with timing from the `approval_resolved` event.
- *
- * `outcome` is the empty string during the brief window after a decision
- * is signalled but before the status snapshot reflects the task output —
- * consumers render a "finalizing" affordance in that state.
- */
 /**
  * Display identity of the reviewer, snapshotted server-side at decision
  * time (see `reviewer_actor` in the human_input task-output contract).
@@ -95,6 +86,17 @@ export interface TaskReviewerView {
   readonly isRawId: boolean;
 }
 
+/**
+ * A resolved human_input decision, sourced from the canonical task-output
+ * record (the runner stores the reviewer's full response as the task
+ * output), with the `approval_resolved` event standing in for any field the
+ * status snapshot has not captured yet and supplying the wait duration.
+ *
+ * `outcome` is the empty string only when neither source carries it: in
+ * the brief window before the status snapshot reflects the task output,
+ * for an event recorded before the payload had an `outcome` field.
+ * Consumers render a "finalizing" affordance in that state.
+ */
 export interface TaskDetailApprovalDecision {
   /** Chosen outcome identifier (e.g. "approve", "pause_campaigns"). */
   readonly outcome: string;
@@ -166,7 +168,7 @@ export function deriveTaskApprovalDecision(
   if (resolution === null && outputOutcome === "") return null;
 
   return {
-    outcome: outputOutcome,
+    outcome: outputOutcome || (resolution?.outcome ?? ""),
     reviewer:
       readSnapshotString(taskOutput, "reviewer") || (resolution?.resolvedBy ?? ""),
     reviewerActor: deriveReviewerActor(resolution, taskOutput),
@@ -175,15 +177,20 @@ export function deriveTaskApprovalDecision(
       readSnapshotString(taskOutput, "comment") || (resolution?.comment ?? ""),
     formData: readSnapshotObject(taskOutput, "form_data"),
     waitDurationMs: resolution ? Number(resolution.waitDurationMs) : 0,
-    autoResolved: taskOutput?.["auto_resolved"] === true,
+    // Output first, like every field above: once the snapshot carries the
+    // decision it is the record, and the event only fills the window before.
+    autoResolved:
+      outputOutcome !== ""
+        ? taskOutput?.["auto_resolved"] === true
+        : resolution?.autoResolved === true,
   };
 }
 
 /**
  * Collapses a decision's attribution into the render-ready reviewer view,
  * or `null` when the decision carries no attribution at all (timeout
- * auto-resolution, OSS single-user edition) — consumers omit the "by …"
- * segment entirely in that case.
+ * auto-resolution) — consumers omit the "by …" segment entirely in that
+ * case.
  */
 export function deriveTaskReviewer(
   decision: TaskDetailApprovalDecision,

package/src/workflow/useDiagnoseExecutionFlow.ts

@@ -136,7 +136,10 @@ export function useDiagnoseExecutionFlow(
   const onErrorRef = useRef(onError);
   onErrorRef.current = onError;
 
-  const sessionIdRef = useRef<string | null>(null);
+  // The flow's session and the organization it was created in: every turn
+  // continues there, since a turn in a session belongs to that session's
+  // organization (stigmer/stigmer#1580), even if `org` changes meanwhile.
+  const sessionRef = useRef<{ readonly id: string; readonly org: string } | null>(null);
   const prevTerminalRef = useRef(false);
   const autoStartedRef = useRef(false);
 
@@ -232,22 +235,23 @@ export function useDiagnoseExecutionFlow(
     prevTerminalRef.current = false;
 
     try {
-      let activeSessionId = sessionIdRef.current;
+      let activeSession = sessionRef.current;
 
-      if (!activeSessionId) {
+      if (!activeSession) {
+        const sessionOrg = orgRef.current;
         const { sessionId: newSessionId } = await createSession({
-          org: orgRef.current,
-          agentRef: workflowArchitectRef(orgRef.current),
+          org: sessionOrg,
+          agentRef: workflowArchitectRef(sessionOrg),
         });
-        sessionIdRef.current = newSessionId;
-        activeSessionId = newSessionId;
+        activeSession = { id: newSessionId, org: sessionOrg };
+        sessionRef.current = activeSession;
       }
 
       const message = buildDiagnosisMessage();
 
       const { executionId: newExecutionId } = await createExecution({
-        org: orgRef.current,
-        sessionId: activeSessionId,
+        org: activeSession.org,
+        sessionId: activeSession.id,
         message,
         structuredOutputSchema: WORKFLOW_DIAGNOSIS_RESPONSE_SCHEMA,
       });
@@ -292,20 +296,21 @@ export function useDiagnoseExecutionFlow(
       prevTerminalRef.current = false;
 
       try {
-        let activeSessionId = sessionIdRef.current;
+        let activeSession = sessionRef.current;
 
-        if (!activeSessionId) {
+        if (!activeSession) {
+          const sessionOrg = orgRef.current;
           const { sessionId: newSessionId } = await createSession({
-            org: orgRef.current,
-            agentRef: workflowArchitectRef(orgRef.current),
+            org: sessionOrg,
+            agentRef: workflowArchitectRef(sessionOrg),
           });
-          sessionIdRef.current = newSessionId;
-          activeSessionId = newSessionId;
+          activeSession = { id: newSessionId, org: sessionOrg };
+          sessionRef.current = activeSession;
         }
 
         const { executionId: newExecutionId } = await createExecution({
-          org: orgRef.current,
-          sessionId: activeSessionId,
+          org: activeSession.org,
+          sessionId: activeSession.id,
           message: trimmed,
           structuredOutputSchema: WORKFLOW_DIAGNOSIS_RESPONSE_SCHEMA,
         });
@@ -351,7 +356,7 @@ export function useDiagnoseExecutionFlow(
     setCompletedExecutions([]);
     setExtracted(null);
     setError(null);
-    sessionIdRef.current = null;
+    sessionRef.current = null;
     prevTerminalRef.current = false;
     autoStartedRef.current = false;
   }, []);

package/src/workflow/useExplainWorkflowFlow.ts

@@ -127,9 +127,13 @@ export function useExplainWorkflowFlow(
     prevTerminalRef.current = false;
 
     try {
+      // The session and its first turn live in one organization, read once:
+      // a turn in a session belongs to that session's organization
+      // (stigmer/stigmer#1580), even if `org` changes during the create.
+      const sessionOrg = orgRef.current;
       const { sessionId } = await createSession({
-        org: orgRef.current,
-        agentRef: workflowArchitectRef(orgRef.current),
+        org: sessionOrg,
+        agentRef: workflowArchitectRef(sessionOrg),
       });
 
       const message =
@@ -139,7 +143,7 @@ export function useExplainWorkflowFlow(
         "\n```";
 
       const { executionId: newExecId } = await createExecution({
-        org: orgRef.current,
+        org: sessionOrg,
         sessionId,
         message,
         structuredOutputSchema: WORKFLOW_ARCHITECT_RESPONSE_SCHEMA,

package/src/workflow/useRefineWorkflowFlow.ts

@@ -121,7 +121,13 @@ export function useRefineWorkflowFlow(
   const onErrorRef = useRef(onError);
   onErrorRef.current = onError;
 
-  const sessionIdRef = useRef<string | null>(null);
+  // The flow's session and the organization it was created in: every turn
+  // continues there, since a turn in a session belongs to that session's
+  // organization (stigmer/stigmer#1580), even if `org` changes meanwhile.
+  const sessionRef = useRef<{
+    readonly id: string;
+    readonly org: string;
+  } | null>(null);
   const lastSentYamlRef = useRef<string | null>(null);
   const prevTerminalRef = useRef(false);
 
@@ -244,22 +250,23 @@ export function useRefineWorkflowFlow(
       prevTerminalRef.current = false;
 
       try {
-        let activeSessionId = sessionIdRef.current;
+        let activeSession = sessionRef.current;
 
-        if (!activeSessionId) {
+        if (!activeSession) {
+          const sessionOrg = orgRef.current;
           const { sessionId: newSessionId } = await createSession({
-            org: orgRef.current,
-            agentRef: workflowArchitectRef(orgRef.current),
+            org: sessionOrg,
+            agentRef: workflowArchitectRef(sessionOrg),
           });
-          sessionIdRef.current = newSessionId;
-          activeSessionId = newSessionId;
+          activeSession = { id: newSessionId, org: sessionOrg };
+          sessionRef.current = activeSession;
         }
 
         const message = buildMessage(trimmed);
 
         const { executionId: newExecutionId } = await createExecution({
-          org: orgRef.current,
-          sessionId: activeSessionId,
+          org: activeSession.org,
+          sessionId: activeSession.id,
           message,
           structuredOutputSchema: WORKFLOW_ARCHITECT_RESPONSE_SCHEMA,
         });
@@ -305,7 +312,7 @@ export function useRefineWorkflowFlow(
     setCompletedExecutions([]);
     setExtracted(null);
     setError(null);
-    sessionIdRef.current = null;
+    sessionRef.current = null;
     lastSentYamlRef.current = null;
     prevTerminalRef.current = false;
   }, []);

package/src/workflow/useWorkflowArchitectFlow.ts

@@ -235,14 +235,18 @@ export function useWorkflowArchitectFlow(
     prevTerminalRef.current = false;
 
     try {
+      // The session and its first turn live in one organization, read once:
+      // a turn in a session belongs to that session's organization
+      // (stigmer/stigmer#1580), even if `org` changes during the create.
+      const sessionOrg = orgRef.current;
       const { sessionId: newSessionId } = await createSession({
-        org: orgRef.current,
-        agentRef: workflowArchitectRef(orgRef.current),
+        org: sessionOrg,
+        agentRef: workflowArchitectRef(sessionOrg),
       });
       setSessionId(newSessionId);
 
       const { executionId: newExecutionId } = await createExecution({
-        org: orgRef.current,
+        org: sessionOrg,
         sessionId: newSessionId,
         message: trimmed,
         structuredOutputSchema: WORKFLOW_ARCHITECT_RESPONSE_SCHEMA,

package/src/workspace/ExplorerTree.tsx

@@ -9,6 +9,7 @@ import { Tooltip, TooltipContent, TooltipTrigger } from "../internal/tooltip.js"
 import { useWorkspaceFiles } from "./useWorkspaceFiles.js";
 import type { WorkspaceEntry } from "./useWorkspaceEntries.js";
 import type { WorkspaceFileLister } from "./WorkspaceFileLister.js";
+import { LoadingRegion } from "../internal/LoadingRegion.js";
 
 /** Props for {@link ExplorerTree}. */
 export interface ExplorerTreeProps {
@@ -187,14 +188,9 @@ function ExplorerRootBody({
 }) {
   if (isLoading) {
     return (
-      <div
-        // role="status" both announces the loading state to assistive tech and
-        // makes aria-label permitted here (a role-less generic div cannot carry
-        // an accessible name — axe `aria-prohibited-attr`).
-        role="status"
+      <LoadingRegion
         className="stg:space-y-1.5 stg:px-2 stg:py-2"
-        aria-busy="true"
-        aria-label={`Loading files for ${entryName}`}
+        label={`Loading files for ${entryName}`}
       >
         {[1, 2, 3, 4].map((i) => (
           <div
@@ -204,7 +200,7 @@ function ExplorerRootBody({
             aria-hidden="true"
           />
         ))}
-      </div>
+      </LoadingRegion>
     );
   }
 

package/src/workspace/FileViewer.tsx

@@ -24,6 +24,7 @@ import { useFileChangeContent } from "../execution/useFileChangeContent.js";
 import { UNSTYLED_BUTTON } from "../internal/form-primitives.js";
 import { Tooltip, TooltipContent, TooltipTrigger } from "../internal/tooltip.js";
 import type { RevealTarget } from "../internal/useRevealLine.js";
+import { LoadingRegion } from "../internal/LoadingRegion.js";
 import type { SelectedWorkspaceFile } from "../internal/store/workspace-file-selection-store.js";
 import { useWorkspaceFileContent } from "./useWorkspaceFileContent.js";
 import type { WorkspaceEntry } from "./useWorkspaceEntries.js";
@@ -624,11 +625,9 @@ function CapturedFileContent({
 
 function LoadingSkeleton() {
   return (
-    <div
-      role="status"
+    <LoadingRegion
       className="stg:space-y-2 stg:p-4"
-      aria-busy="true"
-      aria-label="Loading file"
+      label="Loading file"
     >
       {SKELETON_LINE_WIDTHS.map((width, i) => (
         <div
@@ -638,7 +637,7 @@ function LoadingSkeleton() {
           aria-hidden="true"
         />
       ))}
-    </div>
+    </LoadingRegion>
   );
 }