@stigmer/react 3.2.1 → 3.2.3

package/src/workflow/__tests__/task-presentation.test.ts

@@ -196,11 +196,45 @@ describe("per-kind preview lines", () => {
       expected: "delivery failed",
     },
     {
-      label: "human_input settled decision",
+      label: "human_input settled decision (legacy record, raw reviewer)",
       kind: WorkflowTaskKind.human_input,
       overrides: { outputSummary: { outcome: "approve", reviewer: "suresh" } },
       expected: "approve · by suresh",
     },
+    {
+      label: "human_input settled decision prefers the reviewer_actor display name",
+      kind: WorkflowTaskKind.human_input,
+      overrides: {
+        outputSummary: {
+          outcome: "approve",
+          reviewer: "ida_01abc",
+          reviewer_actor: {
+            id: "ida_01abc",
+            display_name: "Ada Lovelace",
+            email: "ada@example.com",
+          },
+        },
+      },
+      expected: "approve · by Ada Lovelace",
+    },
+    {
+      label: "human_input settled decision falls back to the actor email",
+      kind: WorkflowTaskKind.human_input,
+      overrides: {
+        outputSummary: {
+          outcome: "approve",
+          reviewer: "ida_01abc",
+          reviewer_actor: { id: "ida_01abc", email: "ada@example.com" },
+        },
+      },
+      expected: "approve · by ada@example.com",
+    },
+    {
+      label: "human_input unattributed decision omits the by segment",
+      kind: WorkflowTaskKind.human_input,
+      overrides: { outputSummary: { outcome: "approve" } },
+      expected: "approve",
+    },
     {
       label: "wait completed with structured duration",
       kind: WorkflowTaskKind.wait,

package/src/workflow/__tests__/useWorkflowExecutionPanel.test.ts

@@ -9,7 +9,6 @@ import {
   FILE_CHANGE_DOCUMENT_ENTRY_ID,
   fileChangeTabPath,
 } from "../../execution/file-change-document";
-import { AGENT_EXECUTION_DOCUMENT_ENTRY_ID } from "../../execution/agent-execution-document";
 import {
   DIAGNOSIS_DOCUMENT_ENTRY_ID,
   DIAGNOSIS_DOCUMENT_PATH,
@@ -174,62 +173,6 @@ describe("useWorkflowExecutionPanel", () => {
     expect(new Set(editors.map((e) => e.entryId)).size).toBe(2);
   });
 
-  it("openAgentExecution opens a preview tab in the transcript family and expands the panel", () => {
-    const { result } = renderHook(() => useWorkflowExecutionPanel());
-
-    act(() => result.current.openAgentExecution("aex_1", "summarize-report"));
-
-    expect(result.current.isOpen).toBe(true);
-    const { editors } = result.current.editorsStore.getSnapshot();
-    expect(editors).toEqual([
-      {
-        entryId: AGENT_EXECUTION_DOCUMENT_ENTRY_ID,
-        path: "aex_1/summarize-report",
-        preview: true,
-      },
-    ]);
-  });
-
-  it("the transcript preview shares the one slot with artifacts and changes", () => {
-    const { result } = renderHook(() => useWorkflowExecutionPanel());
-
-    act(() => {
-      result.current.openAgentExecution("aex_1", "call-agent");
-      result.current.openArtifact(artifact("art_1", "report.json"));
-    });
-
-    // Preview-tab semantics: the artifact open replaced the transcript.
-    const { editors } = result.current.editorsStore.getSnapshot();
-    expect(editors).toHaveLength(1);
-    expect(editors[0].entryId).toBe(ARTIFACT_DOCUMENT_ENTRY_ID);
-  });
-
-  it("pinAgentExecution makes the transcript's tab persistent", () => {
-    const { result } = renderHook(() => useWorkflowExecutionPanel());
-
-    act(() => {
-      result.current.openAgentExecution("aex_1", "call-agent");
-      result.current.pinAgentExecution("aex_1", "call-agent");
-    });
-
-    const { editors } = result.current.editorsStore.getSnapshot();
-    expect(editors[0].preview).toBe(false);
-  });
-
-  it("two AGENT_CALL tasks calling the same agent open distinct transcript tabs", () => {
-    const { result } = renderHook(() => useWorkflowExecutionPanel());
-
-    act(() => {
-      result.current.openAgentExecution("aex_1", "first-call");
-      result.current.pinAgentExecution("aex_1", "first-call");
-      result.current.openAgentExecution("aex_2", "second-call");
-    });
-
-    const { editors } = result.current.editorsStore.getSnapshot();
-    expect(editors).toHaveLength(2);
-    expect(new Set(editors.map((e) => e.path)).size).toBe(2);
-  });
-
   it("closing an editor keeps the panel open (the panel is more than tabs)", () => {
     const { result } = renderHook(() => useWorkflowExecutionPanel());
     const a = artifact("art_1", "a.json");

package/src/workflow/index.ts

@@ -226,10 +226,10 @@ export {
   type WorkflowArtifactDocumentProps,
 } from "./WorkflowArtifactDocument.js";
 export {
-  WorkflowAgentExecutionDocument,
-  type WorkflowAgentExecutionDocumentProps,
+  WorkflowAgentCallTranscript,
+  type WorkflowAgentCallTranscriptProps,
   type WorkflowAgentExecutionHitl,
-} from "./WorkflowAgentExecutionDocument.js";
+} from "./WorkflowAgentCallTranscript.js";
 export {
   useWorkflowArtifactDownload,
   type UseWorkflowArtifactDownloadReturn,
@@ -609,8 +609,11 @@ export {
   type TaskDetailIO,
   deriveTaskApprovalRequest,
   deriveTaskApprovalDecision,
+  deriveTaskReviewer,
   type TaskApprovalRequestView,
   type TaskDetailApprovalDecision,
+  type TaskReviewerActor,
+  type TaskReviewerView,
   StructuredDataViewer,
   type StructuredDataViewerProps,
 } from "./task-detail/index.js";

package/src/workflow/task-detail/index.ts

@@ -2,8 +2,11 @@ export { buildIO, type TaskDetailIO } from "./task-detail-io.js";
 export {
   deriveTaskApprovalRequest,
   deriveTaskApprovalDecision,
+  deriveTaskReviewer,
   type TaskApprovalRequestView,
   type TaskDetailApprovalDecision,
+  type TaskReviewerActor,
+  type TaskReviewerView,
 } from "./task-approval.js";
 export {
   StructuredDataViewer,

package/src/workflow/task-detail/task-approval.ts

@@ -59,11 +59,49 @@ export interface TaskApprovalRequestView {
  * is signalled but before the status snapshot reflects the task output —
  * consumers render a "finalizing" affordance in that state.
  */
+/**
+ * Display identity of the reviewer, snapshotted server-side at decision
+ * time (see `reviewer_actor` in the human_input task-output contract).
+ * Renderers apply the fallback ladder: displayName → email → raw
+ * {@link TaskDetailApprovalDecision.reviewer} id → omit.
+ */
+export interface TaskReviewerActor {
+  /** Canonical identity (matches the decision's `reviewer`). */
+  readonly id: string;
+  /** Human-readable name; `""` when unknown. */
+  readonly displayName: string;
+  /** Email address; `""` when unknown. */
+  readonly email: string;
+  /** Avatar URL; `""` when unknown. */
+  readonly avatar: string;
+}
+
+/**
+ * How a decided gate's reviewer should be presented — the fallback ladder
+ * ({@link TaskReviewerActor} fields first, raw id last) collapsed to a
+ * render-ready shape shared by the summary card and the thread caption.
+ */
+export interface TaskReviewerView {
+  /** Best display label: display name → email → canonical id. Never empty. */
+  readonly label: string;
+  /** Email for secondary display; `""` when unknown or equal to the label. */
+  readonly email: string;
+  /** Avatar URL; `""` when unknown. */
+  readonly avatar: string;
+  /**
+   * `true` when the label fell through to the raw identity (legacy records
+   * that predate actor enrichment) — renderers de-emphasize it.
+   */
+  readonly isRawId: boolean;
+}
+
 export interface TaskDetailApprovalDecision {
   /** Chosen outcome identifier (e.g. "approve", "pause_campaigns"). */
   readonly outcome: string;
-  /** Reviewer who made the decision. */
+  /** Canonical reviewer identity; `""` when the decision is unattributed. */
   readonly reviewer: string;
+  /** Display snapshot of the reviewer, or `null` for unenriched records. */
+  readonly reviewerActor: TaskReviewerActor | null;
   /** ISO-8601 timestamp the decision was recorded, or `null`. */
   readonly respondedAt: string | null;
   /** Free-text comment the reviewer attached, or the empty string. */
@@ -131,6 +169,7 @@ export function deriveTaskApprovalDecision(
     outcome: outputOutcome,
     reviewer:
       readSnapshotString(taskOutput, "reviewer") || (resolution?.resolvedBy ?? ""),
+    reviewerActor: deriveReviewerActor(resolution, taskOutput),
     respondedAt: readSnapshotString(taskOutput, "responded_at") || null,
     comment:
       readSnapshotString(taskOutput, "comment") || (resolution?.comment ?? ""),
@@ -140,6 +179,61 @@ export function deriveTaskApprovalDecision(
   };
 }
 
+/**
+ * Collapses a decision's attribution into the render-ready reviewer view,
+ * or `null` when the decision carries no attribution at all (timeout
+ * auto-resolution, OSS single-user edition) — consumers omit the "by …"
+ * segment entirely in that case.
+ */
+export function deriveTaskReviewer(
+  decision: TaskDetailApprovalDecision,
+): TaskReviewerView | null {
+  const actor = decision.reviewerActor;
+  const label = actor?.displayName || actor?.email || decision.reviewer;
+  if (!label) return null;
+
+  const email = actor?.email && actor.email !== label ? actor.email : "";
+  return {
+    label,
+    email,
+    avatar: actor?.avatar ?? "",
+    isRawId: !actor?.displayName && !actor?.email,
+  };
+}
+
+/**
+ * Reviewer actor from the task-output snapshot (snake_case JSON stamped by
+ * the control plane), falling back to the `approval_resolved` event's
+ * proto actor for the finalizing window — mirroring the same output-first
+ * precedence as the scalar decision fields.
+ */
+function deriveReviewerActor(
+  resolution: ApprovalResolvedPayload | null,
+  taskOutput: JsonObject | undefined,
+): TaskReviewerActor | null {
+  const snapshot = readSnapshotObject(taskOutput, "reviewer_actor");
+  if (snapshot) {
+    return {
+      id: readSnapshotString(snapshot, "id"),
+      displayName: readSnapshotString(snapshot, "display_name"),
+      email: readSnapshotString(snapshot, "email"),
+      avatar: readSnapshotString(snapshot, "avatar"),
+    };
+  }
+
+  const eventActor = resolution?.resolvedByActor;
+  if (eventActor) {
+    return {
+      id: eventActor.id,
+      displayName: eventActor.displayName,
+      email: eventActor.email,
+      avatar: eventActor.avatar,
+    };
+  }
+
+  return null;
+}
+
 /** Reads a string field from a task-output Struct, or `""` when absent. */
 function readSnapshotString(obj: JsonObject | undefined, key: string): string {
   const value = obj?.[key];