@stigmer/react 3.12.7 → 3.12.8

package/src/session/__tests__/NewSessionViewer.test.tsx

@@ -33,6 +33,7 @@ const emptyWorkspace = {
   clear: vi.fn(),
 };
 
+const setAutoApproveAll = vi.fn();
 const stubEmptyFlow = {
   harness: "native" as const,
   setHarness: vi.fn(),
@@ -48,6 +49,8 @@ const stubEmptyFlow = {
   setSkillRefs: vi.fn(),
   workspace: emptyWorkspace,
   sessionVariables: { entries: [], isEmpty: true, clear: vi.fn() },
+  autoApproveAll: false,
+  setAutoApproveAll,
   isSubmitting: false,
   submitError: null,
   submit: vi.fn(),
@@ -125,6 +128,35 @@ describe("NewSessionViewer — persistent panel chip", () => {
   });
 });
 
+describe("NewSessionViewer — auto-approve placement (#816 rework)", () => {
+  const INDICATOR_TEXT = "Auto-approving tool calls for this session";
+
+  it("shows no indicator while auto-approve is off — the launcher stays clean", () => {
+    render(<NewSessionViewer org="acme" onSessionCreated={vi.fn()} />);
+    expect(screen.queryByText(INDICATOR_TEXT)).toBeNull();
+  });
+
+  it("shows the armed-only indicator when a seed pre-arms the session, with Turn off", () => {
+    mockFlow = { ...stubEmptyFlow, autoApproveAll: true };
+    render(<NewSessionViewer org="acme" onSessionCreated={vi.fn()} />);
+
+    expect(screen.getByText(INDICATOR_TEXT)).toBeTruthy();
+    fireEvent.click(screen.getByRole("button", { name: "Turn off" }));
+    expect(setAutoApproveAll).toHaveBeenCalledExactlyOnceWith(false);
+  });
+
+  it("offers the auto-approve switch in the Config facet, wired to the flow", () => {
+    render(<NewSessionViewer org="acme" onSessionCreated={vi.fn()} />);
+
+    fireEvent.click(screen.getByRole("button", { name: "Show panel" }));
+    const toggle = screen.getByRole("switch", { name: "Auto-approve" });
+    expect(toggle.getAttribute("aria-checked")).toBe("false");
+
+    fireEvent.click(toggle);
+    expect(setAutoApproveAll).toHaveBeenCalledExactlyOnceWith(true);
+  });
+});
+
 describe("NewSessionViewer — composer stays centered", () => {
   // The composer's wrapper is the probe's parent (wrapper > h1 + composer +
   // footer). `my-auto` is unconditional safe-centering; the old `my-6`

package/src/session/__tests__/SessionViewer-autoApprove.test.tsx

@@ -0,0 +1,244 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+import { render, screen, cleanup, fireEvent } from "@testing-library/react";
+
+// ---------------------------------------------------------------------------
+// Wiring-contract tests for auto-approve placement (the #816 rework):
+//
+// - The composer carries NO auto-approve control — the session-level switch
+//   lives in the Config facet (SetupTab receives the `autoApprove` group for
+//   every audience that may submit approvals, never observers; guests never
+//   render the panel at all).
+// - The armed-only AutoApproveIndicator above the composer is the
+//   always-visible disclosure: present exactly while the state is armed,
+//   with a one-click "Turn off"; never rendered for observers.
+// ---------------------------------------------------------------------------
+
+type CapturedProps = Record<string, unknown>;
+
+const composerProps: CapturedProps[] = [];
+vi.mock("../../composer", async (importOriginal) => {
+  const actual = await importOriginal<typeof import("../../composer")>();
+  return {
+    ...actual,
+    SessionComposer: (props: CapturedProps) => {
+      composerProps.push(props);
+      return <div data-testid="composer-probe" />;
+    },
+  };
+});
+
+vi.mock("../../execution/MessageThread", () => ({
+  MessageThread: () => <div data-testid="thread-probe" />,
+}));
+
+vi.mock("../../execution/FileReviewDock", () => ({
+  FileReviewDock: () => <div data-testid="file-review-dock-probe" />,
+}));
+
+// SetupTab renders for real: the facet switch is asserted through its
+// actual DOM (a switch labeled "Auto-approve" in the Run Config section),
+// reached by opening the panel and selecting the Config rail view.
+
+const stubWorkspace = {
+  entries: [],
+  hasEntries: false,
+  toInput: vi.fn().mockReturnValue([]),
+  addGitRepo: vi.fn(),
+  addLocalPath: vi.fn(),
+  removeEntry: vi.fn(),
+  clear: vi.fn(),
+};
+
+const stubConv = {
+  session: { spec: {} } as Record<string, unknown>,
+  isLoading: false,
+  loadError: null,
+  completedExecutions: [],
+  activeStreamExecution: null,
+  activePhase: null,
+  isStreaming: false,
+  isConnecting: false,
+  sendFollowUp: vi.fn(),
+  canSendFollowUp: true,
+  isSending: false,
+  sendError: null,
+  clearSendError: vi.fn(),
+  pendingUserMessage: null,
+  workspaceEntries: [],
+  mcpServerUsages: [],
+  skillRefs: [],
+  pendingApprovals: [],
+  submitApproval: vi.fn(),
+  submittingApprovalIds: new Set<string>(),
+  fileChangeSets: [],
+  submitFileDecision: vi.fn(),
+  submittingFileDecisionKeys: new Set<string>(),
+  fileDecisionErrors: new Map<string, Error>(),
+  streamError: null,
+  reconnectStream: vi.fn(),
+  approvalError: null,
+  retryLastSend: vi.fn(),
+};
+
+const setAutoApproveAll = vi.fn();
+const stubSessionPageFlow = {
+  conv: stubConv,
+  harness: "native" as const,
+  executionTarget: undefined,
+  model: [undefined, vi.fn()] as const,
+  interactionMode: ["agent" as const, vi.fn()] as const,
+  agentRef: { org: "acme", slug: "support-bot" },
+  setAgentRef: vi.fn(),
+  resolution: null,
+  setResolution: vi.fn(),
+  isDefaultAgent: false,
+  mcpServerUsages: [],
+  setMcpServerUsages: vi.fn(),
+  skillRefs: [],
+  setSkillRefs: vi.fn(),
+  workspace: stubWorkspace,
+  sessionVariables: { entries: [], isEmpty: true, clear: vi.fn() },
+  autoApproveAll: false,
+  setAutoApproveAll,
+  submitApproval: vi.fn(),
+  handleSubmit: vi.fn(),
+  submitError: null as Error | null,
+  displayExecution: null,
+  allExecutions: [],
+  sandboxWorkspaceRoot: undefined,
+};
+vi.mock("../useSessionPageFlow", () => ({
+  useSessionPageFlow: () => stubSessionPageFlow,
+}));
+
+vi.mock("../../hooks", () => ({
+  useStigmer: () => ({
+    agentExecution: {
+      uploadAttachment: vi.fn(),
+      getArtifactContent: vi.fn(),
+    },
+  }),
+}));
+
+import { SessionViewer } from "../SessionViewer";
+
+const INDICATOR_TEXT = "Auto-approving tool calls for this session";
+
+function lastComposerProps(): CapturedProps {
+  expect(composerProps.length).toBeGreaterThan(0);
+  return composerProps.at(-1)!;
+}
+
+/** Selects the panel's Config facet (the rail's radio). */
+function openConfigFacet() {
+  fireEvent.click(screen.getByRole("radio", { name: "Config" }));
+}
+
+function facetSwitch(): HTMLElement | null {
+  return screen.queryByRole("switch", { name: "Auto-approve" });
+}
+
+beforeEach(() => {
+  composerProps.length = 0;
+  stubConv.session = { spec: {} };
+  stubSessionPageFlow.autoApproveAll = false;
+});
+
+afterEach(() => {
+  cleanup();
+  vi.clearAllMocks();
+});
+
+describe("SessionViewer — composer stays clean (#816 rework)", () => {
+  it("hands the composer no auto-approve control at all", () => {
+    render(<SessionViewer sessionId="ses_1" org="acme" />);
+
+    expect("autoApprove" in lastComposerProps()).toBe(false);
+  });
+});
+
+describe("SessionViewer — Config facet auto-approve switch (#816 rework)", () => {
+  it("renders the switch reflecting the flow state, and flipping calls the flow (integrator)", () => {
+    render(<SessionViewer sessionId="ses_1" org="acme" defaultPanelOpen />);
+    openConfigFacet();
+
+    const toggle = facetSwitch();
+    expect(toggle).not.toBeNull();
+    expect(toggle!.getAttribute("aria-checked")).toBe("false");
+    fireEvent.click(toggle!);
+    expect(setAutoApproveAll).toHaveBeenCalledExactlyOnceWith(true);
+  });
+
+  it("mirrors an armed flow state into the switch", () => {
+    stubSessionPageFlow.autoApproveAll = true;
+    render(<SessionViewer sessionId="ses_1" org="acme" defaultPanelOpen />);
+    openConfigFacet();
+
+    expect(facetSwitch()!.getAttribute("aria-checked")).toBe("true");
+  });
+
+  it("endUser gets the switch — the walk-away persona is an end user", () => {
+    render(
+      <SessionViewer
+        sessionId="ses_1"
+        org="acme"
+        audience="endUser"
+        defaultPanelOpen
+      />,
+    );
+    openConfigFacet();
+
+    expect(facetSwitch()).not.toBeNull();
+  });
+
+  it("observers never get the switch — the approval-submission withhold", () => {
+    render(
+      <SessionViewer
+        sessionId="ses_1"
+        org="acme"
+        audience="observer"
+        defaultPanelOpen
+      />,
+    );
+    openConfigFacet();
+
+    expect(facetSwitch()).toBeNull();
+  });
+
+  it("channel-origin sessions never get the switch (observer by construction)", () => {
+    stubConv.session = {
+      spec: {},
+      metadata: { labels: { "stigmer.ai/channel-id": "chn_1" } },
+    };
+    render(<SessionViewer sessionId="ses_1" org="acme" defaultPanelOpen />);
+    openConfigFacet();
+
+    expect(facetSwitch()).toBeNull();
+  });
+});
+
+describe("SessionViewer — armed-only indicator (#816 rework)", () => {
+  it("absent while auto-approve is off — the composer stays clean", () => {
+    render(<SessionViewer sessionId="ses_1" org="acme" />);
+
+    expect(screen.queryByText(INDICATOR_TEXT)).toBeNull();
+  });
+
+  it("renders while armed, and Turn off flips the flow state", () => {
+    stubSessionPageFlow.autoApproveAll = true;
+    render(<SessionViewer sessionId="ses_1" org="acme" />);
+
+    expect(screen.getByText(INDICATOR_TEXT)).toBeTruthy();
+    fireEvent.click(screen.getByRole("button", { name: "Turn off" }));
+    expect(setAutoApproveAll).toHaveBeenCalledExactlyOnceWith(false);
+  });
+
+  it("never renders for observers — they cannot arm or disarm anything", () => {
+    stubSessionPageFlow.autoApproveAll = true;
+    render(
+      <SessionViewer sessionId="ses_1" org="acme" audience="observer" />,
+    );
+
+    expect(screen.queryByText(INDICATOR_TEXT)).toBeNull();
+  });
+});

package/src/session/__tests__/SessionViewer-transcriptExport.test.tsx

@@ -1,11 +1,12 @@
-// SessionViewer's built-in transcript export (stigmer/stigmer#814): the
-// control ships ON by default in the header corner — wherever a conversation
-// is viewed, its transcript is one click away (the owner-ratified DD-011
-// divergence recorded on SessionViewerProps.transcriptExport) — composes
-// with host headerActions, and disappears on explicit opt-out.
+// SessionViewer's built-in transcript export (stigmer/stigmer#814, placement
+// reworked with #816): export lives in the Config facet's Transcript section
+// for viewers with the session panel, and the header TranscriptExportMenu
+// remains ONLY as the panel-less fallback (guests, panel="none") — so
+// wherever a conversation is viewed, its transcript stays reachable, without
+// a floating header button on surfaces that have a proper home for it.
 
 import { describe, it, expect, vi, afterEach } from "vitest";
-import { render, screen, cleanup } from "@testing-library/react";
+import { render, screen, cleanup, fireEvent } from "@testing-library/react";
 
 vi.mock("../../composer", async (importOriginal) => {
   const actual = await importOriginal<typeof import("../../composer")>();
@@ -20,9 +21,10 @@ vi.mock("../../execution/MessageThread", () => ({
 vi.mock("../../execution/FileReviewDock", () => ({
   FileReviewDock: () => <div data-testid="file-review-dock-probe" />,
 }));
-vi.mock("../facets/SetupTab", () => ({
-  SetupTab: () => <div data-testid="setup-probe" />,
-}));
+
+// SetupTab renders for real: the facet's Transcript section is asserted
+// through its actual DOM (the "Copy transcript" action row), reached by
+// opening the panel and selecting the Config rail view.
 
 const stubWorkspace = {
   entries: [],
@@ -107,45 +109,81 @@ vi.mock("../../hooks", () => ({
 
 import { SessionViewer } from "../SessionViewer";
 
-afterEach(cleanup);
+afterEach(() => {
+  cleanup();
+  vi.clearAllMocks();
+});
 
-function exportTrigger(): HTMLElement | null {
+function headerExportTrigger(): HTMLElement | null {
   return screen.queryByRole("button", { name: "Export transcript" });
 }
 
-describe("SessionViewer transcript export wiring", () => {
-  it("renders the export control by default", () => {
-    render(<SessionViewer sessionId="ses_1" org="acme" />);
-    expect(exportTrigger()).not.toBeNull();
+/** Selects the panel's Config facet (the rail's radio). */
+function openConfigFacet() {
+  fireEvent.click(screen.getByRole("radio", { name: "Config" }));
+}
+
+function facetCopyAction(): HTMLElement | null {
+  return screen.queryByRole("button", { name: "Copy transcript" });
+}
+
+describe("SessionViewer transcript export placement", () => {
+  it("panel-enabled viewers export from the Config facet, not the header", () => {
+    render(<SessionViewer sessionId="ses_1" org="acme" defaultPanelOpen />);
+    expect(headerExportTrigger()).toBeNull();
+    openConfigFacet();
+    expect(facetCopyAction()).not.toBeNull();
+  });
+
+  it("observers keep facet export — a bulk copy of what they already see", () => {
+    render(
+      <SessionViewer
+        sessionId="ses_1"
+        org="acme"
+        audience="observer"
+        defaultPanelOpen
+      />,
+    );
+    openConfigFacet();
+    expect(facetCopyAction()).not.toBeNull();
+  });
+
+  it("panel=\"none\" hosts fall back to the header menu", () => {
+    render(<SessionViewer sessionId="ses_1" org="acme" panel="none" />);
+    expect(headerExportTrigger()).not.toBeNull();
   });
 
-  it("keeps the export control for the read-only observer audience — a bulk copy of what the observer already sees", () => {
-    render(<SessionViewer sessionId="ses_1" org="acme" audience="observer" />);
-    expect(exportTrigger()).not.toBeNull();
+  it("guests fall back to the header menu (no panel to reach the facet)", () => {
+    render(<SessionViewer sessionId="ses_1" org="acme" audience="guest" />);
+    expect(headerExportTrigger()).not.toBeNull();
   });
 
-  it("composes with host headerActions rather than replacing them", () => {
+  it("the header fallback composes with host headerActions", () => {
     render(
       <SessionViewer
         sessionId="ses_1"
         org="acme"
+        panel="none"
         headerActions={<button>Share</button>}
       />,
     );
     expect(screen.getByRole("button", { name: "Share" })).toBeTruthy();
-    expect(exportTrigger()).not.toBeNull();
+    expect(headerExportTrigger()).not.toBeNull();
   });
 
-  it("disappears on explicit opt-out, leaving host actions intact", () => {
+  it("explicit opt-out removes BOTH surfaces, leaving host actions intact", () => {
     render(
       <SessionViewer
         sessionId="ses_1"
         org="acme"
         transcriptExport={false}
+        defaultPanelOpen
         headerActions={<button>Share</button>}
       />,
     );
-    expect(exportTrigger()).toBeNull();
+    expect(headerExportTrigger()).toBeNull();
+    openConfigFacet();
+    expect(facetCopyAction()).toBeNull();
     expect(screen.getByRole("button", { name: "Share" })).toBeTruthy();
   });
 });

package/src/session/__tests__/useNewSessionFlow.test.tsx

@@ -464,6 +464,62 @@ describe("useNewSessionFlow", () => {
       expect(execInput.autoApproveAll).toBeUndefined();
     });
 
+    it("arms from the account's default_auto_approve preference", async () => {
+      const opts = {
+        ...defaultOptions(),
+        accountDefaults: { autoApprove: true },
+      };
+      const { result } = renderHook(() => useNewSessionFlow(opts), { wrapper: createWrapper() });
+
+      expect(result.current.autoApproveAll).toBe(true);
+
+      await act(async () => {
+        await result.current.submit("Hello");
+      });
+
+      const execInput = mockCreateExecution.mock.calls[0][0];
+      expect(execInput.autoApproveAll).toBe(true);
+    });
+
+    it("a LATE-arriving account preference still arms (derived, not initialized)", () => {
+      // whoAmI resolves after mount — the seed must be part of the
+      // derivation so it cannot be missed by a useState initializer.
+      const initialProps: { accountDefaults?: { autoApprove?: boolean } } = {};
+      const { result, rerender } = renderHook(
+        ({ accountDefaults }: typeof initialProps) =>
+          useNewSessionFlow({ ...defaultOptions(), accountDefaults }),
+        { wrapper: createWrapper(), initialProps },
+      );
+      expect(result.current.autoApproveAll).toBe(false);
+
+      rerender({ accountDefaults: { autoApprove: true } });
+      expect(result.current.autoApproveAll).toBe(true);
+    });
+
+    it("a late arrival never overrides the user's explicit OFF", () => {
+      const initialProps: { accountDefaults?: { autoApprove?: boolean } } = {};
+      const { result, rerender } = renderHook(
+        ({ accountDefaults }: typeof initialProps) =>
+          useNewSessionFlow({ ...defaultOptions(), accountDefaults }),
+        { wrapper: createWrapper(), initialProps },
+      );
+      act(() => result.current.setAutoApproveAll(false));
+
+      rerender({ accountDefaults: { autoApprove: true } });
+      expect(result.current.autoApproveAll).toBe(false);
+    });
+
+    it("guests never inherit the account auto-approve preference", () => {
+      const opts = {
+        ...defaultOptions(),
+        audience: "guest" as const,
+        accountDefaults: { autoApprove: true },
+      };
+      const { result } = renderHook(() => useNewSessionFlow(opts), { wrapper: createWrapper() });
+
+      expect(result.current.autoApproveAll).toBe(false);
+    });
+
     it("passes cursor harness in the sessionSpec after switching", async () => {
       const opts = defaultOptions();
       const { result } = renderHook(() => useNewSessionFlow(opts), { wrapper: createWrapper() });

package/src/session/__tests__/useSessionPageFlow.autoApprove.test.tsx

@@ -231,6 +231,93 @@ describe("useSessionPageFlow — host-set approval default (#302)", () => {
   });
 });
 
+describe("useSessionPageFlow — account preference seed (default_auto_approve)", () => {
+  beforeEach(() => {
+    mockSubmitApproval.mockResolvedValue(undefined);
+  });
+  afterEach(() => {
+    vi.clearAllMocks();
+  });
+
+  it("arms autoApproveAll from the account preference", () => {
+    const { result } = renderHook(() =>
+      useSessionPageFlow({ ...OPTS, accountDefaults: { autoApprove: true } }),
+    );
+    expect(result.current.autoApproveAll).toBe(true);
+  });
+
+  it("a LATE-arriving preference still applies (whoAmI resolves async)", () => {
+    // The preference is part of the derivation, not a mount-time
+    // initializer — a value arriving after mount must not be missed.
+    const initialProps: { accountDefaults?: { autoApprove?: boolean } } = {};
+    const { result, rerender } = renderHook(
+      ({ accountDefaults }: typeof initialProps) =>
+        useSessionPageFlow({ ...OPTS, accountDefaults }),
+      { initialProps },
+    );
+    expect(result.current.autoApproveAll).toBe(false);
+
+    rerender({ accountDefaults: { autoApprove: true } });
+    expect(result.current.autoApproveAll).toBe(true);
+  });
+
+  it("a late arrival never overrides an explicit in-session OFF", () => {
+    const initialProps: { accountDefaults?: { autoApprove?: boolean } } = {};
+    const { result, rerender } = renderHook(
+      ({ accountDefaults }: typeof initialProps) =>
+        useSessionPageFlow({ ...OPTS, accountDefaults }),
+      { initialProps },
+    );
+    act(() => {
+      result.current.setAutoApproveAll(false);
+    });
+
+    rerender({ accountDefaults: { autoApprove: true } });
+    expect(result.current.autoApproveAll).toBe(false);
+  });
+
+  it("the user's Turn off beats the preference for this session only", async () => {
+    const { result } = renderHook(() =>
+      useSessionPageFlow({ ...OPTS, accountDefaults: { autoApprove: true } }),
+    );
+
+    act(() => {
+      result.current.setAutoApproveAll(false);
+    });
+    expect(result.current.autoApproveAll).toBe(false);
+
+    await act(async () => {
+      await result.current.handleSubmit("after turn off");
+    });
+    const followUpOpts = mockSendFollowUp.mock.calls.at(-1)?.[1];
+    expect(followUpOpts.autoApproveAll).toBeUndefined();
+  });
+
+  it("carries the preference-armed state into follow-ups", async () => {
+    const { result } = renderHook(() =>
+      useSessionPageFlow({ ...OPTS, accountDefaults: { autoApprove: true } }),
+    );
+
+    await act(async () => {
+      await result.current.handleSubmit("first message");
+    });
+
+    const followUpOpts = mockSendFollowUp.mock.calls[0][1];
+    expect(followUpOpts.autoApproveAll).toBe(true);
+  });
+
+  it("guests never inherit the account preference", () => {
+    const { result } = renderHook(() =>
+      useSessionPageFlow({
+        ...OPTS,
+        audience: "guest",
+        accountDefaults: { autoApprove: true },
+      }),
+    );
+    expect(result.current.autoApproveAll).toBe(false);
+  });
+});
+
 describe("useSessionPageFlow — arming derived from the in-flight run (#816)", () => {
   afterEach(() => {
     mockConv.activeStreamExecution = null;