@stigmer/react 3.12.5 → 3.12.6

package/src/workflow/__tests__/WorkflowInstanceDetailPanel.test.tsx

@@ -0,0 +1,83 @@
+import { describe, it, expect, vi, afterEach } from "vitest";
+import { cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
+import { create } from "@bufbuild/protobuf";
+import {
+  WorkflowInstanceSchema,
+  type WorkflowInstance,
+} from "@stigmer/protos/ai/stigmer/agentic/workflowinstance/v1/api_pb";
+import { WorkflowExecutionVisibility } from "@stigmer/protos/ai/stigmer/agentic/workflowinstance/v1/spec_pb";
+import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/apiresourcekind/api_resource_kind_pb";
+import type { WorkflowInstanceInput } from "@stigmer/sdk";
+import { StigmerContext } from "../../context";
+import { WorkflowInstanceDetailPanel } from "../instance/WorkflowInstanceDetailPanel";
+
+/**
+ * Regression suite for the full-spec-replace wipe bug: before the
+ * generated-mapper migration, saving environment edits in this panel
+ * silently reset `execution_visibility` (run observability, which has its
+ * own dedicated updateExecutionVisibility RPC and control). The panel
+ * must spread `toWorkflowInstanceUpdateInput` and override only the
+ * environment refs.
+ */
+
+const INSTANCE: WorkflowInstance = create(WorkflowInstanceSchema, {
+  metadata: {
+    id: "wfi-1",
+    name: "Nightly Triage",
+    slug: "nightly-triage",
+    org: "acme",
+  },
+  spec: {
+    workflowId: "wf-1",
+    description: "Runs every night.",
+    environmentRefs: [
+      { org: "acme", slug: "prod", kind: ApiResourceKind.environment },
+    ],
+    executionVisibility: WorkflowExecutionVisibility.organization,
+  },
+});
+
+function renderPanel(update: ReturnType<typeof vi.fn>) {
+  const client = {
+    workflowInstance: { update },
+    iamPolicy: {
+      checkMyPermission: vi.fn(async () => ({ isAuthorized: true })),
+    },
+    environment: {
+      list: vi.fn(async () => ({ items: [], totalCount: 0 })),
+    },
+  } as never;
+  return render(
+    <StigmerContext.Provider value={client}>
+      <WorkflowInstanceDetailPanel instance={INSTANCE} org="acme" onClose={() => {}} />
+    </StigmerContext.Provider>,
+  );
+}
+
+afterEach(cleanup);
+
+describe("WorkflowInstanceDetailPanel save payload", () => {
+  it("round-trips execution_visibility on an environments-only save (the wipe bug)", async () => {
+    const update = vi.fn(async (_input: WorkflowInstanceInput) => INSTANCE);
+    renderPanel(update);
+
+    fireEvent.click(await screen.findByRole("button", { name: "Edit" }));
+    fireEvent.click(screen.getByRole("button", { name: "Save" }));
+
+    await waitFor(() => expect(update).toHaveBeenCalledTimes(1));
+    const input = update.mock.calls[0]![0];
+
+    // The wipe-bug guard: run visibility is edited elsewhere and must
+    // survive an environment save untouched.
+    expect(input.executionVisibility).toBe(
+      WorkflowExecutionVisibility.organization,
+    );
+    expect(input.workflowId).toBe("wf-1");
+    expect(input.description).toBe("Runs every night.");
+    // The form-owned field.
+    expect(input.environmentRefs).toEqual([{ org: "acme", slug: "prod" }]);
+    // Addressing fields.
+    expect(input.org).toBe("acme");
+    expect(input.slug).toBe("nightly-triage");
+  });
+});

package/src/workflow/index.ts

@@ -481,8 +481,6 @@ export {
   type UseUpdateWorkflowReturn,
 } from "./useUpdateWorkflow.js";
 
-export { workflowToInput } from "./internal/workflowToInput.js";
-
 // Starter YAML template for new workflow creation
 export { STARTER_WORKFLOW_YAML } from "./starter-workflow-yaml.js";
 

package/src/workflow/instance/WorkflowInstanceDetailPanel.tsx

@@ -9,7 +9,7 @@ import { ApiResourceVisibility } from "@stigmer/protos/ai/stigmer/commons/apires
 import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/apiresourcekind/api_resource_kind_pb";
 import { WorkflowExecutionVisibility } from "@stigmer/protos/ai/stigmer/agentic/workflowinstance/v1/spec_pb";
 import type { ResourceRef } from "@stigmer/sdk";
-import { getUserMessage } from "@stigmer/sdk";
+import { getUserMessage, toWorkflowInstanceUpdateInput } from "@stigmer/sdk";
 import { useUpdateWorkflowInstance } from "./useUpdateWorkflowInstance.js";
 import { useDeleteWorkflowInstance } from "./useDeleteWorkflowInstance.js";
 import { RunVisibilityControl } from "./RunVisibilityControl.js";
@@ -104,20 +104,19 @@ export function WorkflowInstanceDetailPanel({
 
   const handleSaveEnvs = useCallback(async () => {
     try {
+      // Full-spec-replace safety: spread the complete mapped input so
+      // unlisted spec fields (e.g. execution_visibility, which has its
+      // own dedicated control above) survive an environment-only save.
       await update({
-        name: meta?.name ?? "",
-        org: meta?.org ?? org,
-        workflowId: spec?.workflowId ?? "",
-        description: spec?.description,
+        ...toWorkflowInstanceUpdateInput(instance),
         environmentRefs: editEnvRefs,
-        visibility: meta?.visibility,
       });
       setIsEditingEnvs(false);
       onUpdated?.();
     } catch {
       // error displayed by hook
     }
-  }, [update, meta, spec, org, editEnvRefs, onUpdated]);
+  }, [update, instance, editEnvRefs, onUpdated]);
 
   const handleDelete = useCallback(async () => {
     setDeleteError(null);

package/src/workflow/useUpdateWorkflow.ts

@@ -23,9 +23,9 @@ export interface UseUpdateWorkflowReturn {
  *
  * Wraps `stigmer.workflow.update(input)` with loading and error state.
  * The caller must provide a **complete** `WorkflowInput` -- the backend
- * performs full spec replacement. Use `workflowToInput()` to reconstruct
- * the input from a fetched workflow, modify the desired field, and pass
- * the result here.
+ * performs full spec replacement. Use `toWorkflowUpdateInput()` (from
+ * `@stigmer/sdk`) to reconstruct the input from a fetched workflow,
+ * modify the desired field, and pass the result here.
  */
 export function useUpdateWorkflow(): UseUpdateWorkflowReturn {
   const stigmer = useStigmer();