@stigmer/react 3.12.4 → 3.12.5

package/src/settings/__tests__/settings-nav.test.ts

@@ -0,0 +1,27 @@
+import { describe, it, expect } from "vitest";
+import { SETTINGS_NAV_GROUPS } from "../settings-nav";
+
+// The nav model is the single source for the sidebar AND both client-app
+// landing grids — these entries disappearing would silently orphan the
+// preference pages everywhere at once.
+describe("SETTINGS_NAV_GROUPS preference entries", () => {
+  it("lists org preferences in the Organization group", () => {
+    const organization = SETTINGS_NAV_GROUPS.find(
+      (g) => g.label === "Organization",
+    );
+    expect(organization).toBeDefined();
+    expect(
+      organization!.items.find((i) => i.href === "/settings/org-preferences")
+        ?.label,
+    ).toBe("Preferences");
+  });
+
+  it("lists account preferences in the Account group", () => {
+    const account = SETTINGS_NAV_GROUPS.find((g) => g.label === "Account");
+    expect(account).toBeDefined();
+    expect(
+      account!.items.find((i) => i.href === "/settings/account-preferences")
+        ?.label,
+    ).toBe("Preferences");
+  });
+});

package/src/settings/index.ts

@@ -10,6 +10,8 @@ export { BillingSection } from "./BillingSection.js";
 export type { BillingSectionProps } from "./BillingSection.js";
 export { MembersSection } from "./MembersSection.js";
 export { OrgProfileSection } from "./OrgProfileSection.js";
+export { OrgPreferencesSection } from "./OrgPreferencesSection.js";
+export { AccountPreferencesSection } from "./AccountPreferencesSection.js";
 export { EnvironmentsSection } from "./EnvironmentsSection.js";
 export { InvitationsSection } from "./InvitationsSection.js";
 export { IdentityProvidersSection } from "./IdentityProvidersSection.js";

package/src/settings/settings-nav.ts

@@ -13,6 +13,8 @@ import {
   Plug,
   Scale,
   ShieldCheck,
+  SlidersHorizontal,
+  UserCog,
   Users,
 } from "lucide-react";
 
@@ -55,6 +57,11 @@ export const SETTINGS_NAV_GROUPS: readonly SettingsNavGroup[] = [
       "Manage your team, organization identity, and identity providers.",
     items: [
       { href: "/settings/org-profile", label: "Org Profile", icon: Building2 },
+      {
+        href: "/settings/org-preferences",
+        label: "Preferences",
+        icon: SlidersHorizontal,
+      },
       { href: "/settings/members", label: "Members", icon: Users },
       { href: "/settings/invitations", label: "Invitations", icon: Link },
       {
@@ -92,6 +99,17 @@ export const SETTINGS_NAV_GROUPS: readonly SettingsNavGroup[] = [
       { href: "/settings/usage", label: "Usage", icon: BarChart3 },
     ],
   },
+  {
+    label: "Account",
+    description: "Personal settings that apply to you across the platform.",
+    items: [
+      {
+        href: "/settings/account-preferences",
+        label: "Preferences",
+        icon: UserCog,
+      },
+    ],
+  },
 ];
 
 /**

package/src/workflow/ApprovalFormBuilder.tsx

@@ -24,11 +24,15 @@ interface FormFieldEntry {
   enumValues: string;
 }
 
+// HUMAN_INPUT_TIMEOUT_ESCALATE is deliberately absent: the proto declares it
+// but no runtime exists, and the server validator refuses it at apply
+// (stigmer/stigmer#779). The old option also wrote an `escalation_task` field
+// that HumanInputTaskConfig never had, so every config it produced failed
+// the server's strict decode.
 const TIMEOUT_POLICY_OPTIONS = [
   { value: "HUMAN_INPUT_TIMEOUT_FAIL", label: "Fail — task errors on timeout" },
   { value: "HUMAN_INPUT_TIMEOUT_APPROVE", label: "Auto-approve — proceed as approved" },
   { value: "HUMAN_INPUT_TIMEOUT_DENY", label: "Auto-deny — proceed as denied" },
-  { value: "HUMAN_INPUT_TIMEOUT_ESCALATE", label: "Escalate — branch to escalation task" },
 ] as const;
 
 const TIMEOUT_UNITS = [
@@ -107,8 +111,6 @@ export const ApprovalFormBuilder = memo(function ApprovalFormBuilder({
       <TimeoutSection
         timeout={typeof cfg.timeout === "number" ? cfg.timeout : 0}
         onTimeout={typeof cfg.on_timeout === "string" ? cfg.on_timeout : ""}
-        escalationTask={typeof cfg.escalation_task === "string" ? cfg.escalation_task : ""}
-        allTaskNames={allTaskNames}
         onUpdateConfig={onUpdateConfig}
       />
       <StringListSection
@@ -619,14 +621,10 @@ function FormFieldRow({
 function TimeoutSection({
   timeout,
   onTimeout,
-  escalationTask,
-  allTaskNames,
   onUpdateConfig,
 }: {
   timeout: number;
   onTimeout: string;
-  escalationTask: string;
-  allTaskNames: readonly string[];
   onUpdateConfig: (fieldPath: string, value: unknown) => void;
 }) {
   const bestUnit = useMemo(() => {
@@ -665,8 +663,6 @@ function TimeoutSection({
     [timeout, unit, onUpdateConfig],
   );
 
-  const isEscalate = onTimeout === "HUMAN_INPUT_TIMEOUT_ESCALATE";
-
   return (
     <CollapsibleSection title="Timeout">
       <div className="stg:flex stg:items-center stg:gap-1">
@@ -710,24 +706,6 @@ function TimeoutSection({
         </div>
       )}
 
-      {isEscalate && (
-        <div className="stg:mt-1.5 stg:flex stg:flex-col stg:gap-1">
-          <label className="stg:text-[10px] stg:text-[var(--stgm-muted-foreground,#737373)]">
-            Escalation task
-          </label>
-          <select
-            value={escalationTask}
-            onChange={(e) => onUpdateConfig("escalation_task", e.target.value || undefined)}
-            className={cn(smallInputClass)}
-            aria-label="Escalation target task"
-          >
-            <option value="">— Select escalation task —</option>
-            {allTaskNames.map((name) => (
-              <option key={name} value={name}>{name}</option>
-            ))}
-          </select>
-        </div>
-      )}
     </CollapsibleSection>
   );
 }