@stigmer/react 3.1.1 → 3.1.3

package/src/execution/__tests__/PlanArtifactCard.test.tsx

@@ -47,18 +47,32 @@ function renderCard(ui: ReactNode) {
 
 afterEach(cleanup);
 
-describe("PlanArtifactCard — action surface", () => {
-  it("is an accessible region labelled as the plan's actions, with name + size", () => {
+describe("PlanArtifactCard — compact document card", () => {
+  it("is an accessible region with the plan's title, filename, and size", () => {
     renderCard(
-      <PlanArtifactCard executionId="aex_1" artifact={planArtifact} org="acme" />,
+      <PlanArtifactCard
+        executionId="aex_1"
+        artifact={planArtifact}
+        title="Refactor the auth flow"
+        org="acme"
+      />,
     );
 
-    const region = screen.getByRole("region", { name: "Plan actions" });
-    expect(region.textContent).toContain("Plan");
+    const region = screen.getByRole("region", { name: "Plan" });
+    expect(region.textContent).toContain("Refactor the auth flow");
+    expect(region.textContent).toContain("plan.md");
     expect(region.textContent).toContain("KB");
   });
 
-  it("does NOT render the plan content (the message above is the document)", () => {
+  it("falls back to 'Plan' when the plan has no title", () => {
+    renderCard(
+      <PlanArtifactCard executionId="aex_1" artifact={planArtifact} org="acme" />,
+    );
+    const region = screen.getByRole("region", { name: "Plan" });
+    expect(region.textContent).toContain("Plan");
+  });
+
+  it("does NOT render the plan content (the document lives in the plan tab)", () => {
     const { stigmer, getArtifactContent } = createStigmerMock();
     render(
       withStigmer(
@@ -66,12 +80,12 @@ describe("PlanArtifactCard — action surface", () => {
         stigmer,
       ),
     );
-    // The card is a pure action surface — it must not fetch the plan body until
-    // the user explicitly opens the full preview.
+    // The card is the plan's compact stand-in — it must not fetch the plan
+    // body; that belongs to the plan tab (or the explicit preview modal).
     expect(getArtifactContent).not.toHaveBeenCalled();
   });
 
-  it("offers exactly one primary 'Build from plan' action that calls onImplement", () => {
+  it("offers exactly one primary 'Build' action that calls onImplement", () => {
     const onImplement = vi.fn();
     renderCard(
       <PlanArtifactCard
@@ -82,18 +96,37 @@ describe("PlanArtifactCard — action surface", () => {
       />,
     );
 
-    fireEvent.click(screen.getByText("Build from plan"));
+    fireEvent.click(screen.getByRole("button", { name: "Build" }));
     expect(onImplement).toHaveBeenCalledTimes(1);
   });
 
-  it("hides 'Build from plan' when onImplement is not provided", () => {
+  it("hides 'Build' when onImplement is not provided", () => {
     renderCard(
       <PlanArtifactCard executionId="aex_1" artifact={planArtifact} org="acme" />,
     );
-    expect(screen.queryByText("Build from plan")).toBeNull();
+    expect(screen.queryByRole("button", { name: "Build" })).toBeNull();
   });
 
-  it("disables 'Build from plan' when disabled", () => {
+  it("shows the pending label while the approved plan uploads (buildPending)", () => {
+    renderCard(
+      <PlanArtifactCard
+        executionId="aex_1"
+        artifact={planArtifact}
+        org="acme"
+        onImplement={vi.fn()}
+        disabled
+        buildPending
+      />,
+    );
+
+    // The primary reads as in-progress and stays disabled — no double-submits
+    // while the upload precedes the implement turn.
+    expect(screen.queryByRole("button", { name: "Build" })).toBeNull();
+    const button = screen.getByText("Starting build…").closest("button")!;
+    expect(button.disabled).toBe(true);
+  });
+
+  it("disables 'Build' when disabled", () => {
     const onImplement = vi.fn();
     renderCard(
       <PlanArtifactCard
@@ -105,12 +138,44 @@ describe("PlanArtifactCard — action surface", () => {
       />,
     );
 
-    const button = screen.getByText("Build from plan").closest("button")!;
+    const button = screen.getByRole("button", { name: "Build" }) as HTMLButtonElement;
     expect(button.disabled).toBe(true);
     fireEvent.click(button);
     expect(onImplement).not.toHaveBeenCalled();
   });
 
+  it("copies the plan text to the clipboard on demand", async () => {
+    const writeText = vi.fn().mockResolvedValue(undefined);
+    vi.stubGlobal("navigator", { clipboard: { writeText } });
+    const getArtifactContent = vi
+      .fn()
+      .mockResolvedValue({ content: new TextEncoder().encode("# Plan\n\nsteps") });
+    const getArtifactDownloadUrl = vi.fn();
+    const stigmer = {
+      agentExecution: { getArtifactContent, getArtifactDownloadUrl },
+    } as unknown as Stigmer;
+
+    render(
+      withStigmer(
+        <PlanArtifactCard executionId="aex_1" artifact={planArtifact} org="acme" />,
+        stigmer,
+      ),
+    );
+
+    fireEvent.click(screen.getByRole("button", { name: "Copy plan" }));
+
+    // Content is fetched at click time from the stable storage key, then
+    // written to the clipboard — the card never pre-fetches on mount.
+    expect(getArtifactContent).toHaveBeenCalledTimes(1);
+    const req = getArtifactContent.mock.calls[0][0];
+    expect(req.executionId).toBe("aex_1");
+    expect(req.storageKey).toBe("artifacts/aex_1/plan.md");
+    await screen.findByRole("button", { name: "Copied" });
+    expect(writeText).toHaveBeenCalledWith("# Plan\n\nsteps");
+
+    vi.unstubAllGlobals();
+  });
+
   it("downloads the artifact on demand via a freshly minted URL", async () => {
     const { stigmer, getArtifactDownloadUrl } = createStigmerMock();
     render(
@@ -119,7 +184,7 @@ describe("PlanArtifactCard — action surface", () => {
         stigmer,
       ),
     );
-    fireEvent.click(screen.getByText("Download"));
+    fireEvent.click(screen.getByRole("button", { name: "Download plan.md" }));
     // The URL is resolved at click time from the stable storage key — never a
     // baked, expirable URL.
     expect(getArtifactDownloadUrl).toHaveBeenCalledTimes(1);
@@ -141,7 +206,7 @@ describe("PlanArtifactCard — Cmd/Ctrl+Enter accelerator (card-scoped)", () =>
       />,
     );
 
-    const region = screen.getByRole("region", { name: "Plan actions" });
+    const region = screen.getByRole("region", { name: "Plan" });
     fireEvent.keyDown(region, { key: "Enter", metaKey: true });
     expect(onImplement).toHaveBeenCalledTimes(1);
   });
@@ -157,7 +222,7 @@ describe("PlanArtifactCard — Cmd/Ctrl+Enter accelerator (card-scoped)", () =>
       />,
     );
 
-    const region = screen.getByRole("region", { name: "Plan actions" });
+    const region = screen.getByRole("region", { name: "Plan" });
     fireEvent.keyDown(region, { key: "Enter", ctrlKey: true });
     expect(onImplement).toHaveBeenCalledTimes(1);
   });
@@ -173,7 +238,7 @@ describe("PlanArtifactCard — Cmd/Ctrl+Enter accelerator (card-scoped)", () =>
       />,
     );
 
-    const region = screen.getByRole("region", { name: "Plan actions" });
+    const region = screen.getByRole("region", { name: "Plan" });
     fireEvent.keyDown(region, { key: "Enter" });
     expect(onImplement).not.toHaveBeenCalled();
   });
@@ -190,14 +255,14 @@ describe("PlanArtifactCard — Cmd/Ctrl+Enter accelerator (card-scoped)", () =>
       />,
     );
 
-    const region = screen.getByRole("region", { name: "Plan actions" });
+    const region = screen.getByRole("region", { name: "Plan" });
     fireEvent.keyDown(region, { key: "Enter", metaKey: true });
     expect(onImplement).not.toHaveBeenCalled();
   });
 });
 
-describe("PlanArtifactCard — Open full (org-gated preview)", () => {
-  it("opens the shared preview modal when 'Open full' is clicked", () => {
+describe("PlanArtifactCard — Open plan modal fallback (org-gated preview)", () => {
+  it("opens the shared preview modal when the open icon is clicked (no onOpenPlan)", () => {
     const { stigmer } = createStigmerMock();
     render(
       withStigmer(
@@ -209,14 +274,14 @@ describe("PlanArtifactCard — Open full (org-gated preview)", () => {
     // No dialog before the user opens it.
     expect(document.querySelector("dialog")).toBeNull();
 
-    fireEvent.click(screen.getByText("Open full"));
+    fireEvent.click(screen.getByRole("button", { name: "Open plan" }));
 
     const dialog = document.querySelector("dialog");
     expect(dialog).toBeTruthy();
     expect(dialog!.getAttribute("aria-label")).toBe("Preview plan.md");
   });
 
-  it("hides 'Open full' when org is absent (modal needs org), keeping Build + Download", () => {
+  it("hides the open action when org is absent (modal needs org), keeping Build + Download", () => {
     const onImplement = vi.fn();
     renderCard(
       <PlanArtifactCard
@@ -225,8 +290,31 @@ describe("PlanArtifactCard — Open full (org-gated preview)", () => {
         onImplement={onImplement}
       />,
     );
-    expect(screen.queryByText("Open full")).toBeNull();
-    expect(screen.queryByText("Build from plan")).not.toBeNull();
-    expect(screen.queryByText("Download")).not.toBeNull();
+    expect(screen.queryByRole("button", { name: "Open plan" })).toBeNull();
+    expect(screen.queryByRole("button", { name: "Build" })).not.toBeNull();
+    expect(
+      screen.queryByRole("button", { name: "Download plan.md" }),
+    ).not.toBeNull();
+  });
+});
+
+describe("PlanArtifactCard — Open plan (panel-first review)", () => {
+  it("routes the open action to the panel when onOpenPlan is provided (no modal)", () => {
+    const onOpenPlan = vi.fn();
+    renderCard(
+      <PlanArtifactCard
+        executionId="aex_1"
+        artifact={planArtifact}
+        org="acme"
+        onOpenPlan={onOpenPlan}
+      />,
+    );
+
+    // One review affordance, not two: the facet supersedes the modal.
+    expect(screen.getAllByRole("button", { name: "Open plan" })).toHaveLength(1);
+
+    fireEvent.click(screen.getByRole("button", { name: "Open plan" }));
+    expect(onOpenPlan).toHaveBeenCalledTimes(1);
+    expect(document.querySelector("dialog")).toBeNull();
   });
 });

package/src/execution/__tests__/PlanCompletionCard.test.tsx

@@ -3,7 +3,7 @@ import { render, fireEvent, cleanup } from "@testing-library/react";
 import { PlanCompletionCard } from "../PlanCompletionCard";
 
 describe("PlanCompletionCard", () => {
-  it("renders the card with status text and a 'Build from plan' button", () => {
+  it("renders the card with status text and a 'Build' button", () => {
     const { container } = render(<PlanCompletionCard onImplement={() => {}} />);
 
     const root = container.firstElementChild as HTMLElement;
@@ -13,7 +13,7 @@ describe("PlanCompletionCard", () => {
 
     const button = root.querySelector("button");
     expect(button).toBeTruthy();
-    expect(button!.textContent).toContain("Build from plan");
+    expect(button!.textContent).toContain("Build");
 
     expect(root.textContent).toContain("Plan complete");
     cleanup();

package/src/execution/__tests__/PlanDocumentMessage.test.tsx

@@ -0,0 +1,55 @@
+import { describe, it, expect, afterEach } from "vitest";
+import { render, screen, cleanup } from "@testing-library/react";
+import { PlanDocumentMessage } from "../PlanDocumentMessage";
+
+afterEach(cleanup);
+
+describe("PlanDocumentMessage", () => {
+  it("lifts the leading H1 into the header and renders the body as markdown", () => {
+    render(
+      <PlanDocumentMessage
+        content={"# Migration Plan\n\n## Phase 1\n\n- step one"}
+      />,
+    );
+
+    const doc = screen.getByRole("article", { name: "Plan document" });
+    expect(doc).toBeTruthy();
+    expect(doc.querySelector("header")!.textContent).toContain(
+      "Migration Plan",
+    );
+    // The lifted title does not repeat inside the prose body.
+    expect(doc.querySelectorAll("h1")).toHaveLength(0);
+  });
+
+  it("falls back to a 'Plan' header when the document has no leading H1", () => {
+    render(<PlanDocumentMessage content="Just prose, no heading." />);
+
+    const doc = screen.getByRole("article", { name: "Plan document" });
+    expect(doc.querySelector("header")!.textContent).toContain("Plan");
+    expect(doc.textContent).toContain("Just prose, no heading.");
+  });
+
+  it("unwraps a whole-body BARE fence (plan-scoped fence handling)", () => {
+    render(
+      <PlanDocumentMessage content={"```\n# Fenced Plan\n\nBody text\n```"} />,
+    );
+
+    const doc = screen.getByRole("article", { name: "Plan document" });
+    // Unwrapped: the H1 became the header title, the body is prose (not a
+    // flat code block).
+    expect(doc.querySelector("header")!.textContent).toContain("Fenced Plan");
+    expect(doc.querySelector("pre")).toBeNull();
+    expect(doc.textContent).toContain("Body text");
+  });
+
+  it("keeps an inner code fence as a code block", () => {
+    render(
+      <PlanDocumentMessage
+        content={"# Plan\n\n```ts\nconst x = 1;\n```"}
+      />,
+    );
+
+    const doc = screen.getByRole("article", { name: "Plan document" });
+    expect(doc.querySelector("pre")).not.toBeNull();
+  });
+});

package/src/execution/__tests__/PlanStreamingCard.test.tsx

@@ -0,0 +1,56 @@
+import { describe, it, expect, vi, afterEach } from "vitest";
+import { render, screen, fireEvent, cleanup } from "@testing-library/react";
+import { PlanStreamingCard } from "../PlanStreamingCard";
+
+afterEach(cleanup);
+
+describe("PlanStreamingCard — live plan stand-in", () => {
+  it("is a busy region with the streaming title, status, and live size", () => {
+    render(
+      <PlanStreamingCard
+        title="Refactor the auth flow"
+        sizeBytes={2048}
+        onOpenPlan={vi.fn()}
+      />,
+    );
+
+    const region = screen.getByRole("region", { name: "Plan being written" });
+    expect(region.getAttribute("aria-busy")).toBe("true");
+    expect(region.textContent).toContain("Refactor the auth flow");
+    expect(region.textContent).toContain("Writing…");
+    expect(region.textContent).toContain("2.0 KB");
+  });
+
+  it("shows no filename mid-stream (the final name is not known yet)", () => {
+    render(
+      <PlanStreamingCard title="Refactor the auth flow" sizeBytes={2048} onOpenPlan={vi.fn()} />,
+    );
+    const region = screen.getByRole("region", { name: "Plan being written" });
+    expect(region.textContent).not.toContain("plan.md");
+  });
+
+  it("falls back to 'Writing plan…' until the title has streamed in", () => {
+    render(<PlanStreamingCard sizeBytes={12} onOpenPlan={vi.fn()} />);
+    expect(screen.getByText("Writing plan…")).toBeTruthy();
+  });
+
+  it("routes 'Open plan' to onOpenPlan", () => {
+    const onOpenPlan = vi.fn();
+    render(<PlanStreamingCard sizeBytes={64} onOpenPlan={onOpenPlan} />);
+
+    fireEvent.click(screen.getByText("Open plan"));
+    expect(onOpenPlan).toHaveBeenCalledTimes(1);
+  });
+
+  it("offers no Download or Build actions — nothing final exists yet", () => {
+    render(<PlanStreamingCard sizeBytes={64} onOpenPlan={vi.fn()} />);
+    expect(screen.queryByRole("button", { name: /download/i })).toBeNull();
+    expect(screen.queryByText("Build")).toBeNull();
+  });
+
+  it("renders without an action when onOpenPlan is absent", () => {
+    render(<PlanStreamingCard sizeBytes={64} />);
+    expect(screen.queryByText("Open plan")).toBeNull();
+    expect(screen.queryByRole("button")).toBeNull();
+  });
+});