@stigmer/react 3.0.9-dev.20260615153829 → 3.1.0

package/src/workflow/execution-inspector/ExecutionInspector.tsx

@@ -35,8 +35,17 @@ export interface ExecutionInspectorProps {
   readonly pendingApprovals?: readonly WorkflowPendingApproval[];
   /** Callback to submit an agent tool approval decision. */
   readonly onSubmitApproval?: (toolCallId: string, action: ApprovalAction, comment?: string) => Promise<unknown>;
-  /** Whether an approval submission is in flight. */
-  readonly isSubmittingApproval?: boolean;
+  /**
+   * Tool-call ids whose agent-tool approval is in flight, keyed by `toolCallId`
+   * so deciding one gate never spins another. Supply
+   * {@link useWorkflowExecutionActions}'s `approvalSubmittingToolCallIds`.
+   */
+  readonly approvalSubmittingToolCallIds?: ReadonlySet<string>;
+  /**
+   * Per-gate agent-tool approval failures, keyed by `toolCallId`. Supply
+   * {@link useWorkflowExecutionActions}'s `approvalErrorsByToolCallId`.
+   */
+  readonly approvalErrorsByToolCallId?: ReadonlyMap<string, Error>;
   /** Callback to submit a workflow-level human_input task decision. */
   readonly onSubmitTaskApproval?: (
     taskName: string,
@@ -44,8 +53,16 @@ export interface ExecutionInspectorProps {
     formData?: Record<string, unknown>,
     comment?: string,
   ) => Promise<unknown>;
-  /** Whether a task approval submission is in flight. */
-  readonly isSubmittingTaskApproval?: boolean;
+  /**
+   * Task names whose human_input approval is in flight, keyed by `taskName`.
+   * Supply {@link useWorkflowExecutionActions}'s `taskApprovalSubmittingTaskNames`.
+   */
+  readonly taskApprovalSubmittingTaskNames?: ReadonlySet<string>;
+  /**
+   * Per-gate human_input approval failures, keyed by `taskName`. Supply
+   * {@link useWorkflowExecutionActions}'s `taskApprovalErrorsByTaskName`.
+   */
+  readonly taskApprovalErrorsByTaskName?: ReadonlyMap<string, Error>;
   /** Additional CSS class names. */
   readonly className?: string;
 }
@@ -89,9 +106,11 @@ export const ExecutionInspector = memo(function ExecutionInspector({
   onNavigateToAgentExecution,
   pendingApprovals,
   onSubmitApproval,
-  isSubmittingApproval,
+  approvalSubmittingToolCallIds,
+  approvalErrorsByToolCallId,
   onSubmitTaskApproval,
-  isSubmittingTaskApproval,
+  taskApprovalSubmittingTaskNames,
+  taskApprovalErrorsByTaskName,
   className,
 }: ExecutionInspectorProps) {
   const { detail } = useExecutionTaskDetail({
@@ -212,17 +231,21 @@ export const ExecutionInspector = memo(function ExecutionInspector({
           )}
           {effectiveTab === "approval" && taskApprovals.length > 0 && onSubmitApproval && (
             <div className="space-y-2">
-              {taskApprovals.map((pa) => (
-                <WorkflowExecutionApprovalCard
-                  key={pa.approval?.toolCallId ?? pa.childAgentExecutionId}
-                  prompt={pa.approval?.message || `Tool "${pa.approval?.toolName}" requires approval`}
-                  toolCallId={pa.approval?.toolCallId ?? ""}
-                  approvers={[]}
-                  timeoutSeconds={0}
-                  onSubmitApproval={onSubmitApproval}
-                  isSubmitting={isSubmittingApproval ?? false}
-                />
-              ))}
+              {taskApprovals.map((pa) => {
+                const toolCallId = pa.approval?.toolCallId ?? "";
+                return (
+                  <WorkflowExecutionApprovalCard
+                    key={toolCallId || pa.childAgentExecutionId}
+                    prompt={pa.approval?.message || `Tool "${pa.approval?.toolName}" requires approval`}
+                    toolCallId={toolCallId}
+                    approvers={[]}
+                    timeoutSeconds={0}
+                    onSubmitApproval={onSubmitApproval}
+                    isSubmitting={approvalSubmittingToolCallIds?.has(toolCallId) ?? false}
+                    error={approvalErrorsByToolCallId?.get(toolCallId) ?? null}
+                  />
+                );
+              })}
             </div>
           )}
           {effectiveTab === "approval" && detail.approval && (
@@ -234,7 +257,8 @@ export const ExecutionInspector = memo(function ExecutionInspector({
                 outcomes={detail.approval.outcomes}
                 formSchema={detail.approval.formSchema ?? undefined}
                 onSubmit={onSubmitTaskApproval}
-                isSubmitting={isSubmittingTaskApproval ?? false}
+                isSubmitting={taskApprovalSubmittingTaskNames?.has(detail.taskName) ?? false}
+                error={taskApprovalErrorsByTaskName?.get(detail.taskName) ?? null}
               />
             ) : (
               // Gate resolved — present the captured decision read-only so a

package/src/workflow/index.ts

@@ -208,6 +208,11 @@ export {
   WorkflowExecutionApprovalCard,
   type WorkflowExecutionApprovalCardProps,
 } from "./WorkflowExecutionApprovalCard";
+export {
+  WorkflowFileReviewList,
+  type WorkflowFileReviewListProps,
+  type WorkflowFileDecisionSubmit,
+} from "./WorkflowFileReviewList";
 
 export {
   WorkflowTaskApprovalCard,

package/src/workflow/useWorkflowExecutionActions.ts

@@ -1,8 +1,9 @@
 "use client";
 
-import { useCallback, useRef, useState } from "react";
+import { useCallback, useMemo, useRef, useState } from "react";
 import type { WorkflowExecution } from "@stigmer/protos/ai/stigmer/agentic/workflowexecution/v1/api_pb";
-import type { ApprovalAction } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import type { ApprovalAction, FileDecisionAction } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import { FileDecisionScope } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
 import { create, type JsonObject } from "@bufbuild/protobuf";
 import {
   CancelWorkflowExecutionInputSchema,
@@ -12,9 +13,12 @@ import {
   RecoverWorkflowExecutionInputSchema,
   SubmitWorkflowApprovalInputSchema,
   SubmitWorkflowTaskApprovalInputSchema,
+  SubmitWorkflowFileDecisionInputSchema,
 } from "@stigmer/protos/ai/stigmer/agentic/workflowexecution/v1/io_pb";
 import { useStigmer } from "../hooks";
 import { toError } from "../internal/toError";
+import { useKeyedSubmission } from "../internal/useKeyedSubmission";
+import { fileDecisionKey, type FileDecisionOptions } from "../execution/useFileReview";
 
 /** Options for {@link useWorkflowExecutionActions}. */
 export interface UseWorkflowExecutionActionsOptions {
@@ -71,12 +75,74 @@ export interface UseWorkflowExecutionActionsReturn {
     formData?: Record<string, unknown>,
     comment?: string,
   ) => Promise<WorkflowExecution | null>;
-  /** `true` while any action is in flight. */
+  /**
+   * Submit a keep/discard decision for a child agent's file review, surfaced on
+   * this workflow via `status.pending_file_reviews`. The file-review sibling of
+   * {@link submitApproval}: the server forwards it to the child's
+   * `AgentExecution.submitFileDecision`.
+   *
+   * `childAgentExecutionId` comes from the surfaced
+   * `WorkflowPendingFileReview` reference. `options` carries the same
+   * per-decision detail as {@link FileReviewCard}'s `onSubmit` (scope,
+   * `fileChangeId`, `expectedDigest`, `reason`, `acknowledgeUnreviewable`).
+   */
+  readonly submitFileDecision: (
+    childAgentExecutionId: string,
+    changeSetId: string,
+    action: FileDecisionAction,
+    options?: FileDecisionOptions,
+  ) => Promise<WorkflowExecution | null>;
+  /**
+   * `true` while a **lifecycle** action (cancel/terminate/pause/resume/recover)
+   * is in flight. Approvals are excluded — they are per-gate, so read their
+   * in-flight state from {@link approvalSubmittingToolCallIds} /
+   * {@link taskApprovalSubmittingTaskNames} instead.
+   */
   readonly isSubmitting: boolean;
-  /** Error from the last failed action, or `null`. */
+  /**
+   * Error from the last failed **lifecycle** action, or `null`. Approval
+   * failures are per-gate and live in {@link approvalErrorsByToolCallId} /
+   * {@link taskApprovalErrorsByTaskName} so each surfaces beside the gate that
+   * failed — never in this shared scalar (which backs the header banner).
+   */
   readonly error: Error | null;
-  /** Reset `error` to `null`. */
+  /** Reset the lifecycle {@link error} to `null`. */
   readonly clearError: () => void;
+  /**
+   * Tool-call ids whose agent-tool approval is currently being submitted, keyed
+   * exactly like {@link approvalErrorsByToolCallId}. A workflow can hold many
+   * concurrent gates, so deciding one must not spin or disable the others.
+   */
+  readonly approvalSubmittingToolCallIds: ReadonlySet<string>;
+  /**
+   * Per-gate agent-tool approval failures, keyed by `toolCallId`. Consumed by
+   * {@link WorkflowExecutionApprovalCard} to surface the failure in-card,
+   * beside the gate that failed. Cleared for a gate when it is retried.
+   */
+  readonly approvalErrorsByToolCallId: ReadonlyMap<string, Error>;
+  /**
+   * Task names whose human_input task approval is currently being submitted,
+   * keyed exactly like {@link taskApprovalErrorsByTaskName}.
+   */
+  readonly taskApprovalSubmittingTaskNames: ReadonlySet<string>;
+  /**
+   * Per-gate human_input task approval failures, keyed by `taskName`. Consumed
+   * by `WorkflowTaskApprovalCard` to surface the failure in-card, beside
+   * the gate that failed. Cleared for a gate when it is retried.
+   */
+  readonly taskApprovalErrorsByTaskName: ReadonlyMap<string, Error>;
+  /**
+   * Decision keys currently being submitted for file reviews, keyed exactly like
+   * {@link FileReviewCard}'s `submittingDecisionKeys` (via {@link fileDecisionKey}
+   * — the change set id for a whole-set decision, `changeSetId:fileChangeId` for a
+   * per-file one). Pass straight through to each surfaced card.
+   */
+  readonly fileDecisionSubmittingKeys: ReadonlySet<string>;
+  /**
+   * Per-decision file-review failures, keyed like {@link fileDecisionSubmittingKeys}.
+   * Pass straight through to {@link FileReviewCard}'s `decisionErrors`.
+   */
+  readonly fileDecisionErrorsByKey: ReadonlyMap<string, Error>;
 }
 
 /**
@@ -107,6 +173,14 @@ export function useWorkflowExecutionActions(
   const [isSubmitting, setIsSubmitting] = useState(false);
   const [error, setError] = useState<Error | null>(null);
 
+  // Approvals are per-gate (a workflow can hold many at once), so each kind gets
+  // its own keyed in-flight + error state — keyed by tool-call id for agent-tool
+  // approvals and by task name for human_input task approvals. The lifecycle
+  // actions below stay on the shared scalar (they are header singletons).
+  const approvals = useKeyedSubmission<WorkflowExecution>();
+  const taskApprovals = useKeyedSubmission<WorkflowExecution>();
+  const fileDecisions = useKeyedSubmission<WorkflowExecution>();
+
   const executionIdRef = useRef(executionId);
   executionIdRef.current = executionId;
   const stigmerRef = useRef(stigmer);
@@ -202,10 +276,15 @@ export function useWorkflowExecutionActions(
     [wrap],
   );
 
+  // Approvals do NOT go through `wrap`: their in-flight + error state is keyed
+  // (per gate), and the keyed primitive re-throws after recording, so we swallow
+  // to `null` here to keep the `WorkflowExecution | null` contract. They never
+  // fire `onSuccess` — their effects arrive via the event stream.
   const submitApproval = useCallback(
-    (toolCallId: string, action: ApprovalAction, comment?: string) =>
-      wrap(
-        () =>
+    (toolCallId: string, action: ApprovalAction, comment?: string) => {
+      if (!executionIdRef.current) return Promise.resolve(null);
+      return approvals
+        .run(toolCallId, () =>
           stigmerRef.current.workflowExecution.submitApproval(
             create(SubmitWorkflowApprovalInputSchema, {
               executionId: executionIdRef.current!,
@@ -214,15 +293,17 @@ export function useWorkflowExecutionActions(
               comment: comment ?? "",
             }),
           ),
-        false,
-      ),
-    [wrap],
+        )
+        .catch(() => null);
+    },
+    [approvals.run],
   );
 
   const submitTaskApproval = useCallback(
-    (taskName: string, outcome: string, formData?: Record<string, unknown>, comment?: string) =>
-      wrap(
-        () =>
+    (taskName: string, outcome: string, formData?: Record<string, unknown>, comment?: string) => {
+      if (!executionIdRef.current) return Promise.resolve(null);
+      return taskApprovals
+        .run(taskName, () =>
           stigmerRef.current.workflowExecution.submitWorkflowTaskApproval(
             create(SubmitWorkflowTaskApprovalInputSchema, {
               executionId: executionIdRef.current!,
@@ -233,21 +314,88 @@ export function useWorkflowExecutionActions(
               comment: comment ?? "",
             }),
           ),
-        false,
-      ),
-    [wrap],
+        )
+        .catch(() => null);
+    },
+    [taskApprovals.run],
   );
 
-  return {
-    cancel,
-    terminate,
-    pause,
-    resume,
-    recover,
-    submitApproval,
-    submitTaskApproval,
-    isSubmitting,
-    error,
-    clearError,
-  };
+  // File decisions are per-target (a workflow can surface many change sets across
+  // parallel children), so they use the keyed primitive keyed exactly like
+  // FileReviewCard expects (fileDecisionKey). Never fires onSuccess — the effect
+  // arrives via the execution stream.
+  const submitFileDecision = useCallback(
+    (
+      childAgentExecutionId: string,
+      changeSetId: string,
+      action: FileDecisionAction,
+      options?: FileDecisionOptions,
+    ) => {
+      if (!executionIdRef.current) return Promise.resolve(null);
+      const fileChangeId = options?.fileChangeId ?? "";
+      const scope =
+        options?.scope ??
+        (fileChangeId ? FileDecisionScope.FILE : FileDecisionScope.CHANGE_SET);
+      const key = fileDecisionKey(changeSetId, fileChangeId || undefined);
+      return fileDecisions
+        .run(key, () =>
+          stigmerRef.current.workflowExecution.submitFileDecision(
+            create(SubmitWorkflowFileDecisionInputSchema, {
+              executionId: executionIdRef.current!,
+              childAgentExecutionId,
+              changeSetId,
+              scope,
+              fileChangeId,
+              action,
+              expectedDigest: options?.expectedDigest ?? "",
+              reason: options?.reason ?? "",
+              acknowledgeUnreviewable: options?.acknowledgeUnreviewable ?? false,
+            }),
+          ),
+        )
+        .catch(() => null);
+    },
+    [fileDecisions.run],
+  );
+
+  return useMemo(
+    () => ({
+      cancel,
+      terminate,
+      pause,
+      resume,
+      recover,
+      submitApproval,
+      submitTaskApproval,
+      submitFileDecision,
+      isSubmitting,
+      error,
+      clearError,
+      approvalSubmittingToolCallIds: approvals.submittingKeys,
+      approvalErrorsByToolCallId: approvals.errorsByKey,
+      taskApprovalSubmittingTaskNames: taskApprovals.submittingKeys,
+      taskApprovalErrorsByTaskName: taskApprovals.errorsByKey,
+      fileDecisionSubmittingKeys: fileDecisions.submittingKeys,
+      fileDecisionErrorsByKey: fileDecisions.errorsByKey,
+    }),
+    [
+      cancel,
+      terminate,
+      pause,
+      resume,
+      recover,
+      submitApproval,
+      submitTaskApproval,
+      submitFileDecision,
+      isSubmitting,
+      error,
+      clearError,
+      approvals.submittingKeys,
+      approvals.errorsByKey,
+      taskApprovals.submittingKeys,
+      taskApprovals.errorsByKey,
+      fileDecisions.submittingKeys,
+      fileDecisions.errorsByKey,
+    ],
+  );
 }