@stigmer/plugin-package 3.35.0 → 3.37.0

package/src/__test-utils__/directory-files.ts

@@ -1,29 +0,0 @@
-/**
- * A test-only `PluginFiles` over a directory on disk, for the vendored
- * fixtures. Sorted, symlinks skipped, sizes from `stat`, the contract the
- * CLI's walker honours; kept here (not in the library) because the
- * library's main entry imports no `node:*` module and the CLI owns the
- * real walker with its ignore rules.
- */
-
-import { readdirSync, readFileSync, statSync } from "node:fs";
-import { join } from "node:path";
-
-import { comparePaths, type PluginFileEntry, type PluginFiles } from "../files.js";
-
-export function directoryPluginFiles(root: string): PluginFiles {
-  const entries: PluginFileEntry[] = [];
-  const walk = (dir: string, prefix: string): void => {
-    for (const entry of readdirSync(dir, { withFileTypes: true })) {
-      const path = prefix === "" ? entry.name : `${prefix}/${entry.name}`;
-      if (entry.isDirectory()) walk(join(dir, entry.name), path);
-      else if (entry.isFile()) entries.push({ path, size: statSync(join(dir, entry.name)).size });
-    }
-  };
-  walk(root, "");
-  entries.sort((a, b) => comparePaths(a.path, b.path));
-  return {
-    entries,
-    read: (path) => new Uint8Array(readFileSync(join(root, ...path.split("/")))),
-  };
-}

package/src/__test-utils__/read.ts

@@ -1,55 +0,0 @@
-/**
- * Test helpers: read a fixture map, name the finding kinds an outcome
- * carries, and unwrap the arms with a diagnostic when the other arm came
- * back. Kinds are returned SORTED and complete (errors and warnings both),
- * so an adversarial test asserts everything the reader said and a warning
- * that appears beside the error under test is named, never tolerated by
- * omission.
- */
-
-import { expect } from "vitest";
-
-import { inMemoryPluginFiles } from "../files.js";
-import type { Finding, PluginFinding, PluginReadOutcome } from "../outcome.js";
-import { readPluginPackage } from "../read-plugin-package.js";
-import type { PluginFixture } from "../testing.js";
-import type { PluginPackage } from "../types.js";
-
-export function read(files: PluginFixture): PluginReadOutcome {
-  return readPluginPackage(inMemoryPluginFiles(files));
-}
-
-export interface Kinds {
-  readonly errors: readonly string[];
-  readonly warnings: readonly string[];
-}
-
-export function kindsOf(outcome: PluginReadOutcome): Kinds {
-  const sorted = (findings: readonly PluginFinding[]): string[] => findings.map((f) => f.kind).sort();
-  return outcome.ok
-    ? { errors: [], warnings: sorted(outcome.warnings) }
-    : { errors: sorted(outcome.errors), warnings: sorted(outcome.warnings) };
-}
-
-/** The plugin, failing with every finding's sentence when the read refused. */
-export function accepted(outcome: PluginReadOutcome): PluginPackage {
-  if (!outcome.ok) {
-    expect.fail(`expected an accepted plugin, got refusals:\n${outcome.errors.map((f) => `  ${f.kind}: ${f.message}`).join("\n")}`);
-  }
-  return outcome.plugin;
-}
-
-/** The errors, failing when the read accepted. */
-export function refused(outcome: PluginReadOutcome): readonly PluginFinding[] {
-  if (outcome.ok) {
-    expect.fail(`expected a refusal, got an accepted plugin '${outcome.plugin.name}'`);
-  }
-  return outcome.errors;
-}
-
-/** The one finding of `kind`, failing when it is absent or repeated; over either vocabulary. */
-export function findingOf<K extends string>(findings: readonly Finding<K>[], kind: string): Finding<K> {
-  const matches = findings.filter((f) => f.kind === kind);
-  expect(matches, `exactly one '${kind}' finding`).toHaveLength(1);
-  return matches[0] as Finding<K>;
-}

package/src/__tests__/adversarial.test.ts

@@ -1,434 +0,0 @@
-/**
- * The adversarial suite: one fixture per finding kind, each a valid plugin
- * with exactly one thing broken, asserting the COMPLETE sorted list of
- * kinds the reader produced (errors and warnings both) and the sentence of
- * the kind under test. A warning that legitimately accompanies an error is
- * named in its case, never tolerated by omission.
- *
- * The two tables are `Record`s over the kind unions, so a kind added to
- * `outcome.ts` without a case here does not compile, and a case for a kind
- * that no longer exists does not either. Together with `messages.ts` this
- * is the contract: every kind, one sentence, one fixture.
- */
-
-import { describe, expect, it } from "vitest";
-
-import { PLUGIN_DOCUMENT_LIMITS } from "../files.js";
-import type { PluginErrorKind, PluginWarningKind } from "../outcome.js";
-import { claudePlugin, cursorPlugin, openPlugin, type PluginFixture, withFile, withManifestField, withoutFile } from "../testing.js";
-import { findingOf, type Kinds, kindsOf, read } from "../__test-utils__/read.js";
-
-interface Case {
-  readonly files: PluginFixture;
-  /** Every kind the read produces, sorted. */
-  readonly kinds: Kinds;
-  /** The sentence of the kind under test. */
-  readonly message: string;
-}
-
-const OPEN_MANIFEST_SCHEMA = "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json";
-const OPEN_MCP_SCHEMA = "https://agent-plugins.org/schemas/1.0.0/mcp.schema.json";
-const HTTP = { type: "streamable-http", url: "https://mcp.example.com/mcp" } as const;
-const CURSOR_HTTP = { type: "http", url: "https://mcp.example.com/mcp" } as const;
-
-const errors = (...kinds: PluginErrorKind[]): Kinds => ({ errors: [...kinds].sort(), warnings: [] });
-const withWarnings = (kinds: Kinds, ...warnings: PluginWarningKind[]): Kinds => ({ errors: kinds.errors, warnings: [...warnings].sort() });
-
-const ERROR_CASES: Record<PluginErrorKind, Case> = {
-  "no-manifest": {
-    files: new Map([["README.md", "no manifest here"]]),
-    kinds: errors("no-manifest"),
-    message: "no plugin manifest found: expected one of 'plugin.json', '.claude-plugin/plugin.json', '.cursor-plugin/plugin.json', '.codex-plugin/plugin.json'",
-  },
-  "manifest-unreadable": {
-    files: new Map([["plugin.json", "{ oops"]]),
-    kinds: errors("manifest-unreadable"),
-    message: /^manifest 'plugin.json' is not valid JSON: /.source,
-  },
-  "manifest-schema-missing": {
-    files: openPlugin({ schema: null }),
-    kinds: errors("manifest-schema-missing"),
-    message: `manifest 'plugin.json' is missing the required '$schema' field; an Agent Plugins manifest declares '${OPEN_MANIFEST_SCHEMA}'`,
-  },
-  "manifest-schema-unsupported": {
-    files: openPlugin({ schema: "https://agent-plugins.org/schemas/9.0.0/plugin.schema.json" }),
-    kinds: errors("manifest-schema-unsupported"),
-    message: `manifest 'plugin.json' declares an unsupported '$schema' 'https://agent-plugins.org/schemas/9.0.0/plugin.schema.json'; this reader supports '${OPEN_MANIFEST_SCHEMA}'`,
-  },
-  "manifest-name-missing": {
-    files: withManifestField(openPlugin(), "plugin.json", "name", undefined),
-    kinds: errors("manifest-name-missing"),
-    message: "manifest 'plugin.json' is missing the required 'name' field",
-  },
-  "manifest-name-invalid": {
-    files: openPlugin({ name: "Has--Double" }),
-    kinds: errors("manifest-name-invalid"),
-    message: "plugin name 'Has--Double' in 'plugin.json' is invalid: 1 to 64 characters of lowercase letters, digits, hyphens and periods, starting and ending alphanumeric, with no '--' or '..'",
-  },
-  "manifest-name-conflict": {
-    files: new Map([...openPlugin({ name: "one" }), ...claudePlugin({ name: "two" })]),
-    kinds: errors("manifest-name-conflict"),
-    message: "manifests disagree on the plugin name: 'one' in 'plugin.json' versus 'two' in '.claude-plugin/plugin.json'",
-  },
-  "manifest-field-type": {
-    files: openPlugin({ manifest: { version: 3 } }),
-    kinds: errors("manifest-field-type"),
-    message: "field 'version' in 'plugin.json' has the wrong type: expected a string",
-  },
-
-  "path-not-relative": {
-    files: cursorPlugin({ manifest: { skills: "skills/" } }),
-    kinds: errors("path-not-relative"),
-    message: "path 'skills/' in '.cursor-plugin/plugin.json' must be plugin-relative and begin with './'",
-  },
-  "path-escapes-root": {
-    files: cursorPlugin({ manifest: { agents: "./../shared/agents/" } }),
-    kinds: errors("path-escapes-root"),
-    message: "path './../shared/agents/' in '.cursor-plugin/plugin.json' escapes the plugin root",
-  },
-  "path-glob-unsupported": {
-    files: cursorPlugin({ manifest: { skills: "./skills/**" } }),
-    kinds: errors("path-glob-unsupported"),
-    message: "path './skills/**' in '.cursor-plugin/plugin.json' is a glob pattern; declare directories and files by path",
-  },
-  "path-uncontained": {
-    files: withFile(openPlugin(), "/etc/passwd", "root"),
-    kinds: errors("path-uncontained"),
-    message: "the reader listed a path outside the plugin root: '/etc/passwd'",
-  },
-  "document-too-large": {
-    files: withFile(openPlugin(), "skills/big/SKILL.md", `---\nname: big\ndescription: d\n---\n${"x".repeat(PLUGIN_DOCUMENT_LIMITS.skillMd)}`),
-    kinds: errors("document-too-large"),
-    message: `'skills/big/SKILL.md' is ${PLUGIN_DOCUMENT_LIMITS.skillMd + "---\nname: big\ndescription: d\n---\n".length} bytes, over the ${PLUGIN_DOCUMENT_LIMITS.skillMd}-byte limit for this kind of document`,
-  },
-
-  "skill-frontmatter-missing": {
-    files: openPlugin({ skills: [{ name: "bare", frontmatter: null }] }),
-    kinds: errors("skill-frontmatter-missing"),
-    message: "'skills/bare/SKILL.md' must start with YAML frontmatter ('---')",
-  },
-  "skill-frontmatter-unclosed": {
-    files: withFile(openPlugin(), "skills/open/SKILL.md", "---\nname: open\ndescription: d\nbody without a closing fence"),
-    kinds: errors("skill-frontmatter-unclosed"),
-    message: "'skills/open/SKILL.md' frontmatter is not closed (missing the closing '---')",
-  },
-  "skill-frontmatter-unreadable": {
-    files: withFile(openPlugin(), "skills/broken/SKILL.md", "---\nname: [unclosed\n---\nbody"),
-    kinds: errors("skill-frontmatter-unreadable"),
-    message: /^'skills\/broken\/SKILL.md' frontmatter is not valid YAML: /.source,
-  },
-  "skill-name-invalid": {
-    files: openPlugin({ skills: [{ name: "Bad_Name", dir: "bad", description: "d" }] }),
-    kinds: errors("skill-name-invalid"),
-    message: "skill name 'Bad_Name' in 'skills/bad/SKILL.md' is invalid: lowercase letters, digits and hyphens, optionally dot-scoped, with every segment alphanumeric",
-  },
-  "skill-name-duplicate": {
-    files: openPlugin({ skills: [{ name: "same", dir: "a", description: "d" }, { name: "same", dir: "b", description: "d" }] }),
-    kinds: withWarnings(errors("skill-name-duplicate"), "skill-name-differs-from-directory", "skill-name-differs-from-directory"),
-    message: "skill name 'same' appears more than once (again in 'skills/b/SKILL.md')",
-  },
-
-  "mcp-config-unreadable": {
-    files: withFile(openPlugin(), "mcp.json", "not json"),
-    kinds: errors("mcp-config-unreadable"),
-    message: /^MCP configuration 'mcp.json' is not valid JSON: /.source,
-  },
-  "mcp-config-shape": {
-    files: withFile(openPlugin(), "mcp.json", JSON.stringify({ $schema: OPEN_MCP_SCHEMA, mcpServers: [] })),
-    kinds: errors("mcp-config-shape"),
-    message: "MCP configuration 'mcp.json' must be an object with an 'mcpServers' object",
-  },
-  "mcp-config-schema-missing": {
-    files: openPlugin({ mcpServers: { s: HTTP }, mcpSchema: null }),
-    kinds: errors("mcp-config-schema-missing"),
-    message: `MCP configuration 'mcp.json' is missing the required '$schema' field; an Agent Plugins configuration declares '${OPEN_MCP_SCHEMA}'`,
-  },
-  "mcp-config-schema-unsupported": {
-    files: openPlugin({ mcpServers: { s: HTTP }, mcpSchema: "https://agent-plugins.org/schemas/9.0.0/mcp.schema.json" }),
-    kinds: errors("mcp-config-schema-unsupported"),
-    message: `MCP configuration 'mcp.json' declares an unsupported '$schema' 'https://agent-plugins.org/schemas/9.0.0/mcp.schema.json'; this reader supports '${OPEN_MCP_SCHEMA}'`,
-  },
-  "mcp-config-field-unknown": {
-    files: openPlugin({ mcpServers: { s: HTTP }, mcpConfig: { comment: "x" } }),
-    kinds: errors("mcp-config-field-unknown"),
-    message: "MCP configuration 'mcp.json' has an unexpected top-level field 'comment'; only '$schema' and 'mcpServers' are allowed",
-  },
-
-  "mcp-server-shape": {
-    files: openPlugin({ mcpServers: { s: "not-an-object" } }),
-    kinds: errors("mcp-server-shape"),
-    message: "MCP server 's' in 'mcp.json' must be an object",
-  },
-  "mcp-server-type-missing": {
-    files: openPlugin({ mcpServers: { s: { url: "https://mcp.example.com/mcp" } } }),
-    kinds: errors("mcp-server-type-missing"),
-    message: "MCP server 's' in 'mcp.json' is missing the 'type' field the Agent Plugins format requires ('stdio', 'streamable-http' or 'sse')",
-  },
-  "mcp-server-transport-unknown": {
-    files: cursorPlugin({ mcpServers: { s: { args: ["x"] } } }),
-    kinds: errors("mcp-server-transport-unknown"),
-    message: "MCP server 's' in 'mcp.json' has no 'type' and neither a 'command' nor a 'url' to infer it from",
-  },
-  "mcp-server-type-ambiguous": {
-    files: cursorPlugin({ mcpServers: { s: { command: "npx", url: "https://mcp.example.com/mcp" } } }),
-    kinds: errors("mcp-server-type-ambiguous"),
-    message: "MCP server 's' in 'mcp.json' declares both 'command' and 'url'; a server is either stdio or HTTP",
-  },
-  "mcp-server-type-unknown": {
-    files: cursorPlugin({ mcpServers: { s: { type: "websocket", url: "wss://x" } } }),
-    kinds: errors("mcp-server-type-unknown"),
-    message: "MCP server 's' in 'mcp.json' has an unknown 'type' 'websocket'; expected 'stdio', 'http', 'streamable-http' or 'sse'",
-  },
-  "mcp-server-field-unknown": {
-    files: openPlugin({ mcpServers: { s: { ...HTTP, env: { A: "${A}" } } } }),
-    kinds: errors("mcp-server-field-unknown"),
-    message: "MCP server 's' in 'mcp.json' has a field 'env' that its transport does not define",
-  },
-  "mcp-server-field-type": {
-    files: openPlugin({ mcpServers: { s: { type: "stdio", command: "npx", args: "-y" } } }),
-    kinds: errors("mcp-server-field-type"),
-    message: "MCP server 's' in 'mcp.json' field 'args' has the wrong type",
-  },
-  "mcp-server-url-missing": {
-    files: openPlugin({ mcpServers: { s: { type: "streamable-http" } } }),
-    kinds: errors("mcp-server-url-missing"),
-    message: "MCP server 's' in 'mcp.json' is missing the 'url' its HTTP transport requires",
-  },
-  "mcp-server-url-invalid": {
-    files: openPlugin({ mcpServers: { s: { type: "streamable-http", url: "http://mcp.example.com/mcp" } } }),
-    kinds: errors("mcp-server-url-invalid"),
-    message: "MCP server 's' in 'mcp.json' has an invalid 'url' 'http://mcp.example.com/mcp': expected an absolute HTTPS URL (HTTP only for localhost) with no user information or fragment",
-  },
-  "mcp-server-url-variable": {
-    files: cursorPlugin({ variables: { URL: { type: "string" } }, required: ["URL"], mcpServers: { s: { type: "http", url: "${URL}" } } }),
-    kinds: errors("mcp-server-url-variable"),
-    message: "MCP server 's' in 'mcp.json' has a variable in its 'url'; Stigmer sends the URL as written, so write the URL out and put variables in 'headers'",
-  },
-  "mcp-server-command-missing": {
-    files: openPlugin({ mcpServers: { s: { type: "stdio", args: ["x"] } } }),
-    kinds: errors("mcp-server-command-missing"),
-    message: "MCP server 's' in 'mcp.json' is missing the 'command' its stdio transport requires",
-  },
-  "mcp-server-command-invalid": {
-    files: openPlugin({ mcpServers: { s: { type: "stdio", command: "npx -y @acme/server" } } }),
-    kinds: errors("mcp-server-command-invalid"),
-    message: "MCP server 's' in 'mcp.json' has a 'command' that is not a single executable name; put arguments in 'args'",
-  },
-  "mcp-server-command-relative": {
-    files: openPlugin({ mcpServers: { s: { type: "stdio", command: "./bin/server" } } }),
-    kinds: errors("mcp-server-command-relative"),
-    message: "MCP server 's' in 'mcp.json' runs a command bundled in the plugin './bin/server'; Stigmer runs only commands on the runner's PATH (for example 'npx' or 'uvx')",
-  },
-  "mcp-server-plugin-root-reference": {
-    files: claudePlugin({ mcpServers: { s: { command: "npx", args: ["--config", "${CLAUDE_PLUGIN_ROOT}/config.json"] } } }),
-    kinds: errors("mcp-server-plugin-root-reference"),
-    message: "MCP server 's' in '.mcp.json' references the plugin's own files through '${CLAUDE_PLUGIN_ROOT}'; Stigmer does not mount plugin files into the runner",
-  },
-  "mcp-server-cwd-unsupported": {
-    files: openPlugin({ mcpServers: { s: { type: "stdio", command: "npx", cwd: "./data" } } }),
-    kinds: errors("mcp-server-cwd-unsupported"),
-    message: "MCP server 's' in 'mcp.json' sets a working directory; Stigmer does not mount plugin files, so a bundled directory cannot be reached",
-  },
-  "mcp-server-env-literal": {
-    files: openPlugin({ mcpServers: { s: { type: "stdio", command: "npx", env: { LOG_LEVEL: "debug" } } } }),
-    kinds: errors("mcp-server-env-literal"),
-    message: `MCP server 's' in 'mcp.json' sets environment variable 'LOG_LEVEL' to a literal value; Stigmer passes declared variables by name, so write 'LOG_LEVEL: "\${LOG_LEVEL}"' and declare the variable`,
-  },
-  "mcp-server-env-rename": {
-    files: openPlugin({ mcpServers: { s: { type: "stdio", command: "npx", env: { API_KEY: "${MY_KEY}" } } } }),
-    kinds: errors("mcp-server-env-rename"),
-    message: "MCP server 's' in 'mcp.json' maps environment variable 'API_KEY' to a differently named variable; Stigmer passes declared variables by name, so use the same name on both sides",
-  },
-  "mcp-server-name-duplicate": {
-    files: new Map([
-      ...openPlugin({ name: "dup", mcpServers: { s: HTTP } }),
-      ...claudePlugin({ name: "dup", mcpServers: { s: { url: "https://other.example.com/mcp" } } }),
-    ]),
-    kinds: errors("mcp-server-name-duplicate"),
-    message: "MCP server name 's' appears more than once (again in '.mcp.json')",
-  },
-  "mcp-server-header-duplicate": {
-    files: openPlugin({ mcpServers: { s: { ...HTTP, headers: { Authorization: "a", authorization: "b" } } } }),
-    kinds: errors("mcp-server-header-duplicate"),
-    message: "MCP server 's' in 'mcp.json' declares header 'authorization' more than once (header names are case-insensitive)",
-  },
-  "mcp-server-header-invalid": {
-    files: openPlugin({ mcpServers: { s: { ...HTTP, headers: { "X Bad Header": "a" } } } }),
-    kinds: errors("mcp-server-header-invalid"),
-    message: "MCP server 's' in 'mcp.json' has an invalid header name 'X Bad Header'",
-  },
-
-  "sub-agent-frontmatter-unreadable": {
-    files: withFile(cursorPlugin({ agents: [] }), "agents/broken.md", "---\nname: [unclosed\n---\nA perfectly good prompt body."),
-    kinds: errors("sub-agent-frontmatter-unreadable"),
-    message: /^'agents\/broken.md' frontmatter is not valid YAML: /.source,
-  },
-  "sub-agent-instructions-short": {
-    files: cursorPlugin({ agents: [{ file: "terse", frontmatter: { name: "terse" }, body: "Go.\n" }] }),
-    kinds: errors("sub-agent-instructions-short"),
-    message: "sub-agent 'terse' in 'agents/terse.md' has instructions under 10 characters; the body of the file is the sub-agent's prompt",
-  },
-  "sub-agent-name-duplicate": {
-    files: cursorPlugin({ agents: [{ file: "a", frontmatter: { name: "same" } }, { file: "b", frontmatter: { name: "same" } }] }),
-    kinds: errors("sub-agent-name-duplicate"),
-    message: "sub-agent name 'same' appears more than once (again in 'agents/b.md')",
-  },
-
-  "variable-name-invalid": {
-    files: cursorPlugin({ variables: { "my-token": { type: "string" } } }),
-    kinds: errors("variable-name-invalid"),
-    message: "variable name 'my-token' in '.cursor-plugin/plugin.json' is invalid: an environment variable name is letters, digits and underscores, not starting with a digit",
-  },
-
-  "overlay-server-unknown": {
-    files: openPlugin({ mcpServers: { s: HTTP }, files: { "ai.stigmer/mcp-servers/other.yaml": "spec: {}\n" } }),
-    kinds: errors("overlay-server-unknown"),
-    message: "'ai.stigmer/mcp-servers/other.yaml' overlays MCP server 'other', which the plugin does not declare",
-  },
-  "overlay-document-unknown": {
-    files: openPlugin({ files: { "ai.stigmer/agent.yml": "kind: Agent\n" } }),
-    kinds: errors("overlay-document-unknown"),
-    message: "'ai.stigmer/agent.yml' is not a document Stigmer reads; the 'ai.stigmer/' folder holds 'agent.yaml', 'workflows/<name>.yaml' and 'mcp-servers/<server>.yaml'",
-  },
-};
-
-const warnings = (...kinds: PluginWarningKind[]): Kinds => ({ errors: [], warnings: [...kinds].sort() });
-
-const WARNING_CASES: Record<PluginWarningKind, Case> = {
-  "manifest-field-unknown": {
-    files: openPlugin({ manifest: { colour: "blue" } }),
-    kinds: warnings("manifest-field-unknown"),
-    message: "manifest 'plugin.json' has an unknown field 'colour', ignored",
-  },
-  "manifest-extensions-invalid": {
-    files: openPlugin({ manifest: { extensions: ["nope"] } }),
-    kinds: warnings("manifest-extensions-invalid"),
-    message: "manifest 'plugin.json' has an 'extensions' field that is not an object, ignored",
-  },
-  "path-missing": {
-    files: cursorPlugin({ manifest: { agents: "./agents/" } }),
-    kinds: warnings("path-missing"),
-    message: "path './agents' declared in '.cursor-plugin/plugin.json' does not exist in the plugin",
-  },
-  "skill-name-defaulted": {
-    files: withFile(openPlugin(), "skills/from-dir/SKILL.md", "---\ndescription: d\n---\nbody"),
-    kinds: warnings("skill-name-defaulted"),
-    message: "'skills/from-dir/SKILL.md' has no 'name' in its frontmatter; the skill is named after its directory, 'from-dir'",
-  },
-  "skill-name-differs-from-directory": {
-    files: openPlugin({ skills: [{ name: "real", dir: "folder", description: "d" }] }),
-    kinds: warnings("skill-name-differs-from-directory"),
-    message: "skill 'real' in 'skills/folder/SKILL.md' is named differently from its directory 'folder'",
-  },
-  "skill-description-missing": {
-    files: openPlugin({ skills: [{ name: "quiet" }] }),
-    kinds: warnings("skill-description-missing"),
-    message: "skill 'quiet' in 'skills/quiet/SKILL.md' has no 'description'",
-  },
-  "mcp-config-field-ignored": {
-    files: withFile(claudePlugin(), ".mcp.json", JSON.stringify({ mcpServers: {}, comment: "x" })),
-    kinds: warnings("mcp-config-field-ignored"),
-    message: "MCP configuration '.mcp.json' has a top-level field 'comment' Stigmer does not read, ignored",
-  },
-  "mcp-server-sse-mapped": {
-    files: openPlugin({ mcpServers: { legacy: { type: "sse", url: "https://legacy.example.com/sse" } } }),
-    kinds: warnings("mcp-server-sse-mapped"),
-    message: "MCP server 'legacy' in 'mcp.json' declares the legacy 'sse' transport; Stigmer connects over Streamable HTTP and falls back to SSE only when the server rejects it",
-  },
-  "mcp-server-field-ignored": {
-    files: cursorPlugin({ mcpServers: { s: { ...CURSOR_HTTP, timeout: 30 } } }),
-    kinds: warnings("mcp-server-field-ignored"),
-    message: "MCP server 's' in 'mcp.json' has a field 'timeout' Stigmer does not read, ignored",
-  },
-  "mcp-server-auth-ignored": {
-    files: cursorPlugin({ mcpServers: { s: { ...CURSOR_HTTP, auth: { scopes: ["read"] } } } }),
-    kinds: warnings("mcp-server-auth-ignored"),
-    message: "MCP server 's' in 'mcp.json' has an 'auth' block Stigmer does not read; OAuth for a server is declared in 'ai.stigmer/mcp-servers/s.yaml'",
-  },
-  "variable-inferred": {
-    files: cursorPlugin({ mcpServers: { s: { ...CURSOR_HTTP, headers: { Authorization: "Bearer ${TOKEN}" } } } }),
-    kinds: warnings("variable-inferred"),
-    message: "variable 'TOKEN' is referenced by MCP server 's' but not declared; it is declared as a required secret",
-  },
-  "variable-unreferenced": {
-    files: cursorPlugin({ variables: { UNUSED: { type: "string" } } }),
-    kinds: warnings("variable-unreferenced"),
-    message: "variable 'UNUSED' in '.cursor-plugin/plugin.json' is declared but no MCP server references it",
-  },
-  "variable-default-dropped": {
-    files: claudePlugin({ userConfig: { MODE: { type: "string", default: "fast" } }, mcpServers: { s: { command: "npx", args: ["${MODE}"] } } }),
-    kinds: warnings("variable-default-dropped"),
-    message: "variable 'MODE' in '.claude-plugin/plugin.json' has a default value, which Stigmer does not carry; the user supplies the value",
-  },
-  "variable-type-narrowed": {
-    files: claudePlugin({ userConfig: { DIR: { type: "directory" } }, mcpServers: { s: { command: "npx", args: ["${DIR}"] } } }),
-    kinds: warnings("variable-type-narrowed"),
-    message: "variable 'DIR' in '.claude-plugin/plugin.json' is typed 'directory'; Stigmer variables are strings",
-  },
-  "variable-option-dropped": {
-    files: claudePlugin({ userConfig: { MODE: { type: "string", options: ["a", "b"] } }, mcpServers: { s: { command: "npx", args: ["${MODE}"] } } }),
-    kinds: warnings("variable-option-dropped"),
-    message: "variable 'MODE' in '.claude-plugin/plugin.json' has a 'options' constraint, which Stigmer does not carry",
-  },
-  "sub-agent-name-defaulted": {
-    files: cursorPlugin({ agents: [{ file: "helper", frontmatter: null, body: "You help with everything, patiently.\n" }] }),
-    kinds: warnings("sub-agent-name-defaulted"),
-    message: "'agents/helper.md' has no 'name' in its frontmatter; the sub-agent is named after the file, 'helper'",
-  },
-  "sub-agent-skill-unknown": {
-    files: claudePlugin({ agents: [{ file: "a", frontmatter: { skills: ["missing"] } }] }),
-    kinds: warnings("sub-agent-skill-unknown"),
-    message: "sub-agent 'a' in 'agents/a.md' asks for skill 'missing', which the plugin does not ship",
-  },
-  "sub-agent-model-unknown": {
-    files: cursorPlugin({ agents: [{ file: "a", frontmatter: { model: "grok-4.6[effort=xhigh]" } }] }),
-    kinds: warnings("sub-agent-model-unknown"),
-    message: "sub-agent 'a' in 'agents/a.md' names model 'grok-4.6[effort=xhigh]', which Stigmer cannot map; the sub-agent runs on the session's model",
-  },
-  "sub-agent-field-ignored": {
-    files: cursorPlugin({ agents: [{ file: "a", frontmatter: { readonly: true } }] }),
-    kinds: warnings("sub-agent-field-ignored"),
-    message: "sub-agent 'a' in 'agents/a.md' has a field 'readonly' Stigmer does not read, ignored",
-  },
-};
-
-function expectSentence(actual: string, expected: string): void {
-  // A case whose sentence ends in a parser's own message pins its prefix.
-  if (expected.startsWith("^")) expect(actual).toMatch(new RegExp(expected));
-  else expect(actual).toBe(expected);
-}
-
-describe("every error kind refuses with its own sentence and nothing unexpected", () => {
-  it.each(Object.entries(ERROR_CASES))("%s", (kind, testCase) => {
-    const outcome = read(testCase.files);
-    expect(kindsOf(outcome)).toEqual(testCase.kinds);
-    expect(outcome.ok).toBe(false);
-    if (!outcome.ok) expectSentence(findingOf(outcome.errors, kind).message, testCase.message);
-  });
-});
-
-describe("every warning kind warns with its own sentence and the plugin is accepted", () => {
-  it.each(Object.entries(WARNING_CASES))("%s", (kind, testCase) => {
-    const outcome = read(testCase.files);
-    expect(kindsOf(outcome)).toEqual(testCase.kinds);
-    expect(outcome.ok).toBe(true);
-    expectSentence(findingOf(outcome.warnings, kind).message, testCase.message);
-  });
-});
-
-describe("a valid plugin in every dialect produces no findings at all", () => {
-  it.each([
-    ["open", openPlugin({ skills: [{ name: "a", description: "d" }], mcpServers: { s: HTTP } })],
-    ["claude", claudePlugin({ skills: [{ name: "a", description: "d" }], agents: [{ file: "b", frontmatter: { description: "x" } }] })],
-    ["cursor", cursorPlugin({ skills: [{ name: "a", description: "d" }], agents: [{ file: "b" }], mcpServers: { s: CURSOR_HTTP } })],
-  ])("%s", (_dialect, files) => {
-    expect(kindsOf(read(files))).toEqual({ errors: [], warnings: [] });
-  });
-
-  it("removing the one broken thing from an adversarial case yields a clean plugin", () => {
-    // The env-literal case minus its env block is the open stdio server every other stdio case starts from.
-    const files = withFile(ERROR_CASES["mcp-server-env-literal"].files, "mcp.json", JSON.stringify({ $schema: OPEN_MCP_SCHEMA, mcpServers: { s: { type: "stdio", command: "npx" } } }));
-    expect(kindsOf(read(files))).toEqual({ errors: [], warnings: [] });
-    expect(withoutFile(files, "mcp.json").has("mcp.json")).toBe(false);
-  });
-});

package/src/__tests__/client-ignore.test.ts

@@ -1,133 +0,0 @@
-/**
- * The ignore engine's table tests: the filepath.Match port, the Pattern
- * matcher (scoping, dir-only, globs, negation) and the composed matcher's
- * source precedence with last-match-wins. Moved here with the engine from
- * the CLI; the matcher is now built from the TEXT of the ignore files, so
- * the precedence cases hand it text where they once wrote a temp directory.
- */
-
-import { describe, expect, it } from "vitest";
-
-import { matchName } from "../client/ignore/match.js";
-import { buildMatcher } from "../client/ignore/matcher.js";
-import { MatchResult, parsePattern } from "../client/ignore/pattern.js";
-
-describe("matchName (filepath.Match port)", () => {
-  const cases: [string, string, boolean][] = [
-    ["*.go", "main.go", true],
-    ["*.go", "main.rs", false],
-    ["*", "anything", true],
-    ["a?c", "abc", true],
-    ["a?c", "ac", false],
-    ["[abc]", "b", true],
-    ["[abc]", "d", false],
-    ["[a-c]", "b", true],
-    ["[a-c]", "z", false],
-    ["[^a]", "b", true],
-    ["[^a]", "a", false],
-    ["foo*", "foobar", true],
-    ["*bar", "foobar", true],
-    ["h[a-z]llo", "hello", true],
-    ["node_modules", "node_modules", true],
-    ["\\*.go", "*.go", true],
-    // Malformed patterns: Go returns ErrBadPattern → callers treat as no match.
-    ["[", "a", false],
-    ["[a-", "a", false],
-  ];
-  for (const [pattern, name, expected] of cases) {
-    it(`${pattern} ~ ${name} => ${expected}`, () => {
-      expect(matchName(pattern, name)).toBe(expected);
-    });
-  }
-});
-
-describe("parsePattern / Pattern.match", () => {
-  it("directory-only patterns only match directories (or ancestors)", () => {
-    const p = parsePattern("node_modules/", []);
-    expect(p.match(["node_modules"], true)).toBe(MatchResult.Exclude);
-    expect(p.match(["node_modules"], false)).toBe(MatchResult.NoMatch);
-    expect(p.match(["src", "node_modules"], true)).toBe(MatchResult.Exclude);
-  });
-
-  it("simple name patterns match at any depth", () => {
-    const p = parsePattern("*.log", []);
-    expect(p.match(["app.log"], false)).toBe(MatchResult.Exclude);
-    expect(p.match(["sub", "app.log"], false)).toBe(MatchResult.Exclude);
-    expect(p.match(["app.txt"], false)).toBe(MatchResult.NoMatch);
-  });
-
-  it("leading slash anchors to the domain root", () => {
-    const p = parsePattern("/build", []);
-    expect(p.match(["build"], true)).toBe(MatchResult.Exclude);
-    expect(p.match(["src", "build"], true)).toBe(MatchResult.NoMatch);
-  });
-
-  it("** matches zero-to-many directories", () => {
-    const p = parsePattern("**/foo", []);
-    expect(p.match(["foo"], false)).toBe(MatchResult.Exclude);
-    expect(p.match(["a", "b", "foo"], false)).toBe(MatchResult.Exclude);
-    expect(p.match(["a", "bar"], false)).toBe(MatchResult.NoMatch);
-  });
-
-  it("negation patterns produce Include", () => {
-    const p = parsePattern("!keep.txt", []);
-    expect(p.inclusion).toBe(true);
-    expect(p.match(["keep.txt"], false)).toBe(MatchResult.Include);
-  });
-
-  it("domain scopes matching below a subtree", () => {
-    const p = parsePattern("*.txt", ["sub"]);
-    expect(p.match(["sub", "a.txt"], false)).toBe(MatchResult.Exclude);
-    expect(p.match(["a.txt"], false)).toBe(MatchResult.NoMatch);
-  });
-});
-
-describe("buildMatcher (source precedence, last-match-wins)", () => {
-  it("applies security defaults including the .env.example negation", () => {
-    const m = buildMatcher({ includeDefaults: true });
-    expect(m.match(".env", false)).toBe(true);
-    expect(m.match(".env.example", false)).toBe(false);
-    expect(m.match("id_rsa", false)).toBe(true);
-    expect(m.match("node_modules", true)).toBe(true);
-  });
-
-  it("honors .gitignore with negation (last match wins)", () => {
-    const m = buildMatcher({ includeDefaults: true, gitignore: "*.draft\n!keep.draft\n" });
-    expect(m.match("notes.draft", false)).toBe(true);
-    expect(m.match("keep.draft", false)).toBe(false);
-  });
-
-  it("an absent .gitignore contributes nothing", () => {
-    const m = buildMatcher({ includeDefaults: true });
-    expect(m.match("notes.draft", false)).toBe(false);
-  });
-
-  it(".stigmerignore outranks .gitignore", () => {
-    const m = buildMatcher({ includeDefaults: true, gitignore: "!shared.draft\n", stigmerignore: "*.draft\n" });
-    expect(m.match("shared.draft", false)).toBe(true);
-  });
-
-  it("caller extra ignore/include override file sources", () => {
-    const m = buildMatcher({
-      includeDefaults: true,
-      gitignore: "*.draft\n",
-      extraIgnore: ["*.tmp"],
-      extraInclude: ["important.draft"],
-    });
-    expect(m.match("scratch.tmp", false)).toBe(true);
-    expect(m.match("important.draft", false)).toBe(false);
-  });
-
-  it("reports the matching source and reason", () => {
-    const m = buildMatcher({ includeDefaults: true });
-    const reason = m.matchWithReason(".env", false);
-    expect(reason.ignored).toBe(true);
-    expect(reason.source).toBe("defaults");
-  });
-
-  it("CRLF ignore files parse line by line", () => {
-    const m = buildMatcher({ includeDefaults: false, gitignore: "*.a\r\n*.b\r\n" });
-    expect(m.match("x.a", false)).toBe(true);
-    expect(m.match("x.b", false)).toBe(true);
-  });
-});