@stigmer/cli 3.12.5 → 3.12.7

package/src/resources/run/create.ts

@@ -10,7 +10,7 @@ import type { Client } from "@connectrpc/connect";
 import { create, type DescService } from "@bufbuild/protobuf";
 import { type AgentExecution, AgentExecutionSchema } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/api_pb";
 import { AgentExecutionCommandController } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/command_pb";
-import { InteractionMode, ServiceTier } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import { InteractionMode, ServiceTier, ThinkingMode } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
 import type { Attachment } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/spec_pb";
 import {
   AgentExecutionSpecSchema,
@@ -29,7 +29,7 @@ import { WorkflowExecutionSpecSchema } from "@stigmer/protos/ai/stigmer/agentic/
 import { ExecutionValueSchema } from "@stigmer/protos/ai/stigmer/agentic/executioncontext/v1/spec_pb";
 import { ApiResourceMetadataSchema } from "@stigmer/protos/ai/stigmer/commons/apiresource/metadata_pb";
 import type { RuntimeEnv } from "./env.js";
-import type { RunMode, ServiceTierFlag } from "./prepare.js";
+import type { RunMode, ServiceTierFlag, ThinkingFlag } from "./prepare.js";
 
 const API_VERSION = "agentic.stigmer.ai/v1";
 
@@ -58,6 +58,7 @@ export interface CreateAgentExecutionInput {
   readonly model: string;
   readonly mode: RunMode;
   readonly serviceTier: ServiceTierFlag;
+  readonly thinking: ThinkingFlag;
   readonly autoApproveAll: boolean;
 }
 
@@ -84,7 +85,7 @@ export async function createAgentExecution(
         input.workspaceEntries.length > 0
           ? create(SessionSpecSchema, { workspaceEntries: [...input.workspaceEntries] })
           : undefined,
-      executionConfig: buildExecutionConfig(input.model, input.mode, input.serviceTier),
+      executionConfig: buildExecutionConfig(input.model, input.mode, input.serviceTier, input.thinking),
     }),
   });
   return controller(AgentExecutionCommandController).create(execution);
@@ -123,19 +124,23 @@ export async function createWorkflowExecution(
 // Build ExecutionConfig, or undefined when no flag is set so the backend
 // applies its defaults. Mirrors Go's buildExecutionConfig (only "plan" maps to a
 // non-default InteractionMode; "agent"/"" leave it unspecified). An explicit
-// --service-tier value maps to the enum even for "standard": unspecified vs
-// explicit-standard is a load-bearing ledger distinction (#357).
+// --service-tier or --thinking value maps to the enum even for the base
+// choice ("standard"/"disabled"): unspecified vs explicit is a load-bearing
+// ledger distinction (#357/#772).
 function buildExecutionConfig(
   model: string,
   mode: RunMode,
   serviceTier: ServiceTierFlag,
+  thinking: ThinkingFlag,
 ): ExecutionConfig | undefined {
-  if (model === "" && mode === "" && serviceTier === "") return undefined;
+  if (model === "" && mode === "" && serviceTier === "" && thinking === "") return undefined;
   const cfg = create(ExecutionConfigSchema);
   if (model !== "") cfg.modelName = model;
   if (mode === "plan") cfg.interactionMode = InteractionMode.PLAN;
   if (serviceTier === "fast") cfg.serviceTier = ServiceTier.FAST;
   else if (serviceTier === "standard") cfg.serviceTier = ServiceTier.STANDARD;
+  if (thinking === "enabled") cfg.thinkingMode = ThinkingMode.ENABLED;
+  else if (thinking === "disabled") cfg.thinkingMode = ThinkingMode.DISABLED;
   return cfg;
 }
 

package/src/resources/run/prepare.test.ts

@@ -5,7 +5,7 @@
 import { describe, expect, it } from "vitest";
 import { ApprovalAction } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
 import type { Stigmer } from "@stigmer/sdk";
-import { type AgentExecFlags, parseApprovalAction, prepareAgentExec, validateMode, validateServiceTier } from "./prepare.js";
+import { type AgentExecFlags, parseApprovalAction, prepareAgentExec, validateMode, validateServiceTier, validateThinking } from "./prepare.js";
 
 describe("parseApprovalAction", () => {
   it("maps each accepted value (case-insensitive)", () => {
@@ -47,6 +47,18 @@ describe("validateServiceTier", () => {
   });
 });
 
+describe("validateThinking", () => {
+  it("accepts empty, disabled, and enabled", () => {
+    expect(() => validateThinking("")).not.toThrow();
+    expect(() => validateThinking("disabled")).not.toThrow();
+    expect(() => validateThinking("enabled")).not.toThrow();
+  });
+
+  it("rejects anything else before a network round trip", () => {
+    expect(() => validateThinking("harder")).toThrow(/must be "disabled" or "enabled"/);
+  });
+});
+
 const BASE_FLAGS: AgentExecFlags = {
   message: "hi",
   attach: [],
@@ -64,6 +76,7 @@ const BASE_FLAGS: AgentExecFlags = {
   autoApprove: false,
   mode: "",
   serviceTier: "",
+  thinking: "",
 };
 
 // prepareAgentExec only touches client.agentExecution for attachment uploads;

package/src/resources/run/prepare.ts

@@ -26,6 +26,12 @@ export type RunMode = "" | "agent" | "plan";
  */
 export type ServiceTierFlag = "" | "standard" | "fast";
 
+/**
+ * The `--thinking` flag's value space (#772), the tier's twin: empty means
+ * unset — distinct from an explicit "disabled" for the same ledger reason.
+ */
+export type ThinkingFlag = "" | "disabled" | "enabled";
+
 /** Raw agent-execution flags shared by `run` and `draft` (Go's agentExecFlags). */
 export interface AgentExecFlags {
   readonly message: string;
@@ -44,6 +50,7 @@ export interface AgentExecFlags {
   readonly autoApprove: boolean;
   readonly mode: RunMode;
   readonly serviceTier: ServiceTierFlag;
+  readonly thinking: ThinkingFlag;
 }
 
 /**
@@ -63,6 +70,7 @@ export interface PreparedRun {
   readonly autoApproveAll: boolean;
   readonly mode: RunMode;
   readonly serviceTier: ServiceTierFlag;
+  readonly thinking: ThinkingFlag;
 }
 
 /** Optional behavior switches for {@link prepareAgentExec}. */
@@ -91,6 +99,7 @@ export async function prepareAgentExec(
   const defaultAction = parseApprovalAction(flags.approveDefault);
   validateMode(flags.mode);
   validateServiceTier(flags.serviceTier);
+  validateThinking(flags.thinking);
 
   // Layered model seed (oss#293 Phase 1.5): an explicit --model always wins;
   // an omitted one fills from the account preference on cloud. `run` and
@@ -134,6 +143,7 @@ export async function prepareAgentExec(
     autoApproveAll: flags.autoApprove,
     mode: flags.mode,
     serviceTier: flags.serviceTier,
+    thinking: flags.thinking,
   };
 }
 
@@ -202,3 +212,18 @@ export function validateServiceTier(tier: string): asserts tier is ServiceTierFl
     );
   }
 }
+
+/**
+ * Validate the `--thinking` flag, the tier check's twin (#772). Empty means
+ * "platform default" (which resolves to disabled — never the provider
+ * account default). The server refuses enabled on models without the
+ * registry thinking capability; this check only catches spelling errors
+ * before a network round trip.
+ */
+export function validateThinking(mode: string): asserts mode is ThinkingFlag {
+  if (mode !== "" && mode !== "disabled" && mode !== "enabled") {
+    throw new UsageError(
+      `invalid --thinking value "${mode}": must be "disabled" or "enabled"`,
+    );
+  }
+}

package/src/resources/task-configs.ts

@@ -100,7 +100,7 @@ export function decodeWorkflowTaskConfigs(workflow: Workflow): void {
 /**
  * Rewrites user-friendly DSL forms to the shapes the proto decode expects —
  * the twin of the server's `normalizeEnumShorthands` (unmarshal.go): agent_call
- * harness shorthands ("cursor" → "HARNESS_CURSOR"), run_config service-tier
+ * harness shorthands ("cursor" → "HARNESS_CURSOR"), run_config service-tier/thinking-mode
  * shorthands ("fast" → "SERVICE_TIER_FAST"), and the environment_refs kind
  * default (an omitted kind means environment). Without this twin the offline
  * decode would be STRICTER than a real apply and fail valid manifests.
@@ -123,6 +123,10 @@ function normalizeTaskConfigShorthands(kind: WorkflowTaskKind, config: JsonValue
       const tier = SERVICE_TIER_SHORTHANDS[runConfig.service_tier.toLowerCase()];
       if (tier !== undefined) runConfig.service_tier = tier;
     }
+    if (typeof runConfig.thinking_mode === "string") {
+      const mode = THINKING_MODE_SHORTHANDS[runConfig.thinking_mode.toLowerCase()];
+      if (mode !== undefined) runConfig.thinking_mode = mode;
+    }
     normalized.run_config = runConfig;
   }
 
@@ -145,6 +149,11 @@ const SERVICE_TIER_SHORTHANDS: Record<string, string> = {
   fast: "SERVICE_TIER_FAST",
 };
 
+const THINKING_MODE_SHORTHANDS: Record<string, string> = {
+  disabled: "THINKING_MODE_DISABLED",
+  enabled: "THINKING_MODE_ENABLED",
+};
+
 function isJsonObject(value: JsonValue | undefined): value is Record<string, JsonValue> {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }