@stevecastaneda/paseo-progress 1.14.2 → 1.14.3

package/shared/rpc.ts

@@ -11,7 +11,14 @@ import type { WhatsNew } from "./whats-new.ts";
 // `inRepo`: saving history needs a git repo to keep the choice in.
 // `version` changes whenever anything else in the result does.
 export type DashboardResult = {
-  configured: boolean; dashboard: Dashboard; panelOpened: boolean; file: string; savedTo: string | null; inRepo: boolean; root: string; version: string;
+  configured: boolean;
+  dashboard: Dashboard;
+  panelOpened: boolean;
+  file: string;
+  savedTo: string | null;
+  inRepo: boolean;
+  root: string;
+  version: string;
 };
 
 export const getDashboard = defineRpc({
@@ -153,7 +160,7 @@ export const canOpenOnHost = defineRpc({
   output: z.object({ canOpen: z.boolean() }),
 });
 
-// An image, text, Markdown or HTML file's contents, for the preview dialog.
+// An image, text or Markdown file's contents, for the preview dialog.
 export const previewDeliverable = defineRpc({
   name: "progress.deliverable.preview",
   input: z.object({
@@ -168,7 +175,6 @@ export const previewDeliverable = defineRpc({
     z.object({ kind: z.literal("pdf"), bytes: z.number() }),
     z.object({ kind: z.literal("text"), text: z.string(), bytes: z.number(), truncated: z.boolean() }),
     z.object({ kind: z.literal("markdown"), markdown: z.string(), bytes: z.number(), truncated: z.boolean() }),
-    z.object({ kind: z.literal("html"), html: z.string(), bytes: z.number() }),
     z.object({ kind: z.literal("folder"), entries: z.array(z.object({ name: z.string(), folder: z.boolean() })), truncated: z.boolean() }),
   ]),
 });

package/shared/show.ts

@@ -4,11 +4,15 @@ import { formatAgo, formatClock, formatMinutes, formatWorkDone, minutesSince } f
 import type { QuestionState } from "./question-modes.ts";
 
 const STATUS: Record<string, string> = { not_started: "Not started", working: "Working", blocked: "Blocked", done: "Done", skipped: "Skipped" };
-const QUESTION_STATE: Record<QuestionState, string> = { stopped: "agent stopped until the answer", waiting: "waiting for the answer", building: "building with it" };
+const QUESTION_STATE: Record<QuestionState, string> = {
+  stopped: "agent stopped until the answer",
+  waiting: "waiting for the answer",
+  building: "building with it",
+};
 
 // The dashboard as plain text, so an agent can check what the user sees.
 export function dashboardText(dashboard: Dashboard, nowMs: number): string {
-  if (!dashboard.run && !dashboard.tickets.length) return "No run yet. Start one with: paseo-progress start \"<title>\"";
+  if (!dashboard.run && !dashboard.tickets.length) return 'No run yet. Start one with: paseo-progress start "<title>"';
   const lines: string[] = [];
   const when = (iso: string) => `${formatClock(iso)} (${formatAgo(iso, nowMs)})`;
   lines.push(dashboard.run?.title ?? "Progress");
@@ -22,7 +26,9 @@ export function dashboardText(dashboard: Dashboard, nowMs: number): string {
   if (dashboard.updatedAt) lines.push(`Last updated ${when(dashboard.updatedAt)}`);
   if (dashboard.stale && dashboard.updatedAt) lines.push(`POSSIBLY STALE: no update for ${formatMinutes(minutesSince(dashboard.updatedAt, nowMs))}.`);
   if (dashboard.progress.totalMin) {
-    lines.push(`${dashboard.progress.percent}% of estimated work done, ${dashboard.progress.tookMin !== undefined ? "took " : ""}${formatWorkDone(dashboard.progress.doneMin, dashboard.progress.totalMin, dashboard.progress.tookMin)}`);
+    lines.push(
+      `${dashboard.progress.percent}% of estimated work done, ${dashboard.progress.tookMin !== undefined ? "took " : ""}${formatWorkDone(dashboard.progress.doneMin, dashboard.progress.totalMin, dashboard.progress.tookMin)}`,
+    );
   }
   if (dashboard.issues.length) {
     lines.push("", `Skipped lines: ${dashboard.issues.map((issue) => `line ${issue.line} (${issue.reason})`).join(", ")}`);
@@ -30,9 +36,12 @@ export function dashboardText(dashboard: Dashboard, nowMs: number): string {
   if (dashboard.stuck.length) {
     lines.push("", "Stuck");
     for (const item of dashboard.stuck) {
-      const detail = item.kind === "overdue" ? `no update for longer than its ${formatMinutes(item.estimateMin)} estimate`
-        : item.kind === "blocked" ? `blocked${item.note ? `: ${item.note}` : ""}`
-        : `${item.id}: ${item.reason}`;
+      const detail =
+        item.kind === "overdue"
+          ? `no update for longer than its ${formatMinutes(item.estimateMin)} estimate`
+          : item.kind === "blocked"
+            ? `blocked${item.note ? `: ${item.note}` : ""}`
+            : `${item.id}: ${item.reason}`;
       lines.push(`  ${item.title} (${detail}), since ${when(item.since)}`);
     }
   }
@@ -46,7 +55,9 @@ export function dashboardText(dashboard: Dashboard, nowMs: number): string {
   if (dashboard.questions.open.length) {
     lines.push("", "Questions waiting");
     for (const question of dashboard.questions.open) {
-      lines.push(`  ${question.id} ${question.ticketId ? `[${question.ticketId}] ` : ""}(${question.title}): ${question.question} You recommended ${question.recommended}, ${QUESTION_STATE[question.state]}${question.big ? `. Big: ${question.big}` : ""}`);
+      lines.push(
+        `  ${question.id} ${question.ticketId ? `[${question.ticketId}] ` : ""}(${question.title}): ${question.question} You recommended ${question.recommended}, ${QUESTION_STATE[question.state]}${question.big ? `. Big: ${question.big}` : ""}`,
+      );
       for (const option of question.options) lines.push(`      ${option.letter}) ${option.label}${option.consequence ? `: ${option.consequence}` : ""}`);
     }
   }
@@ -65,7 +76,8 @@ export function dashboardText(dashboard: Dashboard, nowMs: number): string {
   }
   if (dashboard.activity.length) {
     lines.push("", "Activity");
-    for (const entry of dashboard.activity.slice(0, 5)) lines.push(`  ${entry.id}  ${entry.ticketId ? `[${entry.ticketId}] ` : ""}${entry.text} (${formatAgo(entry.at, nowMs)})`);
+    for (const entry of dashboard.activity.slice(0, 5))
+      lines.push(`  ${entry.id}  ${entry.ticketId ? `[${entry.ticketId}] ` : ""}${entry.text} (${formatAgo(entry.at, nowMs)})`);
   }
   return lines.join("\n");
 }

package/shared/ticket-story.ts

@@ -68,9 +68,7 @@ export function ticketTimeline(ticket: Ticket, nowMs: number): TimelineStep[] {
 // Each includes its start but not its end, so an entry logged at a handoff
 // belongs to the ticket that just started.
 function workingWindows(steps: TimelineStep[], nowMs: number): Array<[number, number]> {
-  return steps
-    .filter((step) => step.status === "working")
-    .map((step) => [Date.parse(step.at), step.until ? Date.parse(step.until) : nowMs + 1]);
+  return steps.filter((step) => step.status === "working").map((step) => [Date.parse(step.at), step.until ? Date.parse(step.until) : nowMs + 1]);
 }
 
 export function ticketStory(ticket: Ticket, related: { deliverables: Deliverable[]; questions: Question[]; activity: Activity[] }, nowMs: number): TicketStory {

package/skills/paseo-progress/SKILL.md

@@ -25,6 +25,7 @@ Done when `show` lists every ticket with an estimate.
 
 Move each ticket through `--status working --stage Build`, then the stages `Review`, `Fixes` and `Verify`, then `--status done`. Along the way, record what the user would want to see: `deliverable add` for anything reviewable, `activity add` for milestones, `ticker set` for what you are doing right now. Tag each with `--ticket` unless it covers the whole run.
 
+- An HTML deliverable must be self-contained, with its CSS in the page and images embedded as data URIs, and no scripts or styles from the web, because Paseo's preview blocks the network.
 - A ticket past its estimate with no update turns stuck. Keep its stage current, or raise its `--estimate`.
 - A ticket another session adds is part of the plan. Work it in order.
 - `--status blocked` and `stuck set` are for things outside the run, like a service that's down or missing access.

package/tsconfig.json

@@ -3,9 +3,7 @@
     "target": "ES2020",
     "module": "ESNext",
     "moduleResolution": "Bundler",
-    "lib": [
-      "ES2023"
-    ],
+    "lib": ["ES2023"],
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
@@ -14,11 +12,6 @@
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true
   },
-  "include": [
-    "**/*.ts",
-    "**/*.tsx"
-  ],
-  "exclude": [
-    "node_modules"
-  ]
+  "include": ["**/*.ts", "**/*.tsx"],
+  "exclude": ["node_modules"]
 }

package/client/page-opener.ts

@@ -1,9 +0,0 @@
-export type PageParams = { workspaceId: string; workspaceDirectory: string; ref: string; title: string };
-
-// Panels can't open a screen themselves, only the plugin's client can, so it
-// sets this once it has added the page screen.
-export let openPage: ((params: PageParams) => void) | null = null;
-
-export function setPageOpener(opener: typeof openPage) {
-  openPage = opener;
-}

package/client/page-screen.tsx

@@ -1,97 +0,0 @@
-import { type PluginClientContext, type PluginScreenProps, useRpc } from "@getpaseo/plugin/client";
-import { useQuery } from "@tanstack/react-query";
-import React, { useEffect, useRef, useState } from "react";
-import { ActivityIndicator, Text, View } from "react-native";
-import { previewDeliverable } from "../shared/rpc";
-import { errorText } from "./errors";
-import { ProgressLanguageProvider, useProgressLanguage } from "./language";
-import { type PageParams, setPageOpener } from "./page-opener";
-
-const PAGE_SCREEN_ID = "page";
-
-export function addPageScreen(client: PluginClientContext) {
-  setPageOpener((params) => client.openScreen({ screenId: PAGE_SCREEN_ID, params }));
-  const stop = client.addScreen({
-    id: PAGE_SCREEN_ID,
-    title: (params) => params.title ?? "",
-    Component: (props) => <ProgressLanguageProvider><PageScreen {...props} /></ProgressLanguageProvider>,
-  });
-  return () => {
-    setPageOpener(null);
-    void stop();
-  };
-}
-
-// Keys pressed inside the page go to the page, so it tells Progress about
-// Escape itself, unless one of its own handlers has used the key.
-const ESCAPE = "progress:page-escape";
-const ESCAPE_SCRIPT = `<script>addEventListener("keydown",function(e){if(e.key==="Escape"&&!e.defaultPrevented)parent.postMessage("${ESCAPE}","*")})</script>`;
-
-// The plugin compiles without the DOM's types; these are the browser APIs used here.
-type KeyEvent = { key: string; defaultPrevented: boolean };
-type FrameMessage = { data: unknown; source: unknown };
-type Frame = { contentWindow: unknown; getClientRects(): { length: number } };
-const browser = globalThis as unknown as {
-  addEventListener(type: "keydown", listener: (event: KeyEvent) => void): void;
-  addEventListener(type: "message", listener: (event: FrameMessage) => void): void;
-  removeEventListener(type: "keydown" | "message", listener: (event: never) => void): void;
-};
-
-// Escape leaves the page, like the Close button in Paseo's header.
-// Paseo can keep a screen mounted, hidden, after leaving it, so Escape only
-// counts while the page is on screen.
-function useEscapeToClose(frame: React.RefObject<Frame | null>, close: (() => void) | undefined) {
-  useEffect(() => {
-    if (!close || typeof browser.addEventListener !== "function") return;
-    const onKey = (event: KeyEvent) => {
-      if (event.key === "Escape" && !event.defaultPrevented && frame.current?.getClientRects().length) close();
-    };
-    const onMessage = (event: FrameMessage) => {
-      if (event.data === ESCAPE && event.source === frame.current?.contentWindow) close();
-    };
-    browser.addEventListener("keydown", onKey);
-    browser.addEventListener("message", onMessage);
-    return () => {
-      browser.removeEventListener("keydown", onKey);
-      browser.removeEventListener("message", onMessage);
-    };
-  }, [close]);
-}
-
-// An HTML deliverable across the whole screen, the width it was written for.
-function PageScreen({ params, theme: { colors }, navigation }: PluginScreenProps) {
-  const { messages: m } = useProgressLanguage();
-  const fetchPreview = useRpc(previewDeliverable);
-  const { workspaceId, workspaceDirectory, ref } = params as PageParams;
-  const page = useQuery({
-    queryKey: ["progress", "page", workspaceId, ref],
-    queryFn: () => fetchPreview({ workspaceId, workspaceDirectory, ref }),
-  });
-  // The page stays hidden on Paseo's background until it has drawn, so opening it
-  // doesn't flash an empty white frame first.
-  const [shownHtml, setShownHtml] = useState<string | null>(null);
-  const frame = useRef<Frame | null>(null);
-  useEscapeToClose(frame, navigation ? () => navigation.openWorkspace({ workspaceId }) : undefined);
-  if (page.data?.kind === "html") {
-    const html = page.data.html + ESCAPE_SCRIPT;
-    return (
-      <View style={{ flex: 1, backgroundColor: colors.surface0 }}>
-        {/* `allow-scripts` alone, as in Paseo's own HTML preview: the page runs its scripts
-            (and loads them from the web, so no CSP) in an opaque origin that can't reach
-            Paseo's DOM or storage, navigate the app, open windows or submit forms. */}
-        <iframe ref={frame as never} srcDoc={html} sandbox="allow-scripts" referrerPolicy="no-referrer" title={params.title} onLoad={() => setShownHtml(html)}
-          style={{ flex: 1, width: "100%", height: "100%", display: "block", border: "none", backgroundColor: "white",
-            opacity: shownHtml === html ? 1 : 0, transition: "opacity 150ms ease-out" }} />
-      </View>
-    );
-  }
-  return (
-    <View style={{ flex: 1, alignItems: "center", justifyContent: "center", padding: 24 }}>
-      {page.error ? (
-        <Text accessibilityRole="alert" selectable style={{ color: colors.statusDanger, fontSize: 12, lineHeight: 18 }}>
-          {m.previewError(errorText(page.error, m.unknownError))}
-        </Text>
-      ) : <ActivityIndicator color={colors.foregroundMuted} accessibilityLabel={m.loadingPreview} />}
-    </View>
-  );
-}