@steve31415/baselib 2.4.1 → 2.4.3

package/dist/deploy/deploy.js

@@ -209,7 +209,10 @@ export async function runDeploy(options) {
                 await evidence.save(`gate-${index}.log`, result.stdout + result.stderr);
                 timer.record(`gate:${gate}`, Date.now() - gateStart);
                 if (result.code !== 0) {
-                    const tail = (result.stderr.trim() || result.stdout.trim()).slice(-1500);
+                    // Quote the tail of BOTH streams: test runners put the failing spec on
+                    // stdout and only build/server noise on stderr, so stderr alone can
+                    // hide which test failed. stderr last, so it survives the cut.
+                    const tail = [result.stdout.trim(), result.stderr.trim()].filter(Boolean).join('\n').slice(-1500);
                     throw new Error(`gate failed: ${gate}\n${tail}`);
                 }
                 log(`gate passed: ${gate}`);
@@ -397,9 +400,11 @@ export async function runDeploy(options) {
             })),
             timingsMs: timer.timings,
         });
-        if (hold && !hold.heldShas.includes(sha)) {
+        if (hold) {
+            // A successful deploy clears any hold: either a different SHA shipped
+            // (the fix landed) or the operator deliberately overrode the hold.
             await clearHold(runner, holdUri);
-            log('cleared rollback hold (a newer build deployed successfully)');
+            log('cleared rollback hold');
         }
         log(`deployed ${sha.slice(0, 12)} (${record})`);
         log(`timings:\n${timer.table()}`);

package/dist/deploy/plan.js

@@ -141,7 +141,8 @@ export function releaseEntriesFrom(rows, prefix) {
         return [];
     return rows.flatMap((row) => {
         const r = row;
-        const url = r.url ?? '';
+        // `gcloud storage ls --json` appends `#<generation>` to object URLs.
+        const url = (r.url ?? '').replace(/#\d+$/, '');
         const name = url.slice(url.lastIndexOf('/') + 1);
         const sha = name.endsWith('.json') ? name.slice(0, -5) : '';
         if (!SHA40.test(sha) || !url.includes(prefix))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@steve31415/baselib",
-  "version": "2.4.1",
+  "version": "2.4.3",
   "description": "Plasticine new-world shared platform library: logging, auth, service-to-service auth, db, HTTP, sync, app updates",
   "type": "module",
   "license": "MIT",