@stencil/core 5.0.0-beta.20 → 5.0.0-beta.21

package/dist/compiler/browser.js

@@ -1844,7 +1844,7 @@ const validateComponentTag = (tag) => {
 };
 //#endregion
 //#region src/version.ts
-const version = "5.0.0-beta.20";
+const version = "5.0.0-beta.21";
 //#endregion
 //#region src/compiler/events.ts
 const buildEvents = () => {
@@ -15440,13 +15440,13 @@ const parseStaticComponentMeta = (compilerCtx, typeChecker, cmpNode, moduleFile,
 		hasPatchClone: false,
 		hasPatchInsert: false
 	};
-	const visitComponentChildNode = (node, ctx) => {
-		validateComponentMembers(node, ctx);
+	if (!isCollectionDependency) validateComponentMembers(cmpNode, buildCtx);
+	const visitComponentChildNode = (node) => {
 		if (ts$1.isCallExpression(node)) parseCallExpression(cmp, node, typeChecker);
 		else if (ts$1.isStringLiteral(node)) parseStringLiteral(cmp, node);
-		node.forEachChild((child) => visitComponentChildNode(child, ctx));
+		node.forEachChild(visitComponentChildNode);
 	};
-	visitComponentChildNode(cmpNode, buildCtx);
+	visitComponentChildNode(cmpNode);
 	parseClassMethods(classMethods, cmp);
 	cmp.hasModernPropertyDecls = detectModernPropDeclarations(cmpNode) || doesExtend;
 	cmp.htmlAttrNames = unique(cmp.htmlAttrNames);
@@ -15464,31 +15464,32 @@ const parseStaticComponentMeta = (compilerCtx, typeChecker, cmpNode, moduleFile,
 	return cmpNode;
 };
 /**
-* Check whether a class declaration is a Stencil component, i.e. it's
-* decorated with `@Component({ tag: ... })`.
-* @param classNode the class declaration to check
-* @returns whether `classNode` is a Stencil component class
+* Warn about members a Stencil component class should not define.
+* @param cmpNode the component class declaration
+* @param buildCtx the current build context, used to surface diagnostics
 */
-const isStencilComponentClass = (classNode) => {
-	const decorator = ts$1.getDecorators(classNode)?.[0];
-	return decorator != null && ts$1.isCallExpression(decorator.expression) && decorator.expression.arguments.length === 1 && ts$1.isObjectLiteralExpression(decorator.expression.arguments[0]) && decorator.expression.arguments[0].properties.some((prop) => ts$1.isPropertyAssignment(prop) && prop.name.getText() === "tag");
-};
-const validateComponentMembers = (node, buildCtx) => {
-	/**
-	* validate if:
-	*/
-	if (ts$1.isGetAccessorDeclaration(node) && ts$1.isIdentifier(node.name) && typeof node.name.escapedText === "string" && BLACKLISTED_COMPONENT_METHODS.includes(node.name.escapedText) && node.parent && ts$1.isClassDeclaration(node.parent) && isStencilComponentClass(node.parent)) {
-		const propName = node.name.escapedText;
-		const componentName = node.parent.name.getText();
-		const err = buildWarn(buildCtx.diagnostics);
-		err.messageText = `The component "${componentName}" has a getter called "${propName}". This getter is reserved for use by Stencil components and should not be defined by the user.`;
-		augmentDiagnosticWithNode(err, node);
-	}
-	if (ts$1.isMethodDeclaration(node) && ts$1.isIdentifier(node.name) && node.name.escapedText === "componentShouldUpdate" && node.parameters.length > 1 && node.parent && ts$1.isClassDeclaration(node.parent) && isStencilComponentClass(node.parent)) {
-		const componentName = node.parent.name.getText();
-		const err = buildWarn(buildCtx.diagnostics);
-		err.messageText = `The component "${componentName}" defines "componentShouldUpdate" with ${node.parameters.length} parameters. As of Stencil v5, "componentShouldUpdate" is called once per render with a single "changes" argument (a map of prop/state names to "{ newVal, oldVal }") instead of once per prop with "(newVal, oldVal, propName)". This method will still compile, but any extra parameters will be "undefined" at runtime.`;
-		augmentDiagnosticWithNode(err, node);
+const validateComponentMembers = (cmpNode, buildCtx) => {
+	const componentName = cmpNode.name?.text ?? "";
+	for (const member of cmpNode.members) {
+		if (!member.name || !ts$1.isIdentifier(member.name)) continue;
+		const memberName = member.name.text;
+		/**
+		* the component has a getter called "shadowRoot"
+		*/
+		if (ts$1.isGetAccessorDeclaration(member) && BLACKLISTED_COMPONENT_METHODS.includes(memberName)) {
+			const err = buildWarn(buildCtx.diagnostics);
+			err.messageText = `The component "${componentName}" has a getter called "${memberName}". This getter is reserved for use by Stencil components and should not be defined by the user.`;
+			augmentDiagnosticWithNode(err, ts$1.getOriginalNode(member));
+		}
+		/**
+		* the component defines a "componentShouldUpdate" method with more than one parameter,
+		* which was the pre-v5 per-prop signature "(newVal, oldVal, propName)"
+		*/
+		if (ts$1.isMethodDeclaration(member) && memberName === "componentShouldUpdate" && member.parameters.length > 1) {
+			const err = buildWarn(buildCtx.diagnostics);
+			err.messageText = `The component "${componentName}" defines "componentShouldUpdate" with ${member.parameters.length} parameters. As of Stencil v5, "componentShouldUpdate" is called once per render with a single "changes" argument (a map of prop/state names to "{ newVal, oldVal }") instead of once per prop with "(newVal, oldVal, propName)". This method will still compile, but any extra parameters will be "undefined" at runtime.`;
+			augmentDiagnosticWithNode(err, ts$1.getOriginalNode(member));
+		}
 	}
 };
 const parseVirtualProps = (docs) => {

package/dist/compiler/index.mjs

@@ -1,3 +1,3 @@
-import { A as version, C as hasStencilHydrateImport, D as parseCssOnlyComponents, E as replaceStencilHydrateImport, M as scopeCss, O as buildId, S as hasStencilGlobalsImport, T as replaceStencilGlobalsImport, _ as cmpMetaToDocsComponent, a as createPrerenderer, b as buildHydrateCss, c as createWorkerContext, d as nodeRequire, f as optimizeCss, g as generateManifest, h as generateComponentTypesFile, i as createSystem, j as versions, k as vermoji, l as createWorkerMessageHandler, m as validateHydrated, n as transpile, o as loadConfig, p as validateConfig, r as transpileSync, s as createCompiler, t as ts, u as optimizeJs, v as getScopeId, w as replaceStencilCssComponentsImport, x as hasStencilCssComponentsImport, y as foldBuildFlags } from "../compiler-CUsOl_Kw.mjs";
+import { A as version, C as hasStencilHydrateImport, D as parseCssOnlyComponents, E as replaceStencilHydrateImport, M as scopeCss, O as buildId, S as hasStencilGlobalsImport, T as replaceStencilGlobalsImport, _ as cmpMetaToDocsComponent, a as createPrerenderer, b as buildHydrateCss, c as createWorkerContext, d as nodeRequire, f as optimizeCss, g as generateManifest, h as generateComponentTypesFile, i as createSystem, j as versions, k as vermoji, l as createWorkerMessageHandler, m as validateHydrated, n as transpile, o as loadConfig, p as validateConfig, r as transpileSync, s as createCompiler, t as ts, u as optimizeJs, v as getScopeId, w as replaceStencilCssComponentsImport, x as hasStencilCssComponentsImport, y as foldBuildFlags } from "../compiler-ApS_Tn_4.mjs";
 import { a as LOG_LEVELS, i as CustomElementsExportBehaviorOptions } from "../node-Bz2SOK7_.mjs";
 export { CustomElementsExportBehaviorOptions, LOG_LEVELS, buildHydrateCss, buildId, cmpMetaToDocsComponent, createCompiler, createPrerenderer, createSystem, createWorkerContext, createWorkerMessageHandler, foldBuildFlags, generateComponentTypesFile, generateManifest, getScopeId, hasStencilCssComponentsImport, hasStencilGlobalsImport, hasStencilHydrateImport, loadConfig, nodeRequire, optimizeCss, optimizeJs, parseCssOnlyComponents, replaceStencilCssComponentsImport, replaceStencilGlobalsImport, replaceStencilHydrateImport, scopeCss, transpile, transpileSync, ts, validateConfig, validateHydrated, vermoji, version, versions };

package/dist/{compiler-CUsOl_Kw.mjs → compiler-ApS_Tn_4.mjs}

@@ -461,9 +461,9 @@ const scopeCss = (cssText, scopeId, commentOriginalSelector) => {
 };
 //#endregion
 //#region src/version.ts
-const version = "5.0.0-beta.20";
-const buildId = "1791812865";
-const vermoji = "🚕";
+const version = "5.0.0-beta.21";
+const buildId = "1791840744";
+const vermoji = "🍎";
 /**
 * Get the installed version of a tool/dependency.
 * Handles packages with exports maps that point to subdirectories.
@@ -12778,11 +12778,9 @@ const generateSsrFactory = async (config, compilerCtx, buildCtx) => {
 				format: "cjs",
 				esModule: false,
 				strict: false,
-				intro: SSR_FACTORY_INTRO,
-				outro: SSR_FACTORY_OUTRO,
 				codeSplitting: false
 			});
-			if (!buildCtx.hasError && rolldownOutput != null && Array.isArray(rolldownOutput.output)) return rolldownOutput.output[0].code;
+			if (!buildCtx.hasError && rolldownOutput != null && Array.isArray(rolldownOutput.output)) return SSR_FACTORY_INTRO + rolldownOutput.output[0].code + SSR_FACTORY_OUTRO;
 		}
 	} catch (e) {
 		catchError(buildCtx.diagnostics, e);
@@ -18174,13 +18172,13 @@ const parseStaticComponentMeta = (compilerCtx, typeChecker, cmpNode, moduleFile,
 		hasPatchClone: false,
 		hasPatchInsert: false
 	};
-	const visitComponentChildNode = (node, ctx) => {
-		validateComponentMembers(node, ctx);
+	if (!isCollectionDependency) validateComponentMembers(cmpNode, buildCtx);
+	const visitComponentChildNode = (node) => {
 		if (ts.isCallExpression(node)) parseCallExpression(cmp, node, typeChecker);
 		else if (ts.isStringLiteral(node)) parseStringLiteral(cmp, node);
-		node.forEachChild((child) => visitComponentChildNode(child, ctx));
+		node.forEachChild(visitComponentChildNode);
 	};
-	visitComponentChildNode(cmpNode, buildCtx);
+	visitComponentChildNode(cmpNode);
 	parseClassMethods(classMethods, cmp);
 	cmp.hasModernPropertyDecls = detectModernPropDeclarations(cmpNode) || doesExtend;
 	cmp.htmlAttrNames = unique(cmp.htmlAttrNames);
@@ -18198,31 +18196,32 @@ const parseStaticComponentMeta = (compilerCtx, typeChecker, cmpNode, moduleFile,
 	return cmpNode;
 };
 /**
-* Check whether a class declaration is a Stencil component, i.e. it's
-* decorated with `@Component({ tag: ... })`.
-* @param classNode the class declaration to check
-* @returns whether `classNode` is a Stencil component class
+* Warn about members a Stencil component class should not define.
+* @param cmpNode the component class declaration
+* @param buildCtx the current build context, used to surface diagnostics
 */
-const isStencilComponentClass = (classNode) => {
-	const decorator = ts.getDecorators(classNode)?.[0];
-	return decorator != null && ts.isCallExpression(decorator.expression) && decorator.expression.arguments.length === 1 && ts.isObjectLiteralExpression(decorator.expression.arguments[0]) && decorator.expression.arguments[0].properties.some((prop) => ts.isPropertyAssignment(prop) && prop.name.getText() === "tag");
-};
-const validateComponentMembers = (node, buildCtx) => {
-	/**
-	* validate if:
-	*/
-	if (ts.isGetAccessorDeclaration(node) && ts.isIdentifier(node.name) && typeof node.name.escapedText === "string" && BLACKLISTED_COMPONENT_METHODS.includes(node.name.escapedText) && node.parent && ts.isClassDeclaration(node.parent) && isStencilComponentClass(node.parent)) {
-		const propName = node.name.escapedText;
-		const componentName = node.parent.name.getText();
-		const err = buildWarn(buildCtx.diagnostics);
-		err.messageText = `The component "${componentName}" has a getter called "${propName}". This getter is reserved for use by Stencil components and should not be defined by the user.`;
-		augmentDiagnosticWithNode(err, node);
-	}
-	if (ts.isMethodDeclaration(node) && ts.isIdentifier(node.name) && node.name.escapedText === "componentShouldUpdate" && node.parameters.length > 1 && node.parent && ts.isClassDeclaration(node.parent) && isStencilComponentClass(node.parent)) {
-		const componentName = node.parent.name.getText();
-		const err = buildWarn(buildCtx.diagnostics);
-		err.messageText = `The component "${componentName}" defines "componentShouldUpdate" with ${node.parameters.length} parameters. As of Stencil v5, "componentShouldUpdate" is called once per render with a single "changes" argument (a map of prop/state names to "{ newVal, oldVal }") instead of once per prop with "(newVal, oldVal, propName)". This method will still compile, but any extra parameters will be "undefined" at runtime.`;
-		augmentDiagnosticWithNode(err, node);
+const validateComponentMembers = (cmpNode, buildCtx) => {
+	const componentName = cmpNode.name?.text ?? "";
+	for (const member of cmpNode.members) {
+		if (!member.name || !ts.isIdentifier(member.name)) continue;
+		const memberName = member.name.text;
+		/**
+		* the component has a getter called "shadowRoot"
+		*/
+		if (ts.isGetAccessorDeclaration(member) && BLACKLISTED_COMPONENT_METHODS.includes(memberName)) {
+			const err = buildWarn(buildCtx.diagnostics);
+			err.messageText = `The component "${componentName}" has a getter called "${memberName}". This getter is reserved for use by Stencil components and should not be defined by the user.`;
+			augmentDiagnosticWithNode(err, ts.getOriginalNode(member));
+		}
+		/**
+		* the component defines a "componentShouldUpdate" method with more than one parameter,
+		* which was the pre-v5 per-prop signature "(newVal, oldVal, propName)"
+		*/
+		if (ts.isMethodDeclaration(member) && memberName === "componentShouldUpdate" && member.parameters.length > 1) {
+			const err = buildWarn(buildCtx.diagnostics);
+			err.messageText = `The component "${componentName}" defines "componentShouldUpdate" with ${member.parameters.length} parameters. As of Stencil v5, "componentShouldUpdate" is called once per render with a single "changes" argument (a map of prop/state names to "{ newVal, oldVal }") instead of once per prop with "(newVal, oldVal, propName)". This method will still compile, but any extra parameters will be "undefined" at runtime.`;
+			augmentDiagnosticWithNode(err, ts.getOriginalNode(member));
+		}
 	}
 };
 const parseVirtualProps = (docs) => {

package/dist/sys/node/worker.mjs

@@ -1,4 +1,4 @@
-import { l as createWorkerMessageHandler } from "../../compiler-CUsOl_Kw.mjs";
+import { l as createWorkerMessageHandler } from "../../compiler-ApS_Tn_4.mjs";
 import { t as createNodeSys } from "../../node-Bz2SOK7_.mjs";
 //#region src/sys/node/node-worker-thread.ts
 /**

package/dist/testing/index.mjs

@@ -33,7 +33,7 @@ import "@rollup/pluginutils";
 import { createHash } from "crypto";
 import { afterAll, vi } from "vitest";
 //#region src/version.ts
-const version = "5.0.0-beta.20";
+const version = "5.0.0-beta.21";
 const MEMBER_FLAGS = {
 	String: 1,
 	Number: 2,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stencil/core",
-  "version": "5.0.0-beta.20",
+  "version": "5.0.0-beta.21",
   "description": "A Compiler for Web Components and Progressive Web Apps",
   "keywords": [
     "components",
@@ -126,9 +126,9 @@
     "terser": "^5.50.0",
     "tinyglobby": "^0.2.17",
     "typescript": ">5.0.0 <7.0.0",
-    "@stencil/cli": "5.0.0-beta.20",
-    "@stencil/mock-doc": "5.0.0-beta.20",
-    "@stencil/dev-server": "5.0.0-beta.20"
+    "@stencil/cli": "5.0.0-beta.21",
+    "@stencil/mock-doc": "5.0.0-beta.21",
+    "@stencil/dev-server": "5.0.0-beta.21"
   },
   "devDependencies": {
     "@ionic/prettier-config": "^4.0.0",