@stencil/angular-output-target 1.4.0 → 1.4.1

package/dist/wizard.d.ts

@@ -4,6 +4,6 @@ export declare const wizard: {
         id: string;
         displayName: string;
         description: string;
-        run({ config, workspaceRoot, prompts, nypm }: WizardContext): Promise<void>;
+        run({ config, workspaceRoot, prompts, nypm, openStencilConfig }: WizardContext): Promise<void>;
     };
 };

package/dist/wizard.js

@@ -1,54 +1,6 @@
-import { Project, SyntaxKind } from 'ts-morph';
 import { access, mkdir, readFile, writeFile } from 'node:fs/promises';
 import { join, relative, dirname } from 'node:path';
 // ---------------------------------------------------------------------------
-// ts-morph helpers
-// ---------------------------------------------------------------------------
-function amendStencilConfig(configPath, targetCode) {
-    const project = new Project({ skipAddingFilesFromTsConfig: true });
-    const src = project.addSourceFileAtPath(configPath);
-    if (!src.getImportDeclaration('@stencil/angular-output-target')) {
-        src.addImportDeclaration({
-            moduleSpecifier: '@stencil/angular-output-target',
-            namedImports: ['angularOutputTarget'],
-        });
-    }
-    const existingProp = src
-        .getDescendantsOfKind(SyntaxKind.PropertyAssignment)
-        .find((p) => p.getName() === 'outputTargets');
-    if (!existingProp) {
-        const configObj = src.getVariableDeclaration('config')?.getInitializerIfKind(SyntaxKind.ObjectLiteralExpression) ??
-            src
-                .getDescendantsOfKind(SyntaxKind.ObjectLiteralExpression)
-                .find((obj) => obj.getProperty('namespace') !== undefined);
-        if (!configObj)
-            throw new Error('Could not find Stencil config object in stencil.config.ts');
-        configObj.addPropertyAssignment({ name: 'outputTargets', initializer: '[]' });
-    }
-    const prop = src.getDescendantsOfKind(SyntaxKind.PropertyAssignment).find((p) => p.getName() === 'outputTargets');
-    const arr = prop.getInitializerIfKind(SyntaxKind.ArrayLiteralExpression);
-    if (!arr)
-        throw new Error('outputTargets is not an array literal in stencil.config.ts');
-    const existing = arr.getText();
-    const alreadyAdded = existing.includes('angularOutputTarget(');
-    // Filter out any existing angularOutputTarget call so it can be replaced cleanly
-    const elements = arr
-        .getElements()
-        .map((e) => e.getText().trim())
-        .filter((e) => !e.includes('angularOutputTarget('));
-    const hasStandalone = existing.includes("type: 'standalone'") ||
-        existing.includes('type: "standalone"') ||
-        existing.includes("type: 'dist-custom-elements'") ||
-        existing.includes('type: "dist-custom-elements"');
-    if (!hasStandalone)
-        elements.push("{ type: 'standalone' }");
-    elements.push(targetCode);
-    prop.setInitializer(`[\n${elements.map((e) => `  ${e}`).join(',\n')},\n]`);
-    src.formatText();
-    src.saveSync();
-    return !alreadyAdded;
-}
-// ---------------------------------------------------------------------------
 // pnpm build approval
 // ---------------------------------------------------------------------------
 async function allowPnpmBuild(pkg, rootDir, workspaceRoot) {
@@ -194,19 +146,12 @@ export const wizard = {
         id: '@stencil/angular-output-target',
         displayName: 'Angular',
         description: 'Angular component wrappers for your Stencil components',
-        async run({ config, workspaceRoot, prompts, nypm }) {
+        async run({ config, workspaceRoot, prompts, nypm, openStencilConfig }) {
             const { intro, outro, text, select, confirm, spinner, isCancel, cancel, log } = prompts;
             intro('Angular output target');
-            const stencilConfigPath = join(config.rootDir, 'stencil.config.ts');
             // Guard: already configured?
-            const guardProject = new Project({ skipAddingFilesFromTsConfig: true });
-            const alreadyConfigured = guardProject
-                .addSourceFileAtPath(stencilConfigPath)
-                .getDescendantsOfKind(SyntaxKind.PropertyAssignment)
-                .find((p) => p.getName() === 'outputTargets')
-                ?.getInitializerIfKind(SyntaxKind.ArrayLiteralExpression)
-                ?.getText()
-                .includes('angularOutputTarget(');
+            const editor = await openStencilConfig();
+            const alreadyConfigured = editor.outputTargetsContains('angularOutputTarget(');
             if (alreadyConfigured) {
                 const redo = await confirm({
                     message: 'angularOutputTarget is already in stencil.config.ts — reconfigure?',
@@ -219,18 +164,21 @@ export const wizard = {
             }
             // Where should the wrapper package live?
             let wrapperDir;
-            const defaultName = `${config.fsNamespace}-angular`;
+            let wrapperPackageName = `${config.fsNamespace}-angular`;
             if (workspaceRoot) {
                 const rawName = await text({
                     message: 'Wrapper package name?',
-                    placeholder: defaultName,
-                    defaultValue: defaultName,
+                    placeholder: wrapperPackageName,
+                    defaultValue: wrapperPackageName,
                 });
                 if (isCancel(rawName)) {
                     cancel('Setup cancelled.');
                     return;
                 }
-                wrapperDir = join(dirname(config.rootDir), rawName);
+                wrapperPackageName = rawName;
+                // Directory is already namespaced by living under packages/, so keep it
+                // short rather than repeating the fsNamespace prefix from the package name.
+                wrapperDir = join(dirname(config.rootDir), 'angular');
             }
             else {
                 const defaultRel = `../${config.fsNamespace}-angular`;
@@ -271,8 +219,15 @@ export const wizard = {
                 const s = spinner();
                 s.start(`Scaffolding wrapper package at ${relative(workspaceRoot ?? config.rootDir, wrapperDir)}`);
                 try {
-                    const corePkgVersion = workspaceRoot ? 'workspace:*' : `file:${relative(wrapperDir, config.rootDir)}`;
-                    await scaffoldWrapperPackage(wrapperDir, `${config.fsNamespace}-angular`, componentCorePackage, corePkgVersion, config.fsNamespace, selectedOutputType);
+                    // workspace:* only resolves under pnpm/yarn-berry/bun — npm and yarn classic reject
+                    // the protocol outright (even for devDependencies that are never installed), so only
+                    // use it when the detected package manager actually understands it.
+                    const pm = workspaceRoot ? await nypm.detectPackageManager(workspaceRoot) : undefined;
+                    const supportsWorkspaceProtocol = pm?.name === 'pnpm' || pm?.name === 'bun' || (pm?.name === 'yarn' && pm.majorVersion !== '1');
+                    const corePkgVersion = supportsWorkspaceProtocol
+                        ? 'workspace:*'
+                        : `file:${relative(wrapperDir, config.rootDir)}`;
+                    await scaffoldWrapperPackage(wrapperDir, wrapperPackageName, componentCorePackage, corePkgVersion, config.fsNamespace, selectedOutputType);
                     s.stop('Wrapper package scaffolded');
                 }
                 catch (e) {
@@ -301,10 +256,20 @@ export const wizard = {
                 ...(selectedOutputType !== 'standalone' ? [`outputType: '${selectedOutputType}'`] : []),
             ];
             const targetCode = `angularOutputTarget({\n  ${lines.join(',\n  ')},\n})`;
-            // Amend stencil.config.ts in one pass so formatText() sees the final array
+            // Amend stencil.config.ts
             try {
-                const added = amendStencilConfig(stencilConfigPath, targetCode);
-                log.success(added ? 'stencil.config.ts updated' : 'angularOutputTarget already present — no changes made');
+                editor.addImport('@stencil/angular-output-target', ['angularOutputTarget']);
+                const hasStandalone = editor.outputTargetsContains("type: 'standalone'") ||
+                    editor.outputTargetsContains('type: "standalone"') ||
+                    editor.outputTargetsContains("type: 'dist-custom-elements'") ||
+                    editor.outputTargetsContains('type: "dist-custom-elements"');
+                if (!hasStandalone)
+                    editor.addOutputTarget("{ type: 'standalone' }");
+                if (!editor.replaceOutputTarget('angularOutputTarget(', targetCode)) {
+                    editor.addOutputTarget(targetCode);
+                }
+                await editor.save();
+                log.success('stencil.config.ts updated');
             }
             catch (e) {
                 log.warn(`Could not automatically update stencil.config.ts (${e}). Add manually:\n\n` +

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stencil/angular-output-target",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Angular output target for @stencil/core components.",
   "main": "dist/index.cjs",
   "module": "dist/index.js",
@@ -55,23 +55,21 @@
   "bugs": {
     "url": "https://github.com/stenciljs/output-targets/issues"
   },
-  "dependencies": {
-    "ts-morph": "^28.0.0"
-  },
   "devDependencies": {
-    "@stencil/cli": "^5.0.0 || >=5.0.0-alpha.0 <5.0.0-next.0",
     "@angular/core": "8.2.14",
     "@angular/forms": "8.2.14",
+    "@stencil/cli": "^5.0.0 || >=5.0.0-alpha.17 <5.0.0-next.0",
     "@stencil/core": "4.41.0",
-    "@types/node": "^18.0.0",
-    "npm-run-all2": "^6.2.4",
-    "rimraf": "^5.0.0",
-    "rollup": "^2.23.1",
-    "typescript": "~5.7.0",
-    "vitest": "^2.1.4"
+    "@types/node": "^18.19.130",
+    "npm-run-all2": "^6.2.6",
+    "rimraf": "^5.0.10",
+    "rollup": "^2.80.0",
+    "stencil-output-targets-shared": "workspace:*",
+    "typescript": "~5.7.3",
+    "vitest": "^2.1.9"
   },
   "peerDependencies": {
-    "@stencil/core": ">=2.0.0 || >=3 || >=4.0.0 || ^5.0.0 || >=5.0.0-alpha.0 <5.0.0-next.0"
+    "@stencil/core": ">=2.0.0 || >=3 || >=4.0.0 || ^5.0.0 || >=5.0.0-alpha.17 <5.0.0-next.0"
   },
   "gitHead": "a3588e905186a0e86e7f88418fd5b2f9531b55e0"
 }