@stellar/typescript-wallet-sdk 5.0.0-beta.1788566740000 → 5.0.0

package/CHANGELOG.MD

@@ -20,6 +20,7 @@
 ### Fixed
 * SEP-7 signatures and transaction URIs are correctly base64-encoded. Under stellar-sdk v17 the previous `Buffer`-era code produced comma-joined decimals, which made a signed `Sep7Tx` URI unparseable
 * The SEP-10 `client_domain` integrity check compares transaction hashes correctly again — it used `Buffer#equals`, which does not exist on `Uint8Array`
+* `Watcher` treats `on_hold` as a transient status. `TransactionStatus.on_hold` documents itself as a temporary state — an anchor holding a transfer for review, after which "transaction should follow the regular flow" — but neither watcher recognised it as in progress. `watchOneTransaction` fell through to its terminal branch and invoked `onError` before stopping its poll, so a transfer merely awaiting a compliance check was reported to the caller as a failure and then abandoned; `watchAllTransactions` filed it in the ignored registry and omitted it from the first poll entirely. Both now treat it like `incomplete` and the `pending_*` statuses, so the transaction keeps being watched and surfaces through `onMessage` until it reaches a genuinely final status (#251)
 
 ### Known limitations
 * SEP-12 binary upload (`Customer.add`/`update` with `sep9BinaryInfo`) is not usable on React Native. axios's `toFormData` takes a `Buffer.from(value)` path for typed-array values whenever `FormData` is not spec-compliant, which is the case on React Native. That path was already non-functional there — React Native's `FormData.append` cannot consume a `Buffer` part — so this is a change of failure mode, not of capability: with the polyfill removed it now raises `ReferenceError` instead of producing silent garbage. Browsers and Node.js are unaffected

package/lib/bundle.js

@@ -6573,7 +6573,8 @@ var Watcher = /** @class */ (function () {
             try {
                 var newTransactions = transactions.filter(function (transaction) {
                     var isInProgress = transaction.status.indexOf("pending") === 0 ||
-                        transaction.status === Types_1.TransactionStatus.incomplete;
+                        transaction.status === Types_1.TransactionStatus.incomplete ||
+                        transaction.status === Types_1.TransactionStatus.on_hold;
                     var registeredTransaction = _this._transactionsRegistry[assetCode][transaction.id];
                     // if this is the first watch, only keep the pending ones
                     if (!isRetry) {
@@ -6659,7 +6660,7 @@ var Watcher = /** @class */ (function () {
     };
     /**
      * Watch a transaction until it stops pending. Takes three callbacks:
-     * * onMessage - When the transaction comes back as pending_ or incomplete.
+     * * onMessage - When the transaction comes back as pending_, incomplete, or on_hold.
      * * onSuccess - When the transaction comes back as completed / refunded / expired.
      * * onError - When there's a runtime error, or the transaction comes back as
      * no_market / too_small / too_large / error.
@@ -6731,7 +6732,8 @@ var Watcher = /** @class */ (function () {
             }
             _this._transactionsRegistry[assetCode][transaction.id] = transaction;
             if (transaction.status.indexOf("pending") === 0 ||
-                transaction.status === Types_1.TransactionStatus.incomplete) {
+                transaction.status === Types_1.TransactionStatus.incomplete ||
+                transaction.status === Types_1.TransactionStatus.on_hold) {
                 if (_this._oneTransactionWatcher[assetCode][id]) {
                     clearTimeout(_this._oneTransactionWatcher[assetCode][id]);
                 }