@stellar/typescript-wallet-sdk 4.0.0 → 5.0.0-beta.1788566740000

package/lib/walletSdk/Customer/index.d.ts

@@ -41,12 +41,12 @@ export declare class Sep12 {
     getCustomer(params: GetCustomerParams): Promise<GetCustomerResponse>;
     /**
      * Add a new customer. Customer info is given in sep9Info param. If it
-     * is binary type (eg. Buffer of an image) include it in sep9BinaryInfo.
+     * is binary type (eg. Uint8Array of an image) include it in sep9BinaryInfo.
      * @param {AddCustomerParams} params - The parameters for adding a customer.
      * @param {CustomerInfoMap} [params.sep9Info] - Customer information. What fields you should
      * give is indicated by the anchor.
      * @param {CustomerBinaryInfoMap} [params.sep9BinaryInfo] - Customer information that is in binary
-     * format (eg. Buffer of an image).
+     * format (eg. Uint8Array of an image).
      * @param {string} [params.type] - The type of the customer.
      * @param {string} [params.memo] - A memo associated with the customer.
      * @param {string} [params.transactionId] - The id of the transaction that the customer is
@@ -56,12 +56,12 @@ export declare class Sep12 {
     add({ sep9Info, sep9BinaryInfo, type, memo, transactionId, }: AddCustomerParams): Promise<AddCustomerResponse>;
     /**
      * Updates an existing customer. Customer info is given in sep9Info param. If it
-     * is binary type (eg. Buffer of an image) include it in sep9BinaryInfo.
+     * is binary type (eg. Uint8Array of an image) include it in sep9BinaryInfo.
      * @param {AddCustomerParams} params - The parameters for adding a customer.
      * @param {CustomerInfoMap} [params.sep9Info] - Customer information. What fields you should
      * give is indicated by the anchor.
      * @param {CustomerBinaryInfoMap} [params.sep9BinaryInfo] - Customer information that is in binary
-     * format (eg. Buffer of an image).
+     * format (eg. Uint8Array of an image).
      * @param {string} [params.id] - The id of the customer.
      * @param {string} [params.type] - The type of the customer.
      * @param {string} [params.memo] - A memo associated with the customer.

package/lib/walletSdk/Exceptions/index.d.ts

@@ -61,6 +61,9 @@ export declare class WithdrawalTxMissingMemoError extends Error {
 export declare class PathPayOnlyOneAmountError extends Error {
     constructor();
 }
+export declare class PathPayBoundRequiredError extends Error {
+    constructor(bound: "destMin" | "sendMax");
+}
 export declare class WithdrawalTxMemoError extends Error {
     constructor();
 }
@@ -115,9 +118,18 @@ export declare class NetworkPassphraseMismatchError extends Error {
 export declare class ChallengeTxnIncorrectSequenceError extends Error {
     constructor();
 }
+/**
+ * @deprecated No longer thrown. `Server.signChallengeTransaction` now validates
+ * challenges with `WebAuth.readChallengeTx` and reports every failure, including
+ * an invalid server signature, as `ChallengeValidationFailedError`. This class
+ * will be removed in the next major release.
+ */
 export declare class ChallengeTxnInvalidSignatureError extends Error {
     constructor();
 }
+export declare class ChallengeTxnClientAccountMismatchError extends Error {
+    constructor(expected: string, received: string);
+}
 export declare class AllowHttpOnNonTestnetError extends Error {
     constructor();
 }

package/lib/walletSdk/Horizon/AccountService.d.ts

@@ -1,4 +1,3 @@
-/// <reference types="node" />
 import { Horizon } from "@stellar/stellar-sdk";
 import { Config } from "../";
 import { SigningKeypair } from "./Account";
@@ -27,10 +26,10 @@ export declare class AccountService {
     /**
      * Generate new account keypair (public and secret key) from random bytes. This key pair can be
      * used to create a Stellar account.
-     * @param {Buffer} randomBytes - Random bytes to create keypair from.
+     * @param {Uint8Array} randomBytes - Random bytes to create keypair from.
      * @returns {SigningKeypair} Keypair capable of signing.
      */
-    createKeypairFromRandom(randomBytes: Buffer): SigningKeypair;
+    createKeypairFromRandom(randomBytes: Uint8Array): SigningKeypair;
     /**
      * Get account information from the Stellar network.
      * @param {object} params - The parameters for retrieving account information.

package/lib/walletSdk/Horizon/Transaction/TransactionBuilder.d.ts

@@ -55,19 +55,19 @@ export declare class TransactionBuilder extends CommonTransactionBuilder<Transac
      * @param {string} params.destinationAddress - The destination Stellar address to which the payment is sent.
      * @param {StellarAssetId} params.sendAsset - The asset to be sent.
      * @param {StellarAssetId} params.destAsset - The asset the destination will receive.
-     * @param {string} [params.sendAmount] - The amount to be sent. Must specify either sendAmount or destAmount,
-     * but not both.
-     * @param {string} [params.destAmount] - The amount to be received by the destination. Must specify either sendAmount or destAmount,
-     * but not both.
-     * @param {string} [params.destMin] - The minimum amount of the destination asset to be receive. This is a
-     * protective measure, it allows you to specify a lower bound for an acceptable conversion. Only used
-     * if using sendAmount.
-     * (optional, default is ".0000001").
-     * @param {string} [params.sendMax] - The maximum amount of the destination asset to be sent. This is a
-     * protective measure, it allows you to specify an upper bound for an acceptable conversion. Only used
-     * if using destAmount.
-     * (optional, default is int64 max).
+     * @param {string} [params.sendAmount] - The amount of the send asset to be sent. Must specify either
+     * sendAmount or destAmount, but not both. Requires destMin.
+     * @param {string} [params.destAmount] - The amount of the destination asset to be received by the
+     * destination. Must specify either sendAmount or destAmount, but not both. Requires sendMax.
+     * @param {string} [params.destMin] - The minimum amount of the destination asset to receive. Required
+     * when using sendAmount. This is the slippage limit for the conversion: the payment fails if it would
+     * deliver less than this amount, instead of executing at a worse rate.
+     * @param {string} [params.sendMax] - The maximum amount of the send asset to spend. Required when using
+     * destAmount. This is the slippage limit for the conversion: the payment fails if it would cost more
+     * than this amount, instead of executing at a worse rate.
      *
+     * @throws {PathPayOnlyOneAmountError} If both or neither of sendAmount and destAmount are given.
+     * @throws {PathPayBoundRequiredError} If destMin is missing for sendAmount, or sendMax for destAmount.
      * @returns {TransactionBuilder} - Returns the current TransactionBuilder instance for method chaining.
      */
     pathPay({ destinationAddress, sendAsset, destAsset, sendAmount, destAmount, destMin, sendMax, }: PathPayParams): TransactionBuilder;
@@ -77,10 +77,13 @@ export declare class TransactionBuilder extends CommonTransactionBuilder<Transac
      * @param {StellarAssetId} fromAsset - The source asset to be sent.
      * @param {StellarAssetId} toAsset - The destination asset to receive.
      * @param {string} amount - The amount of the source asset to be sent.
-     * @param {string} [destMin] - (Optional) The minimum amount of the destination asset to be received.
+     * @param {string} destMin - The minimum amount of the destination asset to receive. This is the
+     * slippage limit for the swap: it fails if the conversion would deliver less than this amount,
+     * instead of executing at a worse rate.
+     * @throws {PathPayBoundRequiredError} If destMin is missing.
      * @returns {TransactionBuilder} Returns the current instance of the TransactionBuilder for method chaining.
      */
-    swap(fromAsset: StellarAssetId, toAsset: StellarAssetId, amount: string, destMin?: string): TransactionBuilder;
+    swap(fromAsset: StellarAssetId, toAsset: StellarAssetId, amount: string, destMin: string): TransactionBuilder;
     /**
      * Adds an operation to the transaction.
      * @param {xdr.Operation} op - The operation to add.

package/lib/walletSdk/Server/index.d.ts

@@ -5,14 +5,30 @@
 import { SignChallengeTxnParams, SignChallengeTxnResponse, AnchorTransaction } from "../Types";
 /**
  * Helper method for signing a SEP-10 challenge transaction if valid.
+ *
+ * The challenge is validated with `WebAuth.readChallengeTx` from
+ * `@stellar/stellar-sdk` — the same validator used by `Sep10.sign()` — which
+ * checks the full SEP-10 structure and binds the challenge to the expected
+ * anchor: the transaction source must be the anchor's `SIGNING_KEY`, the
+ * `<home domain> auth` operation must match the expected home domain, and any
+ * `web_auth_domain` operation must match the host of the anchor's
+ * `WEB_AUTH_ENDPOINT` (falling back to `anchorDomain` when the TOML omits it).
+ * The client account the challenge was issued for is then checked against
+ * `accountKp`, so this helper only signs challenges meant for it. Muxed client
+ * accounts are supported: the comparison is made on the underlying `G...`
+ * address, since that is the key that signs. The muxed id itself is not pinned
+ * — a caller that needs to bind a specific subaccount should check the
+ * challenge's client account itself.
+ *
  * @param {SignChallengeTxnParams} params - The Authentication params.
  * @param {AccountKeypair} params.accountKp - Keypair for the Stellar account signing the transaction.
  * @param {string} [params.challengeTx] - The challenge transaction given by an anchor for authentication.
  * @param {string} [params.networkPassphrase] - The network passphrase for the network authenticating on.
  * @param {string} [params.anchorDomain] - Domain hosting stellar.toml file containing `SIGNING_KEY`.
+ * @param {string|string[]} [params.homeDomain] - Expected home domain(s) of the challenge. Defaults to `anchorDomain`.
  * @returns {Promise<SignChallengeTxnResponse>} The signed transaction.
  */
-export declare const signChallengeTransaction: ({ accountKp, challengeTx, networkPassphrase, anchorDomain, }: SignChallengeTxnParams) => Promise<SignChallengeTxnResponse>;
+export declare const signChallengeTransaction: ({ accountKp, challengeTx, networkPassphrase, anchorDomain, homeDomain, }: SignChallengeTxnParams) => Promise<SignChallengeTxnResponse>;
 /**
  * Helper method for parsing a JSON string into an AnchorTransaction.
  * @param {string} transaction - The json string of an anchor transaction.

package/lib/walletSdk/Types/auth.d.ts

@@ -54,6 +54,11 @@ export type SignChallengeTxnParams = {
     challengeTx: string;
     networkPassphrase: string;
     anchorDomain: string;
+    /**
+     * The home domain(s) the challenge is expected to be scoped to. Defaults to
+     * `anchorDomain`. Pass an array for anchors that serve multiple home domains.
+     */
+    homeDomain?: string | string[];
 };
 export type SignChallengeTxnResponse = {
     transaction: XdrEncodedTransaction;

package/lib/walletSdk/Types/horizon.d.ts

@@ -37,9 +37,15 @@ export type PathPayParams = {
     destinationAddress: string;
     sendAsset: StellarAssetId;
     destAsset: StellarAssetId;
-    sendAmount?: string;
-    destAmount?: string;
-    destMin?: string;
-    sendMax?: string;
-};
+} & ({
+    sendAmount: string;
+    destMin: string;
+    destAmount?: never;
+    sendMax?: never;
+} | {
+    destAmount: string;
+    sendMax: string;
+    sendAmount?: never;
+    destMin?: never;
+});
 export type CommonBuilder = TransactionBuilder | SponsoringBuilder;

package/lib/walletSdk/Types/sep12.d.ts

@@ -1,9 +1,8 @@
-/// <reference types="node" />
 export type CustomerInfoMap = {
     [key: string]: string;
 };
 export type CustomerBinaryInfoMap = {
-    [key: string]: Buffer;
+    [key: string]: Uint8Array;
 };
 export declare enum Sep12Status {
     ACCEPTED = "ACCEPTED",

package/lib/walletSdk/Uri/Sep7Base.d.ts

@@ -180,7 +180,7 @@ export declare abstract class Sep7Base {
      *
      * @see https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0007.md#request-signing
      *
-     * @returns {Buffer} array of bytes to be signed with given keypair on
+     * @returns {Uint8Array} array of bytes to be signed with given keypair on
      * the 'addSignature' method.
      */
     private createSignaturePayload;

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "@stellar/typescript-wallet-sdk",
-  "version": "4.0.0",
+  "version": "5.0.0-beta.1788566740000",
   "engines": {
-    "node": ">=22"
+    "node": ">=22.12.0"
   },
   "browser": "./lib/bundle_browser.js",
   "main": "./lib/bundle.js",
@@ -16,6 +16,7 @@
     "@stellar/tsconfig": "^1.0.2",
     "@types/jest": "^29.4.0",
     "@types/lodash": "^4.14.194",
+    "@types/node": "^22.10.2",
     "@types/sinon": "^10.0.15",
     "@typescript-eslint/eslint-plugin": "^6.7.5",
     "@typescript-eslint/parser": "^6.7.5",
@@ -41,22 +42,22 @@
     "ts-loader": "^9.4.2",
     "ts-node": "^10.9.1",
     "tslib": "^2.5.0",
-    "typescript": "^5.0.4",
+    "typescript": "^5.7.3",
     "webpack": "^5.83.1",
     "webpack-cli": "^5.1.1"
   },
   "dependencies": {
     "@stablelib/base64": "^2.0.0",
     "@stablelib/utf8": "^2.0.0",
-    "@stellar/stellar-sdk": "16.2.0",
+    "@stellar/stellar-sdk": "17.0.1",
     "axios": "^1.4.0",
-    "base64url": "^3.0.1",
     "https-browserify": "^1.0.0",
     "jws": "^4.0.0",
     "lodash": "^4.17.21",
     "query-string": "^7.1.3",
     "stream-http": "^3.2.0",
     "tweetnacl": "^1.0.3",
+    "uint8array-extras": "^1.5.0",
     "url": "^0.11.0",
     "util": "^0.12.5",
     "utility-types": "^3.10.0",
@@ -76,4 +77,4 @@
     "example:sep24": "ts-node examples/sep24/sep24.ts",
     "example:sep12": "ts-node examples/sep12/sep12.ts"
   }
-}
+}

package/src/walletSdk/Auth/AuthHeaderSigner.ts

@@ -2,7 +2,7 @@ import { AxiosInstance } from "axios";
 import { encode as utf8Encode } from "@stablelib/utf8";
 import { StrKey } from "@stellar/stellar-sdk";
 import nacl from "tweetnacl";
-import base64url from "base64url";
+import { stringToUint8Array, uint8ArrayToBase64 } from "uint8array-extras";
 
 import { SigningKeypair } from "../Horizon/Account";
 import { DefaultClient } from "../";
@@ -62,15 +62,21 @@ export class DefaultAuthHeaderSigner implements AuthHeaderSigner {
 
     // encode JWT message
     const header = { alg: "EdDSA" };
-    const encodedHeader = base64url(JSON.stringify(header));
-    const encodedPayload = base64url(
-      JSON.stringify({ ...claims, exp: timeExp, iat: issuedAt }),
+    const encodedHeader = uint8ArrayToBase64(
+      stringToUint8Array(JSON.stringify(header)),
+      { urlSafe: true },
+    );
+    const encodedPayload = uint8ArrayToBase64(
+      stringToUint8Array(
+        JSON.stringify({ ...claims, exp: timeExp, iat: issuedAt }),
+      ),
+      { urlSafe: true },
     );
     const utf8Jwt = utf8Encode(`${encodedHeader}.${encodedPayload}`);
 
     // sign JWT and create signature
     const signature = nacl.sign.detached(utf8Jwt, naclKP.secretKey);
-    const encodedSignature = base64url(Buffer.from(signature));
+    const encodedSignature = uint8ArrayToBase64(signature, { urlSafe: true });
 
     const jwt = `${encodedHeader}.${encodedPayload}.${encodedSignature}`;
     return jwt;

package/src/walletSdk/Auth/WalletSigner.ts

@@ -103,7 +103,7 @@ export class DomainSigner implements WalletSigner {
       { headers: this.headers },
     );
 
-    return StellarTransactionBuilder.fromXDR(
+    return StellarTransactionBuilder.fromXdr(
       response.data.transaction,
       networkPassphrase,
     ) as Transaction;

package/src/walletSdk/Auth/index.ts

@@ -1,6 +1,7 @@
 import { AxiosInstance } from "axios";
 import { TransactionBuilder, Transaction, WebAuth } from "@stellar/stellar-sdk";
 import { decode } from "jws";
+import { areUint8ArraysEqual } from "uint8array-extras";
 
 import { Config } from "../";
 import {
@@ -185,7 +186,7 @@ export class Sep10 {
       );
     }
 
-    let transaction: Transaction = TransactionBuilder.fromXDR(
+    let transaction: Transaction = TransactionBuilder.fromXdr(
       challengeResponse.transaction,
       networkPassphrase,
     ) as Transaction;
@@ -206,7 +207,7 @@ export class Sep10 {
       // a domain signer that only appends its signature preserves the hash. Any
       // change to the operations, source account, memo, or other body fields
       // changes the hash and is rejected here.
-      if (!returned.hash().equals(originalHash)) {
+      if (!areUint8ArraysEqual(returned.hash(), originalHash)) {
         throw new DomainSigningModifiedError();
       }
 
@@ -220,7 +221,7 @@ export class Sep10 {
   private async getToken(signedTransaction: Transaction): Promise<AuthToken> {
     try {
       const resp = await this.httpClient.post(this.webAuthEndpoint, {
-        transaction: signedTransaction.toXDR(),
+        transaction: signedTransaction.toXdr(),
       });
       if (!resp.data.token) {
         throw new MissingTokenError();

package/src/walletSdk/Customer/index.ts

@@ -77,12 +77,12 @@ export class Sep12 {
 
   /**
    * Add a new customer. Customer info is given in sep9Info param. If it
-   * is binary type (eg. Buffer of an image) include it in sep9BinaryInfo.
+   * is binary type (eg. Uint8Array of an image) include it in sep9BinaryInfo.
    * @param {AddCustomerParams} params - The parameters for adding a customer.
    * @param {CustomerInfoMap} [params.sep9Info] - Customer information. What fields you should
    * give is indicated by the anchor.
    * @param {CustomerBinaryInfoMap} [params.sep9BinaryInfo] - Customer information that is in binary
-   * format (eg. Buffer of an image).
+   * format (eg. Uint8Array of an image).
    * @param {string} [params.type] - The type of the customer.
    * @param {string} [params.memo] - A memo associated with the customer.
    * @param {string} [params.transactionId] - The id of the transaction that the customer is
@@ -96,7 +96,7 @@ export class Sep12 {
     memo,
     transactionId,
   }: AddCustomerParams): Promise<AddCustomerResponse> {
-    let customerMap: { [key: string]: string | Buffer } = {
+    let customerMap: { [key: string]: string | Uint8Array } = {
       ...sep9Info,
       ...sep9BinaryInfo,
     };
@@ -127,12 +127,12 @@ export class Sep12 {
 
   /**
    * Updates an existing customer. Customer info is given in sep9Info param. If it
-   * is binary type (eg. Buffer of an image) include it in sep9BinaryInfo.
+   * is binary type (eg. Uint8Array of an image) include it in sep9BinaryInfo.
    * @param {AddCustomerParams} params - The parameters for adding a customer.
    * @param {CustomerInfoMap} [params.sep9Info] - Customer information. What fields you should
    * give is indicated by the anchor.
    * @param {CustomerBinaryInfoMap} [params.sep9BinaryInfo] - Customer information that is in binary
-   * format (eg. Buffer of an image).
+   * format (eg. Uint8Array of an image).
    * @param {string} [params.id] - The id of the customer.
    * @param {string} [params.type] - The type of the customer.
    * @param {string} [params.memo] - A memo associated with the customer.
@@ -149,7 +149,7 @@ export class Sep12 {
     memo,
     transactionId,
   }: AddCustomerParams): Promise<AddCustomerResponse> {
-    let customerMap: { [key: string]: string | Buffer } = {};
+    let customerMap: { [key: string]: string | Uint8Array } = {};
     if (id) {
       customerMap["id"] = id;
     }

package/src/walletSdk/Exceptions/index.ts

@@ -182,6 +182,14 @@ export class PathPayOnlyOneAmountError extends Error {
   }
 }
 
+export class PathPayBoundRequiredError extends Error {
+  constructor(bound: "destMin" | "sendMax") {
+    const amount = bound === "destMin" ? "sendAmount" : "destAmount";
+    super(`${bound} is required when using ${amount}`);
+    Object.setPrototypeOf(this, PathPayBoundRequiredError.prototype);
+  }
+}
+
 export class WithdrawalTxMemoError extends Error {
   constructor() {
     super(`Error parsing withdrawal transaction memo`);
@@ -312,6 +320,12 @@ export class ChallengeTxnIncorrectSequenceError extends Error {
   }
 }
 
+/**
+ * @deprecated No longer thrown. `Server.signChallengeTransaction` now validates
+ * challenges with `WebAuth.readChallengeTx` and reports every failure, including
+ * an invalid server signature, as `ChallengeValidationFailedError`. This class
+ * will be removed in the next major release.
+ */
 export class ChallengeTxnInvalidSignatureError extends Error {
   constructor() {
     super("Invalid signature for challenge transaction");
@@ -319,6 +333,19 @@ export class ChallengeTxnInvalidSignatureError extends Error {
   }
 }
 
+export class ChallengeTxnClientAccountMismatchError extends Error {
+  constructor(expected: string, received: string) {
+    super(
+      `Challenge transaction client account mismatch: expected "${expected}" ` +
+        `but challenge was issued for "${received}"`,
+    );
+    Object.setPrototypeOf(
+      this,
+      ChallengeTxnClientAccountMismatchError.prototype,
+    );
+  }
+}
+
 export class AllowHttpOnNonTestnetError extends Error {
   constructor() {
     super("Can only allow Http on Testnet");

package/src/walletSdk/Horizon/AccountService.ts

@@ -42,10 +42,10 @@ export class AccountService {
   /**
    * Generate new account keypair (public and secret key) from random bytes. This key pair can be
    * used to create a Stellar account.
-   * @param {Buffer} randomBytes - Random bytes to create keypair from.
+   * @param {Uint8Array} randomBytes - Random bytes to create keypair from.
    * @returns {SigningKeypair} Keypair capable of signing.
    */
-  createKeypairFromRandom(randomBytes: Buffer): SigningKeypair {
+  createKeypairFromRandom(randomBytes: Uint8Array): SigningKeypair {
     return new SigningKeypair(Keypair.fromRawEd25519Seed(randomBytes));
   }
 

package/src/walletSdk/Horizon/Stellar.ts

@@ -259,7 +259,7 @@ export class Stellar {
    * @returns {Transaction|FeeBumpTransaction} The decoded transaction.
    */
   decodeTransaction(xdr: string): Transaction | FeeBumpTransaction {
-    return StellarTransactionBuilder.fromXDR(xdr, this.cfg.stellar.network);
+    return StellarTransactionBuilder.fromXdr(xdr, this.cfg.stellar.network);
   }
 
   /**

package/src/walletSdk/Horizon/Transaction/TransactionBuilder.ts

@@ -23,7 +23,10 @@ import {
   TransactionStatus,
   PathPayParams,
 } from "../../Types";
-import { PathPayOnlyOneAmountError } from "../../Exceptions";
+import {
+  PathPayBoundRequiredError,
+  PathPayOnlyOneAmountError,
+} from "../../Exceptions";
 import { CommonTransactionBuilder } from "./CommonTransactionBuilder";
 import { SponsoringBuilder } from "./SponsoringBuilder";
 
@@ -140,19 +143,19 @@ export class TransactionBuilder extends CommonTransactionBuilder<TransactionBuil
    * @param {string} params.destinationAddress - The destination Stellar address to which the payment is sent.
    * @param {StellarAssetId} params.sendAsset - The asset to be sent.
    * @param {StellarAssetId} params.destAsset - The asset the destination will receive.
-   * @param {string} [params.sendAmount] - The amount to be sent. Must specify either sendAmount or destAmount,
-   * but not both.
-   * @param {string} [params.destAmount] - The amount to be received by the destination. Must specify either sendAmount or destAmount,
-   * but not both.
-   * @param {string} [params.destMin] - The minimum amount of the destination asset to be receive. This is a
-   * protective measure, it allows you to specify a lower bound for an acceptable conversion. Only used
-   * if using sendAmount.
-   * (optional, default is ".0000001").
-   * @param {string} [params.sendMax] - The maximum amount of the destination asset to be sent. This is a
-   * protective measure, it allows you to specify an upper bound for an acceptable conversion. Only used
-   * if using destAmount.
-   * (optional, default is int64 max).
+   * @param {string} [params.sendAmount] - The amount of the send asset to be sent. Must specify either
+   * sendAmount or destAmount, but not both. Requires destMin.
+   * @param {string} [params.destAmount] - The amount of the destination asset to be received by the
+   * destination. Must specify either sendAmount or destAmount, but not both. Requires sendMax.
+   * @param {string} [params.destMin] - The minimum amount of the destination asset to receive. Required
+   * when using sendAmount. This is the slippage limit for the conversion: the payment fails if it would
+   * deliver less than this amount, instead of executing at a worse rate.
+   * @param {string} [params.sendMax] - The maximum amount of the send asset to spend. Required when using
+   * destAmount. This is the slippage limit for the conversion: the payment fails if it would cost more
+   * than this amount, instead of executing at a worse rate.
    *
+   * @throws {PathPayOnlyOneAmountError} If both or neither of sendAmount and destAmount are given.
+   * @throws {PathPayBoundRequiredError} If destMin is missing for sendAmount, or sendMax for destAmount.
    * @returns {TransactionBuilder} - Returns the current TransactionBuilder instance for method chaining.
    */
   pathPay({
@@ -168,23 +171,29 @@ export class TransactionBuilder extends CommonTransactionBuilder<TransactionBuil
       throw new PathPayOnlyOneAmountError();
     }
     if (sendAmount) {
+      if (destMin === undefined) {
+        throw new PathPayBoundRequiredError("destMin");
+      }
       this.operations.push(
         Operation.pathPaymentStrictSend({
           destination: destinationAddress,
           sendAsset: sendAsset.toAsset(),
           sendAmount,
           destAsset: destAsset.toAsset(),
-          destMin: destMin || ".0000001",
+          destMin,
         }),
       );
     } else {
+      if (sendMax === undefined) {
+        throw new PathPayBoundRequiredError("sendMax");
+      }
       this.operations.push(
         Operation.pathPaymentStrictReceive({
           destination: destinationAddress,
           sendAsset: sendAsset.toAsset(),
           destAmount,
           destAsset: destAsset.toAsset(),
-          sendMax: sendMax || "922337203685.4775807",
+          sendMax,
         }),
       );
     }
@@ -198,14 +207,17 @@ export class TransactionBuilder extends CommonTransactionBuilder<TransactionBuil
    * @param {StellarAssetId} fromAsset - The source asset to be sent.
    * @param {StellarAssetId} toAsset - The destination asset to receive.
    * @param {string} amount - The amount of the source asset to be sent.
-   * @param {string} [destMin] - (Optional) The minimum amount of the destination asset to be received.
+   * @param {string} destMin - The minimum amount of the destination asset to receive. This is the
+   * slippage limit for the swap: it fails if the conversion would deliver less than this amount,
+   * instead of executing at a worse rate.
+   * @throws {PathPayBoundRequiredError} If destMin is missing.
    * @returns {TransactionBuilder} Returns the current instance of the TransactionBuilder for method chaining.
    */
   swap(
     fromAsset: StellarAssetId,
     toAsset: StellarAssetId,
     amount: string,
-    destMin?: string,
+    destMin: string,
   ): TransactionBuilder {
     this.pathPay({
       destinationAddress: this.sourceAddress,
@@ -272,8 +284,8 @@ export class TransactionBuilder extends CommonTransactionBuilder<TransactionBuil
     // the hash and non-hash paths rather than leaking the raw SDK error.
     try {
       if (transaction.withdraw_memo_type === "hash") {
-        const buffer = Buffer.from(transaction.withdraw_memo, "base64");
-        this.setMemo(Memo.hash(buffer.toString("hex")));
+        const memoBytes = xdr.decodeBytes(transaction.withdraw_memo, "base64");
+        this.setMemo(Memo.hash(xdr.encodeBytes(memoBytes, "hex")));
       } else {
         this.setMemo(
           new Memo(transaction.withdraw_memo_type, transaction.withdraw_memo),

package/src/walletSdk/Recovery/AccountRecover.ts

@@ -231,7 +231,7 @@ export abstract class AccountRecover {
       const resp = await this.httpClient.post(
         requestUrl,
         {
-          transaction: transaction.toXDR(),
+          transaction: transaction.toXdr(),
         },
         {
           headers: {