@stellar-expert/tx-meta-effects-parser 5.6.0 → 5.6.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stellar-expert/tx-meta-effects-parser",
-  "version": "5.6.0",
+  "version": "5.6.2",
   "description": "Low-level effects parser for Stellar transaction results and meta XDR",
   "main": "src/index.js",
   "scripts": {
@@ -9,7 +9,7 @@
   "author": "team@stellar.expert",
   "license": "MIT",
   "peerDependencies": {
-    "@stellar/stellar-base": "^12.0.1"
+    "@stellar/stellar-base": "^12.1.0"
   },
   "devDependencies": {
     "@babel/core": "^7.22.9",

package/src/aggregation/asset-supply-analyzer.js

@@ -50,9 +50,9 @@ class AssetSupplyAnalyzer {
                 this.supplyChanges |= 1
             }
         }
-        if ((this.supplyChanges & 3) === 3) { //analyze possible collapsible mints only if both mint and burn effects recorded
+        /*if ((this.supplyChanges & 3) === 3) { //analyze possible collapsible mints only if both mint and burn effects recorded
             new CollapsibleMintsAnalyzer(this.effectsAnalyzer).removeCollapsingMints()
-        }
+        }*/
     }
 
     /**
@@ -181,7 +181,7 @@ class CollapsibleMintsAnalyzer {
             if (sum > 0n) { //asset minted
                 this.effectsAnalyzer.mint(asset, sum.toString(), true) //insert mint effect
             } else if (sum < 0n) { //asset burned
-                this.effectsAnalyzer.burn(asset, sum.toString(), position) //insert burn effect at the position of the last removed effect
+                this.effectsAnalyzer.burn(asset, (-sum).toString(), position) //insert burn effect at the position of the last removed effect
             }
             //if sum=0 then both effects were annihilated and removed
         }

package/src/aggregation/events-analyzer.js

@@ -158,13 +158,6 @@ class EventsAnalyzer {
                 if (classicAsset) {
                     if (classicAsset.includes(from)) {  //SAC transfer by asset issuer
                         this.effectsAnalyzer.mint(classicAsset, amount)
-                        this.effectsAnalyzer.credit(amount, classicAsset, to)
-                        return
-                    }
-                    if (classicAsset.includes(to)) {  //SAC transfer by asset issuer
-                        this.effectsAnalyzer.debit(amount, classicAsset, from)
-                        this.effectsAnalyzer.burn(classicAsset, amount)
-                        return
                     }
                     if (isContractAddress(from)) {
                         this.effectsAnalyzer.debit(amount, classicAsset, from)
@@ -172,6 +165,9 @@ class EventsAnalyzer {
                     if (isContractAddress(to)) {
                         this.effectsAnalyzer.credit(amount, classicAsset, to)
                     }
+                    if (classicAsset.includes(to)) {  //SAC transfer by asset issuer
+                        this.effectsAnalyzer.burn(classicAsset, amount)
+                    }
                 } else { //other cases
                     this.effectsAnalyzer.debit(amount, this.effectsAnalyzer.resolveAsset(contract), from)
                     this.effectsAnalyzer.credit(amount, this.effectsAnalyzer.resolveAsset(contract), to)
@@ -190,7 +186,7 @@ class EventsAnalyzer {
                 }
                 const asset = this.effectsAnalyzer.resolveAsset(contract)
                 this.effectsAnalyzer.mint(asset, amount)
-                if (isContractAddress(asset)) {
+                if (isContractAddress(asset) || isContractAddress(to)) {
                     this.effectsAnalyzer.credit(amount, asset, to)
                 }
             }
@@ -209,7 +205,7 @@ class EventsAnalyzer {
                     mapSacContract(this.effectsAnalyzer, contract, xdrParseAsset(xdrParseScVal(topics[2])))
                 }
                 const asset = this.effectsAnalyzer.resolveAsset(contract)
-                if (isContractAddress(asset)) {
+                if (isContractAddress(asset) || isContractAddress(from)) {
                     this.effectsAnalyzer.debit(amount, asset, from)
                 }
                 this.effectsAnalyzer.burn(asset, amount)

package/src/effects-analyzer.js

@@ -132,7 +132,7 @@ class EffectsAnalyzer {
             type: effectTypes.accountDebited,
             source,
             asset,
-            amount
+            amount: validateAmount(amount)
         }
         if (balance !== undefined) {
             effect.balance = balance
@@ -147,7 +147,7 @@ class EffectsAnalyzer {
             type: effectTypes.accountCredited,
             source,
             asset,
-            amount
+            amount: validateAmount(amount)
         }
         if (balance !== undefined) {
             effect.balance = balance
@@ -162,7 +162,7 @@ class EffectsAnalyzer {
         this.addEffect({
             type: effectTypes.assetMinted,
             asset,
-            amount
+            amount: validateAmount(amount)
         }, position)
     }
 
@@ -170,7 +170,7 @@ class EffectsAnalyzer {
         this.addEffect({
             type: effectTypes.assetBurned,
             asset,
-            amount
+            amount: validateAmount(amount)
         }, position)
     }
 
@@ -998,6 +998,12 @@ function encodeSponsorshipEffectName(action, type) {
     return effectTypes[`${type}Sponsorship${actionKey}`]
 }
 
+function validateAmount(amount) {
+    if (amount < 0)
+        throw new TxMetaEffectParserError('Negative balance change amount: ' + amount.toString())
+    return amount
+}
+
 function parseLargeInt(largeInt) {
     return largeInt._value.toString()
 }