@stellar-expert/tx-meta-effects-parser 5.0.1 → 5.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stellar-expert/tx-meta-effects-parser",
-  "version": "5.0.1",
+  "version": "5.0.3",
   "description": "Low-level effects parser for Stellar transaction results and meta XDR",
   "main": "src/index.js",
   "scripts": {

package/src/index.js

@@ -31,17 +31,18 @@ function parseTxOperationsMeta({network, tx, result, meta}) {
     } catch (e) {
         throw new TxMetaEffectParserError('Invalid transaction envelope XDR. ' + e.message)
     }
-    try {
-        result = ensureXdrInputType(result, xdr.TransactionResult)
-    } catch (e) {
+    if (!isEphemeral) {
         try {
-            const pair = ensureXdrInputType(result, xdr.TransactionResultPair)
-            result = pair.result()
-        } catch {
-            throw new TxMetaEffectParserError('Invalid transaction result XDR. ' + e.message)
+            result = ensureXdrInputType(result, xdr.TransactionResult)
+        } catch (e) {
+            try {
+                const pair = ensureXdrInputType(result, xdr.TransactionResultPair)
+                result = pair.result()
+            } catch {
+                throw new TxMetaEffectParserError('Invalid transaction result XDR. ' + e.message)
+            }
         }
     }
-
     tx = TransactionBuilder.fromXDR(tx, network)
 
     let parsedTx = tx
@@ -78,9 +79,14 @@ function parseTxOperationsMeta({network, tx, result, meta}) {
         }
     }
 
+    res.effects = []
+
+    if (isEphemeral)
+        return res //do not parse meta for unsubmitted/rejected transactions
+
     //process fee charge
     const feeEffect = processFeeChargedEffect(tx, tx.feeSource || parsedTx.source, result.feeCharged().toString(), isFeeBump)
-    res.effects = [feeEffect]
+    res.effects.push(feeEffect)
 
     //check execution result
     const {success, opResults} = parseTxResult(parsedResult)
@@ -89,10 +95,6 @@ function parseTxOperationsMeta({network, tx, result, meta}) {
         return res
     }
 
-    //do not parse meta for unsubmitted/rejected transactions
-    if (isEphemeral)
-        return res
-
     //retrieve operations result metadata
     try {
         meta = ensureXdrInputType(meta, xdr.TransactionMeta)

package/src/tx-xdr-parser-utils.js

@@ -47,7 +47,7 @@ function xdrParseAccountAddress(accountId, muxedAccountsSupported = false) {
                 throw new TxMetaEffectParserError(`Unsupported account type: ${accountId.arm()}`)
         }
     }
-    if (accountId instanceof Buffer) {
+    if (accountId instanceof Uint8Array) {
         return StrKey.encodeEd25519PublicKey(accountId)
     }
     throw new TypeError(`Failed to identify and parse account address: ${accountId}`)