@steipete/oracle 0.15.0 → 0.15.2

package/dist/src/browser/actions/thinkingStatus.js

@@ -1,5 +1,5 @@
 import { formatElapsed } from "../../oracle/format.js";
-import { ASSISTANT_ROLE_SELECTOR, CONVERSATION_TURN_SELECTOR } from "../constants.js";
+import { ASSISTANT_ROLE_SELECTOR, CONVERSATION_TURN_SELECTOR, STOP_BUTTON_SELECTORS, } from "../constants.js";
 const THINKING_STALE_HINT_MS = 10 * 60_000;
 export function startThinkingStatusMonitor(Runtime, logger, options = {}) {
     const intervalMs = resolveThinkingStatusInterval(options.intervalMs);
@@ -127,6 +127,7 @@ async function readThinkingStatus(Runtime) {
 }
 const SAFE_THINKING_STATUS_MESSAGES = new Set([
     "active",
+    "response streaming",
     "thinking sidecar active",
     "thinking sidecar opened",
 ]);
@@ -157,13 +158,16 @@ function buildThinkingStatusExpression() {
         '[aria-live="polite"]',
     ];
     const keywords = ["pro thinking", "thinking", "reasoning"];
+    const stopSelector = STOP_BUTTON_SELECTORS.join(", ");
     const selectorLiteral = JSON.stringify(selectors);
     const keywordsLiteral = JSON.stringify(keywords);
+    const stopSelectorLiteral = JSON.stringify(stopSelector);
     return `(async () => {
     const CONVERSATION_SELECTOR = ${conversationLiteral};
     const ASSISTANT_SELECTOR = ${assistantLiteral};
     const selectors = ${selectorLiteral};
     const keywords = ${keywordsLiteral};
+    const stopSelector = ${stopSelectorLiteral};
     const normalize = (value) =>
       String(value || '')
         .normalize('NFD')
@@ -383,6 +387,20 @@ function buildThinkingStatusExpression() {
         };
       }
     }
+    // Last-resort liveness fallback: selector drift can hide every thinking
+    // indicator while a response is still generating, and returning null here
+    // reads as "dead" downstream. The stop/interrupt control is a stable,
+    // language-independent signal that generation is active; it lives in the
+    // composer, so isComposerAdjacent must not filter it.
+    const stopVisible = Array.from(document.querySelectorAll(stopSelector)).some((node) =>
+      isVisible(node),
+    );
+    if (stopVisible) {
+      return {
+        message: 'response streaming',
+        source: 'inline',
+      };
+    }
     return null;
   })()`;
 }

package/dist/src/browser/artifacts.js

@@ -1,8 +1,14 @@
+import { createHash } from "node:crypto";
+import { createReadStream } from "node:fs";
 import fs from "node:fs/promises";
 import path from "node:path";
 import { getOracleHomeDir } from "../oracleHome.js";
 import { isDeepResearchIncompleteText } from "./deepResearchResult.js";
 const ARTIFACTS_DIRNAME = "artifacts";
+const ZIP_EOCD_SIGNATURE = 0x06054b50;
+const ZIP_LOCAL_FILE_HEADER_SIGNATURE = 0x04034b50;
+const ZIP_EMPTY_ARCHIVE_LENGTH = 22;
+const ZIP_MAX_EOCD_COMMENT_BYTES = 65_535;
 function sanitizePathSegment(value, fallback) {
     const sanitized = value
         .toLowerCase()
@@ -12,6 +18,29 @@ function sanitizePathSegment(value, fallback) {
         .slice(0, 80);
     return sanitized || fallback;
 }
+export function sanitizeArtifactFilename(value, fallback = "artifact.bin") {
+    const normalized = String(value ?? "")
+        .replace(/\0/g, "")
+        .replace(/\\/g, "/");
+    const basename = path.basename(normalized).replace(/\.crdownload$/i, "");
+    const fallbackName = path.basename(fallback.replace(/\\/g, "/")) || "artifact.bin";
+    const sanitized = sanitizePathSegment(basename, sanitizePathSegment(fallbackName, "artifact.bin"));
+    return sanitized === "." || sanitized === ".."
+        ? sanitizePathSegment(fallbackName, "artifact.bin")
+        : sanitized;
+}
+export function sanitizeArtifactMimeType(value) {
+    const mime = String(value ?? "")
+        .split(";", 1)[0]
+        ?.trim()
+        .toLowerCase();
+    if (!mime ||
+        mime.length > 127 ||
+        !/^[a-z0-9][a-z0-9!#$&^_.+-]*\/[a-z0-9][a-z0-9!#$&^_.+-]*$/.test(mime)) {
+        return undefined;
+    }
+    return mime;
+}
 function normalizeSessionId(sessionId) {
     return sanitizePathSegment(path.basename(sessionId), "session");
 }
@@ -27,7 +56,7 @@ async function pathExists(targetPath) {
         return false;
     }
 }
-async function resolveUniquePath(basePath) {
+export async function resolveUniqueArtifactPath(basePath) {
     const ext = path.extname(basePath);
     const stem = ext ? path.basename(basePath, ext) : path.basename(basePath);
     const dir = path.dirname(basePath);
@@ -47,6 +76,138 @@ async function readSizeBytes(targetPath) {
         return undefined;
     }
 }
+export function computeBufferSha256(contents) {
+    return createHash("sha256").update(contents).digest("hex");
+}
+export async function computeFileSha256(targetPath) {
+    const hash = createHash("sha256");
+    await new Promise((resolve, reject) => {
+        const stream = createReadStream(targetPath);
+        stream.on("data", (chunk) => hash.update(chunk));
+        stream.on("error", reject);
+        stream.on("end", () => resolve());
+    });
+    return hash.digest("hex");
+}
+export function isZipArtifact(filename, mimeType) {
+    const ext = path.extname(String(filename ?? "")).toLowerCase();
+    const mime = String(mimeType ?? "").toLowerCase();
+    return (ext === ".zip" ||
+        mime === "application/zip" ||
+        mime === "application/x-zip-compressed" ||
+        mime.endsWith("+zip"));
+}
+export function validateZipBuffer(contents) {
+    if (contents.length < ZIP_EMPTY_ARCHIVE_LENGTH) {
+        return { type: "zip", ok: false, error: "zip-too-small" };
+    }
+    const firstSignature = contents.readUInt32LE(0);
+    if (firstSignature !== ZIP_LOCAL_FILE_HEADER_SIGNATURE && firstSignature !== ZIP_EOCD_SIGNATURE) {
+        return { type: "zip", ok: false, error: "zip-magic-mismatch" };
+    }
+    const searchStart = Math.max(0, contents.length - ZIP_EMPTY_ARCHIVE_LENGTH - ZIP_MAX_EOCD_COMMENT_BYTES);
+    let eocdOffset = -1;
+    for (let offset = contents.length - ZIP_EMPTY_ARCHIVE_LENGTH; offset >= searchStart; offset -= 1) {
+        if (contents.readUInt32LE(offset) === ZIP_EOCD_SIGNATURE) {
+            eocdOffset = offset;
+            break;
+        }
+    }
+    if (eocdOffset < 0) {
+        return { type: "zip", ok: false, error: "zip-central-directory-missing" };
+    }
+    const commentLength = contents.readUInt16LE(eocdOffset + 20);
+    if (eocdOffset + ZIP_EMPTY_ARCHIVE_LENGTH + commentLength !== contents.length) {
+        return { type: "zip", ok: false, error: "zip-eocd-size-mismatch" };
+    }
+    const centralDirectorySize = contents.readUInt32LE(eocdOffset + 12);
+    const centralDirectoryOffset = contents.readUInt32LE(eocdOffset + 16);
+    if (centralDirectoryOffset + centralDirectorySize > eocdOffset) {
+        return { type: "zip", ok: false, error: "zip-central-directory-out-of-range" };
+    }
+    return { type: "zip", ok: true };
+}
+async function readFileWindow(handle, length, position) {
+    const buffer = Buffer.alloc(length);
+    let offset = 0;
+    while (offset < length) {
+        const result = await handle.read(buffer, offset, length - offset, position + offset);
+        if (result.bytesRead === 0) {
+            return null;
+        }
+        offset += result.bytesRead;
+    }
+    return buffer;
+}
+export async function validateZipFile(targetPath) {
+    const handle = await fs.open(targetPath, "r");
+    try {
+        const fileStat = await handle.stat();
+        if (fileStat.size < ZIP_EMPTY_ARCHIVE_LENGTH) {
+            return { type: "zip", ok: false, error: "zip-too-small" };
+        }
+        const first = await readFileWindow(handle, 4, 0);
+        if (!first) {
+            return { type: "zip", ok: false, error: "zip-too-small" };
+        }
+        const firstSignature = first.readUInt32LE(0);
+        if (firstSignature !== ZIP_LOCAL_FILE_HEADER_SIGNATURE &&
+            firstSignature !== ZIP_EOCD_SIGNATURE) {
+            return { type: "zip", ok: false, error: "zip-magic-mismatch" };
+        }
+        const tailLength = Math.min(fileStat.size, ZIP_EMPTY_ARCHIVE_LENGTH + ZIP_MAX_EOCD_COMMENT_BYTES);
+        const tailStart = fileStat.size - tailLength;
+        const tail = await readFileWindow(handle, tailLength, tailStart);
+        if (!tail) {
+            return { type: "zip", ok: false, error: "zip-central-directory-missing" };
+        }
+        let relativeEocdOffset = -1;
+        for (let offset = tail.length - ZIP_EMPTY_ARCHIVE_LENGTH; offset >= 0; offset -= 1) {
+            if (tail.readUInt32LE(offset) === ZIP_EOCD_SIGNATURE) {
+                relativeEocdOffset = offset;
+                break;
+            }
+        }
+        if (relativeEocdOffset < 0) {
+            return { type: "zip", ok: false, error: "zip-central-directory-missing" };
+        }
+        const eocdOffset = tailStart + relativeEocdOffset;
+        const commentLength = tail.readUInt16LE(relativeEocdOffset + 20);
+        if (eocdOffset + ZIP_EMPTY_ARCHIVE_LENGTH + commentLength !== fileStat.size) {
+            return { type: "zip", ok: false, error: "zip-eocd-size-mismatch" };
+        }
+        const centralDirectorySize = tail.readUInt32LE(relativeEocdOffset + 12);
+        const centralDirectoryOffset = tail.readUInt32LE(relativeEocdOffset + 16);
+        if (centralDirectoryOffset + centralDirectorySize > eocdOffset) {
+            return { type: "zip", ok: false, error: "zip-central-directory-out-of-range" };
+        }
+        return { type: "zip", ok: true };
+    }
+    finally {
+        await handle.close();
+    }
+}
+export function validateArtifactBuffer(params) {
+    if (isZipArtifact(params.filename, params.mimeType)) {
+        return validateZipBuffer(params.contents);
+    }
+    return {
+        type: "generic",
+        ok: params.contents.length > 0,
+        error: params.contents.length > 0 ? undefined : "empty-file",
+    };
+}
+export async function validateArtifactFile(params) {
+    if (isZipArtifact(params.filename ?? path.basename(params.path), params.mimeType)) {
+        return validateZipFile(params.path);
+    }
+    const size = await readSizeBytes(params.path);
+    return {
+        type: "generic",
+        ok: Boolean(size && size > 0),
+        error: size && size > 0 ? undefined : "empty-file",
+    };
+}
 export async function writeTextBrowserArtifact(params) {
     const text = params.contents.trim();
     if (!params.sessionId || text.length === 0) {
@@ -54,8 +215,8 @@ export async function writeTextBrowserArtifact(params) {
     }
     const dir = resolveSessionArtifactsDir(params.sessionId);
     await fs.mkdir(dir, { recursive: true });
-    const filename = sanitizePathSegment(params.filename, "artifact.md");
-    const targetPath = await resolveUniquePath(path.join(dir, filename));
+    const filename = sanitizeArtifactFilename(params.filename, "artifact.md");
+    const targetPath = await resolveUniqueArtifactPath(path.join(dir, filename));
     await fs.writeFile(targetPath, `${text}\n`, "utf8");
     params.logger?.(`[browser] Saved ${params.kind} artifact to ${targetPath}`);
     return {
@@ -65,6 +226,10 @@ export async function writeTextBrowserArtifact(params) {
         mimeType: params.mimeType ?? "text/markdown",
         sizeBytes: await readSizeBytes(targetPath),
         sourceUrl: params.sourceUrl,
+        sha256: computeBufferSha256(Buffer.from(`${text}\n`, "utf8")),
+        validation: { type: "generic", ok: true },
+        transfer: { status: "not-needed" },
+        origin: { mode: "local" },
     };
 }
 export async function writeBinaryBrowserArtifact(params) {
@@ -73,10 +238,18 @@ export async function writeBinaryBrowserArtifact(params) {
     }
     const dir = resolveSessionArtifactsDir(params.sessionId);
     await fs.mkdir(dir, { recursive: true });
-    const filename = sanitizePathSegment(params.filename, "artifact.bin");
-    const targetPath = await resolveUniquePath(path.join(dir, filename));
+    const filename = sanitizeArtifactFilename(params.filename, "artifact.bin");
+    const targetPath = await resolveUniqueArtifactPath(path.join(dir, filename));
     await fs.writeFile(targetPath, params.contents);
+    const validation = validateArtifactBuffer({
+        filename,
+        mimeType: params.mimeType,
+        contents: params.contents,
+    });
     params.logger?.(`[browser] Saved ${params.kind} artifact to ${targetPath}`);
+    if (validation.type === "zip" && !validation.ok) {
+        params.logger?.(`[browser] ZIP validation failed for ${filename}: ${validation.error ?? "invalid"}`);
+    }
     return {
         kind: params.kind,
         path: targetPath,
@@ -84,6 +257,10 @@ export async function writeBinaryBrowserArtifact(params) {
         mimeType: params.mimeType,
         sizeBytes: params.contents.length,
         sourceUrl: params.sourceUrl,
+        sha256: computeBufferSha256(params.contents),
+        validation,
+        transfer: { status: "not-needed" },
+        origin: { mode: "local" },
     };
 }
 export async function saveDeepResearchReportArtifact(params) {
@@ -114,7 +291,14 @@ export async function saveBrowserTranscriptArtifact(params) {
             "",
             ...params.artifacts.map((artifact) => {
                 const label = artifact.label ?? artifact.kind;
-                return `- ${label}: ${artifact.path}`;
+                const hash = artifact.sha256 ? ` sha256=${artifact.sha256}` : "";
+                const transfer = artifact.transfer?.status
+                    ? ` transfer=${artifact.transfer.status}`
+                    : "";
+                const validation = artifact.validation
+                    ? ` validation=${artifact.validation.ok ? "ok" : (artifact.validation.error ?? "failed")}`
+                    : "";
+                return `- ${label}: ${artifact.path}${hash}${transfer}${validation}`;
             }),
         ]
         : [];
@@ -159,5 +343,6 @@ export function appendArtifacts(existing, additions) {
 }
 export const __test__ = {
     normalizeSessionId,
+    sanitizeArtifactFilename,
     sanitizePathSegment,
 };