@stealthmole/mcp 0.1.12 → 0.1.13

package/bin/claude-desktop-config.mjs

@@ -27,6 +27,29 @@ const CONFIG_FILENAME = "claude_desktop_config.json";
 /** npx specifier for the retired `stealthmole.mcp` package, with or without a version range. */
 const RETIRED_PACKAGE_ARG = /^stealthmole\.mcp(@.+)?$/;
 
+/**
+ * npx specifier for either package that launches this server.
+ *
+ * Deliberately wider than {@link RETIRED_PACKAGE_ARG}: that one drives the
+ * rewrite and must not touch an entry already on the scoped package, while this
+ * one only answers "is this entry ours".
+ */
+const SERVER_PACKAGE_ARG = /^(?:@stealthmole\/mcp|stealthmole\.mcp)(@.+)?$/;
+
+/**
+ * Whether an `mcpServers` entry launches this server.
+ *
+ * Matched on `args`, not `command`: the command is `npx`, `npx.cmd`, or an
+ * absolute path depending on platform and install, while the package specifier
+ * is identical everywhere.
+ *
+ * @param {object} entry an `mcpServers` entry
+ * @returns {boolean}
+ */
+function launchesThisServer(entry) {
+  return Array.isArray(entry?.args) && entry.args.some((arg) => SERVER_PACKAGE_ARG.test(arg));
+}
+
 /**
  * Repoint an entry's npx args at `@stealthmole/mcp`.
  *
@@ -166,6 +189,21 @@ export function ensureClaudeDesktopConfig({
         return "migrated";
       }
 
+      // The customer may have registered this server by hand under a key of
+      // their own choosing. Identity is the package the entry launches, not the
+      // key it sits under — judging by key alone adds a SECOND entry, so the
+      // server runs twice, every tool shows up twice, and the entry we add
+      // carries none of their `env` (notably STEALTHMOLE_CLIENT_SECRET).
+      const foreignKey = Object.keys(servers).find((key) => launchesThisServer(servers[key]));
+      if (foreignKey) {
+        if (debug) {
+          console.error(
+            `${LOG_PREFIX} Already registered under "${foreignKey}", leaving it as is.`
+          );
+        }
+        return "unchanged";
+      }
+
       servers[SERVER_KEY] = {
         command: "npx",
         args: ["-y", `@stealthmole/mcp@^${pkgVersion}`],

package/bin/cli.mjs

@@ -7,6 +7,7 @@ import { createServer } from "net";
 import { readFileSync } from "fs";
 
 import { ensureClaudeDesktopConfig } from "./claude-desktop-config.mjs";
+import { unsupportedNodeMessage } from "./node-version-guard.mjs";
 import { migrateTokenCache } from "./token-cache-shim.mjs";
 
 // Read current package version for pinned auto-registration
@@ -14,6 +15,38 @@ const PKG_VERSION = JSON.parse(
   readFileSync(new URL("../package.json", import.meta.url), "utf-8")
 ).version;
 
+// --help and --version come first. Both are diagnostics a customer runs to
+// report what they have installed, so nothing below may run ahead of them:
+// a fresh registration exits the process, and argv filtering rewrites
+// process.argv out from under them.
+if (process.argv.includes("--help") || process.argv.includes("-h")) {
+  console.error(
+    `@stealthmole/mcp v${PKG_VERSION}\n` +
+      "\nUsage: npx -y @stealthmole/mcp [options]\n" +
+      "\nOptions:\n" +
+      "  --port <number>           Callback port for OAuth redirect\n" +
+      "  --callback-port <number>  Alias for --port\n" +
+      "  --debug                   Enable debug logging\n" +
+      "  --help, -h                Show this help message\n" +
+      "  --version, -v             Show version number\n"
+  );
+  process.exit(0);
+}
+
+if (process.argv.includes("--version") || process.argv.includes("-v")) {
+  console.error(PKG_VERSION);
+  process.exit(0);
+}
+
+// Refuse an unsupported Node before touching anything. Registering a config
+// entry that cannot run is worse than not registering: Claude Desktop would
+// keep launching a server that crashes inside node_modules.
+const nodeProblem = unsupportedNodeMessage();
+if (nodeProblem) {
+  console.error(nodeProblem);
+  process.exit(1);
+}
+
 // Register (or migrate) the Claude Desktop entry before starting the proxy.
 // A rename keeps running: Claude Desktop launched this process under the old
 // key, so exiting would break the session the user is in right now.
@@ -37,26 +70,6 @@ const AUTH_SUCCESS_URL = "https://www.stealthmole.com/";
 const CALLBACK_HOST = "localhost";
 const DEBUG = process.argv.includes("--debug");
 
-// Handle --help and --version before argv filtering
-if (process.argv.includes("--help") || process.argv.includes("-h")) {
-  console.error(
-    `@stealthmole/mcp v${PKG_VERSION}\n` +
-      "\nUsage: npx -y @stealthmole/mcp [options]\n" +
-      "\nOptions:\n" +
-      "  --port <number>           Callback port for OAuth redirect\n" +
-      "  --callback-port <number>  Alias for --port\n" +
-      "  --debug                   Enable debug logging\n" +
-      "  --help, -h                Show this help message\n" +
-      "  --version, -v             Show version number\n"
-  );
-  process.exit(0);
-}
-
-if (process.argv.includes("--version") || process.argv.includes("-v")) {
-  console.error(PKG_VERSION);
-  process.exit(0);
-}
-
 /**
  * Find an available port not occupied by another process.
  *

package/bin/node-version-guard.mjs

@@ -0,0 +1,56 @@
+// Node.js version guard for the StealthMole MCP client.
+//
+// mcp-remote depends on undici, which dereferences the global `File` at require
+// time (undici/lib/web/webidl/index.js). `File` became global in Node 20, so on
+// Node 18 the proxy dies with `ReferenceError: File is not defined` and a stack
+// trace through node_modules — the customer sees a crash, not a cause.
+//
+// `engines.node` does not prevent this: npm and npx print a warning and run
+// anyway. The check has to happen at runtime.
+
+import { readFileSync } from "fs";
+
+const LOG_PREFIX = "[stealthmole-mcp]";
+
+/**
+ * Node.js version declared in `engines.node`, for the install advice.
+ *
+ * Read from package.json so the number is written once. It mirrors undici's own
+ * `engines` and is only a recommendation here — the guard below refuses strictly
+ * less, because versions between 20.0.0 and this one still run fine (measured:
+ * 20.9.0 loads undici without error).
+ */
+export const RECOMMENDED_NODE_VERSION = JSON.parse(
+  readFileSync(new URL("../package.json", import.meta.url), "utf-8")
+).engines.node.replace(/^[^\d]*/, "");
+
+/**
+ * Explain why this Node cannot run the client, or `null` when it can.
+ *
+ * Tests the missing global directly instead of comparing version numbers.
+ * A version range has to be guessed and then maintained as undici moves, and
+ * guessing it too high is the worse error: it would refuse customers who are
+ * working today. The global either exists or it does not.
+ *
+ * Returns the message rather than printing and exiting, so the decision to
+ * terminate stays with the caller and the rule stays unit-testable.
+ *
+ * @param {boolean} [hasFileGlobal] whether `File` is a global in this runtime
+ * @param {string} [current] version to name in the message
+ * @returns {string|null}
+ */
+export function unsupportedNodeMessage(
+  hasFileGlobal = typeof File !== "undefined",
+  current = process.versions.node
+) {
+  if (hasFileGlobal) {
+    return null;
+  }
+
+  return (
+    `${LOG_PREFIX} Node.js ${current} is too old: mcp-remote needs the global ` +
+    `"File", which Node.js added in version 20.\n` +
+    `${LOG_PREFIX}   Install Node.js ${RECOMMENDED_NODE_VERSION} or newer from ` +
+    `https://nodejs.org/ and restart Claude Desktop.`
+  );
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stealthmole/mcp",
-  "version": "0.1.12",
+  "version": "0.1.13",
   "description": "StealthMole Threat Intelligence MCP client - connect Claude Desktop, Cursor, and other MCP clients to StealthMole API",
   "bin": {
     "stealthmole-mcp": "bin/cli.mjs"