@startsimpli/ui 0.4.64 → 0.4.65

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@startsimpli/ui",
-  "version": "0.4.64",
+  "version": "0.4.65",
   "description": "Shared UI components package for StartSimpli applications",
   "main": "./src/index.ts",
   "types": "./src/index.ts",

package/src/components/collection/InlineReviewActions.tsx

@@ -67,15 +67,26 @@ export function InlineReviewActions({ client, type, record, config, onSaved }: I
     () => [...reviewDecisions(cfg)].sort((a, b) => ORDER.indexOf(a.key) - ORDER.indexOf(b.key)),
     [cfg],
   );
-  const [verdict, setVerdict] = useState(() => fieldStr(record.data, cfg.verdictAttr));
+  // Which decision the record currently reflects — by verdict when the type has
+  // one (topics), else by status (news: acceptable→approve, rejected→reject). The
+  // matching button shows active. Optimistically updated on click.
+  const initialKey = useMemo(() => {
+    const v = fieldStr(record.data, cfg.verdictAttr);
+    const s = fieldStr(record.data, cfg.statusName);
+    return (
+      decisions.find((d) => (d.verdict ? d.verdict === v : d.status ? d.status === s : false))?.key ??
+      null
+    );
+  }, [record.data, cfg, decisions]);
+  const [appliedKey, setAppliedKey] = useState<string | null>(initialKey);
   const [busy, setBusy] = useState<string | null>(null);
   const [noteOpen, setNoteOpen] = useState(false);
   const [note, setNote] = useState('');
 
   /** Apply a decision (status + verdict), optionally attaching a note. Optimistic. */
   async function apply(d: ReviewDecision, noteText?: string) {
-    const prev = verdict;
-    setVerdict(d.verdict ?? ''); // optimistic
+    const prev = appliedKey;
+    setAppliedKey(d.key); // optimistic
     setBusy(d.key);
     try {
       const data = applyDecisionToData(record.data, d, cfg);
@@ -94,7 +105,7 @@ export function InlineReviewActions({ client, type, record, config, onSaved }: I
       onSaved?.();
       return true;
     } catch (err) {
-      setVerdict(prev); // roll back
+      setAppliedKey(prev); // roll back
       notify.error(err instanceof Error ? err.message : 'Could not save.');
       return false;
     } finally {
@@ -104,7 +115,7 @@ export function InlineReviewActions({ client, type, record, config, onSaved }: I
 
   function iconButton(d: ReviewDecision, extraOnClick?: () => void) {
     const Icon = ICON[d.tone];
-    const active = !!d.verdict && d.verdict === verdict;
+    const active = d.key === appliedKey;
     return (
       <button
         type="button"

package/src/components/collection/__tests__/review.test.ts

@@ -124,6 +124,21 @@ describe('reviewDecisions', () => {
     expect(keys).not.toContain('reject');
   });
 
+  it('omitNeedsWork + custom transitions gives a binary accept/reject (news curation)', () => {
+    const news = type([enumAttr('status', ['new', 'surfaced', 'acceptable', 'rejected'])]);
+    const d = reviewDecisions(
+      resolveReviewConfig(news, {
+        approveStatus: 'acceptable',
+        rejectStatus: 'rejected',
+        verdicts: [],
+        omitNeedsWork: true,
+      }),
+    );
+    expect(d.map((x) => x.key).sort()).toEqual(['approve', 'reject']);
+    expect(d.find((x) => x.key === 'approve')).toMatchObject({ status: 'acceptable', verdict: null });
+    expect(d.find((x) => x.key === 'reject')).toMatchObject({ status: 'rejected', verdict: null });
+  });
+
   it('uses custom verdict vocab tones', () => {
     const d = reviewDecisions(
       resolveReviewConfig(topic, {

package/src/components/collection/review.ts

@@ -167,6 +167,8 @@ export interface ReviewConfig {
   metaAttrs?: string[];
   /** Attrs holding source urls/lines (default: source_1..3 + "sources"). */
   sourceAttrs?: string[];
+  /** Drop the middle "Needs work" decision — a binary accept/reject flow (default false). */
+  omitNeedsWork?: boolean;
 }
 
 export interface ResolvedReview {
@@ -182,6 +184,7 @@ export interface ResolvedReview {
   rankAttr: string;
   metaAttrs: string[];
   sourceAttrs: string[];
+  omitNeedsWork: boolean;
 }
 
 const DEFAULT_SOURCE_ATTRS = ['source_1', 'source_2', 'source_3', 'sources'];
@@ -212,6 +215,7 @@ export function resolveReviewConfig(
     metaAttrs: (config.metaAttrs ?? DEFAULT_META_ATTRS).filter((a) => declared.has(a)),
     // Keep source attrs the caller asked for; default to the ones this type declares.
     sourceAttrs: (config.sourceAttrs ?? DEFAULT_SOURCE_ATTRS).filter((a) => declared.has(a)),
+    omitNeedsWork: config.omitNeedsWork ?? false,
   };
 }
 
@@ -269,7 +273,7 @@ export function reviewDecisions(r: ResolvedReview): ReviewDecision[] {
   }
 
   const editVerdict = verdictOf('neutral');
-  if (entry && (editVerdict || entry !== r.transitions.approve)) {
+  if (!r.omitNeedsWork && entry && (editVerdict || entry !== r.transitions.approve)) {
     out.push({
       key: 'needs_work',
       label: 'Needs work',