@startsimpli/ui 0.4.161 → 0.4.163

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@startsimpli/ui",
-  "version": "0.4.161",
+  "version": "0.4.163",
   "description": "Shared UI components package for StartSimpli applications",
   "main": "./src/index.ts",
   "types": "./src/index.ts",
@@ -56,7 +56,7 @@
     "@codemirror/state": "^6.0.0",
     "@codemirror/view": "^6.0.0",
     "@startsimpli/api": "^0.5.68",
-    "@startsimpli/auth": "^0.4.43",
+    "@startsimpli/auth": "^0.4.44",
     "@startsimpli/i18n": "^0.1.3"
   },
   "peerDependenciesMeta": {
@@ -152,8 +152,8 @@
     "tailwindcss": "^3.4.19",
     "tsup": "^8.5.1",
     "typescript": "^6.0.3",
-    "@startsimpli/i18n": "0.1.3",
-    "@startsimpli/realtime": "0.0.2"
+    "@startsimpli/realtime": "0.0.2",
+    "@startsimpli/i18n": "0.1.3"
   },
   "keywords": [
     "ui",

package/src/components/history/RecordActivityPanel.tsx

@@ -289,9 +289,12 @@ export function RecordActivityPanel({
                 <button
                   type="button"
                   className="text-xs text-muted-foreground underline underline-offset-2 hover:text-foreground"
+                  title={`Only ${actorText}'s edits`}
                   onClick={() => onFiltersChange(prune({ ...applied, actor: sitting.actorSub }))}
                 >
-                  Only {actorText}&apos;s edits
+                  {/* The actor's name is printed on the line below; saying it
+                      again here doubled every card (bd startsim-spywp). */}
+                  Only their edits
                 </button>
               )}
             </div>

package/src/components/history/RevisionFields.tsx

@@ -33,6 +33,7 @@ import { DiffViewer } from '../diff';
 import {
   canDiffFieldChange,
   classifyFieldChange,
+  sittingNameRow,
   type FoldedFieldChange,
   type RevisionSitting,
 } from './revision-history';
@@ -180,13 +181,14 @@ export function RevisionFields({
   onNarrowToField,
 }: RevisionFieldsProps) {
   const [open, setOpen] = useState<string | null>(null);
+  const nameRow = sittingNameRow(sitting);
   const entries: Array<[string, FoldedFieldChange]> = [
     ...Object.keys(sitting.changed)
       .sort()
       .map((field) => [field, sitting.changed[field]!] as [string, FoldedFieldChange]),
     // The name COLUMN, kept namespaced away from the data keys because a tenant
     // may declare a data key literally called "name".
-    ...(sitting.name ? ([['name (title)', sitting.name]] as Array<[string, FoldedFieldChange]>) : []),
+    ...(nameRow ? ([['name (title)', nameRow]] as Array<[string, FoldedFieldChange]>) : []),
   ];
 
   return (

package/src/components/history/__tests__/record-activity-panel.test.tsx

@@ -167,7 +167,7 @@ describe('RecordActivityPanel', () => {
     const onFiltersChange = jest.fn()
     const list = jest.fn().mockResolvedValue({ next: null, results: [row('1', draftA)] })
     mount(<RecordActivityPanel client={{ list }} filters={{}} onFiltersChange={onFiltersChange} />)
-    fireEvent.click(await screen.findByRole('button', { name: /only jurga@ogmc\.example/i }))
+    fireEvent.click(await screen.findByRole('button', { name: 'Only their edits' }))
     expect(onFiltersChange).toHaveBeenCalledWith({ actor: 'u-jurga' })
   })
 
@@ -177,3 +177,46 @@ describe('RecordActivityPanel', () => {
     expect(await screen.findByText(/no edits match/i)).toBeInTheDocument()
   })
 })
+
+describe('an Activity card says each thing once (bd startsim-8udmw, startsim-spywp)', () => {
+  const scopeRec = { id: 's-1', type: 'scope', name: 'OGMC' }
+
+  it('a create counts the rows it lists, and the name row reads "set"', async () => {
+    const created = row('1', draftA, {
+      version: 1,
+      action: 'created',
+      metadata: {
+        changed: { blog: { after: 'x' }, linkedin: { after: 'y' } },
+        name: { before: '', after: 'Gulf logistics brief' },
+      },
+    })
+    const list = jest.fn().mockResolvedValue({ next: null, results: [created] })
+    mount(<RecordActivityPanel client={{ list }} filters={{}} onFiltersChange={jest.fn()} />)
+    expect(await screen.findByText('Created the record with 3 fields')).toBeInTheDocument()
+    const nameRow = screen.getByRole('button', { name: /name \(title\)/ })
+    expect(nameRow).toHaveTextContent('set')
+    expect(nameRow).not.toHaveTextContent('changed')
+  })
+
+  it('a type whose own `name` key mirrors the record name shows one name row', async () => {
+    const created = row('1', scopeRec, {
+      version: 1,
+      action: 'created',
+      metadata: {
+        changed: { name: { after: 'OGMC' }, path: { after: '/ogmc' } },
+        name: { before: null, after: 'OGMC' },
+      },
+    })
+    const list = jest.fn().mockResolvedValue({ next: null, results: [created] })
+    mount(<RecordActivityPanel client={{ list }} filters={{}} onFiltersChange={jest.fn()} />)
+    expect(await screen.findByText('Created the record with 2 fields')).toBeInTheDocument()
+    expect(screen.queryByRole('button', { name: /name \(title\)/ })).toBeNull()
+  })
+
+  it('the narrow-to-person link does not repeat the address', async () => {
+    const list = jest.fn().mockResolvedValue({ next: null, results: [row('1', draftA)] })
+    mount(<RecordActivityPanel client={{ list }} filters={{}} onFiltersChange={jest.fn()} />)
+    expect(await screen.findByRole('button', { name: 'Only their edits' })).toBeInTheDocument()
+    expect(screen.queryByText(/Only jurga@ogmc\.example's edits/)).toBeNull()
+  })
+})

package/src/components/history/index.ts

@@ -50,6 +50,7 @@ export {
   normalizeFieldChange,
   normalizeRevision,
   sittingFields,
+  sittingNameRow,
   sittingHeadline,
   sittingSummary,
 } from './revision-history';

package/src/components/history/revision-history.ts

@@ -457,6 +457,33 @@ export function sittingFields(sitting: RevisionSitting): string[] {
   return Object.keys(sitting.changed).sort();
 }
 
+/**
+ * The record-name row a sitting shows, if any (bd startsim-8udmw).
+ *
+ * Two corrections over printing `sitting.name` as is:
+ *
+ * - A type may declare its own data key `name` that mirrors the record name
+ *   (scope, client). When that key changed to the same value in the same
+ *   sitting, the name row says it a second time, under a different verb — so
+ *   it is dropped and the data row stands for both.
+ * - On a CREATE there was no name before it. The wire may still carry a
+ *   `before` (null or blank), which classified the row "changed" on a record
+ *   that had only just come into being; on a create it reads "set".
+ */
+export function sittingNameRow(sitting: RevisionSitting): FoldedFieldChange | undefined {
+  const name = sitting.name;
+  if (!name) return undefined;
+  const dataName = sitting.changed.name;
+  if (dataName && dataName.hasAfter && name.hasAfter && String(dataName.after) === String(name.after)) {
+    return undefined;
+  }
+  if (sitting.action === 'created' && name.hasBefore) {
+    const { before: _before, ...rest } = name;
+    return { ...rest, hasBefore: false };
+  }
+  return name;
+}
+
 /** "a", "a and b", "a, b and c" — an Oxford-free list, because these are field
  *  names in a sentence and not prose. */
 export function joinNames(names: string[]): string {
@@ -495,7 +522,9 @@ export function sittingHeadline(
       : `Restored ${fields.length} fields from ${from}`;
   }
   if (sitting.action === 'created') {
-    return fields.length ? `Created the record with ${fields.length} ${fields.length === 1 ? 'field' : 'fields'}` : 'Created the record';
+    // Counts the rows the reader is shown under it, name row included.
+    const count = fields.length + (sittingNameRow(sitting) ? 1 : 0);
+    return count ? `Created the record with ${count} ${count === 1 ? 'field' : 'fields'}` : 'Created the record';
   }
   if (!fields.length) return renamed ? 'Renamed the record' : 'Saved the record';
   const named =