@startsimpli/ui 0.4.116 → 0.4.117

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@startsimpli/ui",
-  "version": "0.4.116",
+  "version": "0.4.117",
   "description": "Shared UI components package for StartSimpli applications",
   "main": "./src/index.ts",
   "types": "./src/index.ts",
@@ -47,9 +47,9 @@
     "next": "^14.0.0 || ^15.0.0 || ^16.0.0",
     "react": "^18.0.0 || ^19.0.0",
     "react-dom": "^18.0.0 || ^19.0.0",
-    "@startsimpli/api": "^0.5.58",
+    "@startsimpli/auth": "^0.4.35",
     "@startsimpli/i18n": "^0.1.3",
-    "@startsimpli/auth": "^0.4.35"
+    "@startsimpli/api": "^0.5.58"
   },
   "peerDependenciesMeta": {
     "@startsimpli/api": {

package/src/components/collection/DraftReviewWorkspace.tsx

@@ -27,6 +27,7 @@ import {
   isChosen,
   gradeWords,
   wordTargets,
+  draftWordCount,
   sourceOverlapCheck,
   pickChanges,
   isRejectedTopicGroup,
@@ -332,8 +333,7 @@ function CandidateCard({
   const chosen = isChosen(record);
   const status = field(record, 'status');
   const preview = field(record, 'blog').slice(0, 150);
-  const checks = obj(readData(record.data, 'auto_checks'));
-  const blogWords = Number(get(checks, 'blogWords', 'blog_words')) || 0;
+  const blogWords = draftWordCount(record, 'blog');
   const target = wordTargets(contentType).blog;
   return (
     <div className={`flex flex-col rounded-md border p-3 ${chosen ? 'border-emerald-400 bg-emerald-50/40' : 'border-border bg-white'}`}>
@@ -407,8 +407,8 @@ function ContentReview({
   })();
 
   const targets = wordTargets(contentType);
-  const blogWords = Number(get(checks, 'blogWords', 'blog_words')) || 0;
-  const liWords = Number(get(checks, 'linkedinWords', 'linkedin_words')) || 0;
+  const blogWords = draftWordCount(record, 'blog');
+  const liWords = draftWordCount(record, 'linkedin');
   const hype = get(checks, 'hypeFlags', 'hype_flags');
   const approvedSources = get(checks, 'approvedSources', 'approved_sources');
 

package/src/components/collection/__tests__/drafts.test.ts

@@ -1,4 +1,5 @@
-import { parseSources, normUrl, groupKeyOf, groupDrafts, candidateTitle, gradeWords, wordTargets, sourceOverlapCheck, pickChanges, isRejectedTopicGroup } from '../drafts';
+import { parseSources, normUrl, groupKeyOf, groupDrafts, candidateTitle, gradeWords, wordTargets, sourceOverlapCheck, pickChanges, isRejectedTopicGroup, draftWordCount } from '../drafts';
+import { wordCount } from '../../validation';
 import type { EntityRecord } from '../types';
 
 function rec(id: string, name: string, data: Record<string, unknown>): EntityRecord {
@@ -151,3 +152,100 @@ describe('isRejectedTopicGroup (startsim-ay9l — collapse drafts of rejected to
     expect(isRejectedTopicGroup(g, new Set(['']))).toBe(false);
   });
 });
+
+/**
+ * A draft with no stored auto-checks still has a LENGTH (bd startsim-8hgmq.15).
+ *
+ * OBSERVED on the live tenant, 2026-09-07, at /drafts: a Chinese candidate card
+ * read "blog 0w … unjudged". The draft was 1027 characters, 855 of them CJK.
+ * The workspace was reading the count out of the stored `auto_checks` blob with
+ * `Number(get(checks, 'blogWords', 'blog_words')) || 0`, and the blob is null on
+ * every translated draft — `auto_checks` is written by the generator, while a
+ * translation is made by the tenant's own translate-draft, which deliberately
+ * does not inherit checks that measured text the checker never saw. So
+ * `Number(undefined) || 0` announced every translation as empty.
+ *
+ * The three live rows, all `auto_checks: null` and `judge_verdict: null`:
+ *   f6a2d629 zh  1027 chars (855 CJK)
+ *   147d0eb8 zh  1109 chars (972 CJK)
+ *   d0ca457a ar  2998 chars
+ *
+ * "unjudged" was honest — no judge ran. "0w" was not: nothing measured this
+ * draft, and an absent check must never render as a zero measurement.
+ */
+describe('draftWordCount (startsim-8hgmq.15 — a missing check is not a zero)', () => {
+  // The opening of the live zh draft f6a2d629, not invented text — the same
+  // fixture the counter's own tests use (validation/__tests__/word-count-scripts).
+  const ZH_BLOG =
+    '来自《Arabian Business》的报道显示，海湾—亚洲技术走廊正进入新阶段，' +
+    '中国企业正从单纯投资转向在GCC范围内更深度嵌入的运营模式。';
+  const EN_BLOG =
+    'The Gulf-Asia technology corridor is entering a new phase, with Chinese firms ' +
+    'moving from investment into deeper operational embedding across the GCC.';
+
+  it('counts the draft itself when the translation carries no auto_checks', () => {
+    // The reported card. Whitespace counting scores this text 2 and the old
+    // stored-only read scored it 0; either way the reviewer was told the draft
+    // was empty.
+    const zh = rec('f6a2d629', '中国—海湾科技扩张引发入局者对执行的疑问', {
+      candidate_index: 1,
+      lang: 'zh',
+      blog: ZH_BLOG,
+      auto_checks: null,
+      judge_verdict: null,
+    });
+    expect(draftWordCount(zh, 'blog')).toBeGreaterThan(20);
+  });
+
+  it('falls back for linkedin the same way', () => {
+    const zh = rec('f6a2d629', 'zh', { lang: 'zh', linkedin: ZH_BLOG, auto_checks: null });
+    expect(draftWordCount(zh, 'linkedin')).toBeGreaterThan(20);
+    expect(draftWordCount(zh, 'blog')).toBe(0); // no blog field at all IS zero
+  });
+
+  it('is a FALLBACK, not a replacement — a stored count wins', () => {
+    // Without this, "always recompute" passes the test above while quietly
+    // dropping the pipeline's own measurement, which is the number the judge and
+    // the writer agreed on.
+    const en = rec('d1', 'EN', { blog: EN_BLOG, auto_checks: { blog_words: 431, linkedin_words: 118 } });
+    expect(draftWordCount(en, 'blog')).toBe(431);
+    expect(draftWordCount(en, 'linkedin')).toBe(118);
+  });
+
+  it('reads the camelCased blob the API client returns', () => {
+    // The tenant client camelCases response keys, data blob included, so the
+    // same record arrives as autoChecks.blogWords over the wire.
+    const en = rec('d1', 'EN', { blog: EN_BLOG, autoChecks: { blogWords: 431 } });
+    expect(draftWordCount(en, 'blog')).toBe(431);
+  });
+
+  it('keeps a stored zero, which is a measurement rather than an absence', () => {
+    const empty = rec('d2', 'EN', { blog: '', auto_checks: { blog_words: 0 } });
+    expect(draftWordCount(empty, 'blog')).toBe(0);
+  });
+
+  it('recomputes when the blob exists but lacks this field', () => {
+    // A checker that ran on the blog only must not make the LinkedIn post read 0.
+    const partial = rec('d3', 'EN', { blog: EN_BLOG, linkedin: EN_BLOG, auto_checks: { blog_words: 431 } });
+    expect(draftWordCount(partial, 'blog')).toBe(431);
+    expect(draftWordCount(partial, 'linkedin')).toBe(23);
+  });
+
+  it('recomputes rather than trusting an unparseable stored value', () => {
+    const junk = rec('d4', 'EN', { blog: EN_BLOG, auto_checks: { blog_words: 'n/a' } });
+    expect(draftWordCount(junk, 'blog')).toBe(23);
+  });
+
+  it('agrees with the shared counter, so the chip and the rail cannot contradict', () => {
+    // startsim-wn2p.28: the count was wrong in four places because it was
+    // written in four places, and the screen ended up saying "524 words" and
+    // "16w" about one draft. This must stay a call to that one function.
+    const en = rec('d5', 'EN', { blog: EN_BLOG, auto_checks: null });
+    expect(draftWordCount(en, 'blog')).toBe(wordCount(EN_BLOG));
+  });
+
+  it('is 0 for a draft that really is empty', () => {
+    expect(draftWordCount(rec('d6', 'EN', { blog: '', auto_checks: null }), 'blog')).toBe(0);
+    expect(draftWordCount(rec('d7', 'EN', {}), 'blog')).toBe(0);
+  });
+});

package/src/components/collection/__tests__/translated-draft-word-chip.test.tsx

@@ -0,0 +1,129 @@
+/**
+ * The compare workspace must not tell a reviewer that a full draft is empty
+ * (bd startsim-8hgmq.15).
+ *
+ * OBSERVED on the live tenant, 2026-09-07, at /drafts. A Chinese candidate card
+ * in the "How Chinese Firms Are Anchoring Into the Gulf Tech Corridor" set read
+ *
+ *   blog 0w   unjudged
+ *
+ * and the draft behind it was 1027 characters, 855 of them CJK. Half of that
+ * card was honest: no judge ran on a translation, so "unjudged" is true. The
+ * other half was a MISSING measurement rendered as a real zero — the card read
+ * the count out of the stored `auto_checks` blob, which a translation never
+ * gets, and `Number(undefined) || 0` is 0.
+ *
+ * `drafts.test.ts` pins the counting rule. This pins the SCREEN, at the level
+ * the defect was reported at: mount the workspace over a stubbed tenant client
+ * holding the three real drafts and read the chips.
+ */
+import * as React from 'react';
+import { render, screen, waitFor, within } from '@testing-library/react';
+import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
+
+// react-markdown is ESM and this suite is not; the workspace pulls it in only
+// to render an OPEN draft's body, which no assertion here reads.
+jest.mock('../../blog/MarkdownRenderer', () => ({
+  MarkdownRenderer: ({ content }: { content: string }) => <div>{content}</div>,
+}));
+
+import { DraftReviewWorkspace } from '../DraftReviewWorkspace';
+import type { CollectionClient, EntityRecord, EntityTypeDef, Paginated } from '../types';
+
+const DRAFT_TYPE: EntityTypeDef = { id: 1, key: 'draft', label: 'Draft', attributes: [] };
+
+function page<T>(results: T[]): Paginated<T> {
+  return { count: results.length, next: null, previous: null, results };
+}
+
+function draft(id: number, name: string, data: Record<string, unknown>): EntityRecord {
+  return {
+    id,
+    entityType: 'draft',
+    externalId: null,
+    name,
+    data: { content_type: 'weekly_brief', topic_ref: 'topic-1', topic_title: 'Gulf tech corridor', ...data },
+    createdAt: '2026-09-01T00:00:00Z',
+  };
+}
+
+// The opening of the live zh draft f6a2d629 — real text, not a repeat()ed glyph.
+const ZH_BLOG =
+  '来自《Arabian Business》的报道显示，海湾—亚洲技术走廊正进入新阶段，' +
+  '中国企业正从单纯投资转向在GCC范围内更深度嵌入的运营模式。';
+const EN_BLOG =
+  'The Gulf-Asia technology corridor is entering a new phase, with Chinese firms ' +
+  'moving from investment into deeper operational embedding across the GCC.';
+
+/** The English original, which the writer checked, and its zh translation, which nothing checked. */
+const DRAFTS: EntityRecord[] = [
+  draft(1, 'Candidate 1 — Gulf tech corridor', {
+    candidate_index: 1,
+    story_title: 'China-Gulf Tech Expansion Raises Execution Questions for Entrants',
+    lang: 'en',
+    blog: EN_BLOG,
+    auto_checks: { blog_words: 431, linkedin_words: 180 },
+    judge_verdict: { verdict: 'accept' },
+  }),
+  draft(2, 'Candidate 2 — Gulf tech corridor', {
+    candidate_index: 2,
+    story_title: '中国—海湾科技扩张引发入局者对执行的疑问',
+    lang: 'zh',
+    blog: ZH_BLOG,
+    // Exactly how the live translations are stored: the generator's checks and
+    // verdict are NOT inherited, because they measured text neither one saw.
+    auto_checks: null,
+    judge_verdict: null,
+  }),
+];
+
+function stubClient(): CollectionClient {
+  return {
+    listTypes: jest.fn(async () => page([DRAFT_TYPE])),
+    listAllEntities: jest.fn(async (type: string) => (type === 'draft' ? DRAFTS : [])),
+    updateEntity: jest.fn(async () => DRAFTS[0]),
+  };
+}
+
+function renderWorkspace() {
+  const qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
+  return render(
+    <QueryClientProvider client={qc}>
+      <DraftReviewWorkspace client={stubClient()} />
+    </QueryClientProvider>,
+  );
+}
+
+/** The card for one candidate, found by the title the reviewer reads. */
+async function card(title: string): Promise<HTMLElement> {
+  const heading = await screen.findByText(title);
+  const el = heading.closest('div.flex.flex-col');
+  if (!el) throw new Error(`no candidate card around "${title}"`);
+  return el as HTMLElement;
+}
+
+describe('a translated candidate card (startsim-8hgmq.15)', () => {
+  it('shows the draft’s real length instead of “blog 0w”', async () => {
+    renderWorkspace();
+    const zh = await card('中国—海湾科技扩张引发入局者对执行的疑问');
+
+    expect(within(zh).queryByText(/^blog 0w/)).toBeNull();
+    const chip = within(zh).getByText(/^blog \d+w/);
+    const words = Number(chip.textContent!.match(/blog (\d+)w/)![1]);
+    expect(words).toBeGreaterThan(20);
+  });
+
+  it('still says “unjudged”, which was the honest half of that card', async () => {
+    // No judge ran on the translation. The fix is to stop faking the count, not
+    // to fake a verdict alongside it.
+    renderWorkspace();
+    const zh = await card('中国—海湾科技扩张引发入局者对执行的疑问');
+    expect(within(zh).getByText('unjudged')).toBeTruthy();
+  });
+
+  it('leaves a checked candidate showing the count the pipeline stored', async () => {
+    renderWorkspace();
+    const en = await card('China-Gulf Tech Expansion Raises Execution Questions for Entrants');
+    await waitFor(() => expect(within(en).getByText(/^blog 431w/)).toBeTruthy());
+  });
+});

package/src/components/collection/drafts.ts

@@ -9,7 +9,7 @@
  */
 import type { EntityRecord } from './types';
 import { readData } from './data';
-import { runContentChecks, type ContentCheck } from '../validation';
+import { runContentChecks, wordCount, type ContentCheck } from '../validation';
 
 export interface DraftSource {
   url: string;
@@ -160,6 +160,49 @@ export function wordTargets(contentType: string): { blog: [number, number]; link
   }
 }
 
+/**
+ * The word count to SHOW for one field of one draft (bd startsim-8hgmq.15).
+ *
+ * WHY THIS EXISTS. The workspace used to read the count straight out of the
+ * stored blob — `Number(get(checks, 'blogWords', 'blog_words')) || 0` — and on
+ * 2026-09-07 a live Chinese candidate at /drafts advertised itself as
+ * "blog 0w … unjudged". The draft was 1027 characters, 855 of them CJK.
+ *
+ * `auto_checks` is written by the pipeline that GENERATES a candidate. A
+ * TRANSLATION is created by the tenant's own translate-draft, which copies the
+ * prose and deliberately does not inherit the generator's checks or verdict —
+ * they measured text neither one ever saw. So `auto_checks` is null on every
+ * translation, `Number(undefined) || 0` is 0, and every translated draft in the
+ * compare workspace announced itself as empty. Structural, not a bad row: the
+ * three live translations (zh, zh, ar) all read 0w, and so would every future
+ * one. "unjudged" beside it was honest — no judge ran — but an ABSENT check must
+ * never render as a zero MEASUREMENT.
+ *
+ * ABSENCE FALLS BACK, FALSINESS DOES NOT. A stored `0` is a measurement the
+ * pipeline actually took and it survives; only a missing or unparseable value is
+ * recomputed. That is the whole bug: the old code tested truthiness where it
+ * meant presence.
+ *
+ * IT RECOUNTS RATHER THAN BLANKING because the reviewer's job here is comparing
+ * candidates, and "—" tells them nothing about whether this one runs long.
+ *
+ * IT CALLS THE SHARED `wordCount` WITH NO LOCALE, exactly as `runContentChecks`
+ * does, so the chip and the validation rail on the same screen cannot disagree
+ * about one draft. This is a FALLBACK TO that function, never a second
+ * implementation of it — bd startsim-wn2p.28 was one line of arithmetic that
+ * took four PRs because the count had been written in four places, and the
+ * half-fixed screen read "524 words" in the rail and "16w" on the tab above it.
+ */
+export function draftWordCount(r: EntityRecord, field: 'blog' | 'linkedin'): number {
+  const checks = readData(r.data, 'auto_checks');
+  const bag = checks && typeof checks === 'object' && !Array.isArray(checks) ? (checks as Record<string, unknown>) : null;
+  // Both spellings, because the tenant API client camelCases the data blob.
+  const stored = bag ? bag[`${field}Words`] ?? bag[`${field}_words`] : undefined;
+  const n = Number(stored);
+  if (stored != null && stored !== '' && Number.isFinite(n)) return n;
+  return wordCount(str(readData(r.data, field)));
+}
+
 export type CheckStatus = 'ok' | 'low' | 'high' | 'none';
 
 /** Grade a word count against a [lo, hi] target. hi===0 means "no target". */

package/src/components/collection/index.ts

@@ -61,6 +61,7 @@ export {
   groupDrafts,
   wordTargets,
   gradeWords,
+  draftWordCount,
   type DraftSource,
   type DraftGroup,
   type CheckStatus,