@startsimpli/integrations 0.2.22 → 0.2.23

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@startsimpli/integrations",
-  "version": "0.2.22",
+  "version": "0.2.23",
   "description": "Provider-agnostic types, API clients, hooks, and UI primitives for email + calendar integrations across StartSimpli apps.",
   "main": "./src/index.ts",
   "types": "./src/index.ts",

package/src/__tests__/connections.test.tsx

@@ -997,3 +997,113 @@ describe('ConnectionsPage — foundry mode is untouched by personal mode', () =>
     expect(within(section).getByRole('button', { name: /^Save$/i })).toBeInTheDocument();
   });
 });
+
+// --------------------------------------------------------------------------
+//  the members' roster: a verb only where it still does something
+//  (bd startsim-768w.22.25.19)
+// --------------------------------------------------------------------------
+
+/**
+ * One row per status, because the whole defect was a button that never read
+ * the status. `disabled` is the row AFTER a disconnect — key deleted, tokens
+ * revoked, fetches stopped. `error` and `needs_reauth` still hold a stored
+ * credential and a live poll leg, and they are the rows an admin offboarding
+ * somebody most needs to cut, so the suppression has to be narrow enough to
+ * leave them alone.
+ */
+const MEMBER_ROWS = [
+  {
+    id: 'm-live', owner: { id: 'u1', email: 'ana@acme.test', name: 'Ana' },
+    connector_key: 'n8n', connector_name: 'n8n', name: 'Ana n8n',
+    account_label: 'ana@acme.test', status: 'connected', health: 'ok',
+  },
+  {
+    id: 'm-broken', owner: { id: 'u2', email: 'bo@acme.test', name: 'Bo' },
+    connector_key: 'granola', connector_name: 'Granola', name: 'Bo Granola',
+    account_label: 'bo@acme.test', status: 'error', health: 'failing',
+    check_error: 'Vendor said 401',
+  },
+  {
+    id: 'm-stale', owner: { id: 'u3', email: 'cy@acme.test', name: 'Cy' },
+    connector_key: 'granola', connector_name: 'Granola', name: 'Cy Granola',
+    account_label: 'cy@acme.test', status: 'needs_reauth', health: 'expired',
+  },
+  {
+    id: 'm-gone', owner: { id: 'u4', email: 'di@acme.test', name: 'Di' },
+    connector_key: 'n8n', connector_name: 'n8n', name: 'Di n8n',
+    account_label: 'di@acme.test', status: 'disabled', health: 'disconnected',
+  },
+];
+
+function rosterApi(overrides: Partial<ConnectionsApi> = {}): ConnectionsApi {
+  return stubApi({
+    memberConnections: vi.fn().mockResolvedValue({
+      results: MEMBER_ROWS,
+      permissions: { view: true, manage: true, issue_tokens: false },
+    }),
+    disconnectMemberConnection: vi.fn().mockResolvedValue(undefined),
+    ...overrides,
+  } as Partial<ConnectionsApi>);
+}
+
+/** The card element for one member row, by the id the roster stamps on it. */
+async function memberCard(id: string): Promise<HTMLElement> {
+  return waitFor(() => {
+    const el = document.querySelector<HTMLElement>(`div[data-member-connection="${id}"]`);
+    if (!el) throw new Error(`no member row rendered for ${id}`);
+    return el;
+  });
+}
+
+describe('MemberConnectionRoster — Disconnect is not offered twice', () => {
+  it('does NOT offer Disconnect on a row that is already disconnected', async () => {
+    render(<ConnectionsPage api={rosterApi()} foundrySlug="acme" />);
+    const gone = await memberCard('m-gone');
+    expect(within(gone).queryByRole('button', { name: /Disconnect/i })).toBeNull();
+  });
+
+  it('says the account is gone and that only the member can bring it back', async () => {
+    // The row STAYS. Who used to hold a pipe into this foundry is the answer an
+    // offboarding review is looking for; hiding it would lose that.
+    render(<ConnectionsPage api={rosterApi()} foundrySlug="acme" />);
+    const gone = await memberCard('m-gone');
+    const note = gone.querySelector('[data-member-connection-disconnected]');
+    expect(note).not.toBeNull();
+    expect(note!.textContent).toMatch(/Disconnected\./);
+    expect(note!.textContent).toMatch(/di@acme\.test has to connect with n8n again/);
+  });
+
+  it('never claims a deleted key "cannot be undone"', async () => {
+    // The exact copy the bead objects to, over a key that is already gone.
+    render(<ConnectionsPage api={rosterApi()} foundrySlug="acme" />);
+    const gone = await memberCard('m-gone');
+    expect(within(gone).queryByText(/cannot be undone/i)).toBeNull();
+    expect(within(gone).queryByText(/stored key is deleted and their/i)).toBeNull();
+  });
+
+  it('KEEPS Disconnect on a failing row, whose key is still stored', async () => {
+    render(<ConnectionsPage api={rosterApi()} foundrySlug="acme" />);
+    const broken = await memberCard('m-broken');
+    expect(within(broken).getByRole('button', { name: /^Disconnect$/i }))
+      .toBeInTheDocument();
+  });
+
+  it('KEEPS Disconnect on a needs_reauth row, whose poll leg is still live', async () => {
+    render(<ConnectionsPage api={rosterApi()} foundrySlug="acme" />);
+    const stale = await memberCard('m-stale');
+    expect(within(stale).getByRole('button', { name: /^Disconnect$/i }))
+      .toBeInTheDocument();
+  });
+
+  it('still cuts a connected row, naming the person before it does', async () => {
+    const api = rosterApi();
+    render(<ConnectionsPage api={api} foundrySlug="acme" />);
+    const live = await memberCard('m-live');
+    await userEvent.click(within(live).getByRole('button', { name: /^Disconnect$/i }));
+    const prompt = within(live).getByText(/cannot be undone/i);
+    expect(prompt.textContent).toContain('ana@acme.test');
+    await userEvent.click(within(live).getByRole('button', { name: /Yes, disconnect/i }));
+    await waitFor(() =>
+      expect(api.disconnectMemberConnection).toHaveBeenCalledWith('acme', 'm-live'));
+  });
+});

package/src/components/pages/MemberConnectionRoster.tsx

@@ -108,6 +108,19 @@ function MemberConnectionCard({
   const [error, setError] = React.useState('');
   const who = row.owner?.email || row.owner?.name || 'Unknown member';
 
+  /**
+   * ALREADY CUT (bd startsim-768w.22.25.19). `disabled` is the status a row
+   * carries AFTER a disconnect: the key is deleted, the tokens are revoked and
+   * the scheduled fetches are stopped. There is nothing left for this verb to
+   * do, so offering it — and then confirming with "this cannot be undone" over
+   * a key that is already gone — describes an action the server would refuse.
+   *
+   * ONLY `disabled`. `error` and `needs_reauth` still hold a stored credential
+   * and a live poll leg; they are exactly the rows an admin offboarding someone
+   * most needs to cut, so the test for this asserts they keep the button.
+   */
+  const alreadyDisconnected = row.status === 'disabled';
+
   async function cut() {
     if (!disconnect) return;
     setBusy(true);
@@ -143,8 +156,18 @@ function MemberConnectionCard({
               anything the member submitted. An admin deciding whether to cut a
               pipe is entitled to know it is already broken. */}
           {row.check_error ? <p className={cn.error}>{row.check_error}</p> : null}
+          {/* THE ROW STAYS. Who USED to have a pipe into this foundry is the
+              answer an offboarding review is looking for, so a disconnected
+              account is not hidden — it is labelled, and its verb is gone. */}
+          {alreadyDisconnected ? (
+            <p className={cn.muted} data-member-connection-disconnected>
+              Disconnected. This account’s key was deleted and its scheduled
+              fetches stopped. Nothing here can bring it back —{' '}
+              {who} has to connect with {row.connector_name} again themselves.
+            </p>
+          ) : null}
         </div>
-        {canManage && disconnect ? (
+        {canManage && disconnect && !alreadyDisconnected ? (
           <button
             type="button"
             className={cn.button}
@@ -155,7 +178,11 @@ function MemberConnectionCard({
           </button>
         ) : null}
       </div>
-      {confirming ? (
+      {/* `alreadyDisconnected` again, not because the button can open this today
+          but because a reload can flip the row to `disabled` under an open
+          prompt — and the one thing this prompt must never do is warn that an
+          action "cannot be undone" about a key that is already gone. */}
+      {confirming && !alreadyDisconnected ? (
         <div className="mt-3 space-y-2">
           {/* NAMES THE PERSON, because the cost of this button falls on them and
               not on the admin pressing it. A generic "are you sure?" over a list