@startsimpli/integrations 0.1.6 → 0.2.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@startsimpli/integrations",
-  "version": "0.1.6",
+  "version": "0.2.2",
   "description": "Provider-agnostic types, API clients, hooks, and UI primitives for email + calendar integrations across StartSimpli apps.",
   "main": "./src/index.ts",
   "types": "./src/index.ts",
@@ -48,7 +48,7 @@
     "react-dom": "^19.0.0",
     "typescript": "^6.0.0",
     "vitest": "^3.0.0",
-    "@startsimpli/llm": "0.4.14"
+    "@startsimpli/llm": "0.4.15"
   },
   "scripts": {
     "type-check": "tsc --noEmit",

package/src/__tests__/connections.test.tsx

@@ -204,6 +204,7 @@ function stubApi(overrides: Partial<ConnectionsApi> = {}): ConnectionsApi {
     }),
     connectionRuns: vi.fn().mockResolvedValue({ results: [] }),
     updateConnection: vi.fn().mockResolvedValue(CONNECTED.results[0]),
+    rotateCredential: vi.fn().mockResolvedValue(CONNECTED.results[0]),
     ...overrides,
   } as ConnectionsApi;
 }
@@ -383,6 +384,181 @@ describe('capabilities are the admin’s choice, and the page has to ask', () =>
   });
 });
 
+// --------------------------------------------------------------------------
+//  a card an admin can actually maintain (bd startsim-768w.22.24)
+// --------------------------------------------------------------------------
+
+/**
+ * WHAT A CONNECTED CARD COULD DO BEFORE THIS: test it, discover its workflows,
+ * change its capabilities, wire and fire a target. That is the whole list. It
+ * could not have its KEY REPLACED and it could not be REMOVED — the two things
+ * an admin holding a freshly-minted API key actually needs.
+ *
+ * `POST /connections/<id>/credential/` has done a checked, non-destructive
+ * rotation since the endpoint was designed, and `DELETE /connections/<id>/` has
+ * done a transactional disconnect for just as long. `disconnect` was even
+ * declared on this page's own api contract. NOTHING RENDERED EITHER ONE. So an
+ * admin with a new key had exactly one control that looked like it would take
+ * one — the connect form — and using it hit a duplicate-credential collision
+ * that came back as a Django HTML 500 (the server half is bd
+ * startsim-768w.22.24 too). The missing button is the actual bug; the 500 is
+ * only where it surfaced.
+ */
+describe('replacing the key on a connection that already exists', () => {
+  async function openReplaceForm(api = stubApi()) {
+    render(<ConnectionsPage api={api} foundrySlug="acme" />);
+    await screen.findByText('Ops n8n');
+    await userEvent.click(screen.getByRole('button', { name: /replace key|new key/i }));
+    return api;
+  }
+
+  it('offers a way to replace the key on a connected card', async () => {
+    render(<ConnectionsPage api={stubApi()} foundrySlug="acme" />);
+    await screen.findByText('Ops n8n');
+    expect(
+      screen.getByRole('button', { name: /replace key|new key/i }),
+    ).toBeInTheDocument();
+  });
+
+  it('renders the connector’s OWN credential fields, from the catalog row', async () => {
+    // Same schema-driven renderer as the connect form. A bespoke "paste your
+    // key" box would be the per-vendor branch this layer exists to refuse: the
+    // fixture connector takes a url + a secret + a select, and the replace form
+    // has to show the ones that are credentials.
+    await openReplaceForm();
+    expect(await screen.findByLabelText(/Public API key/i)).toBeInTheDocument();
+  });
+
+  it('says the current key survives a bad paste, where the admin can read it', async () => {
+    // The reassurance someone pasting a production key wants, and it is TRUE:
+    // rotation runs check() against the vendor and writes only on success, so a
+    // wrong key leaves the working one live. Saying nothing here is what makes
+    // people go looking for a "safer" path — which is the connect form.
+    await openReplaceForm();
+    expect(
+      screen.getByText(/before it replaces|until the new one|only if it works|nothing changes/i),
+    ).toBeInTheDocument();
+  });
+
+  it('sends the pasted key to the ROTATE endpoint, not to connect', async () => {
+    const api = await openReplaceForm();
+    await userEvent.type(screen.getByLabelText(/Public API key/i), 'n_new_key_123');
+    await userEvent.click(screen.getByRole('button', { name: /^replace$|test and replace/i }));
+
+    await waitFor(() => expect(api.rotateCredential).toHaveBeenCalledWith('acme', 'c1', {
+      api_key: 'n_new_key_123',
+    }));
+    expect(api.connect).not.toHaveBeenCalled();
+  });
+
+  it('reports a rejected key instead of claiming the rotation landed', async () => {
+    const rejected = Object.assign(new Error('Invalid API key format'), { status: 401 });
+    const api = stubApi({ rotateCredential: vi.fn().mockRejectedValue(rejected) });
+    await openReplaceForm(api);
+    await userEvent.type(screen.getByLabelText(/Public API key/i), 'bad');
+    await userEvent.click(screen.getByRole('button', { name: /^replace$|test and replace/i }));
+
+    expect(await screen.findByText(/Invalid API key format/)).toBeInTheDocument();
+  });
+
+  it('does not offer to replace a key when manage is false', async () => {
+    const api = stubApi({
+      connections: vi.fn().mockResolvedValue({
+        ...CONNECTED,
+        permissions: { view: true, manage: false, issue_tokens: false },
+      }),
+    });
+    render(<ConnectionsPage api={api} foundrySlug="acme" />);
+    await screen.findByText('Ops n8n');
+    expect(
+      screen.queryByRole('button', { name: /replace key|new key/i }),
+    ).not.toBeInTheDocument();
+  });
+});
+
+describe('removing a connection', () => {
+  it('offers disconnect on a connected card', async () => {
+    render(<ConnectionsPage api={stubApi()} foundrySlug="acme" />);
+    await screen.findByText('Ops n8n');
+    expect(screen.getByRole('button', { name: /disconnect/i })).toBeInTheDocument();
+  });
+
+  it('CONFIRMS first, and says what stops', async () => {
+    // Disconnect is not an edit. It stops the scheduled fetches, stops the
+    // outbound sends and revokes every token issued for this account, in one
+    // transaction. A single misclick doing all of that silently is not a
+    // control an admin can use with confidence.
+    const api = stubApi();
+    render(<ConnectionsPage api={api} foundrySlug="acme" />);
+    await screen.findByText('Ops n8n');
+    await userEvent.click(screen.getByRole('button', { name: /^disconnect$/i }));
+
+    expect(api.disconnect).not.toHaveBeenCalled();
+    expect(screen.getByText(/stop|revoke/i)).toBeInTheDocument();
+  });
+
+  it('disconnects once confirmed, and refreshes the list', async () => {
+    const api = stubApi();
+    render(<ConnectionsPage api={api} foundrySlug="acme" />);
+    await screen.findByText('Ops n8n');
+    await userEvent.click(screen.getByRole('button', { name: /^disconnect$/i }));
+    await userEvent.click(screen.getByRole('button', { name: /yes, disconnect|confirm disconnect/i }));
+
+    await waitFor(() => expect(api.disconnect).toHaveBeenCalledWith('acme', 'c1'));
+    // Two loads: the mount, and the one after the card changed.
+    await waitFor(() => expect(
+      (api.connections as ReturnType<typeof vi.fn>).mock.calls.length,
+    ).toBeGreaterThan(1));
+  });
+
+  it('lets an admin back out of the confirmation', async () => {
+    const api = stubApi();
+    render(<ConnectionsPage api={api} foundrySlug="acme" />);
+    await screen.findByText('Ops n8n');
+    await userEvent.click(screen.getByRole('button', { name: /^disconnect$/i }));
+    await userEvent.click(screen.getByRole('button', { name: /cancel/i }));
+
+    expect(api.disconnect).not.toHaveBeenCalled();
+    expect(
+      screen.queryByRole('button', { name: /yes, disconnect|confirm disconnect/i }),
+    ).not.toBeInTheDocument();
+  });
+
+  it('does not offer disconnect when manage is false', async () => {
+    const api = stubApi({
+      connections: vi.fn().mockResolvedValue({
+        ...CONNECTED,
+        permissions: { view: true, manage: false, issue_tokens: false },
+      }),
+    });
+    render(<ConnectionsPage api={api} foundrySlug="acme" />);
+    await screen.findByText('Ops n8n');
+    expect(screen.queryByRole('button', { name: /disconnect/i })).not.toBeInTheDocument();
+  });
+});
+
+describe('the connect form knows what is already connected', () => {
+  it('says so, and names the card, before an admin fills the form in again', async () => {
+    // The server now answers a duplicate connect with a 409 that names the card
+    // (bd startsim-768w.22.24) instead of an IntegrityError. Saying it HERE
+    // costs a round trip less and, more to the point, catches the admin before
+    // they have pasted a production key into the wrong form.
+    render(<ConnectionsPage api={stubApi()} foundrySlug="acme" />);
+    await userEvent.click(await screen.findByRole('button', { name: /^connect$/i }));
+    expect(screen.getByText(/already connected/i)).toBeInTheDocument();
+    expect(screen.getAllByText(/Ops n8n/).length).toBeGreaterThan(1);
+  });
+
+  it('still allows a SECOND account on the same vendor', async () => {
+    // Two workspaces on one vendor are two accounts and two cards — the server
+    // says so in `Connection`'s own constraint. The warning is a warning, never
+    // a lock.
+    render(<ConnectionsPage api={stubApi()} foundrySlug="acme" />);
+    await userEvent.click(await screen.findByRole('button', { name: /^connect$/i }));
+    expect(screen.getByRole('button', { name: /test and save/i })).toBeInTheDocument();
+  });
+});
+
 describe('the catalog envelope, as the server actually ships it', () => {
   // REGRESSION. The first browser drive of this page died on
   // `(entry.credential_schema ?? []) is not iterable`, because these fixtures