@startsimpli/funnels 0.4.6 → 0.4.8

package/src/components/FilterRuleEditor/FilterRuleEditor.test.tsx

@@ -47,7 +47,7 @@ const investorFieldRegistry: FieldDefinition[] = [
     category: 'Investment',
     operators: ['eq', 'ne', 'gt', 'lt', 'gte', 'lte'],
     constraints: {
-      min_value: 0,
+      minValue: 0,
     },
   },
   {
@@ -57,8 +57,8 @@ const investorFieldRegistry: FieldDefinition[] = [
     category: 'Metrics',
     operators: ['eq', 'ne', 'gt', 'lt', 'gte', 'lte'],
     constraints: {
-      min_value: 0,
-      max_value: 100,
+      minValue: 0,
+      maxValue: 100,
     },
   },
   {
@@ -108,7 +108,7 @@ const recipeFieldRegistry: FieldDefinition[] = [
     category: 'Time',
     operators: ['eq', 'ne', 'gt', 'lt', 'gte', 'lte'],
     constraints: {
-      min_value: 0,
+      minValue: 0,
     },
   },
   {
@@ -119,7 +119,7 @@ const recipeFieldRegistry: FieldDefinition[] = [
     operators: ['eq', 'is_true', 'is_false'],
   },
   {
-    name: 'created_at',
+    name: 'createdAt',
     label: 'Created Date',
     type: 'date',
     category: 'Metadata',
@@ -132,20 +132,20 @@ const recipeFieldRegistry: FieldDefinition[] = [
 // ============================================================================
 
 describe('FilterRuleEditor - Generic Validation', () => {
-  it('validates empty field_path', () => {
+  it('validates empty fieldPath', () => {
     const rule: FilterRule = {
-      field_path: '',
+      fieldPath: '',
       operator: 'eq',
       value: 'test',
     };
 
     const errors = validateFilterRule(rule);
-    expect(errors).toContain('field_path is required');
+    expect(errors).toContain('fieldPath is required');
   });
 
   it('validates missing operator', () => {
     const rule: FilterRule = {
-      field_path: 'name',
+      fieldPath: 'name',
       operator: '' as any,
       value: 'test',
     };
@@ -156,7 +156,7 @@ describe('FilterRuleEditor - Generic Validation', () => {
 
   it('validates missing value for operators that need it', () => {
     const rule: FilterRule = {
-      field_path: 'name',
+      fieldPath: 'name',
       operator: 'eq',
       value: undefined,
     };
@@ -171,7 +171,7 @@ describe('FilterRuleEditor - Generic Validation', () => {
 
     nullOps.forEach((op) => {
       const rule: FilterRule = {
-        field_path: 'email',
+        fieldPath: 'email',
         operator: op as any,
         value: null,
       };
@@ -185,7 +185,7 @@ describe('FilterRuleEditor - Generic Validation', () => {
 describe('FilterRuleEditor - Investor Domain', () => {
   it('creates string equality rule', () => {
     const rule: FilterRule = {
-      field_path: 'name',
+      fieldPath: 'name',
       operator: 'eq',
       value: 'John Doe',
     };
@@ -195,7 +195,7 @@ describe('FilterRuleEditor - Investor Domain', () => {
 
   it('creates string contains rule', () => {
     const rule: FilterRule = {
-      field_path: 'email',
+      fieldPath: 'email',
       operator: 'contains',
       value: '@vc.com',
     };
@@ -205,7 +205,7 @@ describe('FilterRuleEditor - Investor Domain', () => {
 
   it('creates choice equality rule', () => {
     const rule: FilterRule = {
-      field_path: 'firm.stage',
+      fieldPath: 'firm.stage',
       operator: 'eq',
       value: 'Series A',
     };
@@ -215,7 +215,7 @@ describe('FilterRuleEditor - Investor Domain', () => {
 
   it('creates choice multi-select rule', () => {
     const rule: FilterRule = {
-      field_path: 'firm.stage',
+      fieldPath: 'firm.stage',
       operator: 'in',
       value: ['Series A', 'Series B', 'Series C'],
     };
@@ -225,7 +225,7 @@ describe('FilterRuleEditor - Investor Domain', () => {
 
   it('creates number comparison rule', () => {
     const rule: FilterRule = {
-      field_path: 'firm.check_size_min',
+      fieldPath: 'firm.check_size_min',
       operator: 'gte',
       value: 1000000,
     };
@@ -235,7 +235,7 @@ describe('FilterRuleEditor - Investor Domain', () => {
 
   it('creates number range rule', () => {
     const rule: FilterRule = {
-      field_path: 'metrics.icp_score',
+      fieldPath: 'metrics.icp_score',
       operator: 'gte',
       value: 80,
     };
@@ -245,7 +245,7 @@ describe('FilterRuleEditor - Investor Domain', () => {
 
   it('creates tag rule', () => {
     const rule: FilterRule = {
-      field_path: 'tags',
+      fieldPath: 'tags',
       operator: 'has_tag',
       value: 'priority',
     };
@@ -257,7 +257,7 @@ describe('FilterRuleEditor - Investor Domain', () => {
 describe('FilterRuleEditor - Recipe Domain', () => {
   it('creates recipe title search rule', () => {
     const rule: FilterRule = {
-      field_path: 'title',
+      fieldPath: 'title',
       operator: 'contains',
       value: 'pasta',
     };
@@ -267,7 +267,7 @@ describe('FilterRuleEditor - Recipe Domain', () => {
 
   it('creates cuisine filter rule', () => {
     const rule: FilterRule = {
-      field_path: 'cuisine',
+      fieldPath: 'cuisine',
       operator: 'eq',
       value: 'Italian',
     };
@@ -277,7 +277,7 @@ describe('FilterRuleEditor - Recipe Domain', () => {
 
   it('creates multiple cuisine rule', () => {
     const rule: FilterRule = {
-      field_path: 'cuisine',
+      fieldPath: 'cuisine',
       operator: 'in',
       value: ['Italian', 'French', 'Japanese'],
     };
@@ -287,7 +287,7 @@ describe('FilterRuleEditor - Recipe Domain', () => {
 
   it('creates difficulty filter rule', () => {
     const rule: FilterRule = {
-      field_path: 'difficulty',
+      fieldPath: 'difficulty',
       operator: 'eq',
       value: 'Easy',
     };
@@ -297,7 +297,7 @@ describe('FilterRuleEditor - Recipe Domain', () => {
 
   it('creates prep time rule', () => {
     const rule: FilterRule = {
-      field_path: 'prep_time_minutes',
+      fieldPath: 'prep_time_minutes',
       operator: 'lte',
       value: 30,
     };
@@ -307,7 +307,7 @@ describe('FilterRuleEditor - Recipe Domain', () => {
 
   it('creates boolean rule', () => {
     const rule: FilterRule = {
-      field_path: 'is_vegetarian',
+      fieldPath: 'is_vegetarian',
       operator: 'is_true',
       value: null,
     };
@@ -317,7 +317,7 @@ describe('FilterRuleEditor - Recipe Domain', () => {
 
   it('creates date comparison rule', () => {
     const rule: FilterRule = {
-      field_path: 'created_at',
+      fieldPath: 'createdAt',
       operator: 'gte',
       value: '2024-01-01',
     };
@@ -330,17 +330,17 @@ describe('FilterRuleEditor - Complex Multi-Rule Scenarios', () => {
   it('validates AND logic with multiple rules', () => {
     const rules: FilterRule[] = [
       {
-        field_path: 'firm.stage',
+        fieldPath: 'firm.stage',
         operator: 'in',
         value: ['Series A', 'Series B'],
       },
       {
-        field_path: 'firm.check_size_min',
+        fieldPath: 'firm.check_size_min',
         operator: 'gte',
         value: 500000,
       },
       {
-        field_path: 'metrics.icp_score',
+        fieldPath: 'metrics.icp_score',
         operator: 'gte',
         value: 70,
       },
@@ -354,17 +354,17 @@ describe('FilterRuleEditor - Complex Multi-Rule Scenarios', () => {
   it('validates OR logic with different field types', () => {
     const rules: FilterRule[] = [
       {
-        field_path: 'name',
+        fieldPath: 'name',
         operator: 'contains',
         value: 'Acme',
       },
       {
-        field_path: 'tags',
+        fieldPath: 'tags',
         operator: 'has_tag',
         value: 'hot-lead',
       },
       {
-        field_path: 'metrics.icp_score',
+        fieldPath: 'metrics.icp_score',
         operator: 'gte',
         value: 90,
       },
@@ -378,22 +378,22 @@ describe('FilterRuleEditor - Complex Multi-Rule Scenarios', () => {
   it('validates recipe filter with multiple conditions', () => {
     const rules: FilterRule[] = [
       {
-        field_path: 'cuisine',
+        fieldPath: 'cuisine',
         operator: 'in',
         value: ['Italian', 'French'],
       },
       {
-        field_path: 'difficulty',
+        fieldPath: 'difficulty',
         operator: 'eq',
         value: 'Easy',
       },
       {
-        field_path: 'prep_time_minutes',
+        fieldPath: 'prep_time_minutes',
         operator: 'lte',
         value: 30,
       },
       {
-        field_path: 'is_vegetarian',
+        fieldPath: 'is_vegetarian',
         operator: 'is_true',
         value: null,
       },
@@ -477,7 +477,7 @@ describe('FilterRuleEditor - Operator Filtering', () => {
   });
 
   it('provides correct operators for date fields', () => {
-    const dateField = recipeFieldRegistry.find((f) => f.name === 'created_at');
+    const dateField = recipeFieldRegistry.find((f) => f.name === 'createdAt');
     expect(dateField?.operators).toContain('eq');
     expect(dateField?.operators).toContain('gt');
     expect(dateField?.operators).toContain('lte');
@@ -507,14 +507,14 @@ describe('FilterRuleEditor - Value Constraints', () => {
     const scoreField = investorFieldRegistry.find(
       (f) => f.name === 'metrics.icp_score'
     );
-    expect(scoreField?.constraints?.min_value).toBe(0);
-    expect(scoreField?.constraints?.max_value).toBe(100);
+    expect(scoreField?.constraints?.minValue).toBe(0);
+    expect(scoreField?.constraints?.maxValue).toBe(100);
   });
 
   it('validates number constraints for prep time', () => {
     const prepField = recipeFieldRegistry.find(
       (f) => f.name === 'prep_time_minutes'
     );
-    expect(prepField?.constraints?.min_value).toBe(0);
+    expect(prepField?.constraints?.minValue).toBe(0);
   });
 });

package/src/components/FilterRuleEditor/FilterRuleEditor.tsx

@@ -86,7 +86,7 @@ export function FilterRuleEditor({
   // Add a new empty rule
   const handleAddRule = () => {
     const newRule: FilterRule = {
-      field_path: '',
+      fieldPath: '',
       operator: 'eq' as any,
       value: null,
     };

package/src/components/FilterRuleEditor/RuleRow.tsx

@@ -67,7 +67,7 @@ export function RuleRow({
   className = '',
 }: RuleRowProps) {
   // Find the selected field definition
-  const selectedField = fieldRegistry.find((f) => f.name === rule.field_path);
+  const selectedField = fieldRegistry.find((f) => f.name === rule.fieldPath);
 
   // Get valid operators for the selected field
   const availableOperators = selectedField?.operators || [];
@@ -82,7 +82,7 @@ export function RuleRow({
     const field = fieldRegistry.find((f) => f.name === fieldName);
     onChange({
       ...rule,
-      field_path: fieldName,
+      fieldPath: fieldName,
       operator: field?.operators[0] || ('' as Operator),
       value: null,
     });
@@ -157,8 +157,8 @@ export function RuleRow({
           <NumberValueInput
             value={rule.value}
             onChange={handleValueChange}
-            min={constraints?.min_value as number}
-            max={constraints?.max_value as number}
+            min={constraints?.minValue as number}
+            max={constraints?.maxValue as number}
           />
         );
 
@@ -167,8 +167,8 @@ export function RuleRow({
           <DateValueInput
             value={rule.value || null}
             onChange={handleValueChange}
-            min={constraints?.min_value as string}
-            max={constraints?.max_value as string}
+            min={constraints?.minValue as string}
+            max={constraints?.maxValue as string}
           />
         );
 
@@ -228,7 +228,7 @@ export function RuleRow({
       <div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-3 pr-8">
         <FieldSelector
           fields={fieldRegistry}
-          value={rule.field_path}
+          value={rule.fieldPath}
           onChange={handleFieldChange}
         />
 
@@ -236,7 +236,7 @@ export function RuleRow({
           operators={availableOperators}
           value={rule.operator || ''}
           onChange={handleOperatorChange}
-          disabled={!rule.field_path}
+          disabled={!rule.fieldPath}
         />
 
         {needsValue && renderValueInput()}