@starlove/orbit 1.4.1 → 2.0.0

package/src/core/db.js

@@ -1,315 +0,0 @@
-// Connection management. There is intentionally no module-level "active board"
-// singleton: every caller resolves a per-board DB connection via openConnection
-// and threads it through. This is what makes the server safe under concurrent
-// HTTP requests for different boards — a global active-pointer would race
-// across requests that interleave around `await readJson`.
-
-import { DatabaseSync } from "node:sqlite";
-import { REGISTRY_DB_PATH } from "./paths.js";
-import { __enterEventTx, __settleEventTx } from "./events.js";
-
-const connections = new Map();
-
-/** Open (or return cached) per-database connection. Safe to share within a process. */
-export function openConnection(dbPath) {
-  if (connections.has(dbPath)) return connections.get(dbPath);
-  const conn = new DatabaseSync(dbPath);
-  conn.exec("PRAGMA foreign_keys = ON;");
-  conn.exec("PRAGMA busy_timeout = 5000;");
-  conn.exec("PRAGMA journal_mode = WAL;");
-  // busy_timeout (set above) makes a second writer from another process (MCP
-  // server, CLI) wait instead of failing immediately with SQLITE_BUSY when an
-  // agent commit and a UI drag overlap. NORMAL is the recommended
-  // durability/throughput tradeoff under WAL (a power-loss can lose the last
-  // commit but never corrupts the DB).
-  conn.exec("PRAGMA synchronous = NORMAL;");
-  connections.set(dbPath, conn);
-  return conn;
-}
-
-export function closeConnection(dbPath) {
-  const conn = connections.get(dbPath);
-  if (!conn) return;
-  try {
-    conn.exec("PRAGMA wal_checkpoint(TRUNCATE);");
-  } catch {
-    // Another process may still be attached; closing this connection is enough
-    // to release our file handle.
-  }
-  try {
-    conn.close();
-  } finally {
-    connections.delete(dbPath);
-  }
-}
-
-export function hasConnection(dbPath) {
-  return connections.has(dbPath);
-}
-
-export function closeAllConnections() {
-  for (const dbPath of [...connections.keys()]) {
-    try {
-      closeConnection(dbPath);
-    } catch {
-      // Shutdown cleanup should release every handle it can without masking
-      // the original exit path.
-    }
-  }
-}
-
-// Reentrancy depth per connection. Only the outermost tx() issues
-// BEGIN/COMMIT/ROLLBACK; inner calls (a tx-wrapped function calling another)
-// fold into the enclosing transaction. Execution is synchronous and a request
-// never awaits between BEGIN and COMMIT, so per-connection depth is race-free.
-const txDepth = new WeakMap();
-
-/**
- * Run `fn` inside an IMMEDIATE transaction on `db` so a multi-statement
- * mutation is atomic: it either fully lands or fully rolls back. BEGIN
- * IMMEDIATE takes the write lock up front, which also makes read-then-write
- * sequences (e.g. `MAX(number)+1` ticket numbering) safe against concurrent
- * writer processes. SSE broadcasts for events recorded inside the transaction
- * are buffered and only fan out after COMMIT (see events.js).
- */
-export function tx(db, fn) {
-  const depth = txDepth.get(db) || 0;
-  if (depth === 0) db.exec("BEGIN IMMEDIATE;");
-  txDepth.set(db, depth + 1);
-  __enterEventTx();
-  try {
-    const result = fn();
-    const next = txDepth.get(db) - 1;
-    txDepth.set(db, next);
-    if (next === 0) db.exec("COMMIT;");
-    __settleEventTx(true);
-    return result;
-  } catch (error) {
-    const next = txDepth.get(db) - 1;
-    txDepth.set(db, next);
-    if (next === 0) {
-      try {
-        db.exec("ROLLBACK;");
-      } catch {
-        // A failed BEGIN leaves no transaction to roll back; ignore.
-      }
-    }
-    __settleEventTx(false);
-    throw error;
-  }
-}
-
-export function getRegistry() {
-  return openConnection(REGISTRY_DB_PATH);
-}
-
-/** Add a column to an existing table only if it is missing. Idempotent: safe to
- *  call on every startup. SQLite has no `ADD COLUMN IF NOT EXISTS`, so we probe
- *  `PRAGMA table_info` first. */
-function ensureColumn(reg, table, column, definition) {
-  const cols = reg.prepare(`PRAGMA table_info(${table})`).all();
-  if (cols.some((c) => c.name === column)) return;
-  reg.exec(`ALTER TABLE ${table} ADD COLUMN ${column} ${definition};`);
-}
-
-/** Registry metadata table (not the per-board `boards` content row). */
-export function createRegistrySchema(reg = getRegistry()) {
-  reg.exec(`
-    CREATE TABLE IF NOT EXISTS boards (
-      id TEXT PRIMARY KEY,
-      slug TEXT NOT NULL UNIQUE,
-      name TEXT NOT NULL,
-      repo_path TEXT NOT NULL DEFAULT '',
-      db_path TEXT NOT NULL,
-      repo_url TEXT NOT NULL DEFAULT '',
-      default_branch TEXT NOT NULL DEFAULT 'main',
-      last_active_at TEXT,
-      created_at TEXT NOT NULL,
-      updated_at TEXT NOT NULL
-    );
-    CREATE INDEX IF NOT EXISTS idx_registry_boards_repo_path ON boards(repo_path);
-  `);
-  // Whether Orbit keeps SKILL-ORBIT.md / AGENTS.md in sync inside repo_path.
-  // Defaults to 1 so pre-existing boards (created when files were always
-  // written) keep their managed copies refreshed on startup.
-  ensureColumn(reg, "boards", "manage_helper_files", "INTEGER NOT NULL DEFAULT 1");
-}
-
-/** Full Kanban schema on a per-board database connection. */
-export function createBoardSchema(db) {
-  db.exec(`
-    CREATE TABLE IF NOT EXISTS boards (
-      id TEXT PRIMARY KEY,
-      slug TEXT NOT NULL UNIQUE,
-      name TEXT NOT NULL,
-      repo_url TEXT NOT NULL DEFAULT '',
-      system_path TEXT NOT NULL DEFAULT '',
-      default_branch TEXT NOT NULL DEFAULT 'main',
-      project_notes TEXT NOT NULL DEFAULT '',
-      agent_instructions TEXT NOT NULL DEFAULT '',
-      ai_enabled INTEGER NOT NULL DEFAULT 0,
-      created_at TEXT NOT NULL,
-      updated_at TEXT NOT NULL
-    );
-
-    CREATE TABLE IF NOT EXISTS states (
-      id TEXT PRIMARY KEY,
-      board_id TEXT NOT NULL REFERENCES boards(id) ON DELETE CASCADE,
-      name TEXT NOT NULL,
-      position INTEGER NOT NULL,
-      is_default INTEGER NOT NULL DEFAULT 0,
-      role TEXT,
-      created_at TEXT NOT NULL,
-      UNIQUE(board_id, name)
-    );
-
-    CREATE TABLE IF NOT EXISTS tickets (
-      id TEXT PRIMARY KEY,
-      board_id TEXT NOT NULL REFERENCES boards(id) ON DELETE CASCADE,
-      number INTEGER NOT NULL,
-      title TEXT NOT NULL,
-      description TEXT NOT NULL DEFAULT '',
-      type TEXT NOT NULL DEFAULT 'task',
-      parent_ticket_id TEXT,
-      ai_plan TEXT NOT NULL DEFAULT '',
-      plan_artifact_path TEXT NOT NULL DEFAULT '',
-      implementation_summary TEXT NOT NULL DEFAULT '',
-      implementation_artifact_path TEXT NOT NULL DEFAULT '',
-      implementation_updates TEXT NOT NULL DEFAULT '',
-      state_id TEXT NOT NULL REFERENCES states(id),
-      priority INTEGER NOT NULL DEFAULT 2,
-      created_by TEXT NOT NULL DEFAULT 'human',
-      created_at TEXT NOT NULL,
-      updated_at TEXT NOT NULL,
-      archived_at TEXT,
-      UNIQUE(board_id, number)
-    );
-
-    CREATE TABLE IF NOT EXISTS comments (
-      id TEXT PRIMARY KEY,
-      ticket_id TEXT NOT NULL REFERENCES tickets(id) ON DELETE CASCADE,
-      author TEXT NOT NULL,
-      kind TEXT NOT NULL DEFAULT 'comment',
-      body TEXT NOT NULL,
-      omitted_for_ai INTEGER NOT NULL DEFAULT 0,
-      created_at TEXT NOT NULL
-    );
-
-    CREATE TABLE IF NOT EXISTS review_verdicts (
-      id TEXT PRIMARY KEY,
-      ticket_id TEXT NOT NULL REFERENCES tickets(id) ON DELETE CASCADE,
-      verdict TEXT NOT NULL CHECK (verdict IN ('PASS', 'BLOCK', 'QUESTION')),
-      blocking_findings_json TEXT NOT NULL DEFAULT '[]',
-      optional_findings_json TEXT NOT NULL DEFAULT '[]',
-      evidence_commands_json TEXT NOT NULL DEFAULT '[]',
-      reviewer_profile TEXT NOT NULL DEFAULT '',
-      reviewer_session_id TEXT NOT NULL DEFAULT '',
-      reviewed_commit_sha TEXT NOT NULL DEFAULT '',
-      dispatch_run_id TEXT NOT NULL DEFAULT '',
-      supersedes_prior_review_id TEXT REFERENCES review_verdicts(id) ON DELETE SET NULL,
-      created_by TEXT NOT NULL DEFAULT 'human',
-      created_at TEXT NOT NULL
-    );
-
-    CREATE TABLE IF NOT EXISTS ticket_attachments (
-      id TEXT PRIMARY KEY,
-      ticket_id TEXT NOT NULL REFERENCES tickets(id) ON DELETE CASCADE,
-      board_id TEXT NOT NULL REFERENCES boards(id) ON DELETE CASCADE,
-      original_name TEXT NOT NULL,
-      stored_path TEXT NOT NULL,
-      mime_type TEXT NOT NULL,
-      size_bytes INTEGER NOT NULL,
-      sha256 TEXT NOT NULL,
-      created_by TEXT NOT NULL DEFAULT 'human',
-      created_at TEXT NOT NULL
-    );
-
-    CREATE TABLE IF NOT EXISTS board_entries (
-      id TEXT PRIMARY KEY,
-      board_id TEXT NOT NULL REFERENCES boards(id) ON DELETE CASCADE,
-      type TEXT NOT NULL,
-      title TEXT NOT NULL,
-      body TEXT NOT NULL DEFAULT '',
-      ticket_id TEXT REFERENCES tickets(id) ON DELETE SET NULL,
-      created_by TEXT NOT NULL DEFAULT 'human',
-      created_at TEXT NOT NULL,
-      updated_at TEXT NOT NULL,
-      struck_at TEXT
-    );
-
-    CREATE TABLE IF NOT EXISTS labels (
-      id TEXT PRIMARY KEY,
-      board_id TEXT NOT NULL REFERENCES boards(id) ON DELETE CASCADE,
-      name TEXT NOT NULL,
-      color TEXT NOT NULL DEFAULT '#64748b',
-      created_at TEXT NOT NULL,
-      UNIQUE(board_id, name)
-    );
-
-    CREATE TABLE IF NOT EXISTS ticket_labels (
-      ticket_id TEXT NOT NULL REFERENCES tickets(id) ON DELETE CASCADE,
-      label_id TEXT NOT NULL REFERENCES labels(id) ON DELETE CASCADE,
-      PRIMARY KEY(ticket_id, label_id)
-    );
-
-    CREATE TABLE IF NOT EXISTS relations (
-      id TEXT PRIMARY KEY,
-      source_ticket_id TEXT NOT NULL REFERENCES tickets(id) ON DELETE CASCADE,
-      target_ticket_id TEXT NOT NULL REFERENCES tickets(id) ON DELETE CASCADE,
-      type TEXT NOT NULL,
-      created_at TEXT NOT NULL,
-      UNIQUE(source_ticket_id, target_ticket_id, type)
-    );
-
-    CREATE TABLE IF NOT EXISTS events (
-      id TEXT PRIMARY KEY,
-      ticket_id TEXT REFERENCES tickets(id) ON DELETE SET NULL,
-      actor TEXT NOT NULL,
-      type TEXT NOT NULL,
-      body_json TEXT NOT NULL DEFAULT '{}',
-      created_at TEXT NOT NULL
-    );
-
-    CREATE VIRTUAL TABLE IF NOT EXISTS ticket_fts USING fts5(
-      ticket_id UNINDEXED,
-      title,
-      description,
-      comments
-    );
-
-    CREATE INDEX IF NOT EXISTS idx_states_board ON states(board_id, position);
-    CREATE INDEX IF NOT EXISTS idx_states_role ON states(board_id, role);
-    CREATE INDEX IF NOT EXISTS idx_tickets_board_state ON tickets(board_id, state_id);
-    CREATE INDEX IF NOT EXISTS idx_tickets_archived ON tickets(board_id, archived_at);
-    CREATE INDEX IF NOT EXISTS idx_tickets_parent ON tickets(parent_ticket_id);
-    CREATE INDEX IF NOT EXISTS idx_comments_ticket ON comments(ticket_id, created_at);
-    CREATE INDEX IF NOT EXISTS idx_review_verdicts_ticket ON review_verdicts(ticket_id, created_at);
-    CREATE INDEX IF NOT EXISTS idx_review_verdicts_supersedes ON review_verdicts(supersedes_prior_review_id);
-    CREATE INDEX IF NOT EXISTS idx_ticket_attachments_ticket ON ticket_attachments(ticket_id, created_at);
-    CREATE INDEX IF NOT EXISTS idx_ticket_attachments_board ON ticket_attachments(board_id, created_at);
-    CREATE INDEX IF NOT EXISTS idx_board_entries_board ON board_entries(board_id, type, created_at);
-    CREATE INDEX IF NOT EXISTS idx_relations_source ON relations(source_ticket_id);
-    CREATE INDEX IF NOT EXISTS idx_relations_target ON relations(target_ticket_id);
-    CREATE INDEX IF NOT EXISTS idx_events_ticket ON events(ticket_id, created_at);
-  `);
-  ensureColumn(db, "tickets", "plan_artifact_path", "TEXT NOT NULL DEFAULT ''");
-  ensureColumn(db, "tickets", "implementation_artifact_path", "TEXT NOT NULL DEFAULT ''");
-  ensureColumn(db, "comments", "omitted_for_ai", "INTEGER NOT NULL DEFAULT 0");
-}
-
-export function resetBoard(db) {
-  db.exec(`
-    DELETE FROM ticket_fts;
-    DELETE FROM ticket_labels;
-    DELETE FROM relations;
-    DELETE FROM comments;
-    DELETE FROM review_verdicts;
-    DELETE FROM ticket_attachments;
-    DELETE FROM board_entries;
-    DELETE FROM events;
-    DELETE FROM tickets;
-    DELETE FROM labels;
-    DELETE FROM states;
-    DELETE FROM boards;
-  `);
-}

package/src/core/delete-board.js

@@ -1,163 +0,0 @@
-import { existsSync, rmSync } from "node:fs";
-import { basename, dirname, join, relative } from "node:path";
-import { removeOrbitAgentsSection } from "./agents-md.js";
-import { requireBoardAccess } from "./auth.js";
-import { backupBoardDatabase, backupRegistry, cancelAutomaticBoardBackup } from "./backups.js";
-import { closeConnection } from "./db.js";
-import { BOARDS_DIR, DATA_DIR, DISPATCH_RUNS_DIR } from "./paths.js";
-import { deleteBoard, listBoards, openBoardDb } from "./registry.js";
-import { httpError, normalizePath } from "./util.js";
-
-function isInside(parent, child) {
-  const rel = relative(parent, child);
-  return rel && !rel.startsWith("..") && !rel.startsWith("/") && rel !== "..";
-}
-
-function boardDbDeleteTargets(boardRow) {
-  const dbPath = normalizePath(boardRow.db_path || "");
-  if (!dbPath || basename(dbPath) !== "board.db") {
-    throw httpError(409, "unsafe_board_db_path");
-  }
-
-  // Central storage: db lives inside DATA_DIR/boards/<slug>/board.db
-  const boardsDirNorm = normalizePath(BOARDS_DIR);
-  if (dbPath.startsWith(boardsDirNorm + "/")) {
-    const boardDir = dirname(dbPath);
-    // Safety: boardDir must be exactly one level below BOARDS_DIR
-    if (normalizePath(dirname(boardDir)) !== boardsDirNorm) {
-      throw httpError(409, "unsafe_board_db_path");
-    }
-    return [boardDir];
-  }
-
-  // Legacy in-repo storage: db lives inside <repo>/.orbit/
-  const repoRoot = normalizePath(boardRow.repo_path || "");
-  const orbitRoot = normalizePath(join(repoRoot, ".orbit"));
-  if (!repoRoot || !isInside(orbitRoot, dbPath)) {
-    throw httpError(409, "unsafe_board_db_path");
-  }
-  const boardDir = dirname(dbPath);
-  const boardsRoot = normalizePath(join(orbitRoot, "boards"));
-  if (isInside(boardsRoot, boardDir)) return [boardDir];
-  return [dbPath, `${dbPath}-wal`, `${dbPath}-shm`, `${dbPath}-journal`];
-}
-
-function isLastBoardForRepo(boardRow) {
-  const repoRoot = normalizePath(boardRow.repo_path || "");
-  return !listBoards().some((row) => row.id !== boardRow.id && normalizePath(row.repo_path || "") === repoRoot);
-}
-
-function repoArtifactTargets(boardRow) {
-  const repoRoot = normalizePath(boardRow.repo_path || "");
-  const dbPath = normalizePath(boardRow.db_path || "");
-  if (!repoRoot || !dbPath || basename(dbPath) !== "board.db") {
-    throw httpError(409, "unsafe_board_db_path");
-  }
-  return {
-    orbitRoot: normalizePath(join(repoRoot, ".orbit")),
-    skillMd: join(repoRoot, "SKILL-ORBIT.md")
-  };
-}
-
-function removeOptions(recursive = false) {
-  const options = { force: true };
-  if (recursive) options.recursive = true;
-  if (process.platform === "win32") {
-    options.maxRetries = 10;
-    options.retryDelay = 100;
-  }
-  return options;
-}
-
-function isBusyFilesystemError(error) {
-  const message = String(error?.message || "").toLowerCase();
-  return (
-    ["EBUSY", "EPERM", "ENOTEMPTY"].includes(error?.code) ||
-    (error?.code === "ERR_SQLITE_ERROR" && (message.includes("locked") || message.includes("busy")))
-  );
-}
-
-function boardFilesBusyError(error, boardRow) {
-  if (!isBusyFilesystemError(error)) return error;
-  const wrapped = new Error(
-    [
-      `Orbit could not remove local board files for "${boardRow.slug}".`,
-      "On Windows this usually means an Orbit web server, MCP helper, AI client, editor, or terminal still has .orbit/board.db open.",
-      "Close those processes, then retry the delete from Settings or run orbit reset --cwd <repo>.",
-      `Original error: ${error.message}`
-    ].join("\n")
-  );
-  wrapped.status = 409;
-  wrapped.code = "board_files_busy";
-  wrapped.cause = error;
-  return wrapped;
-}
-
-export function deleteRegisteredBoard(boardRow, body, actor) {
-  requireBoardAccess(actor, { slug: boardRow.slug });
-
-  const confirmation = String(body?.confirm_slug || "").trim();
-  if (confirmation !== boardRow.slug) throw httpError(400, "board_slug_confirmation_required");
-
-  const deleteFiles = body?.delete_files !== false;
-  const removeRepoArtifacts = deleteFiles && isLastBoardForRepo(boardRow);
-  const repoArtifacts = removeRepoArtifacts ? repoArtifactTargets(boardRow) : null;
-  // Always delete the board's own db files/directory; when it is the last board
-  // for a repo also sweep in-repo artifacts (.orbit/, SKILL-ORBIT.md, AGENTS.md).
-  // Also remove the board's central dispatch-runs directory.
-  const dispatchRunsDir = join(DISPATCH_RUNS_DIR, boardRow.slug);
-  const targets = deleteFiles
-    ? [
-        ...boardDbDeleteTargets(boardRow),
-        ...(repoArtifacts ? [repoArtifacts.orbitRoot] : []),
-        ...(existsSync(dispatchRunsDir) ? [dispatchRunsDir] : [])
-      ]
-    : [];
-  const artifactResults = [];
-  cancelAutomaticBoardBackup(boardRow.id);
-  if (deleteFiles) {
-    try {
-      backupBoardDatabase(boardRow, openBoardDb(boardRow), "pre-board-delete");
-    } catch (error) {
-      throw boardFilesBusyError(error, boardRow);
-    } finally {
-      closeConnection(boardRow.db_path);
-    }
-  }
-  backupRegistry("pre-board-delete");
-  closeConnection(boardRow.db_path);
-
-  try {
-    for (const target of targets) {
-      if (existsSync(target)) {
-        rmSync(target, removeOptions(true));
-        artifactResults.push({ path: target, removed: true });
-      }
-    }
-    if (repoArtifacts?.skillMd && existsSync(repoArtifacts.skillMd)) {
-      rmSync(repoArtifacts.skillMd, removeOptions(false));
-      artifactResults.push({ path: repoArtifacts.skillMd, removed: true });
-    }
-  } catch (error) {
-    throw boardFilesBusyError(error, boardRow);
-  }
-  if (removeRepoArtifacts) {
-    const agentsCleanup = removeOrbitAgentsSection(boardRow.repo_path);
-    artifactResults.push({
-      path: agentsCleanup.path,
-      removed: agentsCleanup.removed,
-      ok: agentsCleanup.ok,
-      reason: agentsCleanup.reason
-    });
-  }
-
-  deleteBoard(boardRow.id);
-  return {
-    ok: true,
-    deleted_board_id: boardRow.id,
-    deleted_board_slug: boardRow.slug,
-    deleted_files: deleteFiles,
-    deleted_repo_artifacts: removeRepoArtifacts,
-    artifacts: artifactResults
-  };
-}