@stardustlc/dsh-review 0.3.0 → 0.3.1

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # 变更记录
 
+## 0.3.1（2026-10-26）
+
+- 复核证据绑定候选位置与非空源码锚点；旧 finding 仍存在或缺少原文件覆盖时不自动标为已修复。仅排除真实账本目录，默认配置不再隐藏仓库同名目录。
+- Windows 回归 78 项通过、0 项跳过；宿主与未验收范围见[本次记录](docs/validation-0.3.1.md)。
+
 ## 0.3.0（2026-10-17）
 
 重做 v0.2 中尚未可靠接通的审阅闭环，按实际执行和证据决定是否完成。

package/docs/VALIDATION.md

@@ -1,5 +1,9 @@
 # 验证记录
 
+## 2026-10-26：0.3.1
+
+[本次修复、回归与未验收范围](validation-0.3.1.md)。
+
 日期：2026-10-17。版本：@stardustlc/dsh-review 0.3.0。
 
 ## 本地回归

package/docs/validation-0.3.1.md

@@ -0,0 +1,19 @@
+# 0.3.1 验证记录
+
+日期：2026-10-26。官方 Windows 宿主：DSH 0.2.1-rc.3。
+
+## 行为变化
+
+复核证据绑定候选位置与非空源码锚点；旧 finding 仍存在或缺少原文件覆盖时不自动标为已修复。仅排除真实账本目录，默认配置不再隐藏仓库同名目录。
+
+## 验证与限制
+
+- Windows 本地：78 项，78 通过、0 跳过；没有把跳过计为通过。
+- 官方 RC.3 原生 tools.execute 与审阅子代理验收通过：19 次工具调用，覆盖独立复核、旧快照、真实修复、只读权限、取消和不可信手工报告。模型为本地合成适配器，未评测真实模型的审阅质量。
+- GitHub 的跨平台 CI 和 npm 发布完整性以该版本工作流及 registry 为准；本记录不把本地测试等同于已发布。
+
+## English
+
+Verification requires nonblank snapshot anchors near the candidate. Existing findings remain unresolved when their original anchor still exists or coverage is missing. Only the actual managed ledger directory is excluded.
+
+Runtime/account limits are listed above. Synthetic peers and model adapters do not establish live account delivery or model quality.

package/lib/gate.d.ts

@@ -63,7 +63,7 @@ export interface GateResult {
 }
 export declare function candidateId(f: CandidateFinding, target: ReviewTarget): string;
 export declare function parseCandidate(raw: unknown, lens: string, target: ReviewTarget): CandidateFinding | null;
-export declare function parseVote(raw: unknown, taskId: string, expected: string, target: ReviewTarget): Vote;
+export declare function parseVote(raw: unknown, taskId: string, expected: string, target: ReviewTarget, candidate?: CandidateFinding): Vote;
 export declare function voteDecision(votes: Vote[], required: number): Vote['decision'];
 export declare function gateFindings(options: {
     root: string;

package/lib/gate.js

@@ -39,15 +39,22 @@ export function parseCandidate(raw, lens, target) {
     finding.id = candidateId(finding, target);
     return finding;
 }
-export function parseVote(raw, taskId, expected, target) {
+export function parseVote(raw, taskId, expected, target, candidate) {
     const item = raw;
     if (!item || item.candidateId !== expected || !['confirm', 'reject', 'pre-existing', 'unverifiable'].includes(item.decision) || typeof item.reason !== 'string' || item.reason.trim().length < 12 || !Array.isArray(item.witnesses))
         throw new Error('Invalid independent verification');
     for (const witness of item.witnesses)
-        if (!witness || (witness.side !== undefined && !['before', 'after'].includes(witness.side)) || !sourceMatches(target, witness.file, witness.line, witness.anchor, witness.side ?? 'after'))
-            throw new Error('Verifier cited source outside the immutable snapshot');
+        if (!witness || typeof witness.file !== 'string' || typeof witness.anchor !== 'string' || !witness.anchor.trim() || (witness.side !== undefined && !['before', 'after'].includes(witness.side)) || !sourceMatches(target, witness.file, witness.line, witness.anchor, witness.side ?? 'after'))
+            throw new Error('Verifier witness is blank or outside the immutable snapshot');
     if (item.decision !== 'unverifiable' && item.witnesses.length === 0)
         throw new Error('Verifier supplied no checkable source witness');
+    if (item.decision !== 'unverifiable') {
+        if (!candidate || (candidate.id ?? candidateId(candidate, target)) !== expected)
+            throw new Error('Verifier requires the exact candidate being checked');
+        const locations = [candidate, ...(candidate.introducedBy ? [candidate.introducedBy] : [])];
+        if (!item.witnesses.some(witness => locations.some(location => witness.file === location.file && Math.abs(witness.line - location.line) <= 3)))
+            throw new Error('Verifier witness is unrelated to the candidate or introducing change');
+    }
     if (item.decision === 'pre-existing' && !item.witnesses.some(witness => witness.side === 'before'))
         throw new Error('Pre-existing verdict requires base evidence');
     return { candidateId: expected, decision: item.decision, reason: item.reason.trim(), witnesses: item.witnesses, taskId };
@@ -82,14 +89,21 @@ export function gateFindings(options) {
             continue;
         }
         if (decision === 'reject') {
-            result.rejected.push({ id, reason: votes.map(v => v.reason).join('\n') });
             const prior = record.posted[id];
             if (prior && !prior.disposition) {
-                prior.disposition = prior.targetId === target.id ? 'wrong' : 'fixed';
-                prior.note = 'Independent re-verification rejects the former finding on target ' + target.id;
+                const source = target.files.find(file => file.path === prior.file || file.oldPath === prior.file);
+                const removed = source !== undefined && typeof prior.anchor === 'string' && prior.anchor.trim() !== '' && (source.after === null || !source.after.split(/\r?\n/).includes(prior.anchor));
+                if (!removed) {
+                    result.unverified++;
+                    result.rejected.push({ id, reason: 'The original source anchor remains, or its removal is not covered by this snapshot; human review is required.' });
+                    continue;
+                }
+                prior.disposition = 'fixed';
+                prior.note = 'Independent re-verification and snapshot source confirm removal on target ' + target.id;
                 prior.verification = votes;
                 prior.targetId = target.id;
             }
+            result.rejected.push({ id, reason: votes.map(v => v.reason).join('\n') });
             continue;
         }
         if (decision !== 'pre-existing' && severityRank(finding.severity) < severityRank(rules.severityFloor ?? config.severityFloor)) {

package/lib/lenses.js

@@ -37,6 +37,7 @@ export function verifierTask(input, finding, index) {
         'Trace the trigger, consequences, relevant callers and counterexamples. Check whether the defect was already present in the base, rather than merely whether the same line existed.',
         'Return candidateId, decision=confirm|reject|pre-existing|unverifiable, reason (specific causal explanation), witnesses=[{file,line,anchor,side:\"after\"|\"before\"}].',
         'Witnesses must quote exact snapshot source. confirm requires evidence linked to this introducing change; pre-existing requires before-side evidence. If evidence is insufficient use unverifiable. Command receipts are optional; do not run arbitrary code solely to fill a field.',
+        'Every witness anchor must be nonblank. At least one witness must be in the candidate file within three lines of its location, or within three lines of its introducing evidence. Include this local witness even when additional evidence is elsewhere.',
     ].join('\n'));
     return task;
 }

package/lib/run.d.ts

@@ -1,11 +1,12 @@
 import { type LensTask } from './lenses.js';
 import { type Mode } from './modes.js';
+import { type CandidateFinding } from './gate.js';
 import { Ledger, type StoredRun } from './ledger.js';
 import { type ReviewTarget } from './target.js';
 import type { ReviewConfig } from './config.js';
 import type { Dispatcher } from './dispatch.js';
 export declare function startRun(target: ReviewTarget, mode: Mode, config: ReviewConfig, ledger: Ledger, independent: boolean): StoredRun;
-export declare function parseTaskResult(task: LensTask, text: string, target: ReviewTarget, maxFindings: number): Record<string, any>;
+export declare function parseTaskResult(task: LensTask, text: string, target: ReviewTarget, maxFindings: number, candidate?: CandidateFinding): Record<string, any>;
 export declare function submitResults(ledger: Ledger, runId: string, targetId: string, values: unknown[], config: ReviewConfig): void;
 export declare function advance(ledger: Ledger, runId: string, config: ReviewConfig): void;
 export declare function assertCurrent(run: StoredRun, ledger: Ledger, config: ReviewConfig, signal?: AbortSignal): Promise<void>;

package/lib/run.js

@@ -38,7 +38,7 @@ export function startRun(target, mode, config, ledger, independent) {
     ledger.event('run-start', { runId: id, targetId: target.id, mode, independent });
     return run;
 }
-export function parseTaskResult(task, text, target, maxFindings) {
+export function parseTaskResult(task, text, target, maxFindings, candidate) {
     if (Buffer.byteLength(text) > 1024 * 1024)
         throw new Error('Worker output exceeds 1 MiB');
     const value = JSON.parse(text.trim().replace(/^\x60{3}(?:json)?\s*\n([\s\S]*?)\n\x60{3}$/, '$1'));
@@ -51,7 +51,7 @@ export function parseTaskResult(task, text, target, maxFindings) {
         return { runId: task.runId, targetId: task.targetId, taskId: task.id, findings: parsed.filter(Boolean), ignoredStyleCount: parsed.filter((finding) => finding === null).length, declined: value.declined };
     }
     if (task.role === 'verify')
-        return { runId: task.runId, targetId: task.targetId, ...parseVote(value, task.id, task.candidateId, target) };
+        return { runId: task.runId, targetId: task.targetId, ...parseVote(value, task.id, task.candidateId, target, candidate) };
     if (task.role === 'risk') {
         if (!['low', 'medium', 'high'].includes(value.tier) || typeof value.extraHuman !== 'boolean' || !Array.isArray(value.reasons) || !value.reasons.length || value.reasons.some((r) => typeof r !== 'string' || !r.trim()))
             throw new Error('Invalid risk classification');
@@ -71,7 +71,7 @@ export function submitResults(ledger, runId, targetId, values, config) {
             const task = pending.find(task => task.id === value?.taskId);
             if (!task)
                 throw new Error('Result duplicated or not a task in this stage');
-            return [task.id, parseTaskResult(task, JSON.stringify(value), run.target, config.maxFindings)];
+            return [task.id, parseTaskResult(task, JSON.stringify(value), run.target, config.maxFindings, run.candidates.find(candidate => candidate.id === task.candidateId))];
         });
         if (new Set(parsed.map(([id]) => id)).size !== parsed.length)
             throw new Error('Duplicate task result');
@@ -84,8 +84,13 @@ function votesFor(run) {
     const votes = {};
     for (const task of run.tasks.filter(task => task.role === 'verify')) {
         const value = run.results[task.id];
-        if (value)
-            (votes[task.candidateId] ??= []).push(value);
+        if (value) {
+            try {
+                const checked = parseVote(value, task.id, task.candidateId, run.target, run.candidates.find(candidate => candidate.id === task.candidateId));
+                (votes[task.candidateId] ??= []).push(checked);
+            }
+            catch { /* Old or invalid persisted votes leave the finding unverified. */ }
+        }
     }
     return votes;
 }
@@ -217,7 +222,7 @@ async function executeStages(ledger, runId, config, dispatcher, signal) {
                     if (!result.ok)
                         throw new Error(result.reason ?? 'Worker failed');
                     const text = result.output ?? '';
-                    const parsed = parseTaskResult(task, text, run.target, config.maxFindings);
+                    const parsed = parseTaskResult(task, text, run.target, config.maxFindings, run.candidates.find(candidate => candidate.id === task.candidateId));
                     ledger.transaction(state => { state.runs[runId].results[task.id] = parsed; });
                 }
                 catch (error) {

package/lib/target.js

@@ -4,6 +4,7 @@ import path from 'node:path';
 import { git } from './exec.js';
 import { parseDiff } from './diff.js';
 import { loadRules, parseRules, RULE_PATHS, isSkipped } from './rules.js';
+import { stateDirectory } from './ledger.js';
 const hash = (value) => createHash('sha256').update(value).digest('hex');
 export async function captureTarget(root, args, maxBytes, stateDir, signal) {
     root = realpathSync(root);
@@ -64,8 +65,9 @@ export async function captureTarget(root, args, maxBytes, stateDir, signal) {
     else
         rules = loadRules(root);
     const skipped = [], files = [];
-    const internal = path.isAbsolute(stateDir) ? path.relative(root, stateDir).replaceAll('\\', '/') : stateDir;
-    const inState = (file) => file === internal || file.startsWith(internal + '/') || file === '.dsh-review' || file.startsWith('.dsh-review/');
+    const relativeState = path.relative(root, stateDirectory(root, stateDir)).replaceAll('\\', '/');
+    const internal = relativeState && relativeState !== '..' && !relativeState.startsWith('../') && !path.isAbsolute(relativeState) ? relativeState : undefined;
+    const inState = (file) => internal !== undefined && (file === internal || file.startsWith(internal + '/'));
     let total = Buffer.byteLength(patch);
     const blob = async (spec) => query(['show', '--no-ext-diff', '--no-textconv', spec]);
     for (const entry of entries) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stardustlc/dsh-review",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "以证据为准的代码审阅插件：审 diff、验证结论、记录噪音，让 agent 先读、人只读结论。",
   "type": "module",
   "main": "lib/index.js",