@starci/hfs 4.7.17 → 4.7.19

package/sync/index.mjs

@@ -19,6 +19,7 @@ import { createHash } from 'node:crypto';
 import { createRequire } from 'node:module';
 import fs from 'node:fs';
 import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { braceVariants } from '../runtime/scripts/lib/glob.mjs';
 import { codecovPaths, coverageComponents, jestCoverage, sonarCoverageExclusions } from '../runtime/scripts/hfs/coverage-scope.mjs';
 import { APP_SCOPE, SIDES, litePresenceOf, loadSlotManifest, resolveRepoDeclaration, slotInEdition } from '../runtime/scripts/hfs/slots.mjs';
@@ -159,19 +160,19 @@ export async function loadPresets(root) {
 }
 
 /**
- * The jest preset's Sonar exclusions as @starci/hfs ships them: `@starci/jest-preset/sonar-exclusions.json`, copied byte for byte into
- * packages/hfs/runtime by scripts/hfs/sync-runtime.mjs, so a fresh `starci app scaffold` (nothing installed yet) and an upgrade render the
- * same list the app's installed preset answers. A missing copy is a refusal, never a render without it.
+ * The jest preset's Sonar exclusions as @starci/hfs ships them: `@starci/jest-preset/sonar-exclusions.cjs` (a require-free module),
+ * copied byte for byte into packages/hfs/runtime by scripts/hfs/sync-runtime.mjs, so a fresh `starci app scaffold` (nothing installed
+ * yet) and an upgrade render the same list the app's installed preset answers. A missing copy is a refusal, never a render without it.
  */
-const BUNDLED_SONAR_EXCLUSIONS = new URL('../runtime/packages/jest-preset/sonar-exclusions.json', import.meta.url);
+const BUNDLED_SONAR_EXCLUSIONS = new URL('../runtime/packages/jest-preset/sonar-exclusions.cjs', import.meta.url);
 
 /** The presets ({ sonarExclusions }) of the jest preset version this @starci/hfs pins, read from its bundled copy. */
 export function bundledPresets() {
   let list;
   try {
-    list = JSON.parse(fs.readFileSync(BUNDLED_SONAR_EXCLUSIONS, 'utf8'));
+    list = createRequire(import.meta.url)(fileURLToPath(BUNDLED_SONAR_EXCLUSIONS));
   } catch {
-    throw new SyncError('HFS_SYNC_PRESET_MISSING', '@starci/hfs ships no runtime/packages/jest-preset/sonar-exclusions.json; reinstall @starci/hfs at its published version');
+    throw new SyncError('HFS_SYNC_PRESET_MISSING', '@starci/hfs ships no runtime/packages/jest-preset/sonar-exclusions.cjs; reinstall @starci/hfs at its published version');
   }
   return { sonarExclusions: list.join(',') };
 }

package/templates/be/skeleton/src/modules/platform/database/migrate-connections.client.spec.ts

@@ -0,0 +1,60 @@
+import { Test } from "@nestjs/testing"
+import { mock } from "@starci/jest-preset"
+import { Secret } from "@modules/platform/config"
+import type { DatabaseConnectionOptions } from "./database.options"
+import type { ConnectionOpener, ConnectionSource } from "./database.port"
+import { migrateConnections } from "./migrate-connections.client"
+
+const MIGRATE_CLIENT = Symbol("migrate-connections")
+
+const setup = async () => {
+    const moduleRef = await Test.createTestingModule({
+        providers: [{ provide: MIGRATE_CLIENT, useFactory: () => ({ migrateConnections }) }],
+    }).compile()
+    return moduleRef.get<{ readonly migrateConnections: typeof migrateConnections }>(MIGRATE_CLIENT)
+}
+
+const connection = (name: string): DatabaseConnectionOptions => ({
+    name,
+    url: new Secret(`postgres://localhost:5432/${name}`),
+    entities: [],
+    migrations: [],
+})
+
+describe("migrateConnections", () => {
+    it("runs the pending migrations of each connection in order and answers their names by connection", async () => {
+        const client = await setup()
+        const primary = mock<ConnectionSource>()
+        primary.runMigrations.mockResolvedValue([{ name: "Init1" }])
+        const archive = mock<ConnectionSource>()
+        archive.runMigrations.mockResolvedValue([])
+        const sources = new Map([
+            ["primary", primary],
+            ["archive", archive],
+        ])
+        const opener = mock<ConnectionOpener>()
+        opener.open.mockImplementation(
+            (target: DatabaseConnectionOptions) => sources.get(target.name) ?? mock<ConnectionSource>(),
+        )
+
+        const applied = await client.migrateConnections([connection("primary"), connection("archive")], opener)
+
+        expect(applied).toEqual({ primary: ["Init1"], archive: [] })
+        expect(primary.initialize).toHaveBeenCalledTimes(1)
+        expect(primary.destroy).toHaveBeenCalledTimes(1)
+        expect(archive.destroy).toHaveBeenCalledTimes(1)
+    })
+
+    it("destroys the data source of a connection whose migration fails, and fails", async () => {
+        const client = await setup()
+        const failing = mock<ConnectionSource>()
+        failing.runMigrations.mockRejectedValue(new TypeError("relation already exists"))
+        const opener = mock<ConnectionOpener>()
+        opener.open.mockReturnValue(failing)
+
+        await expect(client.migrateConnections([connection("primary")], opener)).rejects.toThrow(
+            "relation already exists",
+        )
+        expect(failing.destroy).toHaveBeenCalledTimes(1)
+    })
+})

package/runtime/packages/jest-preset/sonar-exclusions.json

@@ -1 +0,0 @@
-["**/*.spec.ts", "**/*.e2e-spec.ts", "**/dist/**", "**/coverage/**"]