@starci/hfs 4.7.16 → 4.7.18

package/templates/be/skeleton/src/modules/platform/database/migrate-connections.client.spec.ts

@@ -0,0 +1,60 @@
+import { Test } from "@nestjs/testing"
+import { mock } from "@starci/jest-preset"
+import { Secret } from "@modules/platform/config"
+import type { DatabaseConnectionOptions } from "./database.options"
+import type { ConnectionOpener, ConnectionSource } from "./database.port"
+import { migrateConnections } from "./migrate-connections.client"
+
+const MIGRATE_CLIENT = Symbol("migrate-connections")
+
+const setup = async () => {
+    const moduleRef = await Test.createTestingModule({
+        providers: [{ provide: MIGRATE_CLIENT, useFactory: () => ({ migrateConnections }) }],
+    }).compile()
+    return moduleRef.get<{ readonly migrateConnections: typeof migrateConnections }>(MIGRATE_CLIENT)
+}
+
+const connection = (name: string): DatabaseConnectionOptions => ({
+    name,
+    url: new Secret(`postgres://localhost:5432/${name}`),
+    entities: [],
+    migrations: [],
+})
+
+describe("migrateConnections", () => {
+    it("runs the pending migrations of each connection in order and answers their names by connection", async () => {
+        const client = await setup()
+        const primary = mock<ConnectionSource>()
+        primary.runMigrations.mockResolvedValue([{ id: 1, timestamp: 1, name: "Init1" }])
+        const archive = mock<ConnectionSource>()
+        archive.runMigrations.mockResolvedValue([])
+        const sources = new Map([
+            ["primary", primary],
+            ["archive", archive],
+        ])
+        const opener = mock<ConnectionOpener>()
+        opener.open.mockImplementation(
+            (target: DatabaseConnectionOptions) => sources.get(target.name) ?? mock<ConnectionSource>(),
+        )
+
+        const applied = await client.migrateConnections([connection("primary"), connection("archive")], opener)
+
+        expect(applied).toEqual({ primary: ["Init1"], archive: [] })
+        expect(primary.initialize).toHaveBeenCalledTimes(1)
+        expect(primary.destroy).toHaveBeenCalledTimes(1)
+        expect(archive.destroy).toHaveBeenCalledTimes(1)
+    })
+
+    it("destroys the data source of a connection whose migration fails, and fails", async () => {
+        const client = await setup()
+        const failing = mock<ConnectionSource>()
+        failing.runMigrations.mockRejectedValue(new TypeError("relation already exists"))
+        const opener = mock<ConnectionOpener>()
+        opener.open.mockReturnValue(failing)
+
+        await expect(client.migrateConnections([connection("primary")], opener)).rejects.toThrow(
+            "relation already exists",
+        )
+        expect(failing.destroy).toHaveBeenCalledTimes(1)
+    })
+})

package/templates/fe/transport/graphql/clients/links/retry.ts

@@ -11,6 +11,6 @@ export const createRetryLink = () =>
         delay: { initial: RETRY_POLICY.initialDelayMs, max: RETRY_POLICY.maxDelayMs, jitter: true },
         attempts: {
             max: RETRY_POLICY.maxAttempts,
-            retryIf: (error) => error !== undefined && !CombinedGraphQLErrors.is(error),
+            retryIf: (error) => !CombinedGraphQLErrors.is(error),
         },
     })

package/upgrade/index.mjs

@@ -18,6 +18,7 @@ import { byCodeUnit } from "../report/order.mjs";
 import {
   TEMPLATES_DIR,
   appSource,
+  bundledPresets,
   checkTargets,
   imageFiles,
   loadHfs,
@@ -48,7 +49,7 @@ const FULL_DEPENDENCIES = Object.freeze(["nest-commander"]);
 // ruling lacks (a current lite app already has it, and the e2e world's @starci/test-world is what full adds). These are the preset's two
 // public sync inputs; once apply resolves the new dependency, normal full sync reads them from @starci/jest-preset again.
 export const UPGRADE_PRESETS = Object.freeze({
-  sonarExclusions: "**/*.spec.ts,**/*.e2e-spec.ts,**/dist/**,**/coverage/**",
+  sonarExclusions: bundledPresets().sonarExclusions,
   coverageSources: Object.freeze([
     "src/**/*.service.ts",
     "src/features/cli/**/*.cli.ts",