@starci/hfs 4.16.3 → 4.16.5

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 4.16.5 - 2026-11-01
+
+- Added: R354 `FE_HEADING_ABOVE_CARD` (eslint-canon-fe `no-heading-above-card`).
+- Added: R353 `FE_TAG_GROUP_SELECTION` (eslint-canon-fe `no-selectable-tag-group`).
+- Added: R352 `FE_COMMAND_FILLS_HEADER` (eslint-canon-fe `no-fill-command-in-header`).
+- Added: R351 `FE_TABLE_IN_CARD` (eslint-canon-fe `no-table-in-card`) in the bundled rule catalog; R61 states the status law as the owner's pair rule.
+- Changed: the bundled canon pins name @starci/grammar 0.20.2, eslint-grammar-core and eslint-grammar-offset-pop 0.20.2, eslint-canon-be 3.11.6, eslint-canon-fe 9.8.5, stylelint-canon 2.4.0 and hfs 4.16.5 (RELEASE_VERSION_NOT_BUMPED: the previous versions are on npm). No behaviour change.
+
+## 4.16.4 - 2026-11-01
+
+- Fixed: the unused-symbol value resolver no longer overflows the call stack on a recursive function that spreads its own parameter (`{ ...term, op }` in a `reset(term)` that maps itself over `term.all`): the typed-property lookup carries the resolver's visited set instead of starting a fresh one, so the cycle ends at the first repeated node (`starci app check` crashed with "Maximum call stack size exceeded" in the hfs structure step).
+- Changed: the bundled canon pins name @starci/grammar 0.20.1, eslint-grammar-core and eslint-grammar-offset-pop 0.20.1, eslint-canon-be 3.11.5, eslint-canon-fe 9.8.4 and hfs 4.16.4.
+
 ## 4.16.3 - 2026-11-01
 
 - Changed: the bundled canon pins name hfs 4.16.3, @starci/grammar 0.20.0, eslint-canon-be 3.11.4, eslint-canon-fe 9.8.3 and eslint-grammar-core and eslint-grammar-offset-pop 0.20.0 (RELEASE_VERSION_NOT_BUMPED: 4.16.2 is on npm).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@starci/hfs",
-  "version": "4.16.3",
+  "version": "4.16.5",
   "description": "The StarCi app command implementation for scaffolding, linting, checking and synchronizing one product repository.",
   "type": "module",
   "license": "MIT",

package/runtime/knowledge/hfs/canon-pins.yaml

@@ -31,35 +31,35 @@ pins:
     source: packages/event-stream/package.json
     why: 'the one server-sent-events client of every front end (fe-stack event-stream, owner:event-stream-package): the transport client layer (modules/api/sse/clients) creates one instance for the app with the bearer token source and the stream operations follow on it; it carries Last-Event-ID resume, the capped doubling backoff, the heartbeat timeout, the single 401 renewal and the useSWRSubscription adapter, so no app keeps a hand-written reader.'
   '@starci/grammar':
-    version: 0.20.0
+    version: 0.20.2
     group: starci
     install: registry
     side: fe
     source: packages/grammar/package.json
     why: 'the grammar front ends read: the brand layer sets `--font-sans` and `--font-mono` and the grammar reads them; it carries the Input tel kind, the copyable and read-only Input, the IconButton disclosure props and count badge, ChatBubble, FillViewport, Textarea mentions and Enter-to-send, the leading PrimaryRailLayout rail, the plate-less Image, ListRow, the soft Alert, Progress steps, the floating primary IconButton, FlowGraph, the STATE-8 loading views and the bordered selectable TagGroup chips. The runtime source version wins for a @starci package.'
   '@starci/eslint-canon-be':
-    version: 3.11.4
+    version: 3.11.6
     group: starci
     install: registry
     side: be
     source: packages/eslint-canon-be/package.json
     why: 'the back-end ESLint canon: `loadHfs(import.meta.url)` of be/eslint.config.mjs finds the app-root hfs.json (kind app) and gives every linted file the view of the be side, and the project graph is built per side; its bundled runtime copies (slots, canon-pins, failure codes, the architecture machine) put .starcistacks and .sops.yaml at the app root; `starciBeConfig({ hfs: loadHfs(import.meta.url) })` is the typed factory and the BE-CONVENTION laws are its rules.'
   '@starci/eslint-canon-fe':
-    version: 9.8.3
+    version: 9.8.5
     group: starci
     install: registry
     side: fe
     source: packages/eslint-canon-fe/package.json
     why: 'the front-end ESLint canon: `loadHfs(import.meta.url)` of fe/eslint.config.mjs finds the app-root hfs.json (kind app) and gives every linted file the view of the fe side, and the project graph is built per side; its bundled runtime copies (slots, canon-pins, failure codes, the architecture machine) put .starcistacks and .sops.yaml at the app root; the front end has no tests (FE_NO_TESTS R97 in hfs) and no-vietnamese-in-source (R91) applies.'
   '@starci/eslint-grammar-core':
-    version: 0.20.0
+    version: 0.20.2
     group: starci
     install: registry
     side: fe
     source: packages/eslint-grammar-core/package.json
     why: 'the StarCi Grammar component API lint, versioned with @starci/grammar; front ends compose this family package with the universal FE canon.'
   '@starci/eslint-grammar-offset-pop':
-    version: 0.20.0
+    version: 0.20.2
     group: starci
     install: registry
     side: fe
@@ -106,7 +106,7 @@ pins:
     source: packages/ai-router/package.json
     why: 'the AI pool router of a back end: a NestJS module that routes OpenAI-compatible chat, stream and embeddings calls across keys, models and providers, with @starci/ai-router/testing for its specs; @starci/jest-preset compiles it as an ESM-only dependency.'
   '@starci/hfs':
-    version: 4.16.3
+    version: 4.16.5
     group: starci
     install: registry
     side: both

package/runtime/knowledge/hfs/rules.yaml

@@ -1253,7 +1253,7 @@ rules:
       - {path: packages/hfs/src/hfs-i18n-catalog-coverage.spec.mjs, editions: [lite, full]}
   - id: R61
     code: "FE_STYLE_TOKEN_ONLY"
-    law: "Application CSS uses the selected Grammar tokens for layout and the declared brand owner for brand values; every source declaration resolves. Status foregrounds reach 3:1 against their tinted surface and page background in each theme, body text reaches 4.5:1, and an insufficiently contrasting solid tone is never text. The selected Grammar owns the concrete token pairs, typography, scale and visual values."
+    law: "Application CSS uses the selected Grammar tokens for layout and the declared brand owner for brand values; every source declaration resolves. Status foregrounds reach 3:1 against their tinted surface and page background in each theme, body text reaches 4.5:1, content on a tone background uses the tone's soft pair and a mark with no background of the tone uses the tone itself. The selected Grammar owns the concrete token pairs, typography, scale and visual values."
     docs: [knowledge/patterns/fe/index.yaml#FE-RULE-OWNERSHIP, packages/stylelint/README.md, packages/eslint/fe/docs/brand-values.md, docs/source-process.md#the-test-ladder, knowledge/hfs/rules.yaml#R225]
     kinds: [lint, design]
     gates: [pre-commit, settle, land, ci]
@@ -6208,3 +6208,95 @@ rules:
         source: owner
         quote: "hay full 3 bỏ 4 đi!!! thầy nghĩ nên v"
         ruling: "One spacing scale with no 16; every container holds its content 12 in, and an app names relations through role props, never spacing utilities."
+  - id: R351
+    code: "FE_TABLE_IN_CARD"
+    law: "A DataTable is not placed inside a SurfaceCard, on the page or in a pane: plain rows with a few facts are a SurfaceListCard with the label outside and the note in its footer, and a table that belongs to a card is an owner decision named in this rule. The rule reads the JSX of the file: a DataTable enclosed by a SurfaceCard element, or rendered by a component of the same file that a SurfaceCard encloses."
+    kinds: [lint]
+    gates: [pre-commit, settle, land, ci]
+    failureCodes: ["FE_TABLE_IN_CARD"]
+    enforcers:
+      - {kind: eslint-fe, id: no-table-in-card}
+    editions: [lite, full]
+    docs: [contexts/ui/components/list-table.md]
+    templateNa: "A template draws no table in a card; an app adds one with its list screens."
+    proves:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_TABLE_IN_CARD]}
+    exemplifiedBy:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_TABLE_IN_CARD]}
+    witness:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_TABLE_IN_CARD]}
+    cases:
+      - id: case-1
+        date: "2026-11-01"
+        source: owner
+        quote: "quá phức tạp mới nhét bảng vào card"
+        ruling: "Plain rows are a SurfaceListCard with a bottom note in its footer; a DataTable is not put in a SurfaceCard."
+  - id: R352
+    code: "FE_COMMAND_FILLS_HEADER"
+    law: "A page or pane command hugs its label and sits at the end of its header row: a Grammar Button with width=\"fill\" in the actions of a PageHeader or the labelEnd of a SurfaceCard or SurfaceListCard is refused; width=\"fill\" is for a form submit, an auth panel and a phone action bar, which a file cannot show and the rule does not judge."
+    kinds: [lint]
+    gates: [pre-commit, settle, land, ci]
+    failureCodes: ["FE_COMMAND_FILLS_HEADER"]
+    enforcers:
+      - {kind: eslint-fe, id: no-fill-command-in-header}
+    editions: [lite, full]
+    docs: [contexts/ui/components/button.md]
+    templateNa: "A template draws no header command with a fill width."
+    proves:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_COMMAND_FILLS_HEADER]}
+    exemplifiedBy:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_COMMAND_FILLS_HEADER]}
+    witness:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_COMMAND_FILLS_HEADER]}
+    cases:
+      - id: case-1
+        date: "2026-11-01"
+        source: owner
+        quote: "(owner order relayed by the coordinator, 2026-11-01) a page or pane command hugs its label and sits at the end of its header row; Button width=fill is only for a form submit, an auth panel, or a phone action bar"
+        ruling: "A header command is never width fill; fill is for a form submit, an auth panel and a phone action bar."
+  - id: R353
+    code: "FE_TAG_GROUP_SELECTION"
+    law: "A TagGroup holds values the user entered, to remove or to order, and has no selection: selectionMode, selectedIds, defaultSelectedIds and onSelectionChange on it are refused. Peer values that filter a collection that stays in place are a FilterButtonGroup (sm toggle buttons on one row, the rest behind a +n search list)."
+    kinds: [lint]
+    gates: [pre-commit, settle, land, ci]
+    failureCodes: ["FE_TAG_GROUP_SELECTION"]
+    enforcers:
+      - {kind: eslint-fe, id: no-selectable-tag-group}
+    editions: [lite, full]
+    docs: [contexts/ui/components/chip.md]
+    templateNa: "A template draws no filter row."
+    proves:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_TAG_GROUP_SELECTION]}
+    exemplifiedBy:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_TAG_GROUP_SELECTION]}
+    witness:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_TAG_GROUP_SELECTION]}
+    cases:
+      - id: case-1
+        date: "2026-11-01"
+        source: owner
+        quote: "sao cái này không phải cụm button... button size xs kiểu nhóm button"
+        ruling: "A filter over a collection is a FilterButtonGroup of sm toggle buttons; the TagGroup has no selection."
+  - id: R354
+    code: "FE_HEADING_ABOVE_CARD"
+    law: "A card has a label by design, so a hand heading above it is wrong: a SectionHeader directly followed, in the same parent, by one SurfaceCard, SurfaceListCard or SurfaceAccordionCard, and a card whose ariaLabel is the header title, are refused; the title moves to the label, the count to fact, the action to labelEnd and the note to footer. Several cards under one header stay legal."
+    kinds: [lint]
+    gates: [pre-commit, settle, land, ci]
+    failureCodes: ["FE_HEADING_ABOVE_CARD"]
+    enforcers:
+      - {kind: eslint-fe, id: no-heading-above-card}
+    editions: [lite, full]
+    docs: [contexts/ui/components/card.md]
+    templateNa: "A template draws no section header above a card."
+    proves:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_HEADING_ABOVE_CARD]}
+    exemplifiedBy:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_HEADING_ABOVE_CARD]}
+    witness:
+      - {path: packages/eslint-canon-fe/src/surface-rules.spec.ts, editions: [lite, full], codes: [FE_HEADING_ABOVE_CARD]}
+    cases:
+      - id: case-1
+        date: "2026-11-01"
+        source: owner
+        quote: "bản thân card đã có label, vốn là mục đích thiết kế"
+        ruling: "A card carries its own title, count, action and note; a SectionHeader above a single card is refused."

package/runtime/scripts/hfs/rules/unused-symbol-flow.mjs

@@ -225,7 +225,7 @@ const readonlyDeclaration = (ts, symbol, name) => {
  * of that property in every object literal the program types by that declaration, in a typed table of constants. Any owner type that is not
  * such a declaration, or a literal whose property comes from an unknown source, leaves the read unresolved.
  */
-function typedPropertyValues(state, node) {
+function typedPropertyValues(state, node, seen) {
     const { ts, checker } = state;
     const owner = checker.getNonNullableType(checker.getTypeAtLocation(node.expression));
     const owners = owner.isUnion() ? owner.types : [owner];
@@ -236,7 +236,7 @@ function typedPropertyValues(state, node) {
         if (!literals?.length || !readonlyDeclaration(ts, symbol, node.name.text))
             return [];
         for (const literal of literals) {
-            const property = ownerProperty(state, literal, node.name.text, new Set(), valuesOf);
+            const property = ownerProperty(state, literal, node.name.text, seen, valuesOf);
             if (property === null)
                 return [];
             values.push(...property.values);
@@ -272,7 +272,7 @@ export function valuesOf(state, expression, visited = new Set()) {
         // Reading a property of null or undefined throws, so a nullish branch of the owner holds no value of the property.
         const owners = valuesOf(state, node.expression, seen).filter((owner) => !isNullish(ts, owner));
         const known = resolveAll(state, propertiesOf(state, owners, node.name.text, seen, valuesOf), seen);
-        return narrowed(known.length ? known : resolveAll(state, typedPropertyValues(state, node), seen));
+        return narrowed(known.length ? known : resolveAll(state, typedPropertyValues(state, node, seen), seen));
     }
     if (ts.isElementAccessExpression(node))
         return orLeaf(resolveAll(state, tableValues(state, node, seen), seen));