@starci/hfs 4.11.22 → 4.12.0

package/runtime/scripts/hfs/rules/database-access.mjs

@@ -2,13 +2,11 @@
 import { found } from './read.mjs';
 import { parseSql } from '../sql/pg-parse.mjs';
 import { eachInOrder } from '../../lib/in-order.mjs';
-
 export const DB_APP_ROLE = 'DB_APP_ROLE';
 export const DB_FORCE_RLS_DEFAULT = 'DB_FORCE_RLS_DEFAULT';
 export const DB_POLICY_TAUTOLOGY = 'DB_POLICY_TAUTOLOGY';
 export const DB_VIEW_UNSAFE = 'DB_VIEW_UNSAFE';
 export const DB_STORAGE_PREFIX = 'DB_STORAGE_PREFIX';
-
 const sval = (value) => value?.String?.sval;
 const names = (values) => (values ?? []).map(sval).filter(Boolean).join('.');
 const qualify = (name) => name.includes('.') ? name : `public.${name}`;
@@ -24,254 +22,285 @@ const NOT = ['NOT', 'EXPR'].join('_');
 const SEQUENCE = ['OBJECT', 'SEQUENCE'].join('_');
 const MATVIEW = ['OBJECT', 'MATVIEW'].join('_');
 const note = (code, source, message, extra = {}) => found(code, source.file, `${source.file}:${source.line} ${message}`, { line: source.line, ...extra });
-
 function someNode(node, predicate) {
-  if (!node || typeof node !== 'object') return false;
-  if (predicate(node)) return true;
-  return Object.values(node).some((child) => someNode(child, predicate));
+    if (!node || typeof node !== 'object')
+        return false;
+    if (predicate(node))
+        return true;
+    return Object.values(node).some((child) => someNode(child, predicate));
 }
-
 function structural(node) {
-  if (Array.isArray(node)) return node.map(structural);
-  if (!node || typeof node !== 'object') return node;
-  return Object.fromEntries(Object.entries(node).filter(([key]) => key !== 'location').map(([key, value]) => [key, structural(value)]));
+    if (Array.isArray(node))
+        return node.map(structural);
+    if (!node || typeof node !== 'object')
+        return node;
+    return Object.fromEntries(Object.entries(node).filter(([key]) => key !== 'location').map(([key, value]) => [key, structural(value)]));
 }
-
 function principalCall(call, helpers) {
-  const name = names(call.funcname);
-  if (['auth.uid', 'auth.jwt'].includes(name) || helpers.has(name)) return true;
-  return ['current_setting', 'pg_catalog.current_setting'].includes(name)
-    && ['request.jwt.claims', 'request.jwt.claim.sub'].includes(stringValue(call.args?.[0]));
+    const name = names(call.funcname);
+    if (['auth.uid', 'auth.jwt'].includes(name) || helpers.has(name))
+        return true;
+    return ['current_setting', 'pg_catalog.current_setting'].includes(name)
+        && ['request.jwt.claims', 'request.jwt.claim.sub'].includes(stringValue(call.args?.[0]));
 }
-
 const hasPrincipal = (node, helpers) => someNode(node, (item) => Boolean(item.FuncCall && principalCall(item.FuncCall, helpers)));
 const literalFalse = (node) => unwrap(node)?.A_Const?.boolval?.boolval === false;
-
 function principalPredicate(expression, helpers) {
-  const node = unwrap(expression);
-  if (!node) return false;
-  if (literalFalse(node)) return true;
-  if (node.NullTest || node.BooleanTest) return false;
-  const bool = node.BoolExpr;
-  if (bool?.boolop === AND) return bool.args.some((arg) => principalPredicate(arg, helpers));
-  if (bool?.boolop === OR) return bool.args.every((arg) => principalPredicate(arg, helpers));
-  if (bool?.boolop === NOT) return false;
-  const expr = node.A_Expr;
-  if (expr && JSON.stringify(structural(expr.lexpr)) === JSON.stringify(structural(expr.rexpr))) return false;
-  return hasPrincipal(node, helpers);
+    const node = unwrap(expression);
+    if (!node)
+        return false;
+    if (literalFalse(node))
+        return true;
+    if (node.NullTest || node.BooleanTest)
+        return false;
+    const bool = node.BoolExpr;
+    if (bool?.boolop === AND)
+        return bool.args.some((arg) => principalPredicate(arg, helpers));
+    if (bool?.boolop === OR)
+        return bool.args.every((arg) => principalPredicate(arg, helpers));
+    if (bool?.boolop === NOT)
+        return false;
+    const expr = node.A_Expr;
+    if (expr && JSON.stringify(structural(expr.lexpr)) === JSON.stringify(structural(expr.rexpr)))
+        return false;
+    return hasPrincipal(node, helpers);
 }
-
 async function principalHelpers(analyses) {
-  const functions = analyses.flatMap(({ facts }) => facts.functions);
-  const bodies = [];
-  await eachInOrder(functions, async (fn) => {
-    const body = (fn.node.options ?? []).find((option) => option.DefElem?.defname === 'as')?.DefElem?.arg?.List?.items?.[0]?.String?.sval;
-    if (!body) return;
-    try { bodies.push({ name: fn.name, ast: await parseSql(body) }); } catch { /* PL/pgSQL safety is checked separately. */ }
-  });
-  const helpers = new Set();
-  for (let remaining = bodies.length; remaining > 0; remaining -= 1) {
-    for (const body of bodies) if (hasPrincipal(body.ast, helpers)) helpers.add(body.name);
-  }
-  return helpers;
+    const functions = analyses.flatMap(({ facts }) => facts.functions);
+    const bodies = [];
+    await eachInOrder(functions, async (fn) => {
+        const body = (fn.node.options ?? []).find((option) => option.DefElem?.defname === 'as')?.DefElem?.arg?.List?.items?.[0]?.String?.sval;
+        if (!body)
+            return;
+        try {
+            bodies.push({ name: fn.name, ast: await parseSql(body) });
+        }
+        catch { /* PL/pgSQL safety is checked separately. */ }
+    });
+    const helpers = new Set();
+    for (let remaining = bodies.length; remaining > 0; remaining -= 1) {
+        for (const body of bodies)
+            if (hasPrincipal(body.ast, helpers))
+                helpers.add(body.name);
+    }
+    return helpers;
 }
-
 function applyPolicies(policies, events, file) {
-  for (const event of events) {
-    const item = event.kind === 'create' ? event.policy : event;
-    const key = `${item.schema}.${item.table}/${item.name}`;
-    if (event.kind === 'drop') policies.delete(key);
-    else if (event.kind === 'create') policies.set(key, { ...item, file });
-    else policies.set(key, { ...policies.get(key), ...item, file, cmd: policies.get(key)?.cmd ?? 'all' });
-  }
+    for (const event of events) {
+        const item = event.kind === 'create' ? event.policy : event;
+        const key = `${item.schema}.${item.table}/${item.name}`;
+        if (event.kind === 'drop')
+            policies.delete(key);
+        else if (event.kind === 'create')
+            policies.set(key, { ...item, file });
+        else
+            policies.set(key, { ...policies.get(key), ...item, file, cmd: policies.get(key)?.cmd ?? 'all' });
+    }
 }
-
 function grantTargets(grant) {
-  if (!['OBJECT_TABLE', SEQUENCE].includes(grant.objtype)) return [];
-  if (grant.targtype === 'ACL_TARGET_ALL_IN_SCHEMA') return grant.objects.map((object) => `${sval(object)}.*`);
-  return grant.objects.filter((object) => object.RangeVar).map((object) => relationName(object.RangeVar, grant.defaultSchema));
+    if (!['OBJECT_TABLE', SEQUENCE].includes(grant.objtype))
+        return [];
+    if (grant.targtype === 'ACL_TARGET_ALL_IN_SCHEMA')
+        return grant.objects.map((object) => `${sval(object)}.*`);
+    return grant.objects.filter((object) => object.RangeVar).map((object) => relationName(object.RangeVar, grant.defaultSchema));
 }
-
 function applyGrant(grants, grant, file) {
-  for (const target of grantTargets(grant)) {
-    for (const role of grant.grantees) {
-      const key = `${target}/${role}`;
-      const state = grants.get(key) ?? { target, role, privileges: new Set(), revokedRead: false, objtype: grant.objtype };
-      const privileges = grant.all || !grant.privileges.length ? ['all'] : grant.privileges;
-      updatePrivileges(state, grant.grant, privileges);
-      grants.set(key, { ...state, file, line: grant.line });
+    for (const target of grantTargets(grant)) {
+        for (const role of grant.grantees) {
+            const key = `${target}/${role}`;
+            const state = grants.get(key) ?? { target, role, privileges: new Set(), revokedRead: false, objtype: grant.objtype };
+            const privileges = grant.all || !grant.privileges.length ? ['all'] : grant.privileges;
+            updatePrivileges(state, grant.grant, privileges);
+            grants.set(key, { ...state, file, line: grant.line });
+        }
     }
-  }
 }
-
 function updatePrivileges(state, granting, privileges) {
-  if (granting) {
-    for (const privilege of privileges) state.privileges.add(privilege);
-    if (privileges.some((privilege) => ['select', 'all'].includes(privilege))) state.revokedRead = false;
-    return;
-  }
-  if (privileges.includes('all')) state.privileges.clear();
-  else for (const privilege of privileges) state.privileges.delete(privilege);
-  if (privileges.some((privilege) => ['select', 'all'].includes(privilege))) state.revokedRead = true;
+    if (granting) {
+        for (const privilege of privileges)
+            state.privileges.add(privilege);
+        if (privileges.some((privilege) => ['select', 'all'].includes(privilege)))
+            state.revokedRead = false;
+        return;
+    }
+    if (privileges.includes('all'))
+        state.privileges.clear();
+    else
+        for (const privilege of privileges)
+            state.privileges.delete(privilege);
+    if (privileges.some((privilege) => ['select', 'all'].includes(privilege)))
+        state.revokedRead = true;
 }
-
 function policyFindings(policies, appRole, helpers) {
-  const findings = [];
-  for (const policy of policies) {
-    const table = `${policy.schema}.${policy.table}`;
-    if (policy.roles.every((role) => role === appRole) || publicRead(policy)) continue;
-    const predicates = [policy.qual, policy.withCheck].filter((expression) => expression !== undefined);
-    if (!predicates.length || predicates.some((expression) => !principalPredicate(expression, helpers))) {
-      findings.push(note(DB_POLICY_TAUTOLOGY, policy, `policy ${policy.name} must constrain a principal; constants, IS NOT NULL and self comparisons grant no ownership boundary`, { table, policy: policy.name }));
+    const findings = [];
+    for (const policy of policies) {
+        const table = `${policy.schema}.${policy.table}`;
+        if (policy.roles.every((role) => role === appRole) || publicRead(policy))
+            continue;
+        const predicates = [policy.qual, policy.withCheck].filter((expression) => expression !== undefined);
+        if (!predicates.length || predicates.some((expression) => !principalPredicate(expression, helpers))) {
+            findings.push(note(DB_POLICY_TAUTOLOGY, policy, `policy ${policy.name} must constrain a principal; constants, IS NOT NULL and self comparisons grant no ownership boundary`, { table, policy: policy.name }));
+        }
     }
-  }
-  return findings;
+    return findings;
 }
-
 function roleFindings(analyses, appRole) {
-  const findings = [];
-  for (const { file, facts } of analyses) {
-    for (const statement of facts.statements) findings.push(...roleStatementFindings({ ...statement, file }, appRole));
-    for (const grant of facts.grants) {
-      if (grant.grant && grant.grantees.includes(appRole) && (grant.all || !grant.privileges.length)) {
-        findings.push(note(DB_APP_ROLE, { ...grant, file }, `${appRole} receives ALL privileges; grant the capabilities it uses explicitly`));
-      }
+    const findings = [];
+    for (const { file, facts } of analyses) {
+        for (const statement of facts.statements)
+            findings.push(...roleStatementFindings({ ...statement, file }, appRole));
+        for (const grant of facts.grants) {
+            if (grant.grant && grant.grantees.includes(appRole) && (grant.all || !grant.privileges.length)) {
+                findings.push(note(DB_APP_ROLE, { ...grant, file }, `${appRole} receives ALL privileges; grant the capabilities it uses explicitly`));
+            }
+        }
     }
-  }
-  return findings;
+    return findings;
 }
-
 function roleStatementFindings(statement, appRole) {
-  const { type, node } = statement;
-  if (!['CreateRoleStmt', 'AlterRoleStmt'].includes(type)) return [];
-  const role = type === 'CreateRoleStmt' ? node.role : roleName(node.role);
-  if (role !== appRole) return [];
-  const options = new Map((node.options ?? []).map(({ DefElem: option }) => [option.defname, option.arg?.Boolean?.boolval]));
-  const unsafe = ['superuser', 'bypassrls', 'createdb', 'createrole', 'replication', 'inherit'].some((option) => options.get(option) === true);
-  const creationInvalid = type === 'CreateRoleStmt' && (options.get('canlogin') !== true || options.get('inherit') !== false);
-  if (!unsafe && !creationInvalid) return [];
-  return [note(DB_APP_ROLE, statement, `${appRole} must LOGIN NOINHERIT without SUPERUSER, BYPASSRLS or administrative role attributes`)];
+    const { type, node } = statement;
+    if (!['CreateRoleStmt', 'AlterRoleStmt'].includes(type))
+        return [];
+    const role = type === 'CreateRoleStmt' ? node.role : roleName(node.role);
+    if (role !== appRole)
+        return [];
+    const options = new Map((node.options ?? []).map(({ DefElem: option }) => [option.defname, option.arg?.Boolean?.boolval]));
+    const unsafe = ['superuser', 'bypassrls', 'createdb', 'createrole', 'replication', 'inherit'].some((option) => options.get(option) === true);
+    const creationInvalid = type === 'CreateRoleStmt' && (options.get('canlogin') !== true || options.get('inherit') !== false);
+    if (!unsafe && !creationInvalid)
+        return [];
+    return [note(DB_APP_ROLE, statement, `${appRole} must LOGIN NOINHERIT without SUPERUSER, BYPASSRLS or administrative role attributes`)];
 }
-
 function tableStates(analyses) {
-  const tables = new Map();
-  let owner = null;
-  for (const { file, facts } of analyses) {
-    owner = null;
-    for (const statement of facts.statements) {
-      const { type, node, defaultSchema } = statement;
-      if (type === 'VariableSetStmt' && ['role', 'session_authorization'].includes(node.name)) owner = stringValue(node.args?.[0]) ?? null;
-      const relation = type === 'CreateTableAsStmt' ? node.into?.rel : node.relation;
-      if (['CreateStmt', 'CreateTableAsStmt'].includes(type) && relation && node.objtype !== MATVIEW && relation.relpersistence !== 't') {
-        tables.set(relationName(relation, defaultSchema), { owner, forced: false, ...statement, file });
-      }
-      applyTableAlter(tables, { ...statement, file });
+    const tables = new Map();
+    let owner = null;
+    for (const { file, facts } of analyses) {
+        owner = null;
+        for (const statement of facts.statements) {
+            const { type, node, defaultSchema } = statement;
+            if (type === 'VariableSetStmt' && ['role', 'session_authorization'].includes(node.name))
+                owner = stringValue(node.args?.[0]) ?? null;
+            const relation = type === 'CreateTableAsStmt' ? node.into?.rel : node.relation;
+            if (['CreateStmt', 'CreateTableAsStmt'].includes(type) && relation && node.objtype !== MATVIEW && relation.relpersistence !== 't') {
+                tables.set(relationName(relation, defaultSchema), { owner, forced: false, ...statement, file });
+            }
+            applyTableAlter(tables, { ...statement, file });
+        }
     }
-  }
-  return tables;
+    return tables;
 }
-
 function applyTableAlter(tables, statement) {
-  const { type, node, defaultSchema } = statement;
-  if (!node.relation) return;
-  const key = relationName(node.relation, defaultSchema);
-  const table = tables.get(key) ?? { forced: false };
-  if (type === 'AlterObjectSchemaStmt' && node.objectType === 'OBJECT_TABLE') {
-    tables.delete(key);
-    tables.set(`${node.newschema}.${node.relation.relname}`, { ...table, ...statement });
-  }
-  if (type !== 'AlterTableStmt' || node.objtype !== 'OBJECT_TABLE') return;
-  for (const { AlterTableCmd: cmd } of node.cmds ?? []) {
-    if (cmd.subtype === 'AT_ChangeOwner') Object.assign(table, statement, { owner: roleName(cmd.newowner) });
-    if (cmd.subtype === 'AT_ForceRowSecurity') table.forced = true;
-    if (cmd.subtype === 'AT_NoForceRowSecurity') Object.assign(table, statement, { forced: false });
-  }
-  tables.set(key, table);
+    const { type, node, defaultSchema } = statement;
+    if (!node.relation)
+        return;
+    const key = relationName(node.relation, defaultSchema);
+    const table = tables.get(key) ?? { forced: false };
+    if (type === 'AlterObjectSchemaStmt' && node.objectType === 'OBJECT_TABLE') {
+        tables.delete(key);
+        tables.set(`${node.newschema}.${node.relation.relname}`, { ...table, ...statement });
+    }
+    if (type !== 'AlterTableStmt' || node.objtype !== 'OBJECT_TABLE')
+        return;
+    for (const { AlterTableCmd: cmd } of node.cmds ?? []) {
+        if (cmd.subtype === 'AT_ChangeOwner')
+            Object.assign(table, statement, { owner: roleName(cmd.newowner) });
+        if (cmd.subtype === 'AT_ForceRowSecurity')
+            table.forced = true;
+        if (cmd.subtype === 'AT_NoForceRowSecurity')
+            Object.assign(table, statement, { forced: false });
+    }
+    tables.set(key, table);
 }
-
 function forceFindings(analyses, db, appRole) {
-  const exemptions = new Set((db.forceRlsExemptions ?? []).filter((item) => typeof item?.table === 'string' && typeof item.reason === 'string' && item.reason.trim()).map((item) => qualify(item.table)));
-  return [...tableStates(analyses)].filter(([name, table]) => table.owner === appRole && !table.forced && !exemptions.has(name))
-    .map(([table, source]) => note(DB_FORCE_RLS_DEFAULT, source, `${appRole} owns ${table} without FORCE ROW LEVEL SECURITY; an exemption needs hfs.json db.forceRlsExemptions with a table and reason`, { table }));
+    const exemptions = new Set((db.forceRlsExemptions ?? []).filter((item) => typeof item?.table === 'string' && typeof item.reason === 'string' && item.reason.trim()).map((item) => qualify(item.table)));
+    return [...tableStates(analyses)].filter(([name, table]) => table.owner === appRole && !table.forced && !exemptions.has(name))
+        .map(([table, source]) => note(DB_FORCE_RLS_DEFAULT, source, `${appRole} owns ${table} without FORCE ROW LEVEL SECURITY; an exemption needs hfs.json db.forceRlsExemptions with a table and reason`, { table }));
 }
-
 function viewFindings(analyses, grants, exposed) {
-  const views = new Map();
-  for (const { file, facts } of analyses) for (const view of facts.views) views.set(`${view.schema}.${view.name}`, { ...view, file });
-  const findings = [];
-  for (const [table, view] of views) {
-    if (!exposed.has(view.schema) || view.securityInvoker) continue;
-    if (['anon', 'authenticated'].every((role) => grants.get(`${table}/${role}`)?.revokedRead)) continue;
-    findings.push(note(DB_VIEW_UNSAFE, view, `exposed ${view.kind} ${table} needs security_invoker = true (ordinary views), or SELECT revoked from anon and authenticated`, { table }));
-  }
-  return findings;
+    const views = new Map();
+    for (const { file, facts } of analyses)
+        for (const view of facts.views)
+            views.set(`${view.schema}.${view.name}`, { ...view, file });
+    const findings = [];
+    for (const [table, view] of views) {
+        if (!exposed.has(view.schema) || view.securityInvoker)
+            continue;
+        if (['anon', 'authenticated'].every((role) => grants.get(`${table}/${role}`)?.revokedRead))
+            continue;
+        findings.push(note(DB_VIEW_UNSAFE, view, `exposed ${view.kind} ${table} needs security_invoker = true (ordinary views), or SELECT revoked from anon and authenticated`, { table }));
+    }
+    return findings;
 }
-
 function folderPrefix(node) {
-  const value = unwrap(node);
-  const subscript = value?.A_Indirection;
-  const call = subscript?.arg?.FuncCall;
-  return names(call?.funcname) === 'storage.foldername'
-    && names(unwrap(call?.args?.[0])?.ColumnRef?.fields) === 'name'
-    && subscript.indirection?.[0]?.A_Indices?.uidx?.A_Const?.ival?.ival === 1;
+    const value = unwrap(node);
+    const subscript = value?.A_Indirection;
+    const call = subscript?.arg?.FuncCall;
+    return names(call?.funcname) === 'storage.foldername'
+        && names(unwrap(call?.args?.[0])?.ColumnRef?.fields) === 'name'
+        && subscript.indirection?.[0]?.A_Indices?.uidx?.A_Const?.ival?.ival === 1;
 }
-
 function ownershipExpression(expression, helpers) {
-  const node = unwrap(expression);
-  if (!node) return false;
-  const op = node.A_Expr;
-  if (!op || operator(op) !== '=') return false;
-  return (folderPrefix(op.lexpr) && hasPrincipal(op.rexpr, helpers)) || (folderPrefix(op.rexpr) && hasPrincipal(op.lexpr, helpers));
+    const node = unwrap(expression);
+    if (!node)
+        return false;
+    const op = node.A_Expr;
+    if (!op || operator(op) !== '=')
+        return false;
+    return (folderPrefix(op.lexpr) && hasPrincipal(op.rexpr, helpers)) || (folderPrefix(op.rexpr) && hasPrincipal(op.lexpr, helpers));
 }
-
 function publicBucketExpression(expression) {
-  const node = unwrap(expression);
-  if (!node) return false;
-  const op = node.A_Expr;
-  if (!op || operator(op) !== '=') return false;
-  const leftColumn = names(unwrap(op.lexpr)?.ColumnRef?.fields);
-  const rightColumn = names(unwrap(op.rexpr)?.ColumnRef?.fields);
-  return (leftColumn === 'bucket_id' && stringValue(op.rexpr)?.endsWith('_public'))
-    || (rightColumn === 'bucket_id' && stringValue(op.lexpr)?.endsWith('_public'));
+    const node = unwrap(expression);
+    if (!node)
+        return false;
+    const op = node.A_Expr;
+    if (!op || operator(op) !== '=')
+        return false;
+    const leftColumn = names(unwrap(op.lexpr)?.ColumnRef?.fields);
+    const rightColumn = names(unwrap(op.rexpr)?.ColumnRef?.fields);
+    return (leftColumn === 'bucket_id' && stringValue(op.rexpr)?.endsWith('_public'))
+        || (rightColumn === 'bucket_id' && stringValue(op.lexpr)?.endsWith('_public'));
 }
-
 function storageBoundaryExpression(expression, helpers) {
-  const node = unwrap(expression);
-  if (!node) return false;
-  const bool = node.BoolExpr;
-  if (bool?.boolop === AND) return bool.args.some((arg) => storageBoundaryExpression(arg, helpers));
-  if (bool?.boolop === OR) return bool.args.every((arg) => storageBoundaryExpression(arg, helpers));
-  return publicBucketExpression(node) || ownershipExpression(node, helpers);
+    const node = unwrap(expression);
+    if (!node)
+        return false;
+    const bool = node.BoolExpr;
+    if (bool?.boolop === AND)
+        return bool.args.some((arg) => storageBoundaryExpression(arg, helpers));
+    if (bool?.boolop === OR)
+        return bool.args.every((arg) => storageBoundaryExpression(arg, helpers));
+    return publicBucketExpression(node) || ownershipExpression(node, helpers);
 }
-
 function storagePrefixFindings(policies, helpers) {
-  const findings = [];
-  for (const policy of policies) {
-    if (policy.schema !== 'storage' || policy.table !== 'objects') continue;
-    const expressions = [policy.qual, policy.withCheck].filter((expression) => expression !== undefined);
-    if (expressions.length && expressions.every((expression) => storageBoundaryExpression(expression, helpers))) continue;
-    findings.push(note(DB_STORAGE_PREFIX, policy, `storage.objects policy ${policy.name} must compare storage.foldername(name)[1] with the principal, unless scoped to an *_public bucket`, { policy: policy.name }));
-  }
-  return findings;
+    const findings = [];
+    for (const policy of policies) {
+        if (policy.schema !== 'storage' || policy.table !== 'objects')
+            continue;
+        const expressions = [policy.qual, policy.withCheck].filter((expression) => expression !== undefined);
+        if (expressions.length && expressions.every((expression) => storageBoundaryExpression(expression, helpers)))
+            continue;
+        findings.push(note(DB_STORAGE_PREFIX, policy, `storage.objects policy ${policy.name} must compare storage.foldername(name)[1] with the principal, unless scoped to an *_public bucket`, { policy: policy.name }));
+    }
+    return findings;
 }
-
 /** All new access checks run on the ordered active migrations in either edition, through checkDatabase. */
 export async function databaseAccessFindings({ analyses, exposed, db = {} }) {
-  const declared = db ?? {};
-  const appRole = declared.appRole ?? 'app_be';
-  const policyMap = new Map();
-  const grants = new Map();
-  for (const { file, facts } of analyses) {
-    applyPolicies(policyMap, facts.policyEvents, file);
-    for (const grant of facts.grants) applyGrant(grants, grant, file);
-  }
-  const policies = [...policyMap.values()];
-  const helpers = await principalHelpers(analyses);
-  return [
-    ...policyFindings(policies, appRole, helpers),
-    ...roleFindings(analyses, appRole),
-    ...forceFindings(analyses, declared, appRole),
-    ...viewFindings(analyses, grants, exposed),
-    ...storagePrefixFindings(policies, helpers),
-  ];
+    const declared = db ?? {};
+    const appRole = declared.appRole ?? 'app_be';
+    const policyMap = new Map();
+    const grants = new Map();
+    for (const { file, facts } of analyses) {
+        applyPolicies(policyMap, facts.policyEvents, file);
+        for (const grant of facts.grants)
+            applyGrant(grants, grant, file);
+    }
+    const policies = [...policyMap.values()];
+    const helpers = await principalHelpers(analyses);
+    return [
+        ...policyFindings(policies, appRole, helpers),
+        ...roleFindings(analyses, appRole),
+        ...forceFindings(analyses, declared, appRole),
+        ...viewFindings(analyses, grants, exposed),
+        ...storagePrefixFindings(policies, helpers),
+    ];
 }

package/runtime/scripts/hfs/rules/database-baseline.d.mts

@@ -0,0 +1,22 @@
+import type { Parsed, Repo } from './rule-types.mjs';
+/** Header comments only: SQL literals and later comments cannot impersonate a baseline marker. */
+export declare function baselineMarkers(text: string): (string | undefined)[];
+/** A cutover may archive only unchanged, committed source files from the same history the finder judges. */
+export declare function baselineSourceFindings({ repoRoot, files, all, git, base }: {
+    repoRoot: string;
+    files?: string[];
+    all?: string[];
+    git?: Parsed;
+    base?: Parsed;
+}): import("./rule-types.mjs").Finding[];
+/** R257 content finder, synchronous in both editions; all paths judge cross-file cutovers even under --fast. */
+export declare function databaseBaselineFindings({ repoRoot, files, all, repo, isRoot, inScope, base, git }: {
+    repoRoot: string;
+    files?: string[];
+    all: string[];
+    repo: Repo;
+    isRoot: boolean;
+    inScope: (file: string) => boolean;
+    base?: Parsed;
+    git?: Parsed;
+}): import("./rule-types.mjs").Finding[];