@starci/hfs 4.11.13 → 4.11.16

package/templates/be/inbox/database-client.spec.ts.tpl

@@ -1,45 +0,0 @@
-import { mockEntityManager } from "@starci/jest-preset"
-import type { EntityManager } from "typeorm"
-import { DatabaseErrorCode } from "./errors/database.error"
-import { recordWebhookDelivery, webhookReceiptInsert } from "./webhook-inbox.client"
-
-const INSERT = webhookReceiptInsert("spec_inbox")
-const PAYLOAD = { id: "delivery-1" }
-
-const record = (manager: EntityManager, deliveryId: string | undefined) =>
-    recordWebhookDelivery({ manager, table: "spec_inbox", provider: "spec", deliveryId, payload: PAYLOAD })
-
-describe("webhookReceiptInsert", () => {
-    it("refuses a table name that is not a lowercase identifier", () => {
-        expect(() => webhookReceiptInsert("spec; drop table x")).toThrow(TypeError)
-    })
-})
-
-describe("recordWebhookDelivery", () => {
-    it("records a new delivery through the caller's transaction manager", async () => {
-        const manager = mockEntityManager({ query: [INSERT, [{ id: "inbox-1" }]] })
-
-        const receiptId = await record(manager, "  delivery-1  ")
-
-        expect(manager.query).toHaveBeenCalledTimes(1)
-        expect(manager.query).toHaveBeenCalledWith(INSERT, ["spec", "delivery-1", JSON.stringify(PAYLOAD)])
-        expect(receiptId).toBe("inbox-1")
-    })
-
-    it("acknowledges a duplicate without any completion or business write", async () => {
-        const manager = mockEntityManager({ query: [INSERT, []] })
-
-        const receiptId = await record(manager, "delivery-1")
-
-        expect(manager.query).toHaveBeenCalledTimes(1)
-        expect(receiptId).toBeUndefined()
-    })
-
-    it.each([["no", undefined], ["a blank", "   "]])("refuses %s delivery id before writing a receipt", async (_label, deliveryId) => {
-        const manager = mockEntityManager()
-
-        await expect(record(manager, deliveryId)).rejects.toMatchObject({ code: DatabaseErrorCode.WebhookDeliveryIdRequired })
-
-        expect(manager.query).not.toHaveBeenCalled()
-    })
-})

package/templates/be/inbox/database-client.ts.tpl

@@ -1,45 +0,0 @@
-import type { EntityManager } from "typeorm"
-import { DatabaseError, DatabaseErrorCode } from "./errors/database.error"
-
-interface RecordWebhookDelivery {
-    readonly manager: EntityManager
-    /** The provider inbox table under public, created by its db migration. */
-    readonly table: string
-    readonly provider: string
-    readonly deliveryId: string | undefined
-    readonly payload: object
-}
-
-type WebhookReceiptId = string | undefined
-
-/** A provider inbox table name: a lowercase identifier, never a value. */
-const TABLE = /^[a-z_][a-z0-9_]*$/
-
-/** The conflict-safe insert of one pending delivery into `public.<table>`, answering its id only to the winning transaction. */
-export const webhookReceiptInsert = (table: string): string => {
-    if (!TABLE.test(table)) throw new TypeError(`${table} is not a provider inbox table name`)
-    return `INSERT INTO public.${table} (provider, delivery_id, payload) VALUES ($1, $2, $3::jsonb) ON CONFLICT (provider, delivery_id) DO NOTHING RETURNING id`
-}
-
-/**
- * Records one pending delivery using the intake's transaction manager and returns its durable receipt identity.
- * Business processing and the completion marker belong to the reactor or job that consumes the committed row.
- */
-export const recordWebhookDelivery = async ({
-    manager,
-    table,
-    provider,
-    deliveryId,
-    payload,
-}: RecordWebhookDelivery): Promise<WebhookReceiptId> => {
-    const normalizedDeliveryId = deliveryId?.trim()
-    if (!normalizedDeliveryId) {
-        throw new DatabaseError({ code: DatabaseErrorCode.WebhookDeliveryIdRequired })
-    }
-    const rows: Array<{ readonly id: string }> = await manager.query(webhookReceiptInsert(table), [
-        provider,
-        normalizedDeliveryId,
-        JSON.stringify(payload),
-    ])
-    return rows[0]?.id
-}