@starci/eslint-grammar-core 0.15.34 → 0.16.2

package/runtime/scripts/hfs/slot-required.mjs

@@ -4,86 +4,92 @@ import path from 'node:path';
 import { braceVariants } from '../lib/glob.mjs';
 import { classifyIn, slotEnabled } from './slot-classify.mjs';
 import { fillVars, varsOf } from './slot-match.mjs';
-
 /** A populated fe.modules instance needs its index.ts only when it contains TypeScript, including nested files. */
 export function requiredFileApplies(slotId, target, files) {
-  if (!/^fe\.modules(?:\.|$)/u.test(slotId) || path.posix.basename(target) !== 'index.ts') return true;
-  const prefix = `${path.posix.dirname(target)}/`;
-  let populated = false;
-  for (const file of files) {
-    if (!file.startsWith(prefix)) continue;
-    populated = true;
-    if (/\.tsx?$/u.test(file)) return true;
-  }
-  return !populated;
+    if (!/^fe\.modules(?:\.|$)/u.test(slotId) || path.posix.basename(target) !== 'index.ts')
+        return true;
+    const prefix = `${path.posix.dirname(target)}/`;
+    let populated = false;
+    for (const file of files) {
+        if (!file.startsWith(prefix))
+            continue;
+        populated = true;
+        if (/\.tsx?$/u.test(file))
+            return true;
+    }
+    return !populated;
 }
-
 /** One `requires` entry of a slot placed under `root`: a leading / makes it repository-relative, the variables are filled from `bindings`. */
 function requiredEntry(entry, bindings, root) {
-  const rooted = entry.startsWith('/');
-  const filled = fillVars(rooted ? entry.slice(1) : entry, bindings);
-  return rooted || !root || root === '.' ? filled : `${root}/${filled}`;
+    const rooted = entry.startsWith('/');
+    const filled = fillVars(rooted ? entry.slice(1) : entry, bindings);
+    return rooted || !root || root === '.' ? filled : `${root}/${filled}`;
 }
-
 /** The files and directories the instance holding `p` must contain (directories end with /); {path} entries are repo-relative. */
 export function requiredFilesIn(scope, input) {
-  const c = classifyIn(scope, input);
-  if (!c.slot) return [];
-  const slot = scope.byId.get(c.slot);
-  return (slot.requires ?? []).map((entry) => requiredEntry(entry, c.bindings, c.root));
+    const c = classifyIn(scope, input);
+    if (!c.slot)
+        return [];
+    const slot = scope.byId.get(c.slot);
+    return (slot.requires ?? []).map((entry) => requiredEntry(entry, c.bindings, c.root));
 }
-
 function growBindings(combos, name, values) {
-  const next = [];
-  for (const combo of combos) {
-    for (const value of values) next.push({ ...combo, [name]: value });
-  }
-  combos.splice(0, combos.length, ...next);
+    const next = [];
+    for (const combo of combos) {
+        for (const value of values)
+            next.push({ ...combo, [name]: value });
+    }
+    combos.splice(0, combos.length, ...next);
 }
-
 const expandApps = (repo, slot) => repo.apps.filter((a) => slot.appKind === undefined || a.kind === slot.appKind);
-
 function appendRequiredVariantPaths(repo, slot, variant, paths) {
-  const names = [...new Set(varsOf(variant))];
-  const fixed = { ...slot.requiredInstances };
-  const open = names.filter((name) => name !== 'app' && !(name in fixed));
-  if (open.length) return;
-  const combos = [{}];
-  if (names.includes('app')) growBindings(combos, 'app', expandApps(repo, slot).map((app) => app.name));
-  for (const [name, values] of Object.entries(fixed)) growBindings(combos, name, values);
-  const isInstance = names.length > 0;
-  for (const bindings of combos) {
-    const target = fillVars(variant, bindings);
-    paths.push({ slot: slot.id, path: target, via: isInstance ? 'instance' : 'slot' });
-    const root = target.endsWith('/') ? target.slice(0, -1) : path.posix.dirname(target);
-    for (const entry of slot.requires ?? []) paths.push({ slot: slot.id, path: requiredEntry(entry, bindings, root), via: 'requires' });
-  }
+    const names = [...new Set(varsOf(variant))];
+    const fixed = { ...slot.requiredInstances };
+    const open = names.filter((name) => name !== 'app' && !(name in fixed));
+    if (open.length)
+        return;
+    const combos = [{}];
+    if (names.includes('app'))
+        growBindings(combos, 'app', expandApps(repo, slot).map((app) => app.name));
+    for (const [name, values] of Object.entries(fixed))
+        growBindings(combos, name, values);
+    const isInstance = names.length > 0;
+    for (const bindings of combos) {
+        const target = fillVars(variant, bindings);
+        paths.push({ slot: slot.id, path: target, via: isInstance ? 'instance' : 'slot' });
+        const root = target.endsWith('/') ? target.slice(0, -1) : path.posix.dirname(target);
+        for (const entry of slot.requires ?? [])
+            paths.push({ slot: slot.id, path: requiredEntry(entry, bindings, root), via: 'requires' });
+    }
 }
-
 function appendRequiredSlotPaths(scope, slot, paths, minimums) {
-  if (slot.presence !== 'required' || !slotEnabled(scope, slot)) return;
-  if (slot.requiredWhen === 'connections' && !scope.repo.connections.length) return;
-  if (slot.minInstances) minimums.push({ slot: slot.id, min: slot.minInstances, ...(slot.appKind ? { appKind: slot.appKind } : {}) });
-  for (const variant of braceVariants(slot.path)) appendRequiredVariantPaths(scope.repo, slot, variant, paths);
+    if (slot.presence !== 'required' || !slotEnabled(scope, slot))
+        return;
+    if (slot.requiredWhen === 'connections' && !scope.repo.connections.length)
+        return;
+    if (slot.minInstances)
+        minimums.push({ slot: slot.id, min: slot.minInstances, ...(slot.appKind ? { appKind: slot.appKind } : {}) });
+    for (const variant of braceVariants(slot.path))
+        appendRequiredVariantPaths(scope.repo, slot, variant, paths);
 }
-
 function uniqueRequiredPaths(paths) {
-  const seen = new Set();
-  return paths.filter((entry) => {
-    const key = `${entry.slot}|${entry.path}`;
-    if (seen.has(key)) return false;
-    seen.add(key);
-    return true;
-  });
+    const seen = new Set();
+    return paths.filter((entry) => {
+        const key = `${entry.slot}|${entry.path}`;
+        if (seen.has(key))
+            return false;
+        seen.add(key);
+        return true;
+    });
 }
-
 /**
  * What the repository must contain, without walking it: {paths: [{slot, path, via}], minimums: [{slot, min}]}.
  * via is slot (a fixed path), instance (a requiredInstances or app-kind root) or requires (a file an instance needs).
  */
 export function requiredPathsIn(scope) {
-  const paths = [];
-  const minimums = [];
-  for (const slot of scope.slots) appendRequiredSlotPaths(scope, slot, paths, minimums);
-  return { paths: uniqueRequiredPaths(paths), minimums };
+    const paths = [];
+    const minimums = [];
+    for (const slot of scope.slots)
+        appendRequiredSlotPaths(scope, slot, paths, minimums);
+    return { paths: uniqueRequiredPaths(paths), minimums };
 }

package/runtime/scripts/hfs/slot-semantic-problems.mjs

@@ -3,147 +3,173 @@ import { isPlainObject } from '../../engine/plain-object.mjs';
 import { triggerProblems } from './declaration-slots.mjs';
 import { litePresenceOf, slotInEdition } from './edition-slots.mjs';
 import { manifestKind, RUNTIME_KIND, runtimeSemanticProblems, tierKindProblems } from './manifest-shape.mjs';
-import { APP_SCOPE, PROFILES } from './slot-manifest-shape.mjs';
-
+import { APP_SCOPE, isSide, PROFILES } from './slot-manifest-shape.mjs';
 function checkAppRootSlot(slot, bad) {
-  for (const key of ['appKind', 'owner', 'layers', 'kinds', 'composedBy', 'requiredWhen', 'requiredInstances']) {
-    if (slot[key] !== undefined) bad.push(`slot ${slot.id}: an app-root slot has no ${key}`);
-  }
-  if (slot.tier !== 'none') bad.push(`slot ${slot.id}: an app-root slot has tier none`);
+    for (const key of ['appKind', 'owner', 'layers', 'kinds', 'composedBy', 'requiredWhen', 'requiredInstances']) {
+        if (slot[key] !== undefined)
+            bad.push(`slot ${slot.id}: an app-root slot has no ${key}`);
+    }
+    if (slot.tier !== 'none')
+        bad.push(`slot ${slot.id}: an app-root slot has tier none`);
 }
-
 function checkSideSlot(slot, profile, manifest, bad) {
-  const tiers = manifest.tiers[profile];
-  if (slot.tier !== 'none' && slot.tier !== 'inherit' && !(slot.tier in tiers)) bad.push(`slot ${slot.id}: tier ${slot.tier} is not a ${profile} tier`);
-  if (slot.appKind !== undefined && !manifest.appKinds[profile].includes(slot.appKind)) bad.push(`slot ${slot.id}: app kind ${slot.appKind} is not a ${profile} kind`);
-  bad.push(...triggerProblems(slot, manifest.triggerKinds));
+    const tiers = manifest.tiers[profile];
+    if (slot.tier !== 'none' && slot.tier !== 'inherit' && !(slot.tier in tiers))
+        bad.push(`slot ${slot.id}: tier ${slot.tier} is not a ${profile} tier`);
+    if (slot.appKind !== undefined && !manifest.appKinds[profile].includes(slot.appKind))
+        bad.push(`slot ${slot.id}: app kind ${slot.appKind} is not a ${profile} kind`);
+    bad.push(...triggerProblems(slot, manifest.triggerKinds));
 }
-
 function claimSlotPatterns(slot, profile, claimed, bad, braceVariants) {
-  if (slot.appKind !== undefined) return;
-  for (const variant of braceVariants(slot.path)) {
-    const key = `${profile}:${variant}`;
-    if (claimed.has(key)) bad.push(`slots ${claimed.get(key)} and ${slot.id} claim the same pattern ${variant} on ${profile}`);
-    else claimed.set(key, slot.id);
-  }
-}
-
+    if (slot.appKind !== undefined)
+        return;
+    for (const variant of braceVariants(slot.path)) {
+        const key = `${profile}:${variant}`;
+        if (claimed.has(key))
+            bad.push(`slots ${claimed.get(key)} and ${slot.id} claim the same pattern ${variant} on ${profile}`);
+        else
+            claimed.set(key, slot.id);
+    }
+}
 function checkSlotProfiles(slot, manifest, claimed, bad, braceVariants) {
-  for (const profile of slot.profiles) {
-    if (profile === APP_SCOPE) checkAppRootSlot(slot, bad);
-    else checkSideSlot(slot, profile, manifest, bad);
-    claimSlotPatterns(slot, profile, claimed, bad, braceVariants);
-  }
+    for (const profile of slot.profiles) {
+        if (profile === APP_SCOPE)
+            checkAppRootSlot(slot, bad);
+        else
+            checkSideSlot(slot, profile, manifest, bad);
+        claimSlotPatterns(slot, profile, claimed, bad, braceVariants);
+    }
 }
-
 function checkLitePath(slot, pathVars, varsOf, bad, braceVariants, compileVariant) {
-  if (slot.lite?.path === undefined) return;
-  for (const name of varsOf(slot.lite.path)) if (!pathVars.has(name)) bad.push(`slot ${slot.id}: lite.path binds <${name}>, which the path does not`);
-  for (const variant of braceVariants(slot.lite.path)) {
-    try { compileVariant(slot, variant); } catch (error) { bad.push(`slot ${slot.id}: lite.path ${variant} does not compile (${error.message})`); }
-  }
+    if (slot.lite?.path === undefined)
+        return;
+    for (const name of varsOf(slot.lite.path))
+        if (!pathVars.has(name))
+            bad.push(`slot ${slot.id}: lite.path binds <${name}>, which the path does not`);
+    for (const variant of braceVariants(slot.lite.path)) {
+        try {
+            compileVariant(slot, variant);
+        }
+        catch (error) {
+            bad.push(`slot ${slot.id}: lite.path ${variant} does not compile (${error.message})`);
+        }
+    }
 }
-
 function checkNamedPathBindings(slot, pathVars, varsOf, bad) {
-  for (const name of Object.keys(slot.requiredInstances ?? {})) {
-    if (!pathVars.has(name)) bad.push(`slot ${slot.id}: requiredInstances names <${name}>, which the path does not bind`);
-  }
-  for (const file of Object.values(slot.roles ?? {})) {
-    for (const name of varsOf(file)) if (!pathVars.has(name)) bad.push(`slot ${slot.id}: roles names <${name}> in ${file}, which the path does not bind`);
-  }
-  for (const entry of slot.requires ?? []) {
-    for (const name of varsOf(entry)) if (!pathVars.has(name)) bad.push(`slot ${slot.id}: requires ${entry} uses <${name}>, which the path does not bind`);
-  }
-}
-
+    for (const name of Object.keys(slot.requiredInstances ?? {})) {
+        if (!pathVars.has(name))
+            bad.push(`slot ${slot.id}: requiredInstances names <${name}>, which the path does not bind`);
+    }
+    for (const file of Object.values(slot.roles ?? {})) {
+        for (const name of varsOf(file))
+            if (!pathVars.has(name))
+                bad.push(`slot ${slot.id}: roles names <${name}> in ${file}, which the path does not bind`);
+    }
+    for (const entry of slot.requires ?? []) {
+        for (const name of varsOf(entry))
+            if (!pathVars.has(name))
+                bad.push(`slot ${slot.id}: requires ${entry} uses <${name}>, which the path does not bind`);
+    }
+}
 function checkSlotPatternCompilation(slot, bad, braceVariants, compileVariant) {
-  for (const variant of braceVariants(slot.path)) {
-    try { compileVariant(slot, variant); } catch (error) { bad.push(`slot ${slot.id}: pattern ${variant} does not compile (${error.message})`); }
-  }
+    for (const variant of braceVariants(slot.path)) {
+        try {
+            compileVariant(slot, variant);
+        }
+        catch (error) {
+            bad.push(`slot ${slot.id}: pattern ${variant} does not compile (${error.message})`);
+        }
+    }
 }
-
 function checkSlotComposition(slot, manifest, bad) {
-  for (const kind of slot.composedBy ?? []) {
-    if (!slot.profiles.every((profile) => manifest.appKinds[profile].includes(kind))) bad.push(`slot ${slot.id}: composedBy names ${kind}, which is not an app kind of every profile of the slot`);
-  }
-  if (slot.layers !== undefined && slot.tier !== 'none' && !slot.profiles.every((profile) => manifest.tiers[profile][slot.tier]?.lowerLayerOnly)) bad.push(`slot ${slot.id}: layers need a lowerLayerOnly tier`);
+    for (const kind of slot.composedBy ?? []) {
+        if (!slot.profiles.every((profile) => manifest.appKinds[profile].includes(kind)))
+            bad.push(`slot ${slot.id}: composedBy names ${kind}, which is not an app kind of every profile of the slot`);
+    }
+    if (slot.layers !== undefined && slot.tier !== 'none' && !slot.profiles.every((profile) => manifest.tiers[profile][slot.tier]?.lowerLayerOnly))
+        bad.push(`slot ${slot.id}: layers need a lowerLayerOnly tier`);
 }
-
 function checkLiteDeclaration(slot, manifest, bad) {
-  if (!slotInEdition(manifest, slot, 'lite') && (slot.litePresence !== undefined || slot.lite !== undefined)) bad.push(`slot ${slot.id}: litePresence/lite on a slot lite never sees (editions)`);
-  if (isPlainObject(slot.litePresence) && slot.profiles.includes(APP_SCOPE)) bad.push(`slot ${slot.id}: an app-root slot takes a bare litePresence, not a per-side map`);
-  for (const profile of slot.profiles) {
-    if (litePresenceOf(slot, profile) === 'forbidden' && typeof slot.goesTo !== 'string') bad.push(`slot ${slot.id}: forbidden in lite for ${profile}, so it says where the content goes (goesTo)`);
-  }
+    if (!slotInEdition(manifest, slot, 'lite') && (slot.litePresence !== undefined || slot.lite !== undefined))
+        bad.push(`slot ${slot.id}: litePresence/lite on a slot lite never sees (editions)`);
+    if (isPlainObject(slot.litePresence) && slot.profiles.includes(APP_SCOPE))
+        bad.push(`slot ${slot.id}: an app-root slot takes a bare litePresence, not a per-side map`);
+    for (const profile of slot.profiles) {
+        if (litePresenceOf(slot, profile) === 'forbidden' && typeof slot.goesTo !== 'string')
+            bad.push(`slot ${slot.id}: forbidden in lite for ${profile}, so it says where the content goes (goesTo)`);
+    }
 }
-
 function checkSlotSemantics(slot, manifest, claimed, bad, helpers) {
-  if (claimed.ids.has(slot.id)) bad.push(`slot id ${slot.id} appears twice`);
-  claimed.ids.add(slot.id);
-  const pathVars = new Set(helpers.varsOf(slot.path));
-  checkSlotProfiles(slot, manifest, claimed.patterns, bad, helpers.braceVariants);
-  if (slot.appKind !== undefined && !pathVars.has('app')) bad.push(`slot ${slot.id}: an app-kind slot binds <app> in its path`);
-  if (slot.requiredWhen !== undefined && slot.presence !== 'required') bad.push(`slot ${slot.id}: requiredWhen belongs to a required slot`);
-  checkLiteDeclaration(slot, manifest, bad);
-  checkLitePath(slot, pathVars, helpers.varsOf, bad, helpers.braceVariants, helpers.compileVariant);
-  checkNamedPathBindings(slot, pathVars, helpers.varsOf, bad);
-  checkSlotPatternCompilation(slot, bad, helpers.braceVariants, helpers.compileVariant);
-  checkSlotComposition(slot, manifest, bad);
-}
-
+    if (claimed.ids.has(slot.id))
+        bad.push(`slot id ${slot.id} appears twice`);
+    claimed.ids.add(slot.id);
+    const pathVars = new Set(helpers.varsOf(slot.path));
+    checkSlotProfiles(slot, manifest, claimed.patterns, bad, helpers.braceVariants);
+    if (slot.appKind !== undefined && !pathVars.has('app'))
+        bad.push(`slot ${slot.id}: an app-kind slot binds <app> in its path`);
+    if (slot.requiredWhen !== undefined && slot.presence !== 'required')
+        bad.push(`slot ${slot.id}: requiredWhen belongs to a required slot`);
+    checkLiteDeclaration(slot, manifest, bad);
+    checkLitePath(slot, pathVars, helpers.varsOf, bad, helpers.braceVariants, helpers.compileVariant);
+    checkNamedPathBindings(slot, pathVars, helpers.varsOf, bad);
+    checkSlotPatternCompilation(slot, bad, helpers.braceVariants, helpers.compileVariant);
+    checkSlotComposition(slot, manifest, bad);
+}
 /** The problem of one declared side read, or null when a slot of the side it names (or of the app root) owns the path. */
 function sideReadProblem(manifest, side, read, braceVariants) {
-  const [owner, ...rest] = read.split('/');
-  if (owner === side) return `sides.${side}.reads names ${read}, which is its own side`;
-  const ownedBySide = PROFILES.includes(owner);
-  const profile = ownedBySide ? owner : APP_SCOPE;
-  const prefix = ownedBySide ? rest.join('/') : read;
-  const owned = manifest.slots.some((slot) => slot.profiles.includes(profile) && slot.presence !== 'forbidden' && braceVariants(slot.path).some((variant) => variant.startsWith(prefix)));
-  const ownerName = ownedBySide ? owner : 'app-root';
-  return owned ? null : `sides.${side}.reads names ${read}, which no ${ownerName} slot owns`;
-}
-
+    const [owner, ...rest] = read.split('/');
+    if (owner === side)
+        return `sides.${side}.reads names ${read}, which is its own side`;
+    const ownedBySide = isSide(owner);
+    const profile = ownedBySide ? owner : APP_SCOPE;
+    const prefix = ownedBySide ? rest.join('/') : read;
+    const owned = manifest.slots.some((slot) => slot.profiles.includes(profile) && slot.presence !== 'forbidden' && braceVariants(slot.path).some((variant) => variant.startsWith(prefix)));
+    const ownerName = ownedBySide ? owner : 'app-root';
+    return owned ? null : `sides.${side}.reads names ${read}, which no ${ownerName} slot owns`;
+}
 function checkSideReads(manifest, bad, braceVariants) {
-  for (const side of PROFILES) {
-    for (const read of manifest.sides[side].reads) {
-      const problem = sideReadProblem(manifest, side, read, braceVariants);
-      if (problem) bad.push(problem);
+    for (const side of PROFILES) {
+        for (const read of manifest.sides[side].reads) {
+            const problem = sideReadProblem(manifest, side, read, braceVariants);
+            if (problem)
+                bad.push(problem);
+        }
     }
-  }
 }
-
 function checkProfileTierTargets(manifest, profile, bad) {
-  bad.push(...tierKindProblems(manifest, profile));
-  for (const [tier, def] of Object.entries(manifest.tiers[profile])) {
-    for (const target of def.mayImport) {
-      if (!(target in manifest.tiers[profile])) bad.push(`tiers.${profile}.${tier}.mayImport names ${target}, which is not a ${profile} tier`);
+    bad.push(...tierKindProblems(manifest, profile));
+    for (const [tier, def] of Object.entries(manifest.tiers[profile])) {
+        for (const target of def.mayImport) {
+            if (!(target in manifest.tiers[profile]))
+                bad.push(`tiers.${profile}.${tier}.mayImport names ${target}, which is not a ${profile} tier`);
+        }
     }
-  }
 }
-
 function checkProfileAppKinds(manifest, profile, bad) {
-  for (const kind of manifest.appKinds[profile]) {
-    const owners = manifest.slots.filter((slot) => slot.profiles.includes(profile) && slot.appKind === kind);
-    if (owners.length !== 1) bad.push(`${profile} app kind ${kind} must have exactly one slot (found ${owners.length})`);
-  }
+    for (const kind of manifest.appKinds[profile]) {
+        const owners = manifest.slots.filter((slot) => slot.profiles.includes(profile) && slot.appKind === kind);
+        if (owners.length !== 1)
+            bad.push(`${profile} app kind ${kind} must have exactly one slot (found ${owners.length})`);
+    }
 }
-
 function checkProfileMaps(manifest, bad) {
-  for (const profile of PROFILES) {
-    checkProfileTierTargets(manifest, profile, bad);
-    checkProfileAppKinds(manifest, profile, bad);
-  }
+    for (const profile of PROFILES) {
+        checkProfileTierTargets(manifest, profile, bad);
+        checkProfileAppKinds(manifest, profile, bad);
+    }
 }
-
 /** The rules a JSON Schema cannot state: unique ids, tiers named and reachable, app kinds, variables, no duplicate pattern. */
 export function manifestSemanticProblems(manifest, helpers) {
-  const bad = [];
-  const claimed = { ids: new Set(), patterns: new Map() };
-  for (const slot of manifest.slots) checkSlotSemantics(slot, manifest, claimed, bad, helpers);
-  if (manifestKind(manifest) === RUNTIME_KIND) return [...bad, ...runtimeSemanticProblems(manifest)];
-  checkSideReads(manifest, bad, helpers.braceVariants);
-  checkProfileMaps(manifest, bad);
-  const major = Number(manifest.version.split('.')[0]);
-  if (String(manifest.schema) !== `starci/hfs-slots@${major}`) bad.push(`schema ${manifest.schema} does not carry the major of version ${manifest.version}`);
-  return bad;
+    const bad = [];
+    const claimed = { ids: new Set(), patterns: new Map() };
+    for (const slot of manifest.slots)
+        checkSlotSemantics(slot, manifest, claimed, bad, helpers);
+    if (manifestKind(manifest) === RUNTIME_KIND)
+        return [...bad, ...runtimeSemanticProblems(manifest)];
+    checkSideReads(manifest, bad, helpers.braceVariants);
+    checkProfileMaps(manifest, bad);
+    const major = Number(manifest.version.split('.')[0]);
+    if (String(manifest.schema) !== `starci/hfs-slots@${major}`)
+        bad.push(`schema ${manifest.schema} does not carry the major of version ${manifest.version}`);
+    return bad;
 }

package/runtime/scripts/hfs/slot-side-problems.mjs

@@ -1,28 +1,32 @@
 // slot-side-problems.mjs - declaration checks for one app side against the HFS manifest.
 import { backingProblems, optionalSlotProblems } from './declaration-slots.mjs';
-
 function sideAppKindProblems(manifest, side, apps) {
-  const bad = [];
-  for (const app of apps) if (!manifest.appKinds[side].includes(app.kind)) bad.push(`${side} app ${app.name} has kind ${app.kind}, which is not a ${side} kind (${manifest.appKinds[side].join(', ')})`);
-  return bad;
+    const bad = [];
+    for (const app of apps)
+        if (!manifest.appKinds[side].includes(app.kind))
+            bad.push(`${side} app ${app.name} has kind ${app.kind}, which is not a ${side} kind (${manifest.appKinds[side].join(', ')})`);
+    return bad;
 }
-
 function requiredAppKindProblems(manifest, side, declaration) {
-  const bad = [];
-  const connections = declaration.connections ?? [];
-  for (const slot of manifest.slots) {
-    if (slot.appKind === undefined || !slot.profiles.includes(side) || slot.presence !== 'required') continue;
-    if (slot.requiredWhen === 'connections' && !connections.length) continue;
-    if (!declaration.apps.some((app) => app.kind === slot.appKind)) bad.push(`no ${side} app of kind ${slot.appKind} is declared (${slot.id} is required${slot.requiredWhen ? ' once a connection is declared' : ''})`);
-  }
-  return bad;
+    const bad = [];
+    const connections = declaration.connections ?? [];
+    for (const slot of manifest.slots) {
+        if (slot.appKind === undefined || !slot.profiles.includes(side) || slot.presence !== 'required')
+            continue;
+        if (slot.requiredWhen === 'connections' && !connections.length)
+            continue;
+        if (!declaration.apps.some((app) => app.kind === slot.appKind))
+            bad.push(`no ${side} app of kind ${slot.appKind} is declared (${slot.id} is required${slot.requiredWhen ? ' once a connection is declared' : ''})`);
+    }
+    return bad;
 }
-
 /** Problems for one side declaration, preserving the manifest's checks and their order. */
 export function sideProblems(manifest, side, declaration, edition = 'full') {
-  const bad = sideAppKindProblems(manifest, side, declaration.apps);
-  bad.push(...optionalSlotProblems(manifest, side, declaration), ...backingProblems(manifest, side, declaration, edition));
-  for (const read of declaration.reads ?? []) if (!manifest.sides[side].reads.includes(read)) bad.push(`sides.${side}.reads names ${read}; ${side} may read only ${manifest.sides[side].reads.join(', ') || 'nothing of the other side'}`);
-  bad.push(...requiredAppKindProblems(manifest, side, declaration));
-  return bad;
+    const bad = sideAppKindProblems(manifest, side, declaration.apps);
+    bad.push(...optionalSlotProblems(manifest, side, declaration), ...backingProblems(manifest, side, declaration, edition));
+    for (const read of declaration.reads ?? [])
+        if (!manifest.sides[side].reads.includes(read))
+            bad.push(`sides.${side}.reads names ${read}; ${side} may read only ${manifest.sides[side].reads.join(', ') || 'nothing of the other side'}`);
+    bad.push(...requiredAppKindProblems(manifest, side, declaration));
+    return bad;
 }