@starci/eslint-canon-fe 6.0.2 → 7.0.0

package/lint-escape-hatch.mjs

@@ -19,10 +19,10 @@
  * nothing is dead weight that reads as if it did.
  */
 
-import { fileOf, isE2eSource, isProductSource, isSpecFile } from "./lib/scope.mjs"
+import { isProductSource } from "./lib/scope.mjs"
 
-/** Product source, its specs and the e2e tree are governed; canon tests deliberately build forbidden directives. */
-const isGoverned = (context) => isProductSource(context) || isSpecFile(fileOf(context)) || isE2eSource(context)
+/** Product source is governed; canon tests deliberately build forbidden directives. */
+const isGoverned = (context) => isProductSource(context)
 
 /**
  * Any directive that changes ESLint's active rule set inside a source file.

package/lists.mjs

@@ -16,7 +16,6 @@
  */
 
 import { attribute, attributeValue, calleeName, isFunction, mentions } from "./lib/ast.mjs"
-import { isSpecFile } from "./lib/scope.mjs"
 
 /** `.map(callback)` where the callback is written inline; the call node, else null. */
 const mapCallback = (call) => {
@@ -86,7 +85,6 @@ export const listItemHasKey = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     return {
       CallExpression(call) {
         const callback = mapCallback(call)
@@ -116,7 +114,6 @@ export const noIndexKey = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     const source = context.sourceCode ?? context.getSourceCode()
     return {
       CallExpression(call) {
@@ -170,7 +167,6 @@ export const noInlineLiteralPropInList = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     return {
       JSXAttribute(node) {
         const opening = node.parent

package/loading.mjs

@@ -12,10 +12,10 @@
  * lint rule is for - the one nothing else will ever report.
  */
 
-import { classOf, fileOf, isComponentFile, isSpecFile } from "./lib/scope.mjs"
+import { classOf, fileOf, isComponentFile } from "./lib/scope.mjs"
 
 /** Product component source these rules govern: a component owner's file, and not a spec (a placeholder in a test fixture is a fixture, not a second tree). */
-const isGoverned = (context) => isComponentFile(context) && !isSpecFile(fileOf(context))
+const isGoverned = (context) => isComponentFile(context)
 
 /** A flag that means "waiting", in the spellings this codebase uses. */
 const WAITING_FLAG = /\bis(?:Loading|Skeleton|Pending)\b/

package/native-controls.mjs

@@ -13,7 +13,6 @@
  */
 
 import { attribute } from "./lib/ast.mjs"
-import { isSpecFile } from "./lib/scope.mjs"
 
 /** Intrinsic elements a reader operates, that the grammar renders for the product. */
 const NATIVE = new Set(["select", "input", "textarea", "button"])
@@ -30,7 +29,6 @@ export const noNativeFormControl = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     return {
       JSXOpeningElement(node) {
         if (node.name.type !== "JSXIdentifier" || !NATIVE.has(node.name.name)) return
@@ -54,7 +52,6 @@ export const noNativeImg = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     return {
       JSXOpeningElement(node) {
         if (node.name.type === "JSXIdentifier" && node.name.name === "img") context.report({ node, messageId: "img" })
@@ -79,7 +76,6 @@ export const imageHasSize = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     const locals = new Set()
     return {
       ImportDeclaration(node) {

package/next-conventions.mjs

@@ -13,7 +13,7 @@
 
 import { attribute, attributeValue, calleeName, leadingTextOf, stringOf } from "./lib/ast.mjs"
 import { hfsOf } from "./lib/hfs.mjs"
-import { baseName, classOf, fileOf, inSlot, isSpecFile, roleOfFile, slotOfFile, stem } from "./lib/scope.mjs"
+import { baseName, classOf, fileOf, inSlot, roleOfFile, slotOfFile, stem } from "./lib/scope.mjs"
 
 /** Another i18n stack: a second place that decides which language a reader sees. */
 const OTHER_I18N = /^(?:react-i18next|i18next|next-i18next|react-intl|next-translate|@lingui\/.+|typesafe-i18n|rosetta)$/
@@ -35,7 +35,6 @@ export const noMiddlewareFile = {
   },
   create(context) {
     const file = fileOf(context)
-    if (isSpecFile(file)) return {}
     // The retired name has a slot of its own (`fe.source-root-retired`, forbidden); the interceptor is the `proxy` role of `fe.source-root-pinned`.
     if (inSlot(context, "fe.source-root-retired")) {
       return { Program: (node) => context.report({ node, messageId: "file", data: { name: baseName(file) } }) }
@@ -189,7 +188,6 @@ export const noNullSuspenseFallback = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     return {
       JSXOpeningElement(node) {
         const name = node.name
@@ -235,7 +233,7 @@ export const navigationFromIntl = {
     },
   },
   create(context) {
-    if (isSpecFile(fileOf(context)) || isNavigationOwner(context)) return {}
+    if (isNavigationOwner(context)) return {}
     return {
       ImportDeclaration(node) {
         if (node.importKind === "type") return
@@ -271,7 +269,6 @@ export const noNativeAnchor = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     return {
       JSXOpeningElement(node) {
         if (node.name.type !== "JSXIdentifier" || node.name.name !== "a") return
@@ -309,7 +306,7 @@ export const noHardcodedRoute = {
     },
   },
   create(context) {
-    if (isSpecFile(fileOf(context)) || isRoutesModule(context)) return {}
+    if (isRoutesModule(context)) return {}
     const source = context.sourceCode ?? context.getSourceCode()
     const report = (node, text) => context.report({ node, messageId: "route", data: { path: text } })
     return {
@@ -393,7 +390,6 @@ export const i18nStackInOneModule = {
     },
   },
   create(context) {
-    if (isSpecFile(context.filename || context.getFilename())) return {}
     const hfs = hfsOf(context)
     const slot = slotOfFile(context)
     const single = hfs.apps.length === 1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@starci/eslint-canon-fe",
-  "version": "6.0.2",
+  "version": "7.0.0",
   "description": "The StarCi front-end lint canon: every rule its laws publish, gathered as one flat-config plugin and attached by one factory.",
   "type": "module",
   "license": "UNLICENSED",

package/props-and-slots.mjs

@@ -1,7 +1,7 @@
 /** Rules for named React props, ordinary children, and local visual ownership. */
 
 import { declarationsOf, fileOf as declarationFile } from "./lib/types.mjs"
-import { fileOf, isComponentFile, isComponentPath, isProductSource, isSpecFile, kindOfFile } from "./lib/scope.mjs"
+import { fileOf, isComponentFile, isComponentPath, isProductSource, kindOfFile } from "./lib/scope.mjs"
 
 const propertyName = (node) => {
   const key = node?.key ?? node?.property
@@ -70,7 +70,7 @@ export const publicComponentSignature = {
       const actual = type?.type === "TSTypeReference" && type.typeName?.type === "Identifier" ? type.typeName.name : null
       if (!actual || !expected.includes(actual)) context.report({ node: params[0], messageId: "type", data: { name, expected: expected.join(" or ") } })
     }
-    if (!isComponentFile(context) || isSpecFile(fileOf(context))) return {}
+    if (!isComponentFile(context)) return {}
     return {
       VariableDeclarator(node) {
         const name = componentNameOf(node)
@@ -93,7 +93,7 @@ export const noPerPartClassNameProp = {
     messages: { perPart: "Keep internal part styling owned by the component." },
   },
   create(context) {
-    if (!isComponentFile(context) || isSpecFile(fileOf(context))) return {}
+    if (!isComponentFile(context)) return {}
     return { TSPropertySignature(node) { const name = propertyName(node); if (name && name !== "className" && /^[a-z][A-Za-z0-9]*ClassName$/.test(name)) context.report({ node, messageId: "perPart" }) } }
   },
 }
@@ -107,7 +107,6 @@ export const noPublicClassNameProp = {
     messages: { declaration: "Component props must not expose {{prop}}.", usage: "Do not pass {{prop}} to house component {{component}}." },
   },
   create(context) {
-    if (isSpecFile(fileOf(context))) return {}
     const declared = isComponentFile(context)
     /** A house component: the identifier resolves (through its import) to a file of a component layer. */
     const isHouseComponent = (identifier) => declarationsOf(context, identifier).some((declaration) => isComponentPath(context, declarationFile(declaration)))
@@ -128,7 +127,7 @@ export const noPublicClassNameProp = {
 export const noPublicFrameCssProps = {
   meta: { type: "problem", docs: { description: "Non-leaf component props do not expose CSS-shaped frame decisions." }, schema: [], messages: { css: "Move {{prop}} into component-owned layout behavior." } },
   create(context) {
-    if (isSpecFile(fileOf(context)) || !isComponentFile(context) || kindOfFile(context) === "leaves") return {}
+    if (!isComponentFile(context) || kindOfFile(context) === "leaves") return {}
     const cssProps = new Set(["gap", "padding", "align", "justify", "className", "classNames", "style", "inline", "nested"])
     return { TSPropertySignature(node) { const name = propertyName(node); if (cssProps.has(name)) context.report({ node, messageId: "css", data: { prop: name } }) } }
   },