@starci/eslint-canon-fe 1.4.5 → 3.0.0

package/the-split.mjs

@@ -73,8 +73,10 @@ export const connectedBlockHasPresentationalTwin = {
         "`{{block}}` reads the world, so it must import exact `{{twin}}` from `./component`. A single leaf, one tree, or no local state is not an exception.",
       bypass:
         "Connected `{{block}}` renders `<{{rendered}}>` directly. Resolve the world here, then render only `<{{twin}}>`; component.tsx owns the complete presentation.",
-      unused:
-        "Connected `{{block}}` imports `{{twin}}` but never renders it. Every connected render path must cross the pure twin.",
+      unused:
+        "Connected `{{block}}` imports `{{twin}}` but never renders it. Every connected render path must cross the pure twin.",
+      called:
+        "Connected `{{block}}` calls `{{twin}}(...)` as an ordinary function. Render `<{{twin}} />` so React owns the twin's hook lifecycle and every render keeps one stable component boundary.",
     },
   },
   create(context) {
@@ -82,8 +84,9 @@ export const connectedBlockHasPresentationalTwin = {
     if (!block) return {}
 
     const twin = `${block}Base`
-    const worldBindings = new Set()
-    const rendered = []
+    const worldBindings = new Set()
+    const rendered = []
+    const calledTwin = []
     let importsTwin = false
     let readsWorld = false
     let rendersTwin = false
@@ -98,9 +101,10 @@ export const connectedBlockHasPresentationalTwin = {
           if (imported && local && REACHES_FOR_THE_WORLD.test(imported)) worldBindings.add(local)
         }
       },
-      CallExpression(node) {
-        if (node.callee?.type !== "Identifier") return
-        if (worldBindings.has(node.callee.name) || REACHES_FOR_THE_WORLD.test(node.callee.name)) {
+      CallExpression(node) {
+        if (node.callee?.type !== "Identifier") return
+        if (node.callee.name === twin) calledTwin.push(node)
+        if (worldBindings.has(node.callee.name) || REACHES_FOR_THE_WORLD.test(node.callee.name)) {
           readsWorld = true
         }
       },
@@ -115,7 +119,7 @@ export const connectedBlockHasPresentationalTwin = {
           context.report({ node, messageId: "missing", data: { block, twin } })
           return
         }
-        for (const entry of rendered) {
+        for (const entry of rendered) {
           if (entry.name !== twin) {
             context.report({
               node: entry.node,
@@ -123,8 +127,11 @@ export const connectedBlockHasPresentationalTwin = {
               data: { block, rendered: entry.name, twin },
             })
           }
-        }
-        if (!rendersTwin) context.report({ node, messageId: "unused", data: { block, twin } })
+        }
+        for (const call of calledTwin) {
+          context.report({ node: call, messageId: "called", data: { block, twin } })
+        }
+        if (!rendersTwin) context.report({ node, messageId: "unused", data: { block, twin } })
       },
     }
   },