@starci/eslint-canon-fe 1.4.0 → 1.4.2

package/icon.mjs

@@ -43,11 +43,13 @@ const GLYPH_PACKAGES = [
 /** Package-name signal for a glyph catalogue not yet listed explicitly. */
 const GLYPH_PACKAGE_NAME = /(?:icon|glyph|lucide|feather|tabler|fortawesome)/i
 
-/** The two Heroicon families selected by the product roles. */
-const HEROICON_PACKAGES = new Set([
-  "@heroicons/react/24/outline",
-  "@heroicons/react/16/solid",
-])
+/** Upstream Heroicons plus StarCi's custom-only extension, each on the same two optical families. */
+const HEROICON_PACKAGES = new Set([
+  "@heroicons/react/24/outline",
+  "@heroicons/react/16/solid",
+  "@starci/heroicons/24/outline",
+  "@starci/heroicons/16/solid",
+])
 
 /**
  * Product reactions are attributed artwork rather than glyph-library imports.
@@ -57,45 +59,6 @@ const HEROICON_PACKAGES = new Set([
  */
 export const REACTION_ASSET_NAMES = new Set(["like", "love", "haha", "wow", "sad", "angry"])
 
-/**
- * ICON-11 - rank artwork is a second closed leaf, and it is the only one.
- *
- * A leaderboard place is not a feature, a state or an action, which is what the Heroicons map is
- * for. It is an AWARD, and the product decided - explicitly, twice - that an award is drawn as the
- * Fluent Emoji Flat medal for it. Heroicons ships no medal, so the choice was never between two
- * glyph families; it was between the artwork the product asked for and no artwork at all.
- *
- * WHY THIS IS A NAMED EXEMPTION RATHER THAN A HOLE. It is bounded on three sides at once: one file
- * may import the library, only from `@iconify/react`, and only these four artwork identities. A
- * fifth medal, a second importing file, or a different vendor is still reported. That is the same
- * shape as the reaction vocabulary above - a closed set owned by one leaf - and it is what keeps
- * "the product asked for it" from becoming a sentence any call site can write.
- *
- * WHY IT IS NOT THE `public/` ROUTE THE REACTIONS TOOK. That route is better and it stays the
- * default: checked-in SVG needs no network at render time and no vendor at all. It was not taken
- * here because the four assets are not in the repository, and the exemption records a decision the
- * product owner made knowing that - not a claim that this is the stronger mechanism.
- */
-const RANK_MARK_RELATIVE = "leaves/RankMark/index.tsx"
-
-/** The one glyph package the rank leaf may name, and nothing else may. */
-const RANK_ARTWORK_PACKAGE = "@iconify/react"
-
-/** The complete rank artwork vocabulary: three places, then one trophy for everyone below. */
-export const RANK_ARTWORK_IDS = new Set([
-  "fluent-emoji-flat:1st-place-medal",
-  "fluent-emoji-flat:2nd-place-medal",
-  "fluent-emoji-flat:3rd-place-medal",
-  "fluent-emoji-flat:trophy",
-])
-
-/** True when this file is the rank leaf, which owns the place-to-artwork map. */
-const isRankMarkFile = (filename) => normalizePath(filename).endsWith(`/${RANK_MARK_RELATIVE}`)
-
-/** True for the one import the rank leaf is permitted to make. */
-const isRankArtworkImport = (filename, source) =>
-  isRankMarkFile(filename) && source === RANK_ARTWORK_PACKAGE
-
 /** True when this file is the icon leaf, which owns the meaning-to-glyph map. */
 const isIconLeafFile = (filename) => normalizePath(filename).endsWith(`/${ICON_MODULE_RELATIVE}`)
 
@@ -152,9 +115,7 @@ export const noVendorIconOutsideIconLeaf = {
       ImportDeclaration(node) {
         const source = node.source && node.source.value
         if (!isGlyphImport(source)) return
-        // ICON-11: the rank leaf owns award artwork the Heroicons map does not carry.
-        if (isRankArtworkImport(file, source)) return
-        context.report({ node, messageId: "vendor", data: { source, leaf: ICON_MODULE_RELATIVE } })
+        context.report({ node, messageId: "vendor", data: { source, leaf: ICON_MODULE_RELATIVE } })
       },
     }
   },
@@ -180,9 +141,7 @@ export const heroiconsIsTheGlyphVendor = {
       ImportDeclaration(node) {
         const source = node.source && node.source.value
         if (!isGlyphImport(source) || HEROICON_PACKAGES.has(String(source))) return
-        // ICON-11: Heroicons ships no medal, so the award vocabulary has its own closed leaf.
-        if (isRankArtworkImport(file, source)) return
-        context.report({ node, messageId: "vendor", data: { source } })
+        context.report({ node, messageId: "vendor", data: { source } })
       },
     }
   },
@@ -247,57 +206,13 @@ export const noDecorativeIconInMetricCell = {
   },
 }
 
-// -- ICON-11 ---------------------------------------------------------------------------------------
-
-/**
- * The rank leaf's exemption is a vocabulary, not a door.
- *
- * ICON-11 lets exactly one file import exactly one glyph package. Without this rule that file could
- * then name ANY artwork in that package, and the exemption would have bought the product four
- * medals and handed back an unbounded catalogue - which is the failure the icon leaf exists to
- * prevent, reintroduced one folder over.
- */
-export const rankArtworkIsAClosedSet = {
-  meta: {
-    type: "problem",
-    docs: { description: "The rank leaf names only the four approved award artworks." },
-    schema: [],
-    messages: {
-      unknown:
-        "`{{id}}` is not one of the four approved rank artworks. The vocabulary is `fluent-emoji-flat:1st-place-medal`, `2nd-place-medal`, `3rd-place-medal` and `trophy` for every place below third. A fifth artwork is a product decision about what a place MEANS, so it is made in the icon law rather than in this file.",
-      outside:
-        "`{{id}}` is rank award artwork, named outside `{{leaf}}`. The place-to-artwork map is kept in one file so a second screen cannot answer the same question differently.",
-    },
-  },
-  create(context) {
-    const file = normalizePath(context.filename || context.getFilename())
-    // A twin test proves the map is closed, which it cannot do without naming what is in it and
-    // what is not. Same exemption, same reason, as the one the double-cast rule already carries.
-    if (!isSourceFile(file) || /\.test\.tsx?$/.test(file)) return {}
-    const inRankLeaf = isRankMarkFile(file)
-    return {
-      Literal(node) {
-        if (typeof node.value !== "string") return
-        const id = node.value
-        if (!id.startsWith("fluent-emoji-flat:")) return
-        if (!inRankLeaf) {
-          context.report({ node, messageId: "outside", data: { id, leaf: RANK_MARK_RELATIVE } })
-          return
-        }
-        if (!RANK_ARTWORK_IDS.has(id)) context.report({ node, messageId: "unknown", data: { id } })
-      },
-    }
-  },
-}
-
 /** The rules this law contributes to the plugin. */
 export const rules = {
   "no-vendor-icon-outside-icon-leaf": noVendorIconOutsideIconLeaf,
   "heroicons-is-the-glyph-vendor": heroiconsIsTheGlyphVendor,
   "no-off-scale-glyph-size": noOffScaleGlyphSize,
   "no-decorative-icon-in-metric-cell": noDecorativeIconInMetricCell,
-  "rank-artwork-is-a-closed-set": rankArtworkIsAClosedSet,
-}
+}
 
 /**
  * The level this law asks for, as the plugin's own opinion.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@starci/eslint-canon-fe",
-  "version": "1.4.0",
+  "version": "1.4.2",
   "description": "The StarCi front-end lint canon: every rule its laws publish, gathered as one flat-config plugin.",
   "type": "module",
   "license": "UNLICENSED",